Kevin Sawicki
f4717b34e9
Register visibility change listener when attached
2017-02-28 08:23:00 -08:00
Kevin Sawicki
739f3ed102
Popup pepper menu in owner browser window
2017-02-24 08:39:22 -08:00
Kevin Sawicki
c951e253c6
Default to focused window whenever param is null/undefined
2017-02-24 08:39:22 -08:00
Kevin Sawicki
3e05350d6b
Check that window is non-null before accessing constructor prop
2017-02-24 08:39:22 -08:00
Kevin Sawicki
d0b07d5c36
Check that x is non-null
2017-02-22 10:49:25 -08:00
Kevin Sawicki
6a023dc4fe
Add Menu.closePopup API on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
4430927f98
Add async option to menu.popup
2017-02-22 10:30:28 -08:00
deepak1556
403e7681c1
add basic webview zoom specs
2017-02-18 01:34:32 +05:30
deepak1556
71fd3e807c
use sync zoom api with guest view manager webpreferences
2017-02-18 01:34:32 +05:30
deepak1556
203a920c64
fix signature of zoom getter apis
2017-02-18 01:34:32 +05:30
Kevin Sawicki
b51adf8ae5
Add spec for updated extra parameters
2017-02-14 09:37:09 -08:00
Kevin Sawicki
ba975d552a
Add setExtraParameter support on macOS
2017-02-14 09:37:09 -08:00
Kevin Sawicki
3e18d8baf5
Remove _ prefix on binding methods
2017-02-14 09:37:09 -08:00
Kevin Sawicki
2a18e3f9ea
Remove Buffer global on load
2017-02-14 08:42:34 -08:00
Samuel Attard
17fe5efa13
Fix linting
2017-02-13 08:23:53 -08:00
Samuel Attard
e45d8079b8
Add support for a noResolveAliases property
2017-02-13 08:23:53 -08:00
deepak1556
e3fe3cc490
map webframe zoom api to use HostZoomMap
2017-02-12 00:49:17 +05:30
deepak1556
63c0e4cbb1
Add ZoomController to manager zoom changes for webcontents
2017-02-12 00:49:17 +05:30
deepak1556
b27c94368d
webContents: set zoom levels with HostZoomMap
2017-02-12 00:49:17 +05:30
Kevin Sawicki
acedc3e726
Merge pull request #8584 from electron/new-webview-event
...
Add will-attach-webview event
2017-02-09 12:40:11 -08:00
Kevin Sawicki
941f6c63e3
🎨 Use embedder var for clarity
2017-02-09 11:48:45 -08:00
Kevin Sawicki
a7c050107b
Remove guest from will-attach-webview event
2017-02-09 11:47:45 -08:00
Kevin Sawicki
8b0d3a2567
Emit attach params as well in event
2017-02-09 11:45:07 -08:00
Kevin Sawicki
46f1a49594
new-webview -> will-attach-webview
2017-02-09 11:45:07 -08:00
Kevin Sawicki
7eda8fbdfb
Add new-webview event that can be prevented
2017-02-09 11:45:07 -08:00
Kevin Sawicki
5130ad24eb
🎨
2017-02-09 11:30:17 -08:00
Kevin Sawicki
f7f4de36af
Merge remote-tracking branch 'origin/master' into macos-open-save-panel
2017-02-09 11:25:05 -08:00
Kevin Sawicki
867bb5a94e
Add DialogSettings helper struct
2017-02-09 10:13:11 -08:00
Birunthan Mohanathas
c8c11e68c6
Add support for checkbox with dialog.showMessageBox
...
This adds the `checkboxLabel` and `checkboxChecked` options to display a
checkbox in the message box. Fixes #6048 .
2017-02-09 09:03:54 -08:00
Tan Wang Leng
347dc835b5
Fix code formatting
2017-02-09 21:51:11 +08:00
Tan Wang Leng
9423143211
Change the default value of showsTagField to true
...
The default value of showsTagField in macOS's NSSavePanel is true.
Therefore, in order to follow the standard behavior and not break
backwards-compatibility, let's change the default value of
showsTagField to true.
Reference:
https://developer.apple.com/reference/appkit/nssavepanel/1525589-showstagfield?language=objc
2017-02-09 21:01:40 +08:00
Tan Wang Leng
36209ddd90
🍎 Add additional options for Mac's open dialog
...
Support an additional attributes available in macOS's NSOpenPanel:
message.
2017-02-09 20:10:57 +08:00
Tan Wang Leng
1d612a12a1
🍎 Add additional options for Mac's save dialog
...
Support additional attributes available in macOS's NSSavePanel: message,
nameFieldLabel and showsTagField
2017-02-09 20:10:57 +08:00
Kevin Sawicki
70178adb6e
Use object for verification request
2017-02-08 11:59:43 -08:00
Kevin Sawicki
5245d42d15
Only document deprecation for now
2017-02-08 11:59:43 -08:00
Greg Nolle
e29b64a18a
modify CertVerifier Class
...
* respond to multiple similar verification requests.
* accept net error result as callback response.
2017-02-08 11:59:43 -08:00
Cheng Zhao
3024d0563f
There were new defaultPrintingSetting fields added
2017-02-06 10:34:29 -08:00
Cheng Zhao
c72438f09f
WebInspector has been split up
2017-02-06 10:34:29 -08:00
Kevin Sawicki
fb08f56fc8
Add forcereload menu item role
2017-02-03 09:39:41 -08:00
Kevin Sawicki
9fef6a1fd7
Add support for FOS_CREATEPROMPT option
2017-02-02 08:51:10 -08:00
Kevin Sawicki
56a8eb3a94
Check that sender is a WebContents instance
2017-01-25 12:36:55 -08:00
Charlie Hess
ddedcf22d1
Move console.warn inside the helper method.
2017-01-25 12:36:55 -08:00
Charlie Hess
f6410d3b77
Assert that listener count decreases after a remove event.
2017-01-25 12:36:55 -08:00
Charlie Hess
c213971a2d
Write a warning instead of crashing.
2017-01-25 12:36:55 -08:00
Charlie Hess
bc2f1e8199
Argh.
2017-01-25 12:36:55 -08:00
Charlie Hess
63d8137da2
Use EventEmitter public methods instead of _events.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
45986405b8
Assert remote event names
2017-01-25 12:36:55 -08:00
Charlie Hess
a0b24bd155
Simplify.
2017-01-25 12:36:55 -08:00
Charlie Hess
67f7a60524
Review CommentZ
2017-01-25 12:36:55 -08:00
Charlie Hess
41ea169784
L I N T I N G P T I I
2017-01-25 12:36:55 -08:00
Charlie Hess
49c6446267
L I N T I N G
2017-01-25 12:36:55 -08:00
Charlie Hess
26e3ad3c2e
Display more information about remote event crashes.
...
If possible, we'll dig into the function args and print the ones that are attached remotely.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
d6eb0d6629
Implement insertCSS on webFrame
2017-01-19 09:05:59 +02:00
Kevin Sawicki
6bcfd0630c
Document implemented APIs at the top
2017-01-16 12:38:16 -08:00
Kevin Sawicki
f4f0174746
Parse guestInstanceId and opener as ints
2017-01-16 12:38:16 -08:00
Kevin Sawicki
fbcbfbda6a
Add back BrowserWindowProxy location property
2017-01-16 12:38:16 -08:00
Kevin Sawicki
de4be56b09
Use internal open event name with fully parsed options
2017-01-16 12:38:16 -08:00
Kevin Sawicki
f3852c57fc
Use empty string for comparison
2017-01-16 12:38:16 -08:00
Kevin Sawicki
2e6d08c652
Remove unneeded this prefix
2017-01-16 12:38:16 -08:00
Kevin Sawicki
bb260343de
Move more functions to outer scope
2017-01-16 12:38:16 -08:00
Kevin Sawicki
3f7b3c4bd7
Implement window overrides in main context
2017-01-16 12:38:16 -08:00
Kevin Sawicki
95054f443f
Enable context isolation on child windows
2017-01-16 12:38:16 -08:00
Javan Makhmali
a64bdbd306
Add "context-menu" DOM event to <webview>
2017-01-13 17:04:09 -05:00
Kevin Sawicki
1944fdc962
Track visited parents and null out cycles
2017-01-06 09:58:40 -08:00
Kevin Sawicki
5f862effaa
Access directly on options object
2017-01-06 09:17:32 -08:00
Kevin Sawicki
eb533e04b9
Add option to normalize dialog access keys
2017-01-06 08:56:24 -08:00
Kevin Sawicki
2bd8ef83d1
Use != null to handle undefined
2016-12-12 16:25:56 -08:00
Daniel Pham
4b53cd9c3c
🐛 Allow buttons to be optional in 'showMessageBox'
2016-12-12 13:25:32 -05:00
Kevin Sawicki
820fb3b82b
Guard against no devtools web contents
2016-12-06 10:36:59 -08:00
Kevin Sawicki
d6d85ade8e
🎨 Assign binding as const
2016-12-02 13:40:31 -08:00
Kevin Sawicki
1278e8cebc
Remove unused variable
2016-12-02 13:40:31 -08:00
Kevin Sawicki
3b99827540
Coerce features to string
2016-12-02 13:40:31 -08:00
Kevin Sawicki
635c909aab
Implement window.alert/confirm/close in main process
2016-12-02 13:40:31 -08:00
Kevin Sawicki
f894da13b0
Pass args array instead of arguments object
2016-12-02 13:40:31 -08:00
Kevin Sawicki
ec43dd067c
Co-locate with other private methods
2016-12-02 10:41:42 -08:00
Kevin Sawicki
f3d391e3f2
Don't clear until render view is deleted for process id
2016-12-02 10:41:42 -08:00
Kevin Sawicki
07f99c06ea
Don't write back to passed in options object
2016-12-01 17:16:18 -08:00
Kevin Sawicki
f56b00718b
Remove unused method
2016-12-01 14:56:00 -08:00
Kevin Sawicki
af555bd879
Use spread syntax instead of apply
2016-12-01 14:56:00 -08:00
Kevin Sawicki
c8ff67ab75
Use spread syntax instead of function apply
2016-12-01 14:56:00 -08:00
Kevin Sawicki
36371357cd
buttonLabel -> Button label for consistency
2016-12-01 14:16:33 -08:00
Kevin Sawicki
477ac313ab
Merge pull request #8086 from deepak1556/devtools_remove_workspace_patch
...
override window.confirm in devtools
2016-11-29 13:31:21 -08:00
Kevin Sawicki
72e559458f
Inline buttons and cancelId values
2016-11-29 13:30:28 -08:00
Kevin Sawicki
bb9876bd6e
Remove deprecation warning for autoSubmit
2016-11-28 15:08:28 -08:00
Samuel Attard
2bf6f28152
shouldUpload --> uploadToServer
2016-11-28 15:08:28 -08:00
Samuel Attard
4b61a4d3de
Fix linting
2016-11-28 15:08:28 -08:00
Samuel Attard
285a36f9de
Use GetUploadsEnabled to return GetShouldUpload
2016-11-28 15:08:28 -08:00
Samuel Attard
5a1a2616aa
Fix build issues
2016-11-28 15:08:12 -08:00
Samuel Attard
0d1804b2a0
Fix issues and deprecate the old prop
2016-11-28 15:08:12 -08:00
Samuel Attard
7b8eb3e09c
Rename autoUpload to shouldUpload
2016-11-28 15:08:12 -08:00
Kevin Sawicki
6f6c5c07f0
Remove unintended returns
2016-11-28 10:56:23 -08:00
Kevin Sawicki
3a29555772
Access URL through webContents directly
2016-11-28 10:56:23 -08:00
deepak1556
3ac9858726
override window.confirm in devtools
2016-11-28 01:08:48 +05:30
Cheng Zhao
bbaab755e3
Merge pull request #8049 from electron/prevent-remove-all-ipc
...
Throw an error when users attempt to remove all listeners from the IPC modules
2016-11-27 14:29:49 +08:00
Kevin Sawicki
0593696344
Remove unnecessary escape characters
2016-11-23 14:27:54 -08:00
Kevin Sawicki
0134d62681
Always use guest contents for canAccessWindow check
2016-11-23 12:01:09 -08:00
Kevin Sawicki
9a5df9da41
Expose setVisualZoomLevelLimits on webContents and <web-view>
2016-11-22 08:07:55 -08:00
Samuel Attard
db729b5b52
Throw an error when users attempt to remove all listeners from the IPC modules
2016-11-22 18:30:58 +11:00
Paul Betts
e2649ce7d8
Add new method to set layout-based zoom level limit
2016-11-21 14:59:55 -05:00
Kevin Sawicki
996ddba715
Add rpc error for ELECTRON_BROWSER_MEMBER_GET
2016-11-17 12:29:23 -08:00
Kevin Sawicki
88959079bd
Add toggledevtools menu item role
2016-11-17 10:57:20 -08:00
Kevin Sawicki
0698b5f1be
Add reload menu item role
2016-11-17 10:57:20 -08:00
Kevin Sawicki
28c39d5151
Merge pull request #8003 from electron/missing-remote-object-error
...
Throw custom error when remote object is missing from registry
2016-11-17 10:57:03 -08:00
Kevin Sawicki
5427ec4844
Negate code as per node docs
2016-11-17 10:22:29 -08:00
Kevin Sawicki
aef898ad93
Set errno on RPC error
2016-11-17 10:09:29 -08:00
Kevin Sawicki
c05ca68811
Throw custom error when remote object is missing from registry
2016-11-17 09:55:13 -08:00
Cheng Zhao
3834f0c6a6
Merge pull request #7974 from electron/chrome-runtime-response-callback
...
Implement chrome.runtime.onMessage response callback
2016-11-17 13:01:38 +09:00
Samuel Attard
7c26ec8bd4
Remove semicolon
2016-11-17 14:56:44 +11:00
Kevin Sawicki
651eaec64f
Use sender.id instead of sender.webContents.id
2016-11-16 07:50:30 -08:00
Kevin Sawicki
92577c37c8
Don't log blocked messages when guestWindow is null
2016-11-16 07:50:30 -08:00
Cheng Zhao
18fca785c4
Print error messages
2016-11-16 07:50:30 -08:00
Cheng Zhao
a1066617a8
Do permission check when calling guest window methods
2016-11-16 07:50:30 -08:00
Kevin Sawicki
5167ccd147
Guard against missing members in setObjectMembers
2016-11-16 07:45:34 -08:00
Kevin Sawicki
bea1a0643c
Memoize ELECTRON_NO_ASAR env var check
2016-11-16 07:37:53 -08:00
Birunthan Mohanathas
2986b7bc4a
Allow webview guests to be resized manually
...
This adds the `disableguestresize` property for webviews to prevent the
webview guest from reacting to size changes of the webview element. This
also partially documents the `webContents.setSize` function in order to
manually control the webview guest size.
These two features can be combined to improve resize performance for
e.g. webviews that span the entire window. This greatly reduces the lag
described in #6905 .
2016-11-15 11:00:09 -08:00
Kevin Sawicki
eeffa42513
Merge pull request #7923 from jhen0409/patch-1
...
Add support remove / clear for chrome.storage
2016-11-15 09:04:45 -08:00
Samuel Attard
01005688b6
Implement chrome.runtime.onMessage response callback
2016-11-15 21:30:40 +11:00
Kevin Sawicki
50019f39e9
🎨
2016-11-11 10:54:01 -08:00
deepak1556
5f596b22c7
specify content type depending on post data
2016-11-11 10:54:01 -08:00
deepak1556
2d7ceae320
fix js lint error
2016-11-11 10:53:00 -08:00
deepak1556
0410a184ce
webContents: handle POST navigation for new windows
2016-11-11 10:53:00 -08:00
Jhen
b86dff45d7
Add support remove / clear for chrome.storage
2016-11-12 02:16:51 +08:00
Kevin Sawicki
6fda4fc45c
Guard against attachedCallback firing while handling detachedCallback
2016-11-07 13:42:36 -08:00
Kevin Sawicki
133ad6e18b
Only set size and load URL on first attach
2016-11-07 13:42:36 -08:00
Kevin Sawicki
a737732521
Only remove guest from embedder when view id changes
2016-11-07 13:42:36 -08:00
Kevin Sawicki
73774f21b7
🎨
2016-11-07 08:28:02 -08:00
Kevin Sawicki
3c18de9c5a
Only return when guestInstance is non-null
2016-11-07 08:25:01 -08:00
Kevin Sawicki
0485069c7b
Use spread operator
2016-11-07 08:25:01 -08:00
Kevin Sawicki
e4d6aa30a1
Do truthy check in if block
2016-11-07 08:25:01 -08:00
Kevin Sawicki
89a26684e5
Return webContents directly
2016-11-07 08:25:01 -08:00
Kevin Sawicki
0e1c2b0fcb
Use for/of and remove loop variables
2016-11-07 08:25:01 -08:00
Kevin Sawicki
6eab14359c
Use ES6 style class for WebViewImpl
2016-11-07 08:25:01 -08:00
Kevin Sawicki
76f96bd99c
Destructure requires
2016-11-07 08:25:01 -08:00
Kevin Sawicki
48bcad87c2
Use template strings
2016-11-07 08:25:01 -08:00
Kevin Sawicki
712b15286c
Use let/const instead of var
2016-11-07 08:25:01 -08:00
Kevin Sawicki
3053be345b
Remove unneeded returns
2016-11-07 08:25:01 -08:00
Kevin Sawicki
e0afb814aa
Only call browserify when one of sandbox sources change
2016-11-07 08:19:59 -08:00
Kevin Sawicki
8e203592e2
🎨 Remove extra returns
2016-11-03 09:51:01 -07:00
Samuel Attard
9f18a6e65c
Use ES6 template strings, fix docs and remove _ERROR_ IPC event
2016-11-03 09:33:47 -07:00
Samuel Attard
857e1da6a3
Make executeJavaScript return a Promise so that caught errors can be sent to the caller
2016-11-03 09:33:47 -07:00
Samuel Attard
75b010ce63
Add sync executeJavaScript test
2016-11-03 09:33:47 -07:00
Samuel Attard
124fbdbd74
Allow web frame methods to return async promises
2016-11-03 09:33:47 -07:00
Brendan Forster
651b0c0f82
fixed a couple of typos
2016-10-31 08:59:26 -07:00
Cheng Zhao
dfefa00a50
Merge pull request #7577 from thomsonreuters/net_module
...
net module
2016-10-31 10:31:56 +09:00
ali.ibrahim
bdb3f4d4cb
Fixing code review issues: adding some test cases for partition/session options.
2016-10-25 16:19:26 +02:00
ali.ibrahim
b44d5290e2
Fixing code review issues: adding a partition options and making the session option only takes Session objects.
2016-10-25 15:47:54 +02:00
ali.ibrahim
61278f9ace
Fixing code review issues.
2016-10-25 12:41:01 +02:00
Kevin Sawicki
1718697ef0
Read/write find pasteboard text via IPC in renderer process
2016-10-25 14:15:54 +09:00
Kevin Sawicki
68c2c9825f
Remove lint warnings
2016-10-25 10:36:43 +09:00
Kevin Sawicki
3aad6a0c99
Use forEach and destructuring for parsing features
2016-10-25 10:31:50 +09:00
