Charles Kerr
10fd0ba655
refactor: use base::Value::Take*() ( #41169 )
...
* perf: avoid temporary strings in Converter<net::HttpRequestHeaders>::FromV8()
* perf: take strings instead of copying them in ToResponseHead()
* refactor: prefer base::Value::Take*() where appropriate
As per the base::Value docs: "prefer over `std::move(value.Get...())`
so clang-tidy can warn about potential use-after-move mistakes."
2024-05-13 15:58:52 +02:00
David Sanders
88f28a302f
docs: improve protocol.handle file examples ( #42111 )
...
* docs: improve protocol.handle file examples
* chore: fix lint
2024-05-13 11:49:18 +02:00
Richard Torres
8d4467bdc4
docs: fixing typo in dark mode fiddle and doc ( #42112 )
2024-05-13 10:50:55 +02:00
David Sanders
188196e78c
ci: auto label bug issues with version label ( #42044 )
2024-05-13 10:49:23 +02:00
Shelley Vohr
c765d57265
fix: BrowserView autoresizing conversion error ( #42056 )
2024-05-13 10:27:01 +02:00
Samuel Attard
3ea3b0e8e1
fix: ensure originalFs.promises.cp works ( #42132 )
2024-05-12 21:03:00 -07:00
Keeley Hammond
96dda274e9
chore: cherry-pick f320600cd1f4 from v8 ( #42120 )
2024-05-11 14:17:02 -07:00
electron-roller[bot]
9b0409f7c9
chore: bump chromium to 126.0.6445.0 (main) ( #41868 )
...
* chore: bump chromium in DEPS to 125.0.6421.0
* chore: bump chromium in DEPS to 125.0.6422.0
* Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/5434658
* chore: update patches
* fixup: Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
* chore: bump chromium in DEPS to 126.0.6423.0
* chore: update patches
* 5426599: Next generation control of unsafe-buffers-usage plugin
https://chromium-review.googlesource.com/c/chromium/src/+/5426599
* chore: bump chromium in DEPS to 126.0.6425.0
* chore: update patches
* Roll clang+rust llvmorg-19-init-7229-g315c88c5-2 : llvmorg-19-init-8091-gab037c4f-1 / ceab6128fa48a616bfd3e3adf4bc80133b8ee223-1 : ab71ee7a9214c2793108a41efb065aa77aeb7326-1
https://chromium-review.googlesource.com/c/chromium/src/+/5444328
Also see https://issues.chromium.org/issues/332931387
* 5445074: [Views AX] Move AXEventNotificationDetails to ui/accessibility/
https://chromium-review.googlesource.com/c/chromium/src/+/5445074
Also
5455993: [Views AX] Rename AXEventNotificationDetails to AXUpdatesAndEvents | https://chromium-review.googlesource.com/c/chromium/src/+/5455993
* Pass IsolationInfo to ContentBrowserClient::WillCreateURLLoaderFactory()
https://chromium-review.googlesource.com/c/chromium/src/+/5405301
* chore: bump chromium in DEPS to 126.0.6427.0
* chore: update patches
* chore: remove no longer needed patch
perfetto is now turned on so this patch is no longer needed.
* chore: bump chromium in DEPS to 126.0.6429.0
* chore: bump chromium in DEPS to 126.0.6431.0
* chore: bump chromium in DEPS to 126.0.6433.0
* 5466654: Do not create a console if logging to a handle
https://chromium-review.googlesource.com/c/chromium/src/+/5466654
* chore: fixup patch indices
* Address Linux NonClientFrameView Changes
- https://chromium-review.googlesource.com/c/chromium/src/+/5180720
- https://chromium-review.googlesource.com/c/chromium/src/+/5367794
* chore: bump chromium in DEPS to 126.0.6435.0
* chore: bump chromium in DEPS to 126.0.6437.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6439.0
* chore: bump chromium in DEPS to 126.0.6441.0
* 5477689: components/crash/content/tools: Format with yapf | https://chromium-review.googlesource.com/c/chromium/src/+/5477689
* 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* chore: update chromium patches
* chore: bump chromium in DEPS to 126.0.6443.0
* 5465608: Convert DCHECKs near RenderWidgetHost, DelegatedFrameHost to CHECK | https://chromium-review.googlesource.com/c/chromium/src/+/5465608
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | https://chromium-review.googlesource.com/c/chromium/src/+/5492605
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6445.0
* chore: update patches
* 5468588: Fullscreen: Encapsulate ExclusiveAccessBubble params in a struct | https://chromium-review.googlesource.com/c/chromium/src/+/5468588
* fixup! 5485006: Remove enable_print_content_analysis GN flag | https://chromium-review.googlesource.com/c/chromium/src/+/5485006
* 5461340: `size_t` in `mojo::DataPipe[Consumer|Producer]Handle`: /components. | https://chromium-review.googlesource.com/c/chromium/src/+/5461340
* 5480213: Add an EvictIds struct to FrameEvictorClient | https://chromium-review.googlesource.com/c/chromium/src/+/5480213
* 4341506: [api] Deprecate Isolate::IdleNotificationDeadline | https://chromium-review.googlesource.com/c/v8/v8/+/4341506
* 5300826: [v8-tasks] Add source location to v8::TaskRunner, step 4/4. | https://chromium-review.googlesource.com/c/v8/v8/+/5300826
* partially revert is_newly_created to allow for browser initiated about:blank loads
* add dep on app_launch_prefetch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5420149
* install sysroots from electron not from chrome
We should add a new var upstream for `download_sysroots` so that we can skip downloading chromes at all.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5462469
* refactor: make UpdateFrameHints an override
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5473548
* fix ppapi
* refactor: update namespace for pwm switches
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5459367: WebSQL: Restrict WebSQL service creation to Android only | https://chromium-review.googlesource.com/c/chromium/src/+/5459367
* 5455853: Revert "[Clipboard] Don't add meta charset tag for async write() method on Mac." | https://chromium-review.googlesource.com/c/chromium/src/+/5455853
* fixup! refactor: update namespace for pwm switches
edd9e26
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617
* 5147611: [heap] Add checks for ensuring position info slow path is not used in heap snapshot | https://chromium-review.googlesource.com/c/v8/v8/+/5147611
* fixup! 5412666: [heap] Also avoid heap allocation for allocation tracked functions | https://chromium-review.googlesource.com/c/v8/v8/+/5412666
* chore: add websql removal to breaking-changes.md
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2024-05-10 11:21:10 -04:00
dependabot[bot]
0725f5c5cf
build(deps): bump mikefarah/yq from 4.40.7 to 4.43.1 ( #42074 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.40.7 to 4.43.1.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bb66c9c872...c35ec752e3
2024-05-10 11:33:15 +02:00
David Sanders
c00eb5d491
chore: update @electron/lint-roller to 2.1.0 ( #42078 )
2024-05-10 11:00:15 +02:00
Shelley Vohr
3bd807b03e
fix: View reordering on re-addition to same parent ( #42085 )
2024-05-10 10:16:33 +02:00
Charles Kerr
e2acdffe58
perf: avoid protocol registry redundant lookup ( #41991 )
...
* perf: avoid redundant map lookup in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL()
* perf: avoid redundant map lookup in InspectableWebContents::LoadNetworkResource()
* refactor: remove unused ProtocolRegistry::IsProtocolRegistered()
refactor: remove unused ProtocolRegistry::IsProtocolIntercepted()
* refactor: remove unused ProtocolRegistry::handlers()
* refactor: rename ProtocolRegistry::FindIntercepted()
refactor: rename ProtocolRegistry::FindRegistered()
similar semantics to base::Value::Find*()
* chore: follow Google C++ brace style
chore: use same variable names as in main
2024-05-09 09:53:09 -04:00
Shelley Vohr
865b0499bb
refactor: use //ui/shell_dialogs on Linux ( #42045 )
...
* refactor: use //ui/shell_dialogs on Linux
* fix: add proper filtering
* fix: add support for missing dialog features to //shell_dialogs
* fix: parent_window could be null
* chore: cleanup patch
* fix: use a OnceCallback in the sync implementation
* chore: remove stray debuglog
* Apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use settings struct
* fix: show hidden file property checking
* chore: changes from review
* fix: multi selection for dialogs
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-05-09 09:51:42 -04:00
Shelley Vohr
6675f3ae65
fix: CHECK when adding view as its own child ( #42067 )
2024-05-09 09:47:47 -04:00
Shelley Vohr
731bc7a334
fix: BrowserWindow.center() should center relative to screen ( #42048 )
2024-05-08 15:42:20 -07:00
dependabot[bot]
793276ac87
build(deps): bump slackapi/slack-github-action from 1.25.0 to 1.26.0 ( #42076 )
2024-05-08 13:36:33 +02:00
Peter Xu
0128a072d6
docs: make corrections for BrowserViews since it is deprecated ( #42030 )
2024-05-08 11:21:26 +02:00
dependabot[bot]
a059dd7b69
build(deps): bump github/codeql-action from 3.24.0 to 3.25.3 ( #42073 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.0 to 3.25.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e8893c57a1...d39d31e687
2024-05-08 10:43:29 +02:00
dependabot[bot]
53a4484372
build(deps): bump actions-cool/issues-helper from 3.3.3 to 3.6.0 ( #42075 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.3.3 to 3.6.0.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](275328970d...a610082f8a
2024-05-08 10:42:32 +02:00
Christian Clauss
8cfc4b9d50
ci: keep GitHub Actions up to date with GitHub's Dependabot ( #42042 )
...
* Keep GitHub Actions up to date with GitHub's Dependabot
Fixes software supply chain safety warnings like at the bottom right of
https://github.com/electron/electron/actions/runs/8619491231
* [Keeping your actions up to date with Dependabot](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot )
* [Configuration options for the dependabot.yml file - package-ecosystem](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem )
* Apply suggestion from code review
* chore: fully remove groups
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-05-07 19:25:46 -04:00
Erick Zhao
c3c4173377
docs: update formatting for mdx3 compatibility ( #42052 )
...
docs: update formatting for mdx3 compat
2024-05-07 19:20:47 -04:00
cptpcrd
d5c8f2d6d9
fix: avoid crash after upgrade on Linux ( #41046 )
2024-05-07 16:04:50 +02:00
Piotr Płaczek
5b60698dea
docs: fix lint command ( #42028 )
2024-05-04 15:48:08 +02:00
Charles Kerr
05631ec445
chore: disable tests that require nut.js ( #42006 )
...
* chore: disable tests that require nut.js
* fixup! chore: disable tests that require nut.js
2024-04-30 21:13:38 -04:00
John Kleinschmidt
36310b8729
chore: fixup gn check when enable_pdf_viewer is false ( #41990 )
2024-04-30 20:32:11 -04:00
Shelley Vohr
f5fb44eaf8
fix: requestFullscreen from WebContentsView ( #41966 )
...
fix: requestFullscreen from WebContentsView
2024-04-29 19:09:29 -04:00
Shelley Vohr
441dbda833
fix: recentDocuments on macOS not working ( #41978 )
2024-04-29 19:07:14 -04:00
Michaela Laurencin
ef097b77ad
chore: fix notes stack updates ( #41600 )
...
* chore: fix removeSupercededStackUpdates for generating notes
* add early stop for less than
* Update script/release/notes/notes.js
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* clean up comparison functionality
* add tests
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-04-29 11:41:54 -04:00
Shelley Vohr
5310b79ffb
fix: setTitleBarOverlay should be implemented on BaseWindow ( #41960 )
...
fix: setTitleBarOverlay should be implemented on BaseWindow
2024-04-29 11:28:24 -04:00
Shelley Vohr
b95d0f7623
build: use env var for build-tools pinning ( #41969 )
2024-04-29 10:07:42 -04:00
Shelley Vohr
b41da150ca
build: add GitHub Actions testing pipeline for macOS ( #41812 )
...
* build: test the Mac runner space
* build: baby steps, super basic checkout
* chore: simplify depot-tools
* build: try a sync
* build: fix path
* build: pass different URL for sync
* build: gclient sync with --verbose
* debug: add logging for mtime cache
* build: add psuedocode for Azure workflow, add workflow_dispatch
* build: enable ssh access to runners
* build: test azure upload without full sync
* build: full sync and cache upload test
* build (WIP): mock out download logic
* build: remove sync, try disk space prune
* build: lets try it again, lads
* ci: add cache downloading wip
* fix: correct json parsing
* chore: use depshash and fix output syntax
* chore: rework depshash state and delete more
* refactor: split checkout to Linux runner
* fix: depot_tools get on Linux
* fix: add infra/3pp/tools/swift-format handling
* chore: move to patch file in build as well
* chore: misc cleanup of env steps
* chore: add fix sync step
* build: use tar file, strip .git dirs
* build: set GIT_CACHE_PATH outside of src
* ci: fix cache prefix, add check for ssh debug
* fix: fix tar pack/unpack
* build: add reclient support & ninja build step
* chore: clean up reclient round 1
* fix: grab ELECTRON_RBE_JWT from secrets
* chore: run tmate if debug logging enabled
* chore: move ulimit setting
* fix: missing GN gen env vars
* fix: workaround packed-refs issue
* chore: fixup PATH usage
* chore: remove GIT_CACHE env var
* fix: call pack refs manually
* fix: add RBE_experimental_credentials_helper_args
* chore: whoops we need electron_node/deps/v8 actually
* fix: we need electron_node/deps/openssl too
* build: load build-tools & xcode
* build: add dist, chromedriver & mksnapshot
* build: add test job, download artifacts
* Cache non-generated build artifacts
* chore: set download path explicitly
* chore: load-xcode is called by e build
* Add codesigning certificate step
* Add Test Step
* Try without codesigning just to get tests running
* Add depot_tools to PATH in test
* Persist src/buildtools/mac
* chore: use script/yarn test directly
* Build Node.js Headers for caching
* Add initial matrix for mas build
* Fix GN_EXTRA_ARGS generation syntax
* Fix BUILD_TYPE interpolation
* Use matrix in test correctly
* feat: add publish config, alter release-build script
* build: force trigger the first workflow
* build: oops
* Ensure env vars escaped
* Move GN_EXTRA_ARGS to gn gen step
* chore: rename yml to match convention
* ci: fix helperPath calls in action configs
* chore: try setting directly
* fix: switch to mas config
* chore: Testing -> Default
* Re-enable darwin build
* Use mas JSON config
* refactor: extract artifact logic to bash scripts
* refactor: build MAS after darwin
* chore: move to script/actions
* chore: use Node.js 20.11.x
* Don't fail-fast in tests
* build: tweak release script
* build: remove macos-publish.yml
* build: change action to trigger on publish workflow dispatch
* chore: remove SSH debugging using action-tmate
* build: do not disable CircleCI config
* chore: switch away from cURL for AzureCLI
* chore: move evm.mas.json to .github/workflows/config
* chore: remove publish logic from initial build flow
* build: add patchup check for non-release builds
* build: pin build-tools to sha 2bb63e2
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-04-24 10:29:19 -07:00
Charles Kerr
b684a98267
refactor: replace base::EndsWith() with std::ends_with() ( #41937 )
2024-04-23 21:13:59 -05:00
South Drifted
7621e7cff7
docs: Windows typo in Tutorial document ( #41896 )
...
Update tutorial-6-publishing-updating.md
2024-04-23 13:14:26 -04:00
Shelley Vohr
d8f8560b1c
refactor: address changes and fix errors in chrome://accessibility ( #41911 )
...
refactor: address changes and fix errors in chrome://accessibility
2024-04-23 11:30:47 -04:00
Kilian Valkhof
1cf194faae
docs: correct the return value for canceled showSaveDialog ( #41926 )
2024-04-23 11:29:14 -04:00
Shelley Vohr
a0fee8f47a
build: fixup codespaces on-create ( #41428 )
2024-04-22 20:26:11 -04:00
Jeremy Rose
4e8c28fdf0
fix: data corruption in protocol.handle ( #41894 )
2024-04-22 13:40:01 -07:00
tuanzijiang
46adb0a3a9
fix: offscreen rendering does not paint after gpu process crashed ( #41904 )
...
Co-authored-by: zhangqi.67 <zhangqi.67@bytedance.com>
2024-04-22 09:50:55 -04:00
Shelley Vohr
a8db7fe2ef
build: use latest devcontainer buildimage with codespaces ( #41916 )
2024-04-22 09:48:30 -04:00
Charles Kerr
0346e0a8bf
refactor: use std::erase() ( #41881 )
...
* refactor: use std::erase() in WebContentsPreferences::~WebContentsPreferences()
* refactor: use std::erase() in WindowList::RemoveWindow()
* refactor: use std::erase() in ElectronBindings::EnvironmentDestroyed()
* refactor: use std::erase() in CleanedUpAtExit::~CleanedUpAtExit()
* refactor: use std::erase_if() in ElectronBrowserContext::RevokeDevicePermission()
* refactor: use std::erase_if() in UsbChooserController::GotUsbDeviceList()
* refactor: move DoesDeviceMatch() out of class into anonymous namespace
2024-04-19 10:55:59 -05:00
Shelley Vohr
39bf441b3b
build: enable Perfetto in Chromium ( #41880 )
...
* build: enable perfetto in Chromium
* refactor: delete TracingControllerImpl
* fix: TraceObject isn't present when v8_use_perfetto is true
* fix: update lib/internal/http for perfetto
* chore: remove stray log
2024-04-19 11:07:36 -04:00
Samuel Attard
46ef7ef8fb
build: update typescript-definitions to 8.15.6 ( #41900 )
2024-04-19 10:29:45 -04:00
JakobDev
07a68c2bf8
fix: don't check for Desktop Environment in unity_service.cc ( #41211 )
...
Don't check for Desktop Environment in unity_service.cc
2024-04-19 09:58:32 -04:00
Jeremy Rose
ed9fec7da4
fix: nativeImage.createThumbnailFromPath and shell.openExternal in renderer ( #41875 )
...
* fix: nativeImage.createThumbnailFromPath in renderer
* also fix shell.openExternal
2024-04-19 09:43:01 -04:00
Shelley Vohr
c4aeb17245
fix: EINVAL when spawning cmd files on Windows ( #41893 )
...
fix: EINVAL when spawning on Windows
2024-04-19 09:27:58 -04:00
Jeremy Rose
67ba30402b
refactor: JSify BrowserWindow unresponsive handling ( #37902 )
2024-04-18 13:14:07 -07:00
Charles Kerr
b683754c16
chore: remove unused hash function ( #41876 )
...
Unused since e1e73fa#24115
2024-04-17 19:04:06 -05:00
nashaofu
0222686e9a
docs: update build docs,support Powershell on Windows ( #41567 )
...
* docs: update build docs,support Powershell on Windows
* chore: fix capitalization
2024-04-17 18:46:52 -04:00
James Yuzawa
bf754a3cae
fix: make window.flashFrame(bool) flash continuously on macOS ( #41391 )
...
fix: window.flashFrame to flash continuously on mac
This brings the behavior to parity with Windows and Linux. Prior behavior: The first `flashFrame(true)` bounces the dock icon only once (using the [NSInformationalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nsinformationalrequest ) level) and `flashFrame(false)` does nothing. New behavior: Flash continuously until `flashFrame(false)` is called. This uses the [NSCriticalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nscriticalrequest ) level instead. To explicitly use `NSInformationalRequest` to cause a single dock icon bounce, it is still possible to use [`dock.bounce('informational')`](https://www.electronjs.org/docs/latest/api/dock#dockbouncetype-macos ).
2024-04-17 12:42:34 -04:00
electron-roller[bot]
7120c58297
chore: bump node to v20.12.2 (main) ( #41710 )
...
* chore: bump node in DEPS to v20.12.0
* chore: update build_add_gn_build_files.patch
* chore: update patches
* chore: bump node in DEPS to v20.12.1
* chore: update patches
* build: encode non-ASCII Latin1 characters as one byte in JS2C
https://github.com/nodejs/node/pull/51605
* crypto: use EVP_MD_fetch and cache EVP_MD for hashes
https://github.com/nodejs/node/pull/51034
* chore: update filenames.json
* chore: bump node in DEPS to v20.12.2
* chore: update patches
* src: support configurable snapshot
https://github.com/nodejs/node/pull/50453
* test: remove test-domain-error-types flaky designation
https://github.com/nodejs/node/pull/51717
* src: avoid draining platform tasks at FreeEnvironment
https://github.com/nodejs/node/pull/51290
* chore: fix accidentally deleted v8 dep
* lib: define FormData and fetch etc. in the built-in snapshot
https://github.com/nodejs/node/pull/51598
* chore: rebase on main
* chore: remove stray log
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Cheng <zcbenz@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-04-17 12:39:13 -04:00
