* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
NB: using the braced-initializer list uncovered an error here:
the float returned by std::floor() can't be implicitly cast to
an int. This is solved by using base::ClampFloor<int>() instead.
std::floor()
fix: AutofillPopup warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
refactor: reduce #indclude scope in autofill_popup.h and autofill_popup_view.h
* perf: avoid double-calls to GetView()
There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:
if (auto* view = foo->GetView())
view->DoSomething();
* perf: avoid discarded GetView() call
* chore: bump chromium in DEPS to 115.0.5772.0
* chore: update disable_color_correct_rendering.patch
no manual changes; patch succeeded with fuzz 2.
* chore: update chromium/build_libc_as_static_library.patch
no manual changes; patch succeeded with fuzz 2 (offset 1 line).
* chore: update chromium/feat_configure_launch_options_for_service_process.patch
Xref: 4518747
patch manually reapplied due to upstream code shear
* chore: update chromium/chore_patch_out_profile_methods_in_profile_selections_cc.patch
4502965
patch manually reapplied due to upstream code shear
* chore: update bundle_locations #include location
Xref: 4525355
* chore: Remove `extension_name` from DesktopStreamsRegistry
Xref: 4514081
* chore: bump chromium in DEPS to 115.0.5778.0
* chore: add chromium/chore_patch_out_profile_methods_in_chrome_browser_pdf.patch
Xref: 4482679
Another instance of patching out upstream references to Profile code
* refactor: add WebViewGuestDelegate::GetGuestDelegateWeakPtr()
Xref: 4515455
This approach copied from GuestViewBase::GetGuestDelegateWeakPtr() approach in that same commit.
* fixup! chore: update bundle_locations #include location
Xref: 4525355
Sync namespace use to upstream base::mac -> base::apple changes
* fixup! chore: update bundle_locations #include location
Xref: 4525355
Sync namespace use to upstream base::mac -> base::apple changes
* chore: update chromium/mas_disable_remote_accessibility.patch
Xref: 4530546
patch manually reapplied due to upstream code shear
* chore: update chromium/printing.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_add_electron_tracing_category.patch
Xref: 4517872
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: 4529098
patch manually reapplied due to upstream code shear
* chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
4529098
patch manually reapplied due to upstream code shear
* chore: update chromium/mas-cgdisplayusesforcetogray.patch
Xref: 4529475
no manual changes; patch succeeded with fuzz
* chore: update chromium/build_only_use_the_mas_build_config_in_the_required_components.patch
Xref: 4429011
no manual changes; patch succeeded with fuzz
* chore: remove chromium/cherry-pick-48a136e77e6d.patch
already present upstream
* chore: remove chromium/cherry-pick-e6e23ba00379.patch
already present upstream
* [Code Health] Remove value based RegisterPref for Dict and List
Xref: 4533537
* Remove `cxx17_backports.h` and adjust unittest file
Xref: 4534916
Notes: mostly just removing #include and s/base::clamp/std::clamp/
* refactor: add FakeBrowserProcess helper class
Xref: 4424072
Used in ElectronBrowserMainParts' fake_browser_process_ field. Previously
this was an BrowserProcessImpl instance, but upstream 4424072 makes that
an abstract base class. `FakeBrowserProcess` is a thin subclass with the
minimum code needed to make it concrete.
`ElectronBrowserMainParts::fake_browser_process_` is now a `shared_ptr`
instead of a `unique_ptr` so we can avoid exposing `FakeBrowserProcess`
in the header.
* fixup! refactor: add FakeBrowserProcess helper class
remove unnecessary unique_ptr
* fix: Browser::SetDockIcon() when !Browser.is_ready()
Xref: 4410741
An alternative fix for https://github.com/electron/electron/pull/36279 .
The previous fix was to call `SetSupportedScales()` ourselves (1b1609a),
but upstream has removed this API.
CC @codebytere
* fixup! chore: remove chromium/cherry-pick-e6e23ba00379.patch
* chore: update chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch
Xref: 4517404
patch manually reapplied due to upstream code shear
* chore: update patches
* chore: add dep: resource_coordinator:mojo_bindings
Xref: 4521464
* fixup! chore: add dep: resource_coordinator:mojo_bindings
chore: make lint happy
* chore: patch out Profile methods in titlebar_config
Xref: 4508143 (primary)
Xref: 4534461 (followup)
* chore: bump chromium in DEPS to 115.0.5780.0
* chore: update chromium/disable_hidden.patch
no manual changes; patch succeeded with fuzz
* chore: update chromium/sysroot.patch
Xref: 4535715
no manual changes; patch succeeded with fuzz
* chore: update chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch
Xref: 4403623
patch manually reapplied due to upstream code shear
* chore: update chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
Xref: 4547380
patch manually reapplied due to upstream code shear
* chore: update patches
* fixup! fix: Browser::SetDockIcon() when !Browser.is_ready()
chore: iwyu image.h
* chore: bump chromium in DEPS to 115.0.5782.0
* chore: bump chromium in DEPS to 115.0.5784.0
* 4514181: CR2023: Update filled cr-input styles.
4514181
* 4521894: Remove SiteInstanceDeleting usage outside of tests.
4521894
* 4525355: Move backup_util and bundle_locations to base/apple
4525355
* 4484743: webauthn: add underlying support for calling iCloud Keychain on macOS.
4484743
* chore: fixup patch indices
* 4546398: Convert /chrome/browser to use ARC
4546398
* chore: bump chromium in DEPS to 115.0.5786.0
* chore: update patches
* 4540682: Initialize PDF SDK with policy in chrome_pdf::RenderPDFPageToDC()
4540682
* Don't import ObjC++ fn headers into electron_api_app
* 4535715: Refactor sysroot-creator.sh
4535715
* fixup! refactor: add FakeBrowserProcess helper class
* 4531903: [string][test] Create/Copy strings to old space before externalization
4531903
* 59645: Add APIs to support RSA keys with large e.
https://boringssl-review.googlesource.com/c/boringssl/+/59645
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: bump chromium in DEPS to 100.0.4880.0
* resolve conflicts
* chore: update patches
* fix patch
* PIP20: add a new DocumentOverlayWindowViews subtype
3252789
* Clean up PictureInPictureWindowManager::EnterPictureInPicture()
3424145
* Remove StoragePartitionId.
2811120
* Remove FLoC code
3424359
* media: Make AddSupportedKeySystems() Async
3430502
* [Extensions] Move some l10n file util methods to //extensions/browser
3408192
* chore: IWYU
* Reland "webhid: Grant permissions for policy-allowed devices"
3444147
* Migrate base::Value::GetList() to base::Value::GetListDeprecated(): 2/N.
343572734409103440088
* [text blink period] Cache blink period instead of fetching from defaults
3419059
* chore: update picture-in-picture.patch
3252789
* ci: update to Xcode 13.2.1
3437552
* chore: bump chromium in DEPS to 100.0.4882.1
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4884.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4886.0
* chore: update patches
* Refactor DownloadManager to use StoragePartitionConfig
3222011
* Remove ToWebInputElement() in favor of new WebNode::DynamicTo<> helpers.
3433852
* refactor: autofill to use the color pipeline
https://bugs.chromium.org/p/chromium/issues/detail?id=1249558https://bugs.chromium.org/p/chromium/issues/detail?id=1003612
* [ProcessSingleton] Add many more trace events to cover all scenarios
3429325
* fixup! PIP20: add a new DocumentOverlayWindowViews subtype
* chore: bump chromium in DEPS to 100.0.4888.0
* chore: update patches
* chore: update picture-in-picture.patch
* fixup! refactor: autofill to use the color pipeline
* ci: fixup fix sync
(cherry picked from commit c1e3e395465739bce5ca8e1c5ec1f5bd72b99ebd)
* chore: bump chromium in DEPS to 100.0.4889.0
* chore: update patches
* chore: fix feat_add_data_transfer_to_requestsingleinstancelock.patch
* fixup! PIP20: add a new DocumentOverlayWindowViews subtype
* Remove remaining NativeTheme::GetSystemColor() machinery.
3421719
* ci: fetch proper esbuild for macos
* ci: fixup fetch proper esbuild for macos
* fix: failing Node.js test on outdated CurrentValueSerializerFormatVersion
* chore: bump chromium in DEPS to 100.0.4892.0
* 3460365: Set V8 fatal error callbacks during Isolate initialization
3460365
* 3454343: PIP20: use permanent top controls
3454343
* 3465574: Move most of GTK color mixers to ui/color/.
3465574
* chore: fixup patch indices
* 3445327: [locales] Remove locales reference
3445327
* 3456548: [DBB][#7] Blue border falls back to all tab if cropped-to zero pixels
3456548
* 3441196: Convert GuestView's remaining legacy IPC messages to Mojo
3441196
* 3455491: Don't include run_loop.h in thread_task_runner_handle.h
3455491
* fixup! 3454343: PIP20: use permanent top controls
* 3442501: Add missing includes of //base/observer_list.h
3442501
* 3437552: mac: Deploy a new hermetic build of Xcode 13.2.1 13C100
3437552
* chore: bump chromium in DEPS to 100.0.4894.0
* fixup! 3460365: Set V8 fatal error callbacks during Isolate initialization
* chore: update patches
* 3425231: Use DnsOverHttpsConfig where appropriate
3425231
* test: disable test-heapsnapshot-near-heap-limit-worker.js
As a result of CLs linked in https://bugs.chromium.org/p/v8/issues/detail?id=12503,
heap snapshotting near the heap limit DCHECKS in Node.js specs. This will
likely require a larger refactor in Node.js so i've disabled the test for
now and opened an upstream issue on node-v8 issue
at https://github.com/nodejs/node-v8/issues/218.
* Port all usage of NativeTheme color IDs to color pipeline
https://bugs.chromium.org/p/chromium/issues/detail?id=1249558
* chore: update patches after rebase
* ci: use gen2 machine for more disk space
* ci: don't try to make root volume writeable
* ci: use older xcode/macos for tests
* fix: html fullscreen transitions stacking
(cherry picked from commit 5e10965cdd7b2a024def5fc568912cefd0f05b44)
* ci: speed up woa testing
(cherry picked from commit 75c33c48b032137794f5734348a9ee3daa60d9de)
(cherry picked from commit e81996234029669663bf0daaababd34684dcbb17)
* ci: disable flaky tests on WOA
* ci: run remote tests separately to isolate issue there
* tests: disable node test parallel/test-worker-debug for now
* revert: fix: html fullscreen transitions stacking
* tests: disable flaky test on macOS arm64
* fixup circleci config so build tools can find xcode version
* make sure the workspace is clean before job runs
(cherry picked from commit 75f713c9748ac1a356846c39f268886130554fd6)
* tests: disable flaky test on Linux
* ci: debug why windows i32 is crashing
* Revert "ci: debug why windows i32 is crashing"
This reverts commit 4c4bba87ea76f16ef3b304dadff59ad4d366f60f.
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: bump chromium in DEPS to 97.0.4678.0
* chore: bump chromium in DEPS to 97.0.4679.0
* chore: bump chromium in DEPS to 97.0.4680.0
* chore: bump chromium in DEPS to 97.0.4681.0
* chore: bump chromium in DEPS to 97.0.4682.0
* chore: update patches
* 3234737: Disable -Wunused-but-set-variable
Ref: 3234737
* 3216953: Reland "Move task-related files from base/ to base/task/"
Ref: 3216953
* 3202710: TimeDelta factory function migration.
Ref: 3202710
* 3226841: Rename WCO::RenderProcessGone to PrimaryMainFrameRenderProcessGone
Ref: 3226841
* 3212165: blink/gin: changes blink to load snapshot based on runtime information
Ref: 3212165
* 3220292: Deprecate returning a GURL from GURL::GetOrigin()
Ref: 3220292
* 3231995: build: Enable -Wbitwise-instead-of-logical everywhere except iOS and Windows
Ref: 3231995
* 3205121: Remove base::DictionaryValue::GetDouble
Ref: 3205121
* 3208413: [flags] Make --js-flags settings have priority over V8 features
Ref: 3208413
* chore: bump chromium in DEPS to 97.0.4683.0
* chore: update patches
* 3188834: Combine RWHVBase GetCurrentDeviceScaleFactor/GetDeviceScaleFactor
Ref: 3188834
* chore: update process_singleton patches
* chore: bump chromium in DEPS to 97.0.4684.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4685.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4686.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4687.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4688.0
* chore: update patches
* 3247722: Use correct source_site_instance if navigating via context menu
Ref: 3247722
Update signature of HandleContextMenu()
* 3247722: Use correct source_site_instance if navigating via context menu
Ref: 3247722
Update signature of HandleContextMenu()
* 3223422: Remove PP_ISOLATEDFILESYSTEMTYPE_PRIVATE_PLUGINPRIVATE enum option
Ref: 3223422
sync pepper_plugin_support.patch with upstream
* chore: bump chromium in DEPS to 97.0.4689.0
* 3247791: ax_mac_merge: Merge AX Math attribute implementations
Xref: ax_mac_merge: Merge AX Math attribute implementations
chore: fix minor patch shear in #includes
* 3243425: Add VisibleTimeRequestTrigger helper class
Xref: 3243425
chore: fix minor patch shear in #includes
* chore: regen chromium patches
* fixup! 3247722: Use correct source_site_instance if navigating via context menu
* chore: bump chromium in DEPS to 97.0.4690.0
* 3188659: Window Placement: make GetScreenInfo(s) const
Xref: 3188659
simple sync GetScreenInfo with upstream refactor
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4690.4
* chore: bump chromium in DEPS to 97.0.4692.0
* 3198073: ozone: //content: clean up from USE_X11
Xref: 3198073
Fixing patch shear. Nothing to see here.
* 3252338: Remove label images checkbox from chrome://accessibility page
Xref: 3252338
Part of our a11y patch is no longer needed due to upstream label removal
* 3258183: Remove DISALLOW_IMPLICIT_CONSTRUCTORS() definition
Xref: 3258183
Replace our use of the macro with explicitly-deleted class methods.
See 3256952
for upstream examples of this same replacement.
* chore: update patches
* 3247295: Unwind SecurityStyleExplanations
Xref: 3247295
update GetSecurityStyle() signature and impl to match upstream changes
* 3259578: media: grabs lock to ensure video output when occluded
Xref: 3259578
Add stub for new upstream virtual method OnCapturerCountChanged()
* fixup! 3247295: Unwind SecurityStyleExplanations
* 3238504: Fix up drag image is not shown from bookmark bar
Xref: 3238504
SetDragImage() no longer takes a widget argument
* 3217452: [devtools] Add getSyncInformation host binding
Xref: 3217452
Add stub for new upstream method GetSyncInformation(). Stub sends info back to caller saying that syncing is disabled.
* chore: bump chromium in DEPS to 98.0.4693.0
* chore: bump chromium in DEPS to 98.0.4694.0
* chore: bump chromium in DEPS to 98.0.4695.0
* chore: bump chromium in DEPS to 98.0.4696.0
* chore: bump chromium in DEPS to 98.0.4697.0
* chore: bump chromium in DEPS to 98.0.4699.0
* chore: bump chromium in DEPS to 98.0.4701.0
* chore: bump chromium in DEPS to 98.0.4703.0
* chore: bump chromium in DEPS to 98.0.4705.0
* chore: bump chromium in DEPS to 98.0.4706.0
* chore: update patches
* 3279210: Rename "base/macros.h" => "base/ignore_result.h"
3279210
* 3259964: Remove all DISALLOW_COPY_AND_ASSIGNs
3259964
* 3269029: blink/gin: sets histogram callbacks during isolate creation
3269029
* fixup after rebase
* [content] Make ContentMainParams and MainFunctionParams move-only
3244976
* 3255305: Stop sending the securityStateChanged event and unwind
3255305
* [Blink] Add promise support to WebLocalFrame::RequestExecuteScript()
3230010
* 3256162: Simplify RWHV Show and ShowWithVisibility handling
3256162
* 3263824: ozone: //ui/base: clean up from USE_X11 1/*
3263824
* Request or cancel RecordContentToPresentationTimeRequest during capture
3256802
* appcache: remove BrowsingData/quota references
3255725
* [Autofill] Don't show Autofill dropdown if overlaps with permissions
3236729
* Rename to_different_document to should_show_loading_ui in LoadingStateChanged() callbacks
3268574
* cleanup patch
* fixup [content] Make ContentMainParams and MainFunctionParams move-only
* 3279210: Rename "base/macros.h" => "base/ignore_result.h"
3279210
* ozone: //chrome/browser clean up from USE_X11
3186490
Refs: https://github.com/electron/electron/issues/31382
* chore: update support_mixed_sandbox_with_zygote.patch
* Enable -Wunused-but-set-variable.
Refs 3234737
* fixup! ozone: //ui/base: clean up from USE_X11 1/*
* fixup! ozone: //chrome/browser clean up from USE_X11
* chore: fix deprecation warning in libuv
* chore: fixup for lint
* 3251161: Reland "Make the Clang update.py script require Python 3"
3251161
* fixup: Enable -Wunused-but-set-variable.
* [base][win] Rename DIR_APP_DATA to DIR_ROAMING_APP_DATA
3262369
* Replace sandbox::policy::SandboxType with mojom Sandbox enum
3213677
* fixup: [content] Make ContentMainParams and MainFunctionParams move-only
* build: ensure angle has a full git checkout available to it
* fixup: [base][win] Rename DIR_APP_DATA to DIR_ROAMING_APP_DATA
* fixup lint
* [unseasoned-pdf] Dispatch 'afterprint' event in PDF plugin frame
3223434
* fixup: [Autofill] Don't show Autofill dropdown if overlaps with permissions
* 3217591: Move browser UI CSS color parsing to own file part 2/2
3217591
* Make kNoSandboxAndElevatedPrivileges only available to utilities
3276784
* 3211575: [modules] Change ScriptOrModule to custom Struct
3211575
* Address review feedback
* chore: update patches
* 3211575: [modules] Change ScriptOrModule to custom Struct
3211575
* fix: unused variable compat
* chore: remove redundant patch
* fixup for 3262517: Re-enable WindowCaptureMacV2
3262517
* chore: cleanup todo
The functions added in 3256802 are not used by offscreen rendering.
* fixup: update mas_no_private_api.patch
* 3216879: [PA] Make features::kPartitionAllocLazyCommit to be PartitionOptions::LazyCommit
Ref: 3216879 Fixes up commit b2f1aca95604ec61649808c846657454097e6935
* chore: cleanup support_mixed_sandbox_with_zygote.patch
* test: use window focus event instead of delay to wait for webContents focus
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
