Shelley Vohr
ffd43c1886
remove quotes and const replaces
2017-10-25 10:17:41 -04:00
Shelley Vohr
c0f2a7b44a
fix standard issues
2017-10-25 09:56:02 -04:00
Shelley Vohr
f129622446
clean up remote
2017-10-25 09:51:21 -04:00
Shelley Vohr
042f84140d
Merge pull request #10896 from electron/update_desktop_capturer
...
Update desktop capturer to ES6
2017-10-25 08:56:30 -04:00
Shelley Vohr
135454342d
remove .only from spec
2017-10-24 22:41:28 -04:00
Shelley Vohr
f7bc5481f3
add a few more tests to api_menu_spec
2017-10-24 22:40:31 -04:00
Matt Lyons
424f9aeae6
🐧 Don't wait for xdg-open to exit
...
Waiting for xdg-open to return freezes Electron application.
Some file managers (ex: Nemo) don't return until some time after they are closed, this freezes the Electron application until the process returns.
The same is true about any application that can potentially be opened with OpenItem
2017-10-24 19:39:54 -07:00
Shelley Vohr
d54148de4e
remove from spec
2017-10-24 20:31:02 -04:00
Shelley Vohr
0e6100ae17
upgrade menu spec to ES6
2017-10-24 20:27:26 -04:00
Felix Rieseberg
8d1ff1c59a
Merge pull request #10900 from electron/issue-10877
...
fix: Ensure that -r isn’t considered interactive
2017-10-24 17:21:08 -07:00
Felix Rieseberg
c38f66cc1b
🔧 Ensure that -r isn’t considered interactive
2017-10-24 17:00:42 -07:00
Shelley Vohr
7593bec687
update reviewed items
2017-10-24 19:36:06 -04:00
Shelley Vohr
e8935232b1
clean falsy statements
2017-10-24 18:52:12 -04:00
John Kleinschmidt
7e1adfcab7
Apply escape analysis patch
2017-10-24 16:28:05 -04:00
Shelley Vohr
98df153750
convert to map and remove shift param
2017-10-24 15:47:09 -04:00
Shelley Vohr
491a00fd84
clean main process desktop_capturer
2017-10-24 12:49:37 -04:00
Vanessa Yuen
aaa8aec946
trying out parameterized builds in circle
2017-10-24 12:42:45 -04:00
Shelley Vohr
b58ceae69c
appease linter gods
2017-10-24 12:28:15 -04:00
Shelley Vohr
43e118fe45
update desktop capturer and remove unnessary vars
2017-10-24 12:01:51 -04:00
John Kleinschmidt
36a51bbf4d
Merge pull request #10893 from maxibanki/patch-1
...
Fixed typo
2017-10-24 10:52:14 -04:00
Max Schmitt
c1cad655c8
Fixed typo
...
`thrid-party` => `third-party`
2017-10-24 11:46:14 +02:00
Jonas Zhang
e7649a800a
Add a little translation for zh-CN
...
Add a little translation for zh-CN
2017-10-24 14:02:07 +08:00
Shelley Vohr
75f32afcd5
clean up excess code from generateGroupId
2017-10-24 00:24:57 -04:00
Shelley Vohr
f93121b226
don't reassign parameters in Menu.prototype.popup
2017-10-24 00:07:39 -04:00
Shelley Vohr
b1e707d535
abstract out switch case from Menu.prototype.insert
2017-10-23 23:46:39 -04:00
Shelley Vohr
7c0f7329d9
appease the linter overlords
2017-10-23 22:35:42 -04:00
Shelley Vohr
508b614769
remove excess code in delegate
2017-10-23 22:33:23 -04:00
Shelley Vohr
9b364d5be3
refactor menuWillShow
2017-10-23 22:22:39 -04:00
Shelley Vohr
9038987e1d
significant cleanup; all tests still passing
2017-10-23 20:04:22 -04:00
Zeke Sikelianos
1672fd22e1
Merge pull request #10874 from Toinane/master
...
Update OSR with more details
2017-10-23 15:54:31 -07:00
Shelley Vohr
3fc5d51a96
clean up delegate
2017-10-23 18:35:16 -04:00
Shelley Vohr
577c0042b0
update to ES6
2017-10-23 14:47:47 -04:00
Toinane
db5a429948
fixe grammar
2017-10-23 18:36:52 +02:00
Shelley Vohr
87802b2c17
initial port of things into a Menu class
2017-10-23 12:11:59 -04:00
John Kleinschmidt
66846bff97
Automate release ( #10827 )
...
* Create prepare-release script
* Add script to merge release
* Cleanup/add logging
* Move release process out of upload.py
* Add cleanup release branch
* Update release doc to reflect new scripts
* Fix to allow running with notesOnly
Also fixup release name and body when beta release.
* Fix issues found during release
* Use getRelease instead of getAssets
github.repos.getAssets is limited to 30 entries which means we may not get back the file we are looking for.
* Documentation corrections
2017-10-23 11:02:50 -04:00
John Kleinschmidt
67f0eb7b3b
Merge pull request #10873 from ahmedmohamedali/fix_issue_10697
...
Fixes #10697
2017-10-23 09:32:28 -04:00
Shelley Vohr
61a93c711c
clean up popup
2017-10-23 00:47:02 -04:00
Shelley Vohr
f9c3123f5f
clean up menuWillShow
2017-10-23 00:16:35 -04:00
Shelley Vohr
1cd53768ab
clean up indexToInsertByPosition
2017-10-22 23:57:23 -04:00
Shelley Vohr
b7ebee985b
refactor indexOfItemById
2017-10-22 23:51:33 -04:00
Toinane
42f51850cc
Update OSR with more details
2017-10-22 00:15:30 +02:00
Ahmed Mohamed Ali
463260b249
Electron crashes if user clicks Dev Tools & Zoom options #10697
2017-10-21 22:21:24 +02:00
Taeho Kim
f8048977ac
📝 Use separate entitlements for login helper
2017-10-21 20:52:20 +09:00
Ted Kim
4119da607f
Implement login helper to manage login item in Mac App Store build
2017-10-20 11:44:19 +09:00
Zeke Sikelianos
306b627090
Merge pull request #10839 from qazbnm456/update_docs
...
[docs] update app.md
2017-10-18 20:35:11 -07:00
John Kleinschmidt
90e7d7e112
v1.8.2-beta.1
2017-10-18 16:49:32 -04:00
Boik
7be79613b8
according to https://github.com/electron/electron/pull/10670 , update app.md
2017-10-19 00:56:05 +08:00
John Kleinschmidt
cf12d31875
Merge pull request #10834 from Vehemos/master
...
Updated online-offline-events.md
2017-10-18 10:06:27 -04:00
Sarthak Tripathi
32f92f7a90
Updated online-offline-events.md
...
Improved readability and simplicity.
2017-10-18 19:26:19 +05:30
Sarthak Tripathi
392f4b44f0
Updated online-offline-events.md
...
Added links, removed grammatical error.
2017-10-18 19:11:05 +05:30
