mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
611 commits 1 branch 183 tags 5.3 GiB
Commit graph

544 commits

Author SHA1 Message Date
Cheng Zhao
f05199d4e4 Don't be too strict on media requests. 2014-08-11 23:22:49 +08:00
Cheng Zhao
eafa888757 Enable devtools experiments. 2014-08-11 10:42:50 +08:00
Cheng Zhao
760f7ed24f Fix "warning: field 'widget_' is uninitialized when used here". 2014-08-09 09:34:06 +08:00
Cheng Zhao
4ed7934567 mac: Close devtools when web contents is destroyed. 
After the BRYInspectableWebContentsView is added as subview to other
NSWindow owned by users, the view_ would not be dealloc when the web
contents got destroyed, which made the devtools window a ghost.
 2014-08-08 12:45:26 +08:00
Cheng Zhao
f455798c05 Fix cpplint warnings. 2014-08-07 10:50:50 +08:00
Cheng Zhao
e5a57b02d8 Focus on devtools when it is opened on Mac. 2014-08-07 10:48:02 +08:00
Haojian Wu
5a5c92ad2d Add remote debugging support. 2014-07-30 22:19:05 +08:00
Cheng Zhao
7b6fbff40d Implement BrowserClient::GetDefaultDownloadDirectory(). 2014-07-28 17:48:55 +08:00
Cheng Zhao
a866718b49 Initialize ProxyResolverV8 at very early phrase. 
In atom-shell we need to ensure node environment is initialized after the
ProxyResolverV8 has been initialized.
 2014-07-28 15:28:38 +08:00
Cheng Zhao
a8e879d0c5 mac: Fix blank page after devtools is opened. 2014-07-28 12:40:38 +08:00
Cheng Zhao
8ff2683ae8 Ignore warning 4189 on Windows. 
The warning comes from mojo/public/cpp/system/core.h.
 2014-07-28 12:12:14 +08:00
Cheng Zhao
f552dc7ba4 mac: Fix the notification presenter of new API. 2014-07-28 11:52:26 +08:00
Cheng Zhao
e52a089ec2 mac: Remove usages of WebContentsView. 2014-07-28 09:34:42 +08:00
Cheng Zhao
edbce1c167 Update libchromiumcontent to fix gfx::display link errors. 2014-07-28 00:21:58 +00:00
Cheng Zhao
d47a94b1fe DispatchBeforeUnload is now a method of WebContents. 2014-07-27 11:27:05 +00:00
Cheng Zhao
8d6a879707 Update libchromiumcontent to include mojo headers. 2014-07-27 11:27:04 +00:00
Cheng Zhao
9821cd1f58 web_contents_view.h has been hidden from user. 2014-07-27 11:27:04 +00:00
Cheng Zhao
a98199511a Implement GetGuestManagerDelegate. 2014-07-27 11:27:04 +00:00
Cheng Zhao
8bf3e084f1 Interface of ProxyResolverV8 has changed. 2014-07-27 11:27:04 +00:00
Cheng Zhao
bb87492897 No more need to init aura::Env. 2014-07-27 11:27:04 +00:00
Cheng Zhao
6dd580526e Refactor notification presenter for new desktop notification interface. 2014-07-27 11:27:04 +00:00
Cheng Zhao
4e63780e4a Prototype of WebContentsDestroyed has changed. 2014-07-27 10:27:19 +00:00
Cheng Zhao
8c38a7547b Upgrade libchromiumcontent to chrome36. 2014-07-27 08:08:27 +00:00
Cheng Zhao
a318b1c5d1 views: Use DesktopNativeWidgetAura for menu view. 2014-07-14 15:56:04 +08:00
Cheng Zhao
46e765f79b Fix crash when closing docked devtools by clicking close button. 
We need to send ack for the close message, so we should destroy web contents
after the beforeunload event has fired.
 2014-07-13 10:08:28 +08:00
Cheng Zhao
9d4e977c01 win: Fix window frame on detached window. 2014-07-12 21:26:29 +08:00
Cheng Zhao
cf1009ab30 Refactor the AddPakPaths to make it possible to set pak's scale factor. 
This is needed when adding high DPI resources.
 2014-07-12 21:16:13 +08:00
Cheng Zhao
8d3f615e61 win: Setup font. 2014-07-12 19:46:26 +08:00
Cheng Zhao
0f5b427648 Always shows window frame except for maximized window on Unity. 2014-07-12 11:45:24 +08:00
Cheng Zhao
14235a65a9 Merge pull request #60 from brightray/new-mac-devtools 
Rewrite the devtools view for Chromium's new devtools architecture
 2014-07-11 23:36:49 +08:00
Cheng Zhao
a080d2c5bb Remove GetNativeView() when compiled with views toolkit. 2014-07-11 23:32:00 +08:00
Cheng Zhao
4b57e1f4f8 Warn about using GetNativeView() in views. 2014-07-11 23:14:20 +08:00
Cheng Zhao
52c521f8b0 Remove duplicate library. 2014-07-11 23:10:57 +08:00
Cheng Zhao
891b7434db Separate the message parsing into a new function. 2014-07-11 23:03:42 +08:00
Cheng Zhao
de08cc1d52 No need for custom dealloc. 2014-07-11 22:22:03 +08:00
Cheng Zhao
e553e11226 Use shortcut way to create scoped_ptr. 2014-07-11 21:55:57 +08:00
Ted Nyman
88e168ada4 Time goes on 2014-07-11 00:39:21 -07:00
Cheng Zhao
24c1544ca5 Upgrade libchromiumcontent to 4b4bcec11a02d1c7981562cf0b8a4670c338992b. 2014-07-09 20:14:49 +08:00
Cheng Zhao
739b352de6 Only init WMState on Linux. 2014-07-09 20:06:31 +08:00
Cheng Zhao
a0ee4a9bf1 Ignore C4819 warning in VS. 2014-07-09 20:04:30 +08:00
Cheng Zhao
aba65c23f6 Give user a chance to override child process and framework path. 2014-07-09 17:07:00 +08:00
Cheng Zhao
d5283b2337 Allow access FileSystem api in devtools. 
It is required by the load/save feature of profilers.
 2014-07-09 15:38:53 +08:00
Cheng Zhao
1fbeb11371 Send message ack to devtools. 2014-07-09 15:34:10 +08:00
Cheng Zhao
a5bb24284e views: Follow WidgetDelegateView's convention on deleting self. 
It could avoid invoking WidgetDelegate's methods when the delegate has been
deleted as a view.
 2014-07-09 11:08:17 +08:00
Cheng Zhao
9747ee4411 Fix cpplint warning for obj-c header. 2014-07-09 10:38:00 +08:00
Cheng Zhao
81d31b1d49 Remove Windows's devtools implementation. 2014-07-09 10:37:54 +08:00
Cheng Zhao
0a7b1fdd87 Add new devtools messages in Chrome 35. 2014-07-09 10:26:01 +08:00
Cheng Zhao
7a196933bb views: Don't leak ViewsDelegate. 2014-07-09 10:26:01 +08:00
Cheng Zhao
651ebdde65 views: Remember bounds of devtools window. 2014-07-09 10:26:01 +08:00
Cheng Zhao
4fb4b2d7ba views: Implement undocked devtools. 2014-07-09 10:26:01 +08:00
Cheng Zhao
e574bf6d0f views: Initial docked devtools implementation. 2014-07-09 10:26:01 +08:00
Cheng Zhao
4048d491f0 views: Use chromium's custom frame view. 2014-07-09 10:26:01 +08:00
Cheng Zhao
da5daecb1d Initialize aura environment. 2014-07-09 10:26:01 +08:00
Cheng Zhao
02f52f7e20 Allow override BrowserMainParts::InitProxyResolverV8. 2014-07-09 10:26:01 +08:00
Cheng Zhao
8f3546ed30 Initialize screen for aura. 2014-07-09 10:26:01 +08:00
Cheng Zhao
bad7b95ed7 Add ViewsDelegate, required when using views::Widget on aura. 2014-07-09 10:26:01 +08:00
Cheng Zhao
2682f3db87 Ignore *_views files on mac. 2014-07-09 10:26:01 +08:00
Cheng Zhao
d59c027996 Link with chromiumviews on Linux and Windows. 
Without using chromiumviews it would be quite hard to setup a fully working
environment with Aura on Linux now.
 2014-07-09 10:26:01 +08:00
Cheng Zhao
48ed03eb39 Initialize Linux UI. 2014-07-09 10:26:01 +08:00
Cheng Zhao
d4e81da19a Make BrowserMainParts's overrides available on all platforms. 2014-07-09 10:26:01 +08:00
Cheng Zhao
bc6237375e Define TOOLKIT_VIEWS for Linux. 2014-07-09 10:26:01 +08:00
Cheng Zhao
7050b7944f Remove devtools view on Linux. 
GTK+ has been replaced, we need to rewrite the whole thing.
 2014-07-09 10:24:10 +08:00
Cheng Zhao
7f5b84fdea Aura has replaced GTK+ in Linux. 2014-07-09 10:24:10 +08:00
Cheng Zhao
563d6e87ff Fix cpplint warning. 2014-07-09 10:24:10 +08:00
Cheng Zhao
1722532e6d No need to remember dock state. 
All devtools states are remembered by devtools itself now.
 2014-07-09 10:24:10 +08:00
Cheng Zhao
7a2dc3fc4f mac: Make focus back to browser window when devtools is closed. 2014-07-09 10:24:10 +08:00
Cheng Zhao
2efeaa268f Place DevTools WebContents underneath inspected WebContents. 
This commit has this strategy implemented on Mac.

See https://code.google.com/p/chromium/issues/detail?id=318751.
 2014-07-09 10:24:10 +08:00
Cheng Zhao
7d130c9697 mac: Revert to simplest undocked-only devtools. 
This makes porting Chrome's devtools easier.
 2014-07-09 10:24:10 +08:00
Adam Roben
8f367f6b35 More coding style fixes 2014-07-07 14:42:30 -04:00
Adam Roben
859051669b Make sure our copy of gyp is used 
If gyp is installed on the system, gyp_main.py might find it instead of our own
version.
 2014-07-07 14:42:02 -04:00
Adam Roben
e86c409e6b Update DevToolsWindow to use views and aura 
This is required to make it work in Chrome 35.
 2014-07-07 14:27:23 -04:00
Adam Roben
f65246b3cd Fix coding style 2014-07-07 14:27:02 -04:00
Adam Roben
8f2a2e19b5 Really fix unused-variable warnings 
I misunderstood how ALLOW_UNUSED is meant to be used. Using a macro like
MSV_WARNING_SUPPRESS() would be nice, but for some reason it isn't working for
me. So now we just manually reference the variable in the code.
 2014-07-07 14:21:40 -04:00
Adam Roben
5b2a62627e Silence unused variable warning on Windows 2014-07-07 13:55:10 -04:00
Adam Roben
6bae1f4b44 Set up a native screen on Windows 
This is needed to prevent a crash inside aura::WindowTreeHost::InitCompositor.
 2014-07-07 13:53:24 -04:00
Adam Roben
a1cf58f811 Link against chromiumviews 
This is needed for InspectableWebContentsViewWin.
 2014-07-07 13:53:02 -04:00
Adam Roben
8fd78b3593 Pull in generated headers from libchromiumcontent 
ui/views/view.h now includes ui/accessibility/ax_enums.h, which is a generated
header.
 2014-07-07 12:28:10 -04:00
Adam Roben
ae1995f849 Update libchromiumcontent for better Chrome 35 support 
* vendor/libchromiumcontent ded3c0a...331dbed (2):
  > Merge pull request #48 from brightray/chrome35-brightray
  > Merge pull request #49 from brightray/linux-fix
 2014-07-07 12:27:38 -04:00
Adam Roben
1269e59a35 Update for move of string conversion functions into base:: 2014-06-27 14:02:44 -04:00
Adam Roben
08c017bd7d Ignore a couple more files on Windows 2014-06-27 13:45:04 -04:00
Adam Roben
307d936d75 Update to use CR_* Windows message macros 
See https://codereview.chromium.org/146833020.
 2014-06-27 13:40:33 -04:00
Adam Roben
78dd3390f5 Define USE_AURA for Windows 
This is true inside of libchromiumcontent, so we need to mirror that here.
 2014-06-27 13:40:06 -04:00
Adam Roben
f8b44a1785 Use the MSBuild that comes with Visual Studio 
See http://msdn.microsoft.com/en-us/library/hh162058.aspx
 2014-06-27 12:06:48 -04:00
Adam Roben
918f38e13f Fix long line 2014-06-27 11:59:01 -04:00
Adam Roben
9602a9aed9 Fix assertion in InitializeICU on launch 
We have to tell Chromium about our framework bundle earlier in the launch
sequence so it can find icudtl.dat. See
https://codereview.chromium.org/12470006
 2014-06-27 11:54:28 -04:00
Adam Roben
8e7fbd604c Update for move of BuildUserAgentFromProduct in Chrome 35 
See https://codereview.chromium.org/186883002
 2014-06-27 11:54:28 -04:00
Adam Roben
51ac56e4c4 Update cookie store code for Chrome 35 
See https://codereview.chromium.org/110883017
 2014-06-27 11:54:28 -04:00
Adam Roben
afc889b883 Update NetworkDelegate for Chrome 35 2014-06-27 11:54:27 -04:00
Adam Roben
3a71958e16 Update MediaStreamDevicesController for Chrome 35 
See https://codereview.chromium.org/180633008
 2014-06-27 11:54:27 -04:00
Adam Roben
e003cc9a0a Update MediaCaptureDevicesDispatcher for Chrome 35 
See https://codereview.chromium.org/183743021
 2014-06-27 11:54:27 -04:00
Adam Roben
5b788476a5 Update for move of string symbols into base:: 2014-06-27 11:54:27 -04:00
Adam Roben
5b93dc74e6 Update BrowserContext for Chrome 35 2014-06-27 11:54:27 -04:00
Adam Roben
42b86242ea Add support for Chrome 35's "protocol interceptors" 
See https://codereview.chromium.org/187223003
 2014-06-27 11:54:27 -04:00
Adam Roben
500861d63d Update prefs code for Chrome 35 
See https://codereview.chromium.org/64193003
 2014-06-27 11:54:27 -04:00
Adam Roben
202f7bcd41 Fix include paths for WebIconURL.h 
It contains #include "public/platform/WebSize.h", so we have to set up the
include path to make that work.
 2014-06-27 11:54:27 -04:00
Adam Roben
ad0a5bdf80 Include Chrome's Skia config, not the default one 
This ensures we get Chrome's Skia settings.
 2014-06-27 11:54:27 -04:00
Adam Roben
55cfef4432 Update libchromiumcontent to Chrome 35 
* vendor/libchromiumcontent 656be94...ded3c0a (1):
  > Merge pull request #47 from brightray/chrome35
 2014-06-27 11:54:15 -04:00
Rus Maxham
cca71fce9f less removal of whitespace 2014-06-23 13:16:01 -07:00
Rus Maxham
3acba90225 brightray namespaced frameAutosaveName 2014-06-23 13:12:20 -07:00
Rus Maxham
92a4b25e47 - remember position and size of developer tools window 2014-06-23 12:48:52 -07:00
Cheng Zhao
e71927c5da Closing devtools window means it is not visible. 2014-06-17 16:51:46 +08:00
Cheng Zhao
1b274a1fd6 Add comments on the usage of attached devtools. 2014-06-10 12:44:30 +08:00
Cheng Zhao
9a70c9bb44 Enable undocked devtools. 2014-06-10 12:35:23 +08:00
Cheng Zhao
d70d24c360 Implement setting dock side. 2014-06-10 12:03:20 +08:00
Cheng Zhao
1943d88bdc Handle focus correctly. 2014-06-10 11:37:07 +08:00
Cheng Zhao
bd0f9df96c Put devtools in split view. 2014-06-10 10:29:39 +08:00
Cheng Zhao
566022cb66 ContainerView should manage itself. 2014-06-10 10:03:35 +08:00
Cheng Zhao
b0374b6a1d Use views::View to represent web view. 2014-06-10 09:58:28 +08:00
Cheng Zhao
4e69bd1733 Add 'third_party/skia/include/core' to include_dirs. 2014-06-10 09:10:26 +08:00
Cheng Zhao
d5d923439e Update to latest libchromiumcontent. 2014-06-04 21:55:50 +08:00
Cheng Zhao
55cbf8aaf2 Merge pull request #54 from brightray/latest-gyp 
Update to latest gyp.
 2014-05-18 19:55:33 +08:00
Cheng Zhao
e1988d3b8e Update to latest gyp. 
This fixes warnings like 'xxx.o has no symbols'.
 2014-05-18 19:48:31 +08:00
Cheng Zhao
5e0dd5c687 Remove from notification center when web contents is destroyed. 2014-04-23 11:20:12 +08:00
Cheng Zhao
54060ed53d Enable delegate to override SaveToFile and AppendToFile. 2014-04-05 09:21:47 +08:00
Cheng Zhao
d2ff5ad798 Provide a way to close devtools completely. 2014-03-20 09:26:21 +08:00
Cheng Zhao
5768ff6981 Enable delegate to change the dock side. 2014-03-04 19:47:33 +08:00
Cheng Zhao
e3aaaf2643 Add InspectableWebContentsDelegate. 2014-03-04 16:26:50 +08:00
Adam Roben
f7fb6371c2 Increase the open file limit on OS X to 1024 
The default (256) is too low for pages that load a lot of resources all at
once. See https://codereview.chromium.org/125151 and bugs like
https://code.google.com/p/chromium/issues/detail?id=14137 and
https://code.google.com/p/chromium/issues/detail?id=151039. The new limit
matches what Chrome itself uses.
 2014-01-31 10:43:38 -05:00
Adam Roben
8b80473ef9 Merge pull request #50 from brightray/debug 
Fix assertions when building against Debug libchromiumcontent
 2014-01-30 06:06:16 -08:00
Adam Roben
e8de51a8dd Destroy ResourceContext on the IO thread 
This matches content_shell and fixes a debug assertion (and maybe even a
crash).
 2014-01-30 09:03:00 -05:00
Adam Roben
c4935acbb1 Fix debug assertions about transport_security_state 
This code was added to content_shell in
https://chromiumcodereview.appspot.com/16501002 and we never picked it up.
 2014-01-30 09:01:23 -05:00
Cheng Zhao
a8f34982a0 Enable passing --commit to download script. 2014-01-30 22:01:22 +08:00
Cheng Zhao
5cf32f1f9c Update libchromiumcontent for --commit argument of download script. 2014-01-30 21:58:55 +08:00
Adam Roben
dcaaeacfe3 Fix assertions in Debug builds about using NetworkDelegate on the wrong thread 
We have to create it on the IO thread.
 2014-01-30 08:36:54 -05:00
Cheng Zhao
167b2f5881 '-std=gnu++11' is also needed by g++. 2014-01-01 02:29:27 +00:00
Cheng Zhao
13f816b4bb Add flag to disable clang under Linux. 2013-12-31 11:11:46 +00:00
Patrick Reynolds
37679214d1 Merge pull request #46 from brightray/linux-notifications 
Linux notifications
 2013-12-19 14:01:47 -08:00
Patrick Reynolds
967e8170f5 brevity and style 2013-12-19 16:01:01 -06:00
Adam Roben
076183c181 Merge pull request #47 from brightray/longer-lines 
allow 100-character lines
 2013-12-19 11:48:14 -08:00
Patrick Reynolds
8d2b392f07 undo some ugly line wrapping 2013-12-19 13:39:37 -06:00
Patrick Reynolds
df190caefd Merge branch 'longer-lines' into linux-notifications 2013-12-19 13:20:55 -06:00
Patrick Reynolds
46ec999b13 allow 100-character lines 2013-12-19 13:19:12 -06:00
Patrick Reynolds
4e31c0011d keep cpplint happy, mostly about line length 2013-12-19 13:06:05 -06:00
Adam Roben
de07839bb6 Update to latest libchromiumcontent 
* vendor/libchromiumcontent ee2e80a...2cd1a60 (1):
  > Merge pull request #35 from brightray/content-test-suite
 2013-12-19 09:08:21 -05:00
Patrick Reynolds
ef6d5dbf4e authorship 2013-12-18 23:20:00 -06:00
Patrick Reynolds
c6424672f5 comments and cleanup 2013-12-18 23:14:36 -06:00
Patrick Reynolds
04d5ed25d8 call PostClose when notification closed by click 2013-12-18 23:14:36 -06:00
Patrick Reynolds
272b3c30d3 free notifications properly 2013-12-18 23:14:36 -06:00
Patrick Reynolds
a82e9f30ed use libnotify to pop up notifications on Linux 2013-12-18 23:14:36 -06:00
Cheng Zhao
b1dc139e4b Set the proxy service a bit earlier to avoid crash. 2013-12-15 15:00:52 +08:00
Adam Roben
dc3f2050c0 Merge pull request #44 from brightray/fix-devtools-flash 
Fix flash of page while resizing devtools NSSplitView divider.
 2013-12-12 07:36:16 -08:00
Cheng Zhao
e0b8935fda Remove the unused dividerHidden property of GraySplitView. 2013-12-12 23:33:50 +08:00
Cheng Zhao
39f5f52423 Fix flash of page while resizing devtools NSSplitView divider. 2013-12-12 18:46:46 +08:00
Cheng Zhao
1a09de0956 The 'ARCHS' key should be an array. 
The ninja generator only supports setting the 'ARCHS' key as array, and
ninja does not support '$(ARCHS_STANDARD_64_BIT)' too. The 'x86_64' is
accepted by both ninja and xcodebuild, and is also used by node.
 2013-12-10 23:54:46 -08:00
Cheng Zhao
b080e5c52d Rename IsDevToolsOpened to IsDevToolsViewShowing. 2013-12-10 18:38:35 -08:00
Cheng Zhao
7a5415a3b7 Fix IsDevToolsOpened when devtools is attched to pane on Linux. 2013-12-09 13:27:22 +00:00
Cheng Zhao
a8c5911094 Implement IsDevToolsOpened for Linux. 2013-12-09 09:03:41 +00:00
Cheng Zhao
de7892cd6e Add API to get whether the devtools is opened. 2013-12-09 09:03:29 +00:00
Cheng Zhao
0a1f756ca6 Use "ProxyResolverV8" instead of "SystemProxyResolver" as proxy service. 
SystemProxyResolver is untested and could cause random crashes.
 2013-12-05 02:56:28 -08:00
Cheng Zhao
cf08bb098f Update libchromiumcontent for net_with_v8. 2013-12-05 02:50:56 -08:00
Adam Roben
1c56afe9d8 Create a BrowserClient by default 
This way applications that don't need to customize the BrowserClient get one
for free.
 2013-12-03 17:13:40 -05:00
Adam Roben
c9c218edc6 Update to 64-bit libchromiumcontent 
* vendor/libchromiumcontent 4252769...5cce386 (1):
  > Merge pull request #31 from brightray/mac-x64
 2013-12-02 16:37:06 -05:00
Adam Roben
7e6f5aa734 Update for ui -> gfx moves in Chrome 31 
See https://codereview.chromium.org/23769011.
 2013-12-02 13:00:39 -05:00
Adam Roben
9c5b81bf7a Stop setting helper process names on OS X 
See https://codereview.chromium.org/45253002.
 2013-12-02 13:00:39 -05:00
Adam Roben
ab8cb1e3a5 Update for changes to content::CreatePersistentCookieStore in Chrome 31 
I just copied how Chrome initializes this object.
 2013-12-02 13:00:39 -05:00
Adam Roben
cfeddb5bcb Update for changes to net::FileProtocolHandler in Chrome 31 
I just copied the way that Chrome initializes this object.
 2013-12-02 13:00:39 -05:00
Adam Roben
265076f19a Update for changes to devtools in Chrome 31 
browser/devtools_embedder_message_dispatcher.* came from
chrome/browser/devtools, and were modified just enough to compile within
brightray.
 2013-12-02 13:00:39 -05:00
Adam Roben
1da8c37098 Update libchromiumcontent to Chrome 31 
* vendor/libchromiumcontent f484ce1...4252769 (1):
  > Merge pull request #32 from brightray/chrome-31
 2013-12-02 13:00:15 -05:00
Patrick Reynolds
711aa5282b make BrowserContext::Initialize virtual 2013-11-27 15:55:06 -06:00
Patrick Reynolds
1f2c2d416c Merge pull request #36 from brightray/linux 
include library dependencies explicitly
 2013-11-26 08:54:25 -08:00
Patrick Reynolds
e1b6718c39 include library dependencies explicitly 
This is necessary for more recent versions of Clang, e.g., on Debian
unstable.
 2013-11-26 10:51:27 -06:00
Adam Roben
89795c9b14 Stop the devtools from turning black when the window gets big enough 
We need to use UnderlayOpenGLHostingWindow to show the devtools to ensure they
remain visible even when they get large.
 2013-11-25 16:28:57 -05:00
Patrick Reynolds
470daa571c back to reinterpret_cast 2013-11-17 22:27:23 -06:00
Patrick Reynolds
9f9aeac59f safer casts, clearer if-else chain 2013-11-17 22:25:24 -06:00
Adam Roben
c9e948dc58 Make ignoring files work on Windows 2013-11-17 19:22:53 -05:00
Adam Roben
3d8b636f9e Fix remaining cpplint errors in inspectable_web_contents_view_linux.cc 2013-11-17 19:21:50 -05:00
Adam Roben
07de5ef462 Silence warnings about ui::WindowImpl's BOOL& parameters 2013-11-17 19:19:58 -05:00
Adam Roben
cdbfff2fcf Fix backwards typedef 2013-11-17 19:15:26 -05:00
Adam Roben
654f415a49 Fix cpplint errors in common/mac/foundation_util.h 2013-11-17 19:14:24 -05:00
Adam Roben
7b47a6152d Fix cpplint errors in media_capture_devices_dispatcher.cc 2013-11-17 19:14:08 -05:00
Adam Roben
d0566e6e05 Fix cpplint errors in application_info_win.cc 2013-11-17 19:13:44 -05:00
Adam Roben
4938fc62ad Fix most cpplint errors in inspectable_web_contents_view_linux.cc 2013-11-17 19:12:50 -05:00
Adam Roben
1595940723 Fix cpplint errors in devtools_window.cc 2013-11-17 19:05:21 -05:00
Adam Roben
0271ff1964 Fix cpplint errors in inspectable_web_contents_view_win.h 2013-11-17 19:03:41 -05:00
Adam Roben
ae504c319e Fix cpplint errors in content_client.h 2013-11-17 19:03:09 -05:00
Adam Roben
073b1c164b Fix cpplint errors in inspectable_web_contents_view_win.cc 2013-11-17 19:02:49 -05:00
Adam Roben
779dfd2baf Fix most cpplint errors in devtools_window.h 
It's still complaining about the non-const reference in BOOL&.
 2013-11-17 19:01:36 -05:00
Adam Roben
51a2779fdb Fix cpplint errors in main_delegate.cc 2013-11-17 18:58:25 -05:00
Adam Roben
32f4862e56 Fix cpplint errors in main_delegate.h 2013-11-17 18:57:54 -05:00
Adam Roben
2c1e1b039d Fix cpplint errors in main_application_bundle.h 2013-11-17 18:57:25 -05:00
Adam Roben
9306fecea8 Fix cpplint errors in content_client.cc 2013-11-17 18:56:44 -05:00
Adam Roben
6aec3006e6 Fix whitespace/comment errors 2013-11-17 18:56:07 -05:00
Adam Roben
84ae61744d Ignore cpplint errors in bry_inspectable_web_contents_view_private.h 
It's not a C++ header.
 2013-11-17 18:55:06 -05:00
Adam Roben
236efa8be5 Fix cpplint errors in bry_application.h 2013-11-17 18:53:34 -05:00
Adam Roben
e5e3dc6a78 Ignore .mm files for cpplint 
It doesn't process them anyway.
 2013-11-17 18:53:16 -05:00
Adam Roben
23bcf4099f Fix cpplint errors in inspectable_web_contents_view_linux.h 2013-11-17 18:52:02 -05:00
Adam Roben
9f82d58761 Fix cpplint errors in web_ui_controller_factory.h 2013-11-17 18:46:23 -05:00
Adam Roben
7a362b7413 Fix cpplint errors in url_request_context_getter.h 2013-11-17 18:43:46 -05:00
Adam Roben
cf4d966958 Fix cpplint errors in notification_presenter_mac.h 2013-11-17 18:43:20 -05:00
Adam Roben
d4ad45334f Turn off build/include_what_you_use 
Chromium doesn't seem to use this rule.
 2013-11-17 18:42:15 -05:00
Adam Roben
ec59df1a51 Fix cpplint errors in network_delegate.h 2013-11-17 18:36:34 -05:00
Adam Roben
cb684c5c6e Fix cpplint errors in inspectable_web_contents_view_mac.h 2013-11-17 18:24:36 -05:00
Adam Roben
ea689b31a4 Fix cpplint errors in inspectable_web_contents_view.h 2013-11-17 18:23:13 -05:00
Adam Roben
877a1f0371 Fix cpplint errors in inspectable_web_contents_impl.h 2013-11-17 18:22:48 -05:00
Adam Roben
0805b414e9 Fix cpplint errors in inspectable_web_contents.h 2013-11-17 18:20:54 -05:00
Adam Roben
9ac1a539ee Fix all remaining readability/namespace errors 2013-11-17 18:20:17 -05:00
Adam Roben
fd54c435a9 Fix cpplint errors in default_web_contents_delegate.h 2013-11-17 18:18:22 -05:00
Adam Roben
7bada78519 Fix cpplint errors in browser_main_parts.h 2013-11-17 18:17:23 -05:00
Adam Roben
a6ecd039e2 Fix typos 2013-11-17 18:16:41 -05:00
Adam Roben
24fbf6e2ef Build before running cpplint 
Let's make sure things build before we check coding style. If it doesn't
even build, who cares about the style?
 2013-11-17 18:15:45 -05:00