Kevin Sawicki
e8a79cb88d
Don't require browser process module from renderer
...
This can cause issues when it is accessed from the
require cache or module tree since the getters throw
errors when called.
2017-02-28 08:45:39 -08:00
Kevin Sawicki
1d84d83fd4
Forward webview visibility change events from browser process
2017-02-28 08:23:00 -08:00
Kevin Sawicki
739f3ed102
Popup pepper menu in owner browser window
2017-02-24 08:39:22 -08:00
Kevin Sawicki
c951e253c6
Default to focused window whenever param is null/undefined
2017-02-24 08:39:22 -08:00
Kevin Sawicki
3e05350d6b
Check that window is non-null before accessing constructor prop
2017-02-24 08:39:22 -08:00
Kevin Sawicki
d0b07d5c36
Check that x is non-null
2017-02-22 10:49:25 -08:00
Kevin Sawicki
6a023dc4fe
Add Menu.closePopup API on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
4430927f98
Add async option to menu.popup
2017-02-22 10:30:28 -08:00
deepak1556
203a920c64
fix signature of zoom getter apis
2017-02-18 01:34:32 +05:30
Samuel Attard
17fe5efa13
Fix linting
2017-02-13 08:23:53 -08:00
Samuel Attard
e45d8079b8
Add support for a noResolveAliases property
2017-02-13 08:23:53 -08:00
deepak1556
b27c94368d
webContents: set zoom levels with HostZoomMap
2017-02-12 00:49:17 +05:30
Kevin Sawicki
5130ad24eb
🎨
2017-02-09 11:30:17 -08:00
Kevin Sawicki
f7f4de36af
Merge remote-tracking branch 'origin/master' into macos-open-save-panel
2017-02-09 11:25:05 -08:00
Kevin Sawicki
867bb5a94e
Add DialogSettings helper struct
2017-02-09 10:13:11 -08:00
Birunthan Mohanathas
c8c11e68c6
Add support for checkbox with dialog.showMessageBox
...
This adds the `checkboxLabel` and `checkboxChecked` options to display a
checkbox in the message box. Fixes #6048 .
2017-02-09 09:03:54 -08:00
Tan Wang Leng
347dc835b5
Fix code formatting
2017-02-09 21:51:11 +08:00
Tan Wang Leng
9423143211
Change the default value of showsTagField to true
...
The default value of showsTagField in macOS's NSSavePanel is true.
Therefore, in order to follow the standard behavior and not break
backwards-compatibility, let's change the default value of
showsTagField to true.
Reference:
https://developer.apple.com/reference/appkit/nssavepanel/1525589-showstagfield?language=objc
2017-02-09 21:01:40 +08:00
Tan Wang Leng
36209ddd90
🍎 Add additional options for Mac's open dialog
...
Support an additional attributes available in macOS's NSOpenPanel:
message.
2017-02-09 20:10:57 +08:00
Tan Wang Leng
1d612a12a1
🍎 Add additional options for Mac's save dialog
...
Support additional attributes available in macOS's NSSavePanel: message,
nameFieldLabel and showsTagField
2017-02-09 20:10:57 +08:00
Kevin Sawicki
70178adb6e
Use object for verification request
2017-02-08 11:59:43 -08:00
Kevin Sawicki
5245d42d15
Only document deprecation for now
2017-02-08 11:59:43 -08:00
Greg Nolle
e29b64a18a
modify CertVerifier Class
...
* respond to multiple similar verification requests.
* accept net error result as callback response.
2017-02-08 11:59:43 -08:00
Cheng Zhao
3024d0563f
There were new defaultPrintingSetting fields added
2017-02-06 10:34:29 -08:00
Kevin Sawicki
fb08f56fc8
Add forcereload menu item role
2017-02-03 09:39:41 -08:00
Kevin Sawicki
9fef6a1fd7
Add support for FOS_CREATEPROMPT option
2017-02-02 08:51:10 -08:00
Kevin Sawicki
d6eb0d6629
Implement insertCSS on webFrame
2017-01-19 09:05:59 +02:00
Kevin Sawicki
de4be56b09
Use internal open event name with fully parsed options
2017-01-16 12:38:16 -08:00
Kevin Sawicki
5f862effaa
Access directly on options object
2017-01-06 09:17:32 -08:00
Kevin Sawicki
eb533e04b9
Add option to normalize dialog access keys
2017-01-06 08:56:24 -08:00
Kevin Sawicki
2bd8ef83d1
Use != null to handle undefined
2016-12-12 16:25:56 -08:00
Daniel Pham
4b53cd9c3c
🐛 Allow buttons to be optional in 'showMessageBox'
2016-12-12 13:25:32 -05:00
Kevin Sawicki
820fb3b82b
Guard against no devtools web contents
2016-12-06 10:36:59 -08:00
Kevin Sawicki
07f99c06ea
Don't write back to passed in options object
2016-12-01 17:16:18 -08:00
Kevin Sawicki
af555bd879
Use spread syntax instead of apply
2016-12-01 14:56:00 -08:00
Kevin Sawicki
c8ff67ab75
Use spread syntax instead of function apply
2016-12-01 14:56:00 -08:00
Kevin Sawicki
36371357cd
buttonLabel -> Button label for consistency
2016-12-01 14:16:33 -08:00
Cheng Zhao
bbaab755e3
Merge pull request #8049 from electron/prevent-remove-all-ipc
...
Throw an error when users attempt to remove all listeners from the IPC modules
2016-11-27 14:29:49 +08:00
Kevin Sawicki
9a5df9da41
Expose setVisualZoomLevelLimits on webContents and <web-view>
2016-11-22 08:07:55 -08:00
Samuel Attard
db729b5b52
Throw an error when users attempt to remove all listeners from the IPC modules
2016-11-22 18:30:58 +11:00
Paul Betts
e2649ce7d8
Add new method to set layout-based zoom level limit
2016-11-21 14:59:55 -05:00
Kevin Sawicki
88959079bd
Add toggledevtools menu item role
2016-11-17 10:57:20 -08:00
Kevin Sawicki
0698b5f1be
Add reload menu item role
2016-11-17 10:57:20 -08:00
deepak1556
0410a184ce
webContents: handle POST navigation for new windows
2016-11-11 10:53:00 -08:00
Kevin Sawicki
8e203592e2
🎨 Remove extra returns
2016-11-03 09:51:01 -07:00
Samuel Attard
9f18a6e65c
Use ES6 template strings, fix docs and remove _ERROR_ IPC event
2016-11-03 09:33:47 -07:00
Samuel Attard
857e1da6a3
Make executeJavaScript return a Promise so that caught errors can be sent to the caller
2016-11-03 09:33:47 -07:00
Brendan Forster
651b0c0f82
fixed a couple of typos
2016-10-31 08:59:26 -07:00
ali.ibrahim
bdb3f4d4cb
Fixing code review issues: adding some test cases for partition/session options.
2016-10-25 16:19:26 +02:00
ali.ibrahim
b44d5290e2
Fixing code review issues: adding a partition options and making the session option only takes Session objects.
2016-10-25 15:47:54 +02:00
ali.ibrahim
61278f9ace
Fixing code review issues.
2016-10-25 12:41:01 +02:00
ali.ibrahim
7f8b180f70
Fixing authentication cancel with null/undefined credentials.
2016-10-20 11:43:26 +02:00
ali.ibrahim
c198828e58
Adding gc tests: fixing a memory leak with C++ URLRequest objects.
2016-10-17 19:02:25 +02:00
ali.ibrahim
0e13b8dd01
making the net module usable only after the ready event.
2016-10-14 17:57:37 +02:00
ali.ibrahim
6f5b0a28c5
Fixing code review issues: function call formatting, renaming JS member variables, refactoring response headers conversion.
2016-10-13 17:14:23 +02:00
ali.ibrahim
ae1c33b863
fixing linter issues.
2016-10-12 14:54:32 +02:00
ali.ibrahim
a5c508d2d7
Adding abort, webRequest interception and creation tests.
2016-10-12 14:54:31 +02:00
ali.ibrahim
4eb9fc1bb6
Adding chunked uploading test.
2016-10-12 14:54:29 +02:00
ali.ibrahim
9b94dfcbdc
Adding basic http tests, fixing issues in ClientRequest constructor.
2016-10-12 14:54:29 +02:00
ali.ibrahim
42bae9d71d
Making the HTTP response a full-fledged Readable stream.
2016-10-12 14:54:27 +02:00
ali.ibrahim
ec1fc5a17b
Implementing error, close, finish, abort events management.
2016-10-12 14:54:24 +02:00
ali.ibrahim
42adb2afd4
Fixing lint-js issues.
2016-10-12 14:54:22 +02:00
ali.ibrahim
08947682b0
Implementing abort workflow, emitting error events.
2016-10-12 14:54:21 +02:00
ali.ibrahim
cbbc4376ca
Adding support for upload chunked encoding.
2016-10-12 14:54:20 +02:00
ali.ibrahim
9498a5738a
Refactoring net module, adding a ClientRequest and IncomingMessage classes.
2016-10-12 14:54:20 +02:00
ali.ibrahim
fcaf9cb031
Some code cleaning.
2016-10-12 14:54:19 +02:00
ali.ibrahim
f7525d7877
Adding support for POST requests.
2016-10-12 14:54:18 +02:00
ali.ibrahim
2b3b41d5f9
Implementing authentication callback.
2016-10-12 14:54:18 +02:00
ali.ibrahim
2d9d4af98d
Implementing URLRequest API, getting response body.
2016-10-12 14:54:17 +02:00
ali.ibrahim
81eab9887b
Adding URLResponse to emit response events, implementing status code.
2016-10-12 14:54:16 +02:00
ali.ibrahim
7521aeea09
Implement URLRequest::Delegate, handle thread sync.
2016-10-12 14:54:15 +02:00
ali.ibrahim
e8d4abe78f
Adding net module and URLRequest class.
2016-10-12 14:54:15 +02:00
Zeke Sikelianos
8aaf029e55
remove unused var
2016-10-10 15:38:27 -07:00
Zeke Sikelianos
b575055d7e
inherit user-specific MenuItem properties more safely
2016-10-10 14:40:49 -07:00
Zeke Sikelianos
2cd10d339f
remove duplicated prop copying
2016-10-10 11:07:01 -07:00
Zeke Sikelianos
b7e078e98d
sanitize MenuItem options
2016-10-06 14:37:13 -07:00
Zeke Sikelianos
16b3962b66
preserve custom properties passed to MenuItem constructor
2016-10-05 12:24:08 -07:00
Michael Vasseur
c811188e22
Updated required code to handle missing additional features for popup windows
2016-10-04 14:38:32 +09:00
Kevin Sawicki
24bcf6ac16
Add initial cookie changed event support
2016-09-29 09:16:29 -07:00
Thiago de Arruda
06cc9a44fe
Add support for native chromium popups on sandboxed renderers.
...
- Allow `api::Window` instances to be created from existing `api::WebContents`.
- Override `WebContentsCreated` and `AddNewContents` to wrap renderer-created
`content::WebContents` into `api::WebContents`.
- For `content::WebContents` that should be displayed in new windows, pass the
wrapped `api::WebContents` object to window manager.
2016-09-27 06:01:46 -03:00
Kevin Sawicki
48fd2bd35f
binding -> bindings
2016-09-19 09:31:59 -07:00
Felix Rieseberg
29fa48d8c3
🔧 Ensure correct types for commandLine
...
This commit ensures that arguments passed to `appendSwitch` and `appendArgument` are turned into strings before passing them over to the binding.
2016-09-19 09:31:59 -07:00
Felix Rieseberg
90bff4d9de
🔧 Ensure correct types for commandLine
...
This commit ensures that arguments passed to `appendSwitch` and `appendArgument` are turned into strings before passing them over to the binding.
2016-09-19 09:31:59 -07:00
Yuya Ochiai
43f955194e
🏁 Use Ctrl+Y as the accelerator of redo on Windows
2016-09-18 17:07:34 +09:00
Cheng Zhao
df3f0a4516
Merge pull request #7175 from bsuh/fix-twitch-navigation
...
Fix navigation controller
2016-09-13 16:01:00 +09:00
Cheng Zhao
9a56959647
Merge pull request #7140 from liusy182/url-fix
...
fix a bug in navigation-controller where string is used as object
2016-09-12 14:46:05 +09:00
Brian Suh
5fc1f57fb5
Fix navigation controller
...
In-page navigation has not actually started if the current entry is
being replaced. Do not set inPageIndex if replaceEntry is true.
2016-09-11 14:46:17 -07:00
liusy182
2c7690be45
simplify logic
2016-09-08 21:36:39 +08:00
liusy182
180a77e671
fix a minor bug in navigation-controller where a string is used as an object
2016-09-08 21:31:42 +08:00
Kevin Sawicki
b54b74c310
Prevent missing Menu.buildFromTemplate function
2016-09-06 11:31:14 -07:00
Cheng Zhao
01f92a83ab
Merge pull request #6780 from electron/update-available-check
...
Mark update available until restart
2016-08-09 20:44:26 +09:00
Kevin Sawicki
dd6c69c90b
Use const instead of var
2016-08-08 13:07:01 -07:00
Kevin Sawicki
49908fd818
Keep update available flag set until restart
2016-08-08 13:03:02 -07:00
Kevin Sawicki
af607f8b67
🎨 function -> =>
2016-08-08 11:09:30 -07:00
Kevin Sawicki
bcc372568f
Add zoom menu item roles
2016-08-08 11:09:30 -07:00
Milan Burda
edc1a9614c
Add macOS specific speaking roles for MenuItem
2016-08-08 00:02:32 +02:00
Cheng Zhao
8c0a033b6f
Fix lint errors of using __proto__
2016-08-02 21:02:28 +09:00
Cheng Zhao
edb573d69e
Make WebContents inherit NavigationController
2016-08-02 20:55:56 +09:00
Cheng Zhao
025034127a
Set JavaScript APIs on prototype of WebContents
2016-08-02 20:52:07 +09:00
Cheng Zhao
844f32aa36
Set prototype of constructor directly
2016-08-02 20:38:35 +09:00
Cheng Zhao
6e0cde5b24
All native objects have prototype now
2016-08-02 17:12:17 +09:00
Cheng Zhao
56b1abd64a
Merge pull request #6685 from electron/document-contents-zoom
...
Implement and Document the zoom methods that are mapped to the webContents object
2016-08-02 14:41:09 +09:00
Samuel Attard
a498cf5b79
Fix linting issues
2016-08-02 13:13:17 +10:00
Samuel Attard
e4f6083753
Implement asynchronous versions of getZoomFactor and GetZoomLevel on the webContents object
2016-08-02 13:02:55 +10:00
Gabriel Handford
7bde92deb9
Add isVisible() to app.dock
2016-08-01 15:22:37 -07:00
Cheng Zhao
ffed3e9c0c
Move the code to native
2016-08-01 20:11:17 +09:00
Cheng Zhao
d23d9dcf01
Do not garbage collect sessions
2016-08-01 19:35:51 +09:00
Samuel Attard
20e26a9639
Move auto-updater-win to ES6
2016-07-26 11:40:55 +10:00
Feross Aboukhadijeh
d6a7ced32c
MenuItem: Use 'Close Window' for 'close' role label
...
On OS X, the standard label that's used for the 'close' role is 'Close
Window'. You can see this in the default macOS apps from Apple.
2016-07-25 15:13:17 -07:00
Cheng Zhao
751ee53683
Do not throw exception when channel name is "error"
2016-07-24 21:08:25 +09:00
Cheng Zhao
9eacd07eda
Merge pull request #6489 from electron/webcontents-static-api
...
Document static methods on webContents
2016-07-15 11:02:00 +09:00
Cheng Zhao
2791f71c03
webContents is now a public module
2016-07-15 10:59:19 +09:00
Samuel Attard
d42e6b3c1f
Fix casing issue on the windows update JS file
2016-07-15 10:05:36 +12:00
Kevin Sawicki
a7badd43d5
Expose getAllWebContents() API
2016-07-14 08:59:49 -07:00
Samuel Attard
84a8c393a8
Fix linting, removes additional semicolon
2016-07-15 00:29:53 +12:00
Samuel Attard
51687e1bc9
Add the getFeedURL API for macOS and Windows
2016-07-15 00:04:48 +12:00
Cheng Zhao
21a2feaf23
Merge pull request #6480 from electron/webcontents-focus
...
Execute role-based menu items on focused web contents
2016-07-14 12:47:07 +09:00
Kevin Sawicki
72cdba2b8e
🎨
2016-07-13 14:49:25 -07:00
Kevin Sawicki
f9a8bd3ea5
Call role method on focused web contents
2016-07-13 14:16:56 -07:00
Kevin Sawicki
06e595e7cc
Add webContents.getFocusedWebContents()
2016-07-13 14:16:56 -07:00
Kevin Sawicki
7877fa7c0a
Add webContents.isFocused()
2016-07-13 14:16:56 -07:00
Cheng Zhao
400bb8d0f3
Hide in_memory parameter in native interface
2016-07-13 12:23:14 +09:00
Cheng Zhao
06a41cedab
Move check of isReady to native code
2016-07-13 12:23:14 +09:00
Cheng Zhao
d739d8772c
Move session-created event to app
...
This follows the convention of other *-created events.
2016-07-13 12:23:14 +09:00
Cheng Zhao
45500701f1
Do not access default session before app is ready
2016-07-13 12:23:14 +09:00
Cheng Zhao
fcd3357fb8
Use Proxy to provide protocol APIs
...
In this way we can avoid initializing defaultSession when protocol
module is used.
2016-07-13 12:23:14 +09:00
Cheng Zhao
4ebb83e999
Move the warning of registerStandardSchemes to native code
2016-07-13 12:23:14 +09:00
Kevin Sawicki
e02cf5905c
Execute command on devtools web contents when focused
2016-07-12 13:24:53 -07:00
Cheng Zhao
f08ac07737
mac: Add showHiddenFiles property for showOpenDialog
2016-07-11 13:30:18 +09:00
Cheng Zhao
6e81c55880
Merge pull request #6385 from electron/only-use-role-accelerator-in-app-menu
...
Only use default role accelerator in app menu
2016-07-08 11:22:21 +09:00
Cheng Zhao
6381f44f26
mac: Pass useDefaultAccelerator to getAcceleratorForCommandId
2016-07-07 11:50:19 -07:00
Kevin Sawicki
1e0e5b0eff
Use CommandOrControl+Q for quit role on Linux
2016-07-07 09:19:20 -07:00
Kevin Sawicki
f7b72f0948
Move capturePage to WebContents
2016-07-06 09:21:28 -07:00
Jonas Schwabe
768ff7af5a
Add additional method isUnityRunning, fix multiple typos in docs
2016-06-29 20:22:17 +02:00
Jonas Schwabe
e2d389fbd4
Rename the unityLauncher api to launcher and make it available on linux in general. + Document it only works on ubuntu
2016-06-29 20:22:17 +02:00
Jonas Schwabe
e3ba6818af
Fix linter errors
2016-06-29 20:22:17 +02:00
Jonas Schwabe
b22ce93477
Implement libunity launcher badge counter to be set via electron, fixes #4193
2016-06-29 20:22:17 +02:00
Kevin Sawicki
c686997209
Ctrl -> Control for consistency
2016-06-22 16:56:45 -07:00
Kevin Sawicki
6165908ba7
Incorporate review feedback
2016-06-22 15:26:17 -07:00
Kevin Sawicki
be642612c0
Export app before requiring modules
2016-06-22 15:21:45 -07:00
Kevin Sawicki
ece319a687
🎨
2016-06-22 14:14:32 -07:00
Kevin Sawicki
58c1d38c96
Remove lint errors
2016-06-22 14:13:12 -07:00
Kevin Sawicki
c6dc6a8905
Specify focused window to execute call
2016-06-22 14:02:31 -07:00
Kevin Sawicki
30e3a6ed83
Add app require
2016-06-22 13:59:49 -07:00
Kevin Sawicki
66f2fb2fe4
Add execute helper to roles file
2016-06-22 13:48:26 -07:00
Kevin Sawicki
653370974a
🎨 Sort roles alphabetically
2016-06-22 13:15:20 -07:00
Kevin Sawicki
c0562d16d5
Add more role defaults
2016-06-22 13:09:49 -07:00
Kevin Sawicki
888068b597
Add default help/window labels
2016-06-22 13:09:49 -07:00
Kevin Sawicki
13a6d32ee9
Add default label/accelerator to role menu items
2016-06-22 13:09:48 -07:00
Kevin Sawicki
25b2724ab9
Add menu item role defaults
2016-06-22 13:09:48 -07:00