Milan Burda
2f79444535
refactor: separate WEB_VIEW_ATTRIBUTES / WEB_VIEW_ERROR_MESSAGES ( #36972 )
2023-01-25 16:08:46 +01:00
Milan Burda
d4e97483aa
refactor: only create webContents after 'will-attach-webview' ( #32941 )
2022-07-21 11:29:31 +02:00
Charles Kerr
cac871c027
Revert "refactor: only create webContents after 'will-attach-webview' ( #30311 )" ( #31785 )
...
This reverts commit 6e43b0bcbf
2021-11-11 15:04:06 -05:00
Milan Burda
6e43b0bcbf
refactor: only create webContents after 'will-attach-webview' ( #30311 )
2021-08-03 10:08:49 -07:00
Milan Burda
c68c65f383
refactor: implement <webview> using contextBridge ( #29037 )
...
* refactor: implement <webview> using contextBridge
* chore: address PR feedback
* chore: address PR feedback
* fix: check for HTMLIFrameElement instance in attachGuest
2021-05-15 16:42:07 +09:00
Milan Burda
49ef1fe342
refactor: use WeakMap instead of hidden V8 properties to store WebViewImpl ( #29049 )
2021-05-07 17:56:22 -07:00
Milan Burda
25f5c01cec
refactor: remove setupWebViewAttributes gymnastics ( #29032 )
2021-05-07 09:07:47 +02:00
Milan Burda
cbba602eae
chore: cleanup dead <webview> related code ( #29039 )
2021-05-06 13:56:05 -07:00
Milan Burda
2c65060ec8
chore: make raw requires type-safe ( #29006 )
...
* chore: make raw requires type-safe
* refactor: no need for separate webViewImplModule
* refactor: no need for separate guestViewInternalModule
2021-05-05 18:05:01 -07:00
Milan Burda
5b205731f6
chore: remove deprecated remote module ( #25734 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-03-09 17:12:40 -08:00
Milan Burda
79b3393768
chore: remove bunch of usages of any ( #27512 )
2021-01-29 12:41:59 -08:00
Jeremy Rose
34156c424c
fix: [webview] fix missing properties on events when contextIsolation: true ( #26289 )
2020-11-04 11:15:20 +09:00
Milan Burda
d25fa7b075
refactor: store <webview> attributes as typed Map ( #26307 )
2020-11-03 15:02:23 -08:00
Milan Burda
8df4faa8f0
chore: cleanup typings/internal-electron.d.ts ( #25711 )
2020-10-02 04:52:29 +02:00
Robo
c438b93f18
fix: ensure guest-embedder map is updated when webview is removed ( #23342 )
...
There are use cases of webview where the container holding the webview is not
actually destroyed first, instead just webview gets removed from DOM, in such
situations the browser process map is not updated accordingly and holds reference
to stale guest contents, and any window operations like scroll, resize or keyboard
events that has to chain through browser embedder will lead to UAF crash.
Ref: https://github.com/microsoft/vscode/issues/92420
2020-04-30 21:33:14 -07:00
Samuel Attard
5d657dece4
build: enable JS semicolons ( #22783 )
2020-03-20 13:28:31 -07:00
Heilig Benedek
43ef561d48
feat: enable NodeIntegrationInSubFrames for webview ( #17226 )
...
* feat: enable nodeIntegrationInSubFrames for webview
* test: add tests
* docs: document webview's nodeintegrationinsubframes
* lint: fix indent
* fix: resolve some merge bloopers
2019-03-15 10:39:20 -07:00
Samuel Attard
61fc95417b
build: fix new TS linting errors ( #17279 )
...
* remove unused _args var
* handle type/variable shadowing
2019-03-07 17:18:10 -08:00
Felix Rieseberg
f3fc4023cf
refactor: Port renderer/web-view to TypeScript ( #17250 )
2019-03-07 15:26:23 -08:00
