Robo
07d017dc01
fix: crash when tray is destroyed ( #14347 )
...
Release the view of status item before destroying it,
gives chance to perform cleanup on the view.
2018-08-28 10:45:24 -07:00
Milan Burda
a08ca9defb
fix: don't crash on tray.setContextMenu(null) ( #14322 )
2018-08-27 11:58:47 -05:00
Keerthi Niranjan
5b48e03c7c
fix: Dialog does not close on ESCAPE if defaultId is set ( #14196 )
...
If defaultId is set, it was removing the key reference for the button at 0 which was previously set for the cancel_id
2018-08-19 13:41:03 -07:00
Shelley Vohr
9f328abe19
refactor: remove instances of createDeepCopy ( #13703 )
...
* add new native_mate converters for base::Value
* fix converter swapping
* remove createDeepCopy from browser/api
* replace missing ListValue converter
* convert bulk of remaining createDeepCopy instances
* convert last remaining instances of createDeepCopy
* incremental progress and helper methods for value conversion
* convert Get and add template function for GetString
* final DictionaryValue method conversions
* remove usage of base::DictionaryValue in web_contents_preferences
* use IsEnabled helper where possible
* Update atom_api_web_view_manager.cc
2018-08-04 07:23:07 +10:00
Birunthan Mohanathas
c8dc2d3730
feat: Add will-resize event to TopLevelWindow ( #13649 )
...
The new `will-resize` event can be used to prevent the resize from
happening before the native window is actually resized. This is in
contrast to the existing the `resize` event, which is sent *after* the
native window has already been resized. For apps with e.g. custom window
snapping logic, the `resize` event is not sufficient because it will
result in flickering between the dragged size and the snapped size.
`will-resize` is only emitted on macOS and Windows.
2018-07-27 18:53:01 +09:00
Maxine Whitely
6cf68f8247
fix: tray setContextMenu crash ( #13513 )
...
Co-authored-by: Zhuo Lu <sethlu@mintkit.net>
Co-authored-by: Kristine Zhang <kzhang@slack-corp.com>
2018-06-29 14:48:26 -07:00
zacwalk
9db76394f7
Link gdi from gyp
2018-06-27 20:58:37 +02:00
Zac Walker
8151c90c6b
Fix warnings as error fixes.
2018-06-27 16:28:12 +02:00
Zac Walker
f122c44b07
Using win32 file open dialogs instead of WTL
2018-06-27 13:09:18 +02:00
Jeremy Apthorp
4b60efcaf8
chore: [gn] fix WTL include paths and namespace include ( #13433 )
...
As of libchromiumcontent#576, the WTL namespace isn't included by
default in the GN build.
2018-06-26 22:57:40 +02:00
Jeremy Apthorp
78bc1081fd
chore: fix some more warnings in windows build ( #13431 )
...
Remove an unused function and fix an int type comparison warning. Only showed up when building with GN.
2018-06-26 02:00:20 +02:00
Jeremy Apthorp
6f91af9343
chore: fix various chromium-style errors in windows ( #13394 )
...
These errors weren't previously picked up because the GN build wasn't running on Windows.
2018-06-25 22:30:00 +02:00
Jeremy Apthorp
8ccb5cc6eb
chore: Annotate fallthrough switch paths with FALLTHROUGH
...
The compiler was throwing errors about unannotated fallthroughs when
building with GN.
2018-06-20 14:38:18 -07:00
Samuel Attard
79fbd6bab1
Revert "fix: Drop support for OS X Mavericks (version 10.9)" ( #13333 )
2018-06-20 07:27:55 -05:00
Milan Burda
794fe741e9
fix: Drop support for OS X Mavericks (version 10.9)
2018-06-19 17:49:27 +02:00
Samuel Attard
9d18be8fde
Remove removed variable popup_bounds_in_view_
2018-06-19 11:58:26 +10:00
Heilig Benedek
65b8dd48d8
Update OSR code
2018-06-19 11:49:44 +10:00
Tomas Rycl
1ac0ab2b71
Include missing "windows.h" and fix headers ordering
...
For PCWSTR on line 198.
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
4a38c2d800
Remove deprecated View::SetLayoutManager
...
https://chromium-review.googlesource.com/844760
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
f6648a0d4d
Remove ScopedComPtr and scoped_comptr.h
...
https://chromium-review.googlesource.com/726461
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
82d204e932
Wrap X11 headers in ui/gfx/x/x11.h
...
https://chromium-review.googlesource.com/756711
2018-06-19 11:49:43 +10:00
deepak1556
2047929cb5
Convert ax_enums.idl to mojom.
...
https://chromium-review.googlesource.com/c/chromium/src/+/877417
2018-06-19 11:49:41 +10:00
Aleksei Kuzmin
576bf8f6c0
Move resource_response.h to //services/network/public/cpp.
...
https://chromium-review.googlesource.com/865664
2018-06-19 11:49:41 +10:00
Heilig Benedek
90911a423a
Fix autofill popup position when the popup is spawned from a webview ( #13184 )
2018-06-18 10:15:37 -05:00
Milan Burda
28fd571d0c
refactoring: use std::make_unique<T> ( #13245 )
2018-06-18 16:32:55 +09:00
Michael Khalil
ef1e2d6fe0
fix: tray title not inverting when highlighted ( #13085 )
2018-06-16 16:24:26 +10:00
mdpetuum
1b8790aeb2
fix: tray icon bounds didn't allow negative macOS ( #13162 )
2018-06-07 18:48:39 +02:00
Cheng Zhao
2c8dc9e0bd
Add View.addChildView API
2018-05-24 15:36:29 +09:00
Milan Burda
2337237d58
Refactoring: use C++11 class member variable initialization
2018-05-22 00:18:38 +02:00
Jeremy Apthorp
156a97b80d
fix: Menu.setApplicationMenu(null) crash on Linux ( #12983 )
2018-05-18 10:29:28 -07:00
Jeremy Apthorp
da0fd10423
refactor: chromium-style warnings in linux code ( #12949 )
2018-05-16 14:12:45 -05:00
John Kleinschmidt
9488ef4867
Merge pull request #12496 from mikeykhalil/8952-ignore-tray-double-click-events
...
8952 option to ignore tray double click events
2018-05-16 10:17:36 -04:00
Jeremy Apthorp
73eb5af2cc
refactor: remove unnecessary std::moves in linux code ( #12951 )
...
The compiler was complaining that the move was preventing copy elision.
2018-05-15 14:33:47 -07:00
Jeremy Apthorp
8fa48d1c04
fix: unused variable warnings in linux code ( #12950 )
2018-05-15 13:49:27 -05:00
Jeremy Apthorp
136105e353
fix: wrong list index type in file_dialog_gtk.cc ( #12952 )
2018-05-15 13:22:52 -05:00
Cheng Zhao
ea97f43145
check content view in SetMenuBarVisibility
2018-05-15 14:12:47 +09:00
Cheng Zhao
640877ebf8
attach native view after widget is created
2018-05-15 14:03:21 +09:00
Heilig Benedek
eae0674f61
Match chromium's workaround when setting size of unresizable windows
2018-05-12 17:37:31 +02:00
Cheng Zhao
5547df6073
report correct content size in AtomNSWindow
...
The views framework relies on NSWindow to return content size of window,
since we don't use the borderless window, the original result would
include titlebar. We have to override the function to return correct
result for frameless window.
2018-05-04 09:55:09 +09:00
Cheng Zhao
28fc58067b
remove usage of FullSizeContentView
2018-05-04 09:55:09 +09:00
Cheng Zhao
a9709a635c
display WebContents as views::View on macOS
2018-05-04 09:55:09 +09:00
mikeykhalil
94ffd4bfc0
add getter for ignoreDoubleClickEvents field
2018-05-03 13:49:33 -07:00
mikeykhalil
208374afa4
clean up ignore double click event implementation
2018-05-03 13:49:33 -07:00
mikeykhalil
1f29124d11
updated Tray API to ignore double click events on macOS ( #8952 )
2018-05-03 13:49:32 -07:00
Jeremy Apthorp
cdc5022305
Fix chromium-style errors ( #12802 )
2018-05-03 09:04:22 -05:00
Cheng Zhao
c67d1b62e3
refactor: NativeWindowViews should not be a View ( #12750 )
2018-05-01 13:28:22 +09:00
Cheng Zhao
cf70267871
remove unnecessary overrides
2018-04-26 09:48:12 +09:00
Cheng Zhao
39242c978f
fix failed BrowserWindow tests
2018-04-25 15:10:29 +09:00
Cheng Zhao
75a624434c
refactor: use views::Widget on macOS
2018-04-25 15:10:29 +09:00
Shelley Vohr
12a57ff1c2
clang-format objc files ( #12673 )
2018-04-20 11:47:04 -07:00