Samuel Attard
fde3137b90
fix: update the FileSelectHelper to support the new promise API ( #18288 )
...
* fix: update the FileSelectHelper to support the new promise API
Fixes #18254
So it turns out we've successfully introduced a way to write
non-typesafe C++.
This fixes two things:
* Uses the object the promise resolves
* Ensures we attach the Then handler before moving the promise
* fix: also fix misuse of Promise::Then in the download manager
2019-05-14 15:46:53 -07:00
Shelley Vohr
cc00fa8874
chore: convert base::Bind instances across some files ( #18112 )
2019-05-03 08:49:26 +09:00
deepak1556
527e8f3a31
IWYU: add missing headers
2019-03-08 15:04:32 -08:00
Shelley Vohr
6cb7b8d3a4
feat: promisify dialog.showSaveDialog() ( #17054 )
...
* feat: promisify dialog.showSaveDialog()
* address some feedback from review
* filename => filePath
* fix last filename => filePath
2019-03-05 13:48:20 -08:00
Shelley Vohr
e05985145b
feat: promisify dialog.showOpenDialog() ( #16973 )
...
* feat: promisify dialog.showOpenDialog()
* address feedback from review
* address feedback from review
2019-03-05 05:54:48 -08:00
Jeremy Apthorp
2cbf3080d0
Make webkitRelativePath interoperable
...
https://chromium-review.googlesource.com/c/1325579
2019-01-22 10:32:05 -08:00
Robo
52fe92d02e
feat: Upgrade to Chromium 71.0.3578.98 ( #15966 )
2019-01-11 17:00:43 -08:00
Jeremy Apthorp
8ccb5cc6eb
chore: Annotate fallthrough switch paths with FALLTHROUGH
...
The compiler was throwing errors about unannotated fallthroughs when
building with GN.
2018-06-20 14:38:18 -07:00
Milan Burda
c4942d931c
Add FILE_DIALOG_TREAT_PACKAGE_APP_AS_DIRECTORY to web open file dialog ( #13220 )
2018-06-15 15:51:38 -05:00
Milan Burda
9d9d6ca20b
Fix empty description when only one extension is given
2018-05-16 01:58:58 +02:00
Jeremy Apthorp
a635f078c6
[chromium-style] auto variable type must not deduce to a raw pointer type
2018-04-19 11:10:52 -07:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
Cheng Zhao
8bbe28e998
No need to get BrowserContext from NativeWindow
2018-03-06 16:21:17 +09:00
acheronfail
d1d50a4c92
Implement App-Scoped Security scoped bookmarks ( #11711 )
...
* implementation of security scoped bookmarks
* option is now only available on mas builds
2018-02-12 13:25:06 -05:00
Heilig Benedek
f8b3009ebf
restructure code to use web_preferences if possible
2017-11-13 15:50:49 +09:00
Kevin Sawicki
c4956132d2
Add filter descriptions for common accept types
2017-07-14 11:04:06 -07:00
Kevin Sawicki
720755e124
Merge pull request #9745 from yuya-oc/input-allow-all-files
...
Add 'All Files (*.*)' filter for <input> file dialog
2017-07-14 10:41:11 -07:00
Birunthan Mohanathas
eb19562316
Fix crash when using file chooser in BrowserView
...
The crash was a segfault caused by a null `WebDialogHelper::window_`.
2017-06-21 16:26:38 -07:00
Yuya Ochiai
be9463b7b7
Add 'All Files (*.*)' filter for <input> file dialog
...
The dialog would filter files as well as Chrome.
2017-06-13 22:33:06 +09:00
Haojian Wu
328cf4789b
Should override the virtual destructor.
2017-03-30 23:19:43 +02:00
Kevin Sawicki
ef085a1f15
Remove unneeded AddRef/Release calls handled by base::Bind
2017-02-24 08:15:02 -08:00
Kevin Sawicki
6837ec8576
Check render frame host before getting context
2017-02-24 07:49:26 -08:00
Kevin Sawicki
a62c2f9e2e
Remove unused include
2017-02-24 07:37:28 -08:00
Kevin Sawicki
29f92bfb53
Extend RefCounted and add private destructor
2017-02-24 07:37:28 -08:00
Kevin Sawicki
a33ffd621f
Use callback dialog methods in RunFileChooser
2017-02-24 07:37:28 -08:00
Kevin Sawicki
867bb5a94e
Add DialogSettings helper struct
2017-02-09 10:13:11 -08:00
Cheng Zhao
f28e8d7168
Fix API changes of Chrome 53
2016-09-14 16:22:43 +09:00
Kevin Sawicki
6285500cdc
Sort includes alphabetically
2016-08-26 15:30:02 -07:00
Ben Gotow
84cce6c2c1
Don't default to "Open", "Save", just let OS decide
2016-05-15 01:03:32 -05:00
Ben Gotow
40c531737d
Add buttonLabel param to showOpen/showSave dialogs
2016-05-15 01:03:32 -05:00
Brian R. Bondy
2da39d31aa
Update to new pref service location in components
2016-05-13 11:07:17 +09:00
Cheng Zhao
898a838ad7
Merge pull request #2340 from atom/set_download_path_api
...
Implement setDownloadPath API.
2015-07-29 17:19:02 +08:00
Haojian Wu
617bff8ec8
Fix a missing the specified mime type check in <input> accept attribute.
2015-07-28 10:32:13 +08:00
Haojian Wu
0700f08d6d
Copy pref_names files from Chromium.
2015-07-26 16:08:29 +08:00
Haojian Wu
21e5054fac
Make <input type="file"\> remember last used directory.
2015-07-16 19:29:12 +08:00
Haojian Wu
04606a9f97
Enable 'accept' attribute in 'input' label.
2015-07-13 14:47:30 +08:00
Cheng Zhao
86644543ed
Fix cpplint warning
2015-01-27 13:18:31 -08:00
Cheng Zhao
715ac35672
Update to new FilesSelectedInChooser API
2015-01-27 13:18:30 -08:00
Cheng Zhao
0f5a058bdd
Implement RunFileChooser
2014-10-31 19:27:01 +08:00
Cheng Zhao
9b1bcf51c6
Implement EnumerateDirectory
2014-10-31 17:37:32 +08:00
Cheng Zhao
b710cc3063
Add WebDialogHelper
2014-10-31 00:37:14 +08:00