refactor: use C++20's contains() method (#45742)
* chore: use std::map<>::contains() instead of count() or find()
* chore: use std::map<>::contains() instead of base::Contains()
feat: service worker preload scripts for improved extensions support (#44411)
* feat: preload scripts for service workers
* feat: service worker IPC
* test: service worker preload scripts and ipc
* chore: bump chromium in DEPS to 133.0.6943.16
* chore: bump chromium in DEPS to 133.0.6943.27
* chore: bump chromium in DEPS to 133.0.6943.35
* chore: bump chromium to 134.0.6968.0
cherry picked from 75eac86506
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: bump chromium in DEPS to 133.0.6902.0
* chore: bump chromium in DEPS to 133.0.6903.0
* chore: update patches
* Update PdfViewer Save File Picker to use showSaveFilePicker.
Refs 6074308
* Code Health: Clean up stale MacWebContentsOcclusion
Refs 6078344
* Change RenderProcessHost::GetID to RenderProcessHost::GetDeprecatedID
Refs 6065543
* [WebRTC] Make WebRTC IP Handling policy a mojo enum
Refs 6063620
* chore: gen filenames.libcxx.gni
* Remove allow_unsafe_buffers pragma in //printing
Refs 6092280
* refactor: to use ChildProcessId where possible
Refs https://issues.chromium.org/issues/379869738
* [Win] Update TabletMode detection code
Refs 6003486
* chore: bump chromium in DEPS to 133.0.6905.0
* chore: update patches
* Reland "Move global shortcut listener to //ui/base"
Refs 6099035
* [shared storage] Implement the batch `with_lock` option for response header
Refs 6072742
* chore: bump chromium in DEPS to 133.0.6907.0
* chore: bump chromium in DEPS to 133.0.6909.0
* chore: bump chromium in DEPS to 133.0.6911.0
* chore: bump chromium in DEPS to 133.0.6912.0
* chore: update patches
* WebUI: Reveal hidden deps to ui/webui/resources.
Refs 6096291
* chore: bump chromium in DEPS to 133.0.6913.0
* chore: bump chromium in DEPS to 133.0.6915.0
* Code Health: Clean up stale base::Feature "AccessibilityTreeForViews"
Refs 6104174
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fix: remove fastapitypedarray usage
* chore: update patches
* chore: script/gen-libc++-filenames.js
* Code Health: Clean up stale base::Feature "WinRetrieveSuggestionsOnlyOnDemand"
Refs 6109477
* fix: empty suggestions with windows platform checker
Amends the fix from https://github.com/electron/electron/pull/29690
since the feature flag is no longer available. We follow the
same pattern as //chrome/browser/renderer_context_menu/spelling_menu_observer.cc
to generate the suggestion list on demand when context menu action
is invoked.
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fixup! fix: empty suggestions with windows platform checker
* fixup! fix: empty suggestions with windows platform checker
* revert: 6078344: Code Health: Clean up stale MacWebContentsOcclusion | 6078344
* Revert "revert: 6078344: Code Health: Clean up stale MacWebContentsOcclusion | 6078344"
This reverts commit 9cacda452ed5a072351e8f5a35b009d91843a08c.
* chore: bump to 133.0.6920.0, update patches
* Revert "6078344: Code Health: Clean up stale MacWebContentsOcclusion"
Refs: 6078344
* fixup! Update PdfViewer Save File Picker to use showSaveFilePicker.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* chore: bump chromium in DEPS to 133.0.6858.0
* chore: bump chromium in DEPS to 133.0.6860.0
* chore: update patches
v8/revert_fastapi_remove_dynamic_overload_resolution.patch had some additions due to 6023139
* 6044060: Reland "Moves shared GN templates into //build/config/apple."
6044060
* Revert "6023139: [fastapi] Add support for attribute setters"
6023139
* Update printing.patch
The removed include is present in the original source file now, just slightly before where it was being added.
6015430: Reduce platform-like buildflags in sandbox code
Refs: 6015430
* 6039836: Migrate Command::IsMediaKey to be a member of ui::Accelerator
6039836
* 6038659: [CodeHealth] Clean up the feature ZstdContentEncoding
6038659
* chore: bump chromium in DEPS to 133.0.6862.0
* chore: update patches
* 72747: crypto: switch to C++
https://boringssl-review.googlesource.com/c/boringssl/+/72747
* fixup! 72747: crypto: switch to C++ https://boringssl-review.googlesource.com/c/boringssl/+/72747
* chore: gen libc++ filenames
* 6042601: [shared storage] Implement with_lock option for methods from response headers
6042601
* chore: bump chromium in DEPS to 133.0.6864.0
* chore: bump chromium in DEPS to 133.0.6866.0
* chore: bump chromium in DEPS to 133.0.6868.0
* chore: bump chromium in DEPS to 133.0.6870.0
* chore: bump chromium in DEPS to 133.0.6872.0
* chore: bump chromium in DEPS to 133.0.6874.0
* chore: bump chromium in DEPS to 133.0.6876.0
* 6039992: Fix false activation logic for context menu. | 6039992
* chore: update patches
* chore: update patches
* chore: bump chromium in DEPS to 133.0.6878.0
* chore: update patches
* [Build] Organize //components/dbus into a single component
Xref: 6055280
* Merge //components/dbus/* into a single //components/dbus, which
matches how most components are organized. This avoids having
many small shared libraries which incurs unnecessary overhead.
* Limit visibility of //components/dbus/* to //components/dbus
* fixup! Update _LIBCPP_ABI_VERSION to always have a default value while keeping unstable false due to changes in llvm https://github.com/llvm/llvm-project/pull/112094
* 6040416: Let s know which widget the input came on. | 6040416
* 6056267: [MPArch guest view] Fix authentication for MPArch guests | 6056267
* make_span() is deprecated: https://issues.chromium.org/issues/341907909
* fixup: https://issues.chromium.org/issues/341907909
* chore: delete extra bracket from removing make_span commit
* fixup: 6059305: Make WTF::UTF8ConversionMode a scoped enum | 6059305
* 6051058: CookieInclusionStatus: Remove ctors which bypass invariants | 6051058
* 6038981: Remove most remaining CHECK(false)s | 6038981
* build: use third_party/simdutf in Node.js
* chore: node ./script/gen-libc++-filenames.js
* chore: fix strict-cast conversion error in subspan()
Xref: 6044946
* chore: fix strict-cast conversion error in base::as_bytes()
Xref: 6044946
* chore: fix strict-cast conversion error in span.split_at()
Xref: 6044946
* chore: use shorthand target name
* chore: better docs in build_add_public_config_simdutf_config.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: more return-braced-init-list, this time for v8 and gin objects
* refactor: more return-braced-init-list, this time for v8, gin, std, and base objects
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
NB: using the braced-initializer list uncovered an error here:
the float returned by std::floor() can't be implicitly cast to
an int. This is solved by using base::ClampFloor<int>() instead.
std::floor()
* chore: bump chromium in DEPS to 131.0.6756.0
* chore: update disable_hidden.patch
no code changes; just handling upstream context shear
5887019
* chore: update feat_expose_raw_response_headers_from_urlloader.patch
Factor out URLLoader's URLRequest configuration into a helper
Xref: 5902254
* chore: update fix_disabling_background_throttling_in_compositor.patch
no manual changes; patch applied with fuzz 1
* chore: e patches all
* 5882129: Fix basic auth issues for sub frame and sub resources | 5882129
- Add `is_request_for_navigation` param to
ElectronBrowserClient::CreateLoginDelegate().
- Propagate the flag as another undocumented property
in the app.login Event's authenticationResponseDetails object
- Side cleanup: also in CreateLoginDelegate(), use upstream's name
for the `is_request_for_main_frame` param, renamed back in
3256171
* 5875189: [FSA] Check for DANGEROUS extension types when creating a new file. | 5875189
* chore: node ./script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6758.0
* chore: bump chromium in DEPS to 131.0.6760.0
* chore: update patches
* [A11y] Remove Accessibility Object Model (AOM)
Refs 5896593
* chore: bump chromium in DEPS to 131.0.6762.0
* [heap] Remove deprecated V8 flag
Refs 5904046
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: bump chromium in DEPS to 131.0.6738.0
* chore: bump chromium in DEPS to 131.0.6740.0
* 5889025: [LaCrOS] Remove LaCrOS screen capturer. | 5889025
* https://boringssl.googlesource.com/boringssl.git/+/40dd94116ba03678226443ba20c5887459c9bf16/crypto/fipsmodule/digest/digests.c.inc
* chore: update patches
* 5878695: Add IsolationInfo for embedders handling external protocols | 5878695
* 5854304: [UI] Remove alias of mojom | 5854304
* chore: bump chromium in DEPS to 131.0.6742.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6744.0
* fixup! 5889025: [LaCrOS] Remove LaCrOS screen capturer. | 5889025
* chore: e patches all
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
Xref: 5894233
* [UI] Remove alias of mojom 'WindowShowState'
Xref: 5854304
* chore: gen-libc++-filenames.js
* chore: partially revert 5894233
see patch commit message for description
* Clean up stale base::Feature "kFileSystemAccessLocalUNCPathBlock"
This feature is always on by default and doesn't have active finch
experiments.
Xref: 5881253
* fix: asar integrity test recognizes SIGABRT as a crash
5882758
ValidateIntegrityOrDie() exits via LOG(FATAL)'s call to
base::ImmediateCrash(). There's been churn there upstream between
5332940 and 5882758 on whether to use SIGTRAP or SIGABRT. For now,
let's accept both until the churn is done.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
it fails to build from source with this error:
../../content/public/browser/plugin_service.h:17:2: error: "Plugins should be enabled"
17 | #error "Plugins should be enabled"
* fix: FTBFS in printing_utils.cc when ENABLE_PDF is false
* fixup! fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
fix BUILD.gn linting
* chore: bump chromium in DEPS to 130.0.6723.4
* chore: bump chromium in DEPS to 131.0.6724.0
* chore: update patches
* chore: update libc++ filenames
* 5844369: controlledframe: Disable Web Bluetooth for <webview> & <controlledframe>
5844369
* (multiple CLs): Use an opaque type for FrameTreeNode IDs
5807683: Use an opaque type for FrameTreeNode IDs, part 1 | 5807683
5829746: Use an opaque type for FrameTreeNode IDs, part 2 | 5829746
5836903: Use an opaque type for FrameTreeNode IDs, part 7 | 5836903
5837249: Use an opaque type for FrameTreeNode IDs, part 8 | 5837249
5836564: Use an opaque type for FrameTreeNode IDs, part 12 | 5836564
5837180: Use an opaque type for FrameTreeNode IDs, part 15 | 5837180
* 5822889: [task] Make GetForegroundTaskRunner non-virtual
5822889
* 5833297: Remove unused inner WebContents attach params
5833297
* 5806403: Shift PowerMonitor to non static
5806403
* 5666874: [3/N] Remove old OnPowerChange in PowerObserver
5666874
* 5829085: [v8] Differentiate between UserVisible and BestEffort task runners
5829085
* 5791112: [webrtc] Use `c/b/permissions/system` for system permissions
5791112
* 5825636: [Extensions] Create WebContentsObservers with ExtensionsBrowserClient
5825636
* fixup! (multiple CLs): Use an opaque type for FrameTreeNode IDs
* fixup! 5791112: [webrtc] Use `c/b/permissions/system` for system permissions 5791112
* chore: bump chromium in DEPS to 131.0.6726.0
* chore: update patches
* chore: update libc++ filenames
* 5858119: Declutter: Allow opening to a specific feature
5858119
* fix: macOS SDK 15 error
Not sure exactly what changed in the upgrade to macOS SDK 15, but it triggered a new error:
```
electron/shell/browser/ui/message_box_mac.mm:84:7: error: multiple methods named 'highlight:' found with mismatched result, parameter type or attributes
```
The `highlight:` selector a few lines down was ambiguous because the object type of the `NSArray` was not specified. Specifying `NSButton` as the element type makes the selector unambiguous for type checking.
* 5854143: [File Download Access Prevention] Obfuscate download file for enterprise deep scan
5854143
* 5854811: Use kNotAllowedError instead of kSecurityError for Web MIDI
5854811
* chore: bump chromium in DEPS to 131.0.6728.0
* chore: update patches
* disable invalid test
* chore: bump chromium in DEPS to 131.0.6730.0
* chore: update patches
* update build tools target commit for new macOS SDK
* chore: update libc++ file names
* chore: bump chromium in DEPS to 131.0.6732.0
* chore: bump chromium in DEPS to 131.0.6734.0
* 5856527: [UI] Use mojo enum for `WindowShowState` in ui/
5856527
* chore: update build-tools sha to include macOD 15.0 SDK
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: alice <alice@makenotion.com>
* feat: support app#login event for utility process net requests
* chore: address review feedback
* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
Refs 5702737
* chore: bump chromium in DEPS to 129.0.6645.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6646.0
* refactor: remove ppapi dependency
PPAPI removal - https://issues.chromium.org/issues/40511450
PDF viewer migration - https://issues.chromium.org/issues/40511452
* chore: update patches
* chore: enable `content_enable_legacy_ipc`
We were indirectly relying on this via `enable_ppapi=true`, with
633a57d9b62da7850ef7946f6b101ed440d04cdd ppapi is now disabled and
this commit makes the dependency explicit.
* fix: gn check
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: bump chromium in DEPS to 128.0.6613.0
* chore: 5725076: Update EventType names | 5725076
* chore: export patches
* chore: 5725076: Update EventType names | 5725076 for windows
* chore: bump chromium in DEPS to 129.0.6614.0
* 5725672: Add a feature to limit the number of preconnect in LoadingPredictor | 5725672
* chore: bump chromium in DEPS to 129.0.6616.0
* chore: e patches all and resolve conflict in patches/v8/fix_disable_scope_reuse_associated_dchecks.patch
* 5730656: Show an error dialog when UpdatePrintSettings() fails | 5730656
* chore: gen-libc++-filenames
* 5729956: Finally remove string_piece.h | 5729956
* chore: replace all references of base::StringPiece with std::string_view
* chore: remove more references of stringPiece in favor of string_view
* chore: rename string_piece variables to string_view
* 5508795: Remove the NotificationService | 5508795
* 5734053: Revert Rename GlobalFeatures to GlobalDesktopFeatures. | 5734053
* chore: resolve conflict with main without merge
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
* chore: bump chromium in DEPS to 128.0.6577.0
* chore: bump chromium in DEPS to 128.0.6579.0
* 5675706: Reland "Reland "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""""
5675706
* 5668597: [PDF Ink Signatures] Prompt download menu on save when there are edits
5668597
* 5677014: Reland "Pull data_sharing_sdk from CIPD"
5677014
* chore: fixup patch indices
* chore: bump chromium in DEPS to 128.0.6581.0
* chore: bump chromium in DEPS to 128.0.6583.0
* update patches
* 5455480: [Extensions] Allow service worker requests to continue without a cert
5455480
* try to get some debugging output from script/push-patch.js
* chore: bump chromium in DEPS to 128.0.6585.0
* chore: bump chromium in DEPS to 128.0.6587.0
* update patches
* chore: bump chromium in DEPS to 128.0.6589.0
* more patch work
* maybe over here?
* chore: update patches
* 5673207: [HTTPS Upgrades] Disable in captive portal login webview
5673207
* 5636785: Extensions: WAR: manifest.json's use_dynamic_url requires a dynamic url
5636785
* chore: bump chromium in DEPS to 128.0.6591.0
* 5665458: Trigger WN2 page when feature is enabled
5665458
* update patches
* chore: bump chromium in DEPS to 128.0.6593.0
* chore: bump chromium in DEPS to 128.0.6595.0
* chore: bump chromium in DEPS to 128.0.6597.0
* (patch update) 5694586: [compile hints] Remove the usage of v8::Isolate::SetJavaScriptCompileHintsMagicEnabledCallback API
5694586
* update patches
* 5691287: Reland "Change blink::WebKeyboardEvent to use std::array in is members"
5691287
The code changed here is modeled after code in `content/renderer/pepper/event_conversion.cc` that was also modified in this CL, so I took the same approach.
* 5529018: Cleanup EnableWebHidOnExtensionServiceWorker flag
5529018
* 5526324: [Code Health] Add deprecation comment for base::SupportsWeakPtr.
5526324
Note that this CL actually does make `SupportsWeakPtr` strictly restricted to existing implementations, no new ones. We could add a patch to add ourselves to this list, but it looks like we'll have to refactor this anyways in the near future. Since the refactor seems straightforward, let's try that first.
* chore: bump chromium in DEPS to 128.0.6598.0
* chore: update patches
* 5704737: Rename ExclusiveAccessContext::GetActiveWebContents to avoid conflict
5704737
* chore: bump chromium in DEPS to 128.0.6601.0
* chore: update patches
* Add `base::StringPiece` header includes
Chromium is working on replacing `base::StringPiece` with `std::string_view`. (See the Chromium Bug below.) They're currently running mass codemods (across many multiple changes) to replace uses of `StringPiece` with `string_view`, including removing the header include for `StringPiece` in those files. This cascades down to our files that were implicitly depending on those includes through some other include.
They're on track to eventually deprecate and remove `StringPiece` so our code should be converted, but that can be done as an upgrade follow-up task. For now, adding the header back to files that need it should suffice for minimal upgrade changes.
Chromium Bug: https://issues.chromium.org/issues/40506050
* 5702737: GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
5702737
contender for smallest commit 2024
* 5706534: Rename GlobalFeatures to GlobalDesktopFeatures.
5706534
* 5691321: ui: remove params variants of SelectFile listener functions
5691321
* 5714949: [Extensions] Display re-enable dialog for MV2 disabled stage
5714949
* chore: update libc++ filenames
* patch: disable scope reuse & associated dchecks in v8 (hopefully temp, upgrade follow-up)
* fixup! Add `base::StringPiece` header includes
* update MAS patch
5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception
5710330
* chore: bump chromium in DEPS to 128.0.6603.0
* chore: update patches
* 5713258: Reland "Preparation for decoupling creation/initialization of context"
5713258
When destroying a context, it must already be shutdown, and this change enforces it with a new CHECK.
We were overriding `BrowserContextKeyedServiceFactory::BrowserContextShutdown` with an empty implementation, which differed from the default implementation that notifies the `KeyedServiceFactory` that the context has shutdown. Since we were missing this notification, the CHECK would later trip when the service was being destoryed because it was not registered as shutdown when it was shutdown.
* chore: bump chromium in DEPS to 128.0.6605.2
* chore: update patches
* refactor: linux open/save dialog patch
Our existing implementation was relying on an opaque `void* params` parameter that was passed through `ui::SelectFileDialog`.
Recently, that parameter has been getting removed:
- 5691321: ui: remove params variants of SelectFile listener functions | 5691321
- 5709097: ui: remove SelectFileDialog impl params | 5709097
- https://issues.chromium.org/issues/340178601 "reconsider SelectFileDialog"
This restructures the patch to work with mostly the same mechanics, but directly on the `ui::SelectFileDialog` object. This nets us some wins in terms of a smaller patch.
* 5713262: DevTools UI binding AIDA client event returns response
5713262
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6606.0
* chore: update patches
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6607.0
* chore: update printing.patch
Xref: 5722937
* fix: pwd error in electron-test, nan-test
fix: unshallow depot_tools before 3-way apply
* chore: e patches all
* fixup! fix: pwd error in electron-test, nan-test
* chore: bump chromium in DEPS to 128.0.6609.0
* chore: bump chromium in DEPS to 128.0.6611.0
* chore: update patches
* chore: update libcxx filenames
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
* feat: Implement password delegate for NSS (#41188)
Introduce an app event client-certificate-request-password. It allows
the user to display a UI to prompt for the password.
An alternative would have been to implement a class similar to
CryptoModulePasswordDialogView, to provide the UI. This might have been
simpler for the user, comparing to letting them implement the UI. But it
seems like electron does not have an i18n framework, so it's not
possible to provide a locale aware UI.
* fix lint:markdown error
* address review comments
* use a trampoline handler in JS. The api exposed is now app.setClientCertRequestPasswordHandler
* use properties on the Event object instead of positional parameters
* remove ChromeNSSCryptoModuleDelegate::OnPassword in favor of args->GetNext(&password_)
* address review comments second round
- backslash escape parametrized TypeScript
- rename hostName param to hostname
- use base::ScopedAllowBaseSyncPrimitivesForTesting
- and then, rename ChromeNSSCryptoModuleDelegate to ElectronNSSCryptoModuleDelegate
* Update docs/api/app.md
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
* Update docs/api/app.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
---------
Co-authored-by: Arno Renevier <arnaud@switchboard.app>
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* chore: bump chromium in DEPS to 126.0.6470.0
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | 5492605
* 5513277: Move subresource-filter-ruleset to GCS | 5513277
* 5512656: Remove CustomizeChromeSupportsChromeRefresh2023 | 5512656
* 5516009: Accept mouse events in inactive window for Top Chrome WebUIs | 5516009
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI. | 5376861
* 5490530: Use partition_alloc PA_BUILDFLAG(...) outside PA. #cleanup | 5490530
* 5296870: network: Allow trusted loaders to learn the sent request cookies. | 5296870
* 5453438: Delegate delegated ink trails to RWHI from RWHIER. | 5453438
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6472.0
* chore: bump chromium in DEPS to 126.0.6474.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6476.0
* chore: bump chromium in DEPS to 126.0.6478.0
* chore: bump chromium in DEPS to 126.0.6478.3
* chore: bump chromium in DEPS to 126.0.6478.8
* update patches
* only disable enterprise_cloud_content_analysis
* 5403888: [api] support v8::Data in v8::TracedReference and v8::EmbedderGraph
5403888
* chore: bump chromium in DEPS to 127.0.6484.0
* chore: bump chromium in DEPS to 127.0.6485.0
* 5539004: Use NOTREACHED_IN_MIGRATION() in remaining chrome/ | 5539004
* src: cast to v8::Value before using v8::EmbedderGraph::V8Node | https://github.com/nodejs/node/pull/52638/files
* chore: update patches
* chore: update v8 patches
* chore: bump chromium in DEPS to 127.0.6486.0
* chore: bump chromium in DEPS to 127.0.6488.0
* chore: bump chromium in DEPS to 127.0.6490.0
* chore: bump chromium in DEPS to 127.0.6492.0
* chore: update patches
For some reason, `feat_expose_raw_response_headers_from_urlloader.patch` got messed up in an earlier commit.
* chore: update patches
printing.patch was updated due to 5535938
* 5527572: Move Connectors prefs files to components/enterprise/connectors/
5527572
* chore: bump chromium in DEPS to 127.0.6494.0
* chore: bump chromium in DEPS to 127.0.6495.0
* chore: bump chromium in DEPS to 127.0.6496.0
* 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation
5465511
* chore: revert v8 deprecation
See patch message for more details.
5526611
* chore: update patches
* 5538771: Remove srcdoc else-if block in CalculateOrigin()
5538771
* 5522321: [devtools] Support saving base64 encoded files via host bindings
5522321
* 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI.
5376861
* 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum
5530163
* 5463431: iwa: Only create IsolatedWebAppURLLoaderFactory for subresources in IWAs
5463431
* fixup! 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation 5465511
* 5512176: Remove OnEnvironmentEstimationComplete()
5512176
* 5528282: Move Web Speech API .mojom files to //media/mojo/mojom
5528282
* 5513740: Reland "[Extensions] Restructure extensions::ProcessMap"
5513740
* 5483406: [PEPC] Make PEPC permission subscription take into account device status
5483406
* 5526034: [DoH] Remove kDnsOverHttps feature flag
5526034
The title is a bit misleading. They removed handling for the feature flag and generally intend to remove it but haven't yet.
I only changed our code to address the flag that was removed. A quick search on GitHub for `DnsOverHttpsFallback` yielded a few results, but they were all C++ chromium code or patches, 0 app code or discussion results. Since I couldn't find any evidence of this flag being used in developer applications, I've chosen to exclude this change from the breaking changes docs.
* chore: revert v8 removal
5497515
See patch message for more details.
* chore: cherry-pick Node.js patch for V8 API removal fix
Node.js PR: https://github.com/nodejs/node/pull/52996
V8 API Removal CL: 5539888
See the patch description for more details.
* 5492183: Extensions: CodeHealth: Give enums some class
5492183
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom 5528282
* 5514687: Reland "Add a secret handshake to the base::Feature constructor"
5514687
* fixup! 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum 5530163
* 5466238: PDF Viewer: add metrics to record if PDF is opened with a11y
5466238
* 5502081: Migrate OnDisplayRemoved to OnDisplaysRemoved
5502081
* 5539888: [api] Remove several APIs deprecated in version 12.6
5539888
This commit essentially only removes the `only_terminate_in_safe_scope` isolate creation parameter. This undoes some work that was originally done in #35766.
* 5498236: Make browser_tests force full async initialization for OSCrypt Async
5498236
* fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom 5528282
* 5545807: Migrate most remaining NOTREACHED()
5545807
I took a systematic approach to modifying all of our uses of `NOTREACHED` that were causing errors:
* If there was a `return` or `break` (etc.) immediately after `NOTREACHED`, I removed the control flow instruction and left the `NOTREACHED` unmodified
* All other instances were migrated to `NOTREACHED_IN_MIGRATION`
We should revisit pretty much all usage of `NOTREACHED` as an upgrade follow-up item.
* fixup! 5526034: [DoH] Remove kDnsOverHttps feature flag 5526034
Turns out the feature flags were removed in the `.cc` file, but not the
`.h` feature list file. This means that the feature flags are pretty
much officially gone. (The leftover symbols in the header are likely an
oversight from what I can gather.)
We may potentially decide to put this in the breaking changes doc if we
decide this feature flag is important enough to highlight.
* chore: bump chromium in DEPS to 127.0.6498.3
* chore: bump chromium in DEPS to 127.0.6500.0
* chore: bump chromium in DEPS to 127.0.6502.0
* chore: bump chromium in DEPS to 127.0.6504.0
* chore: bump chromium in DEPS to 127.0.6505.0
* chore: bump chromium in DEPS to 127.0.6508.0
* build: use Sha256Sum in script/sysroots.json
Xref: 5506275
* chore: update chore_add_electron_deps_to_gitignores.patch
Xref: no manual changes; patch applied with fuzz 2
* chore: update feat_allow_code_cache_in_custom_schemes.patch
Xref: no manual changes; patch applied with fuzz 1
* chore: e patches all
* fixup! build: use Sha256Sum in script/sysroots.json
`sync` succeeds now
* chore: replace absl::optional with std::optional
Xref: 5253843
* chore: update CalculatePreferredSize() to new upstream semantics
Xref: 5459174
Xref: 5541220
Xref: 5514708
Xref: 5504212
Xref: https://chromium-review.googlesource.com/516542
* chore: replace absl::optional with std::optional
Xref: 5296147
* chore: add kPip to enumeration as a no-op
5546257
* [Autofill] Remove RenderFrame::ElementBoundsInWindow()
Xref: 5553982
* chore: fix feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
need new header to pick up definition of BLINK_PLATFORM_EXPORT macro
Xref: 5463143
* chore: bump chromium in DEPS to 127.0.6510.0
* chore: update patches
* chore: fix include path for native_web_keyboard_event.h
Xref: 5541976
* chore: add currently-unused should_include_device_status arg to GetPermissionStatusForCurrentDocument()
Xref: 5545382
* chore: bump chromium in DEPS to 127.0.6512.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
No manual changes; patch applied with fuzz 1
* chore: update webview_fullscreen.patch
No manual changes; patch applied with fuzz 1
* chore=: remove cherry-pick-22db6918bac9.patch
already present upstream
* chore: remove nonexistent patchfiles from .patches
* chore: remove cherry-pick-3e037e195e50.patch
no longer needed; merged upstream
* Update namespace for files moved to //components/input
Xref: 5563251
* Require client for InitParams to always specify an ownership mode.
Xref: 5532482
Xref: 5578714
* chore: e patches all
* fixup! Update namespace for files moved to //components/input
* chore: remove profile_keyed_service_factory, profile_selections from chromium_src
already being linked in via chrome browser for printing
* chore: bump chromium in DEPS to 127.0.6515.0
* chore: bump chromium in DEPS to 127.0.6516.0
* chore: update render_widget_host_view_base.patch
Xref: 5547803
patch applied manually due to simple upstream shear
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* Pull RWHIER and RWT to //content/common/input.
Xref: 5397681
* chore: bump chromium in DEPS to 127.0.6517.0
* chore: update patches
* fixup: Update namespace for files moved to //components/input
* Remove 0-arg (default) constructor for views::Widget::InitParams.
5578714
* fixup: only disable enterprise_cloud_content_analysis
The original commit a5480accc2, was due to this CL 5527572: Move Connectors prefs files to components/enterprise/connectors/ | 5527572
* chore: bump chromium in DEPS to 127.0.6519.0
* chore: update patches
* src: do not use deprecated V8 API
https://github.com/nodejs/node/pull/53084
* src: remove dependency on wrapper-descriptor-based cpp heap
https://github.com/nodejs/node/pull/53086
* 5344413: [DevTools] Add `getHostConfig` UI binding for sending status of `base::Features` to DevTools
5344413
* 5585788: Extensions: ManifestHandler: Separate Registry like ExtensionRegistry
5585788
* chore: update filenames.libcxx.gni
* 5506857: Reland "Migrate clang-format to gcs first class deps"
5506857
* fixup: 5539888: [api] Remove several APIs deprecated in version 12.6
* fixup: 5506857: Reland Migrate clang-format to gcs first class deps
* chore: bump chromium in DEPS to 127.0.6521.0
* chore: update patches
* spec: update navigator.keyboard should lock the keyboard
* Block or allow all MIDI using the existing SysEx permission
Refs 5154368
Refs 5499157
* spec: update test/parallel/test-v8-stats
* views: remove CalculatePreferredSize()
Refs 5504212
* chore: update patches after rebase
* 5560288: Re-enable ChromeOS XNNPack on Intel only
5560288
* chore: add nan patches for v8 changes
Refs
5539888: [api] Remove several APIs deprecated in version 12.6 | 5539888
and
5539852: [heap][api] Remove deprecated v8::Isolate::IdleNotificationDeadline | 5539852
* 5573603: Modularize //chrome/browser/themes
5573603
* 5539888: [api] Remove several APIs deprecated in version 12.6
5539888
* chore: update patches
* test: fixup navigator.keyboard.lock on Windows
* chore: remove unneeded profile target
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: bump chromium in DEPS to 125.0.6421.0
* chore: bump chromium in DEPS to 125.0.6422.0
* Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
5434658
* chore: update patches
* fixup: Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows
* chore: bump chromium in DEPS to 126.0.6423.0
* chore: update patches
* 5426599: Next generation control of unsafe-buffers-usage plugin
5426599
* chore: bump chromium in DEPS to 126.0.6425.0
* chore: update patches
* Roll clang+rust llvmorg-19-init-7229-g315c88c5-2 : llvmorg-19-init-8091-gab037c4f-1 / ceab6128fa48a616bfd3e3adf4bc80133b8ee223-1 : ab71ee7a9214c2793108a41efb065aa77aeb7326-1
5444328
Also see https://issues.chromium.org/issues/332931387
* 5445074: [Views AX] Move AXEventNotificationDetails to ui/accessibility/
5445074
Also
5455993: [Views AX] Rename AXEventNotificationDetails to AXUpdatesAndEvents | 5455993
* Pass IsolationInfo to ContentBrowserClient::WillCreateURLLoaderFactory()
5405301
* chore: bump chromium in DEPS to 126.0.6427.0
* chore: update patches
* chore: remove no longer needed patch
perfetto is now turned on so this patch is no longer needed.
* chore: bump chromium in DEPS to 126.0.6429.0
* chore: bump chromium in DEPS to 126.0.6431.0
* chore: bump chromium in DEPS to 126.0.6433.0
* 5466654: Do not create a console if logging to a handle
5466654
* chore: fixup patch indices
* Address Linux NonClientFrameView Changes
- 5180720
- 5367794
* chore: bump chromium in DEPS to 126.0.6435.0
* chore: bump chromium in DEPS to 126.0.6437.0
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6439.0
* chore: bump chromium in DEPS to 126.0.6441.0
* 5477689: components/crash/content/tools: Format with yapf | 5477689
* 5485006: Remove enable_print_content_analysis GN flag | 5485006
* chore: update chromium patches
* chore: bump chromium in DEPS to 126.0.6443.0
* 5465608: Convert DCHECKs near RenderWidgetHost, DelegatedFrameHost to CHECK | 5465608
* 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs | 5492605
* chore: update patches
* chore: bump chromium in DEPS to 126.0.6445.0
* chore: update patches
* 5468588: Fullscreen: Encapsulate ExclusiveAccessBubble params in a struct | 5468588
* fixup! 5485006: Remove enable_print_content_analysis GN flag | 5485006
* 5461340: `size_t` in `mojo::DataPipe[Consumer|Producer]Handle`: /components. | 5461340
* 5480213: Add an EvictIds struct to FrameEvictorClient | 5480213
* 4341506: [api] Deprecate Isolate::IdleNotificationDeadline | 4341506
* 5300826: [v8-tasks] Add source location to v8::TaskRunner, step 4/4. | 5300826
* partially revert is_newly_created to allow for browser initiated about:blank loads
* add dep on app_launch_prefetch
Ref: 5420149
* install sysroots from electron not from chrome
We should add a new var upstream for `download_sysroots` so that we can skip downloading chromes at all.
Ref: 5462469
* refactor: make UpdateFrameHints an override
Ref: 5473548
* fix ppapi
* refactor: update namespace for pwm switches
Ref: 5444617
* 5459367: WebSQL: Restrict WebSQL service creation to Android only | 5459367
* 5455853: Revert "[Clipboard] Don't add meta charset tag for async write() method on Mac." | 5455853
* fixup! refactor: update namespace for pwm switches
edd9e26
Ref: 5444617
* 5147611: [heap] Add checks for ensuring position info slow path is not used in heap snapshot | 5147611
* fixup! 5412666: [heap] Also avoid heap allocation for allocation tracked functions | 5412666
* chore: add websql removal to breaking-changes.md
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* chore: bump chromium in DEPS to 124.0.6361.0
* chore: bump chromium in DEPS to 124.0.6363.0
* chore: update patches
Manually apply printing.patch w/no code changes due to upstream shear.
Xref: 5349263
* chore: bump chromium in DEPS to 124.0.6365.0
* chore: bump chromium in DEPS to 124.0.6367.0
* update patches
* 5371735: Rename SystemGeolocationSourceMac to SystemGeolocationSourceApple
5371735
* missed a MAS bit
* chore: update windows toolchain
5350823: New toolchain for Windows 11 10.0.22621.2428 SDK | 5350823
* chore: bump chromium in DEPS to 125.0.6368.0
* fix patches
* chore: update patches
* 5232401: [PDF] Move generic utils from //chrome to //components/pdf (1/2)
5232401
* revert 5380898
* chore: bump chromium in DEPS to 125.0.6370.0
* build: use updated windows toolchain
* fix patches
* chore: update patches
* more pdf_util to components
* 5372414: [Extensions] Remove DispatcherDelegate
5372414
* fix accessibility_ui patch
* chore: bump chromium in DEPS to 125.0.6372.0
* chore: bump chromium in DEPS to 125.0.6374.0
* chore: bump chromium in DEPS to 125.0.6376.0
* chore: bump chromium in DEPS to 125.0.6378.0
* chore: bump chromium in DEPS to 125.0.6379.3
* chore: update patches (+ MAS patch changes)
* chore: update patches
* 5381159: Cleanup media::KeySystemSupportObserver
5381159
* 5382233: Reland "Web `Speech to Text` with SODA backend"
5382233
* chore: update `exclusive_access` patch
- 5367497: Add a metric for the website state when Fullscreen API is requested
- 5367497
* chore: add build dependency
5367497: Add a metric for the website state when Fullscreen API is requested
5367497
* chore: bump chromium in DEPS to 125.0.6382.0
* chore: update libcxx filenames
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6384.0
* chore: remove old patch
* 5394039: [Extensions] Change "blessed" -> "privileged" in extension feature files
5394039
* fix: remove deprecated errno constants in node/libuv
* 5362194: Return expected from ProcessMetrics CPU methods
5362194
* 5383927: Add new Pickle factory functions with explicit ownership
5383927
* 5373340: Simplify app-region/Draggable Region implementation
5373340
* 5386875: Cleanup printing preferences files
5386875
* chore: update libc++ filenames
* fix: add enterprise buildflags dep
* chore: bump chromium in DEPS to 125.0.6386.0
* chore: add build dep
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6388.0
* chore: bump chromium in DEPS to 125.0.6390.0
* chore: update patches
* 4918014: preloading: Add NewTabPagePageLoadMetricsObserver
4918014
* 5401234: [PDF] Remove `PDFDocumentHelperClient::FindPdfChildFrame` API
5401234
* 5116175: Relocate Windows XPS printing feature helper methods
5116175
* fixup! 5373340: Simplify app-region/Draggable Region implementation 5373340
* fixup! chore: add build dep
* chore: remove dead code & dead patch
Was dealing with 5402805 when I realized this code is no longer possible to call. It seems like this code became dead in the previous roll (#41514).
The patch exposed a `DxdiagDx12VulkanRequested` method on Chromium's `GpuDataManagerImpl`, which we consumed only in our own `GPUInfoManager::NeedsCompleteGpuInfoCollection`. There are no other references to this method, so it and the patch can both be deleted. Yay!
* chore: bump chromium in DEPS to 125.0.6392.0
* chore: bump chromium in DEPS to 125.0.6393.0
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6394.0
* chore: bump chromium in DEPS to 125.0.6396.0
* chore: bump chromium in DEPS to 125.0.6397.0
* chore: update printing.patch
Xref: 5100842
No code changes, but had to apply patch manually due to upstream code shear
* chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
No manual changes; patch applied with fuzz 1
* chore: update feat_allow_code_cache_in_custom_schemes.patch
No manual changes; patch applied with fuzz 2
* chore: silence "space before tab in indent" git rebase-apply warning
* chore: e patches all
* build: update all.gn to avoid FTBFS when disabling raw_ptr
Xref: 5371737
* Rename PdfService Mojo interface to PdfHost
Xref: 5411957
* chore: bump chromium in DEPS to 125.0.6398.0
* chore: update patches
* chore: bump chromium in DEPS to 125.0.6400.0
* chore: update patches
* [media] Remove unused `GetSupportedKeySystems` from MediaClient
Xref: 5420247
* chore: update JSInjection::New call to match upstream change
Xref: 5403967
[Extensions] Wire up the renderer for multiple user script worlds
* 5362362: Derive display ID from monitor adapter ID instead of szDevice.
5362362
* 5116175: Relocate Windows XPS printing feature helper methods
5116175
* chore: add v8-sandbox.h to electron-node
* chore: update patches
* chore: update patches
* fixup! 5394039: [Extensions] Change blessed -> privileged in extension feature files
* chore: bump chromium in DEPS to 125.0.6412.0
* chore: update patches
* chore: node script/gen-libc++-filenames.js
* [FPF] Create Fingerprinting Protection ruleset service.
Refs 5420158
* Add ExclusiveAccessPermissionManager
Refs 5273787
* Preserve the PNG colorspace when decoding into a SkBitmap.
Refs 5421254
* chore: iwyu
* fix: abstract-socket compilation
* ci: bump container for node 20 support
* fixup! abstract-socket compilation
* fix: compiling nan specs
* chore: revert winreg version bump
accidental bump to 1.2.5 revealed failing app.setasdefaultprotocolclient
test suite. Should be revisited separately.
* ci: set node 20 for darwin x64 tests
* fix: broken patch export
* chore: cleanup mas_avoid_private_macos_api_usage.patch.patch
Removed code that was inadvertently put back after 5348565 removed it
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: bump chromium in DEPS to 124.0.6315.0
* chore: update patches
* 5279678: Stream AIDA responses
5279678
* 5276439: Remove non_network_url_loader_factory_remotes_
5276439
* 5310165: Add DevTools API to show search results
5310165
* chore: bump chromium in DEPS to 124.0.6317.0
* chore: update patches
* Remove Setup.Install.CumulativeDiskUsage2 and supporting code
5314269
* browser: Make cmd line non-const in process singleton callback
5311256
* chore: bump chromium in DEPS to 124.0.6319.0
* chore: bump chromium in DEPS to 124.0.6321.0
* chore: bump chromium in DEPS to 124.0.6323.0
* 5318335: Roll src/third_party/boringssl/src 23824fa0f..4fe29ebc7
5318335
* 5318051: [CBE Watermarking] Hoist `watermark_view` to a member variable.
5318051
* chore: fixup patch indices
* 4946553: Delegate HID permission to Chrome App in webview
4946553
* 5310001: DevTools UI binding for reporting client events to AIDA
5310001
* [libc++] Refactor the predicate taking variant of `__cxx_atomic_wait`
* chore: fix browser_view patch harder
* 5293937: Reland "[gUM] Use preferred device if more than one is eligible"
5293937
* fix: filter {video|audio} devices by eligible device id
* 5267921: enable speak content under the pointer on PWA and WV2
5267921
* 5310195: heap: Remove Blink's GCTaskRunner
5310195
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: 5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: 5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: 5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: 4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
5235021
* address review comment for 5196547
See: 5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | 5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | 5246669
* fix: move nut-js to optional spec deps (#41199)
* chore: bump chromium in DEPS to 123.0.6265.0
* chore: bump chromium in DEPS to 123.0.6266.0
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Xref: 5232280
reverts the revert *and* undoes the rewrites 😵
* chore: update chromium/disable_hidden.patch
Xref: 5148491
minor manual intervention
* chore: update patches
* chore: Rename mouse lock to pointer lock
Xref: 5148491
* refactor: fix use of newly-removed QuitCurrentWhenIdleClosureDeprecated()
Xref: 4710351
Xref: https://github.com/electron/electron/pull/26022
This usage was added in #26022 as part of Wayland support and some
simple fiddles WfM with this patch on Wayland, but I'm unsure what
to be testing for & would like a second opinion on this commit.
* chore: bump chromium in DEPS to 123.0.6268.0
* chore: update patches
* 5235021: WebUI: Migrate accessibility and bluetooth internals to WebUIConfig
5235021
* address review comment for 5196547
See: 5196547
Review comment: https://github.com/electron/electron/pull/41130#discussion_r1468973786
* 5075962: Introduce URLLoaderFactoryBuilder
5075962
* chore: bump chromium in DEPS to 123.0.6270.0
* the missing semicolon strikes again
* chore: update chromium patches
* chore: update v8 patches
* 5242326: Some followup cleanup to Fuchia files in chrome | 5242326
* chore: bump chromium in DEPS to 123.0.6272.0
* chore: update patches
* chore: update patch after rebase
* 5247339: [Clipboard] Remove ClipboardContentType enum.
5247339
* Reland: "Allow content shell to enable the built-in DNS resolver"
5232354
* 5018206: [accessibility] Migrate to ScopedAccessibilityMode
5018206
* 5246669: [Default Nav Transition]Add GetBackForwardTransitionAnimationManager on WebContentsView | 5246669
* fix: typescript error for optional dependency
(cherry picked from commit ea17105c8c01bd1f4c1df5e72190a687d92f93cc)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
* chore: bump chromium in DEPS to 122.0.6239.2
* chore: update patches
* refactor: extensions replaced StringPiece with string_view
Ref: 5171926
* chore: bump chromium in DEPS to 122.0.6240.0
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6241.5
* chore: bump chromium in DEPS to 122.0.6245.0
* chore: bump chromium in DEPS to 122.0.6247.0
* chore: bump chromium in DEPS to 122.0.6249.0
* chore: bump chromium in DEPS to 122.0.6251.0
* 5192010: Rename {absl => std}::optional in //chrome/
5192010
* 5109767: CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
5109767
* 5105227: [media_preview] Show requested device in permission bubble
5105227
* chore: bump chromium in DEPS to 122.0.6253.0
* chore: update patches
* 5180720: Polish tiled browser window UI on Linux | 5180720
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6255.0
* chore: update patches
* 5186276: [autopip] Make "allow once" per navigation | 5186276
* chore: bump chromium in DEPS to 122.0.6257.0
* chore: bump chromium in DEPS to 122.0.6259.0
* chore: update patches
* 5190661: Automated T* -> raw_ptr<T> rewrite "refresh" | 5190661
* 5206106: Make sure RenderFrameHosts are active when printing | 5206106
* 5202674: Reland "Automated T* -> raw_ptr<T> rewrite 'refresh'"
5202674
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
5109767
* fixup 5206106: Make sure RenderFrameHosts are active when printing
* Make legacy ToV8() helpers private to ScriptPromiseResolver, their only user
5207474
* fixup CodeHealth: Fix leaked raw_ptr in Linux ProcessSingleton
* fixup 5186276: [autopip] Make "allow once" per navigation
5186276
* chore: update patches after rebase
* chore: bump chromium in DEPS to 122.0.6260.0
* 5191363: Mark LOG(FATAL) [[noreturn]]
5191363
* fixup 5186276: [autopip] Make "allow once" per navigation
5186276
* fixup Make legacy ToV8() helpers private to ScriptPromiseResolver
5207474
* chore: update patches
* chore: bump chromium in DEPS to 122.0.6261.0
* chore: update patches
* chore: restore patch that was mistakenly removed
* 5181931: Improve LoginHandler (Part 9 / N)
5181931
* Dispatch SiteInstanceGotProcess() only when both process and site are set.
5142354
* 5171446: [AsyncSB] Pass navigation_id into CreateURLLoaderThrottles
5171446
* 5213708: Move DownloadTargetInfo into components/download
5213708
* extensions: Add a loader for Controlled Frame embedder scripts
5202765
* [CSC][Zoom] Add initial_zoom_level to DisplayMediaInformation
5168626
* chore: bump chromium in DEPS to 123.0.6262.0
* chore: bump chromium in DEPS to 122.0.6261.6
* fix: suppress clang -Wimplicit-const-int-float-conversion
* fixup 5191363: Mark LOG(FATAL) [[noreturn]] for Windows
5191363
* 5167921: Remove Widget::IsTranslucentWindowOpacitySupported
5167921
Also
5148392: PinnedState: Support pinned state in PlatformWindowState | 5148392
* fixup: 5180720: Polish tiled browser window UI on Linux
5180720
* 5170669: clipboard: Migrate DOMException constructors to RejectWith-
5170669
* 5178824: [Fullscreen] Record UKM data
5178824
* chore: update patches after rebase
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* refactor: use NoDestructor for g_io_thread_application_locale
* refactor: use NoDestructor for ExtensionActionAPI::GetFactoryInstance()
* refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider()
* refactor: use NoDestructor for feat_add_support_for_overriding_the_base_spellchecker_download_url.patch
* chore: remove unused #include
* fixup! refactor: use NoDestructor for ElectronExtensionsClient::GetPermissionMessageProvider()
make sure instance is static
* chore: remove unused #include "base/lazy_instance.h"
* chore: bump chromium in DEPS to 122.0.6180.0
* chore: update render_widget_host_view_base.patch
Xref: 5079532
minor manual changes to match upstream changes
* chore: update printing.patch
Xref: 5094777
Xref: 5054299
Update patch to upstream changes in print_view_manager_base.cc.
CC @codebytere for 👀
* chore: update feat_add_onclose_to_messageport.patch
Xref: 5083156
no manual changes; patch applied with fuzz 1
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: 5087072
minor manual changes to match upstream changes
* chore: update port_autofill_colors_to_the_color_pipeline.patch
Xref: 4960481
no manual changes; patch applied with fuzz 2
* chore: update revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
Xref: 5076902
Xref: 5096253
The `bailout_value` variable, which allowed us to fail gracefully in
these macros, has been removed upstream. This raises the temperature
on https://github.com/electron/electron/issues/40741 ...
Since we don't have a bailout value, return a default-constructed
instance of whatever the return type is of the function that invokes
the macro.
* Remove performActionOnRemotePage
Xref: 5068017
It appears it is not used by anything within Chromium or outside.
* perf: in SubmenuButton ctor, move() the PressedCallback
Xref: 5066872
The copy construtor is more expensive and has been removed upstream
* chore: update constructor call for ElectronExtensionsRendererClient::dispatcher_
Xref: 5055146
* chore: handle CAPTURED_SURFACE_CONTROL in Converter<blink::PermissionType>::ToV8()
Xref: 5096614
* chore: e patches all
* chore: bump chromium to 122.0.6181.0
* chore: e patches all
* refactor: Add lookup for per-RenderFrame SpellCheckProvider
Xref: 5075094
Previously we could pass a routing ID into the spellcheck methods.
This ID arg has been replaced with a SpellCheckHost& arg.
We can get the SpellCheckHost from an accessor in SpellCheckProvider,
which was already being created on a per-render-frame basis in
RenderClientBase.
This commit adds a RenderFrame-to-SpellCheckProvider accessor
in RenderClientBase so that it can be used to get that needed
SpellCheckHost.
* chore: make lint happy
* chore: restore the will_cause_resize arg to WebContents::ExitFullscreen
Xref: 5074445
Xref: 5031312
upstream reverted this change
* chore: bump chromium in DEPS to 122.0.6182.0
* chore: update patches
* chore: fix virtual function names that were renamed upstream
Xref: 5115241
* chore: handle new blink::PermissionType::SMART_CARD in PermissionType converter
Xref: 5049989
* chore: node script/gen-libc++-filenames.js
* fixup! chore: update build_do_not_depend_on_packed_resource_integrity.patch
* chore: remove revert_api_dcheck-fail_when_we_reenter_v8_while_terminating.patch
The previous experiment of removing the DCHECK in 35093783 was a huge
failure. We either need to either:
A) use upstream as-is and fix the DCHECK failure, or
B) revert 5076902 too
C) find some other workaround
This commit is the first half of option A, removing the patch to use
upstream as-is.
* chore: bump chromium in DEPS to 122.0.6184.0
* chore: bump chromium in DEPS to 122.0.6186.0
* chore; update mas_avoid_private_macos_api_usage.patch.patch
Xref: 5085619
minor manual changes to match upstream changes
* chore: update build_do_not_depend_on_packed_resource_integrity.patch
Xref: 5120922
minor manual changes to match upstream changes
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
Xref: 5041595
no manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
* chore: bump chromium in DEPS to 122.0.6188.0
* chore: bump chromium in DEPS to 122.0.6190.0
* chore: bump chromium in DEPS to 122.0.6192.0
* chore: bump chromium in DEPS to 122.0.6194.0
* Remove an unnecessary DCHECK which causes Lacros to crash.
5124880
* [FixIt Week] Add shared regular profile function that includes ash
5100709
* Simplify the PrintManagerHost::ScriptedPrint() call
5019703
* [local compile hints] Add tests
5024173
* chore: update patches
* fixup! chore: add refactor_update_node-platform_to_match_v8-platform_api_changes.patch
* chore: node script/gen-libc++-filenames.js
* Remove //ui/ozone/buildflags.h
5119048
* fixup! Remove //ui/ozone/buildflags.h
* fixup! Remove //ui/ozone/buildflags.h
* chore: update patches
* fixup! refactor: Add lookup for per-RenderFrame SpellCheckProvider
* fixup! Remove //ui/ozone/buildflags.h
* Add permission policy verification in PermissionControllerImpl
5059112
* fix: ensure spellcheck interface is registered for frame
* [exceptions] Unify pending and scheduled exceptions
5050065
* fix: dchecks in node.js tests
* fix: try adding termination check
* chore: document breaking iframe change
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: use new extensions Messaging API IPC
Refs CRBUG:993189
Incorporates changes from:
* Bind ServiceWorker associated interfaces on Worker Thread (CL:4929154)
* [extensions] Move WakeEventPage to mojom::RendererHost (CL:4902564)
* [extensions] Convert Extension Messaging APIs over to mojo (CL:4947890)
* [extensions] Port GetMessageBundle over to mojom (CL:4956841)
* 5008635: [extensions] Bind the mojo interfaces to the frame instance
5008635
* chore: bump chromium in DEPS to 121.0.6116.0
* chore: update patches
* Update webIDL to support close event.
Refs 4970653
* Remove uses of implicit conversion of ScopedTypeRef
Refs https://bugs.chromium.org/p/chromium/issues/detail?id=1495439
* Add GlobalRenderFrameHostToken
Refs 5001743
* [DevTools] Console Insights: move from build flag to Feature API
Refs 5002232
* [Extensions] Use script serialization in scripting API
Refs 4968680
Refs 4998265
* [api] Remove AllCan Read/Write
5006387
* chore: update libcxx files
* chore: address nan compilation error
* spec: use nan dependency from third_party
It is easier to get fixes for spec modules depending on nan
* ci: publish nan artifact for woa
* fix: bad patch update
* chore: update nan resolution
* Revert "chore: update nan resolution"
This reverts commit 786cdb858c9fc8a038a8f3e16068ee5b4a050137.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
