Shelley Vohr
f09f43a4a9
chore: remove unused arg parsing code in dialog ( #17420 )
2019-03-18 07:58:03 -07:00
Milan Burda
3a091cdea4
refactor: implement clipboard APIs without the remote module ( #17200 )
2019-03-15 17:32:04 -07:00
Heilig Benedek
43ef561d48
feat: enable NodeIntegrationInSubFrames for webview ( #17226 )
...
* feat: enable nodeIntegrationInSubFrames for webview
* test: add tests
* docs: document webview's nodeintegrationinsubframes
* lint: fix indent
* fix: resolve some merge bloopers
2019-03-15 10:39:20 -07:00
Shelley Vohr
961c9a88a8
feat: promisify dialog.showCertificateTrustDialog() ( #17181 )
...
* feat: promisify dialog.showCertificateTrustDialog()
* update promisification doc
2019-03-15 09:02:50 +09:00
Milan Burda
f15d0b1ed7
refactor: make ELECTRON_INSPECTOR_CONFIRM handler async ( #17378 )
2019-03-14 15:29:40 -07:00
Milan Burda
2e89348541
feat: promisify executeJavaScript ( #17312 )
2019-03-14 12:08:54 -07:00
Shelley Vohr
aa8b66aae1
feat: promisify session.getBlobData() ( #17303 )
2019-03-14 08:11:01 -07:00
Shelley Vohr
3e5a98b5f4
feat: promisify In-App Purchase ( #17355 )
...
* feat: promisify In-App Purchase
* use mate::Arguments in GetProducts
2019-03-13 13:56:01 -07:00
Milan Burda
faabd0cc8b
refactor: add ipcMainUtils.invokeInWebContents / ipcRendererUtils.handle helpers ( #17313 )
2019-03-13 12:03:17 -07:00
Shelley Vohr
8991c0056e
feat: promisify dialog.showMessageBox() ( #17298 )
...
* feat: promisify dialog.showMessageBox()
* address feedback from review
2019-03-12 11:06:59 -07:00
Milan Burda
48a95f9677
fix: remove non-existent gpu-crashed event on <webview> ( #17317 )
2019-03-11 17:25:46 -07:00
Milan Burda
6072da239d
feat: add global renderer-process-crashed event ( #17315 )
2019-03-11 16:17:24 -07:00
Shelley Vohr
9ea6c01e02
feat: promisify session.clearAuthCache() ( #17259 )
...
* feat: promisify session.clearAuthCache()
* remove unused callback runner helpers
2019-03-08 18:41:42 -08:00
Samuel Maddock
8ee153dae1
feat: add support for content scripts 'all_frames' option ( #17258 )
...
* feat: add support for content scripts 'all_frames' option
* merged content script tests
'all_frames' test now runs on all variants of sandbox/contentIsolation configurations :D
2019-03-08 15:53:25 -08:00
Shelley Vohr
fc10620082
feat: promisify session cache methods ( #17185 )
2019-03-08 14:42:03 -08:00
Shelley Vohr
2769e75b49
feat: promisify session proxy methods ( #17222 )
2019-03-08 12:51:12 -08:00
Shelley Vohr
e5e6aa207c
feat: promisify ses.clearHostResolverCache() ( #17229 )
2019-03-08 10:26:17 -08:00
Shelley Vohr
bbfa63fd9d
feat: promisify session.clearStorageData() ( #17249 )
2019-03-08 09:02:30 -08:00
Milan Burda
d34f81972d
refactor: make ELECTRON_BROWSER_SANDBOX_LOAD handler async ( #17107 )
2019-03-08 11:21:41 +01:00
Milan Burda
5791a2a9ec
refactor: use ipcRendererUtils.invoke / ipcMainUtils.handle for desktopCapturer.getSources() ( #16619 )
2019-03-07 15:31:25 -08:00
Felix Rieseberg
5581990d78
build: Update TypeScript, use @typescript-eslint ( #17251 )
...
* build: Update TypeScript to v3.3
* build: Update TypeScript, use @typescript-eslint
2019-03-07 12:56:02 -08:00
Milan Burda
2733697819
refactor: make ELECTRON_INSPECTOR_SELECT_FILE handler async ( #17235 )
2019-03-06 22:22:45 +01:00
Shelley Vohr
6cb7b8d3a4
feat: promisify dialog.showSaveDialog() ( #17054 )
...
* feat: promisify dialog.showSaveDialog()
* address some feedback from review
* filename => filePath
* fix last filename => filePath
2019-03-05 13:48:20 -08:00
Shelley Vohr
e05985145b
feat: promisify dialog.showOpenDialog() ( #16973 )
...
* feat: promisify dialog.showOpenDialog()
* address feedback from review
* address feedback from review
2019-03-05 05:54:48 -08:00
Milan Burda
bbd1ae315a
refactor: use invoke/invokeSync helpers for <webview> implementation ( #16784 )
2019-03-01 13:33:03 -05:00
Shelley Vohr
544d8a423c
feat: allow MenuItems to work optionally when hidden ( #16853 )
...
* feat: allow MenuItems to work optionally when hidden
* fix: actually include forward_declaration
2019-02-28 17:00:54 +00:00
Milan Burda
64078324bf
refactor: make CHROME_GET_MESSAGES handler async ( #17148 )
2019-02-27 21:30:35 -06:00
Nitish Sakhawalkar
bfa07ec4be
feat: Add new powerMonitor synchronous API ( #17144 )
...
`powerMonitor.querySystemIdleState` and `powerMonitor.querySystemIdleTime` had async backing APIs in chromium (https://chromium-review.googlesource.com/c/chromium/src/+/1379183 ). However, that has changed in ch73. So, this PR deprecates the old async APIs and adds new sync APIs.
2019-02-27 15:54:01 -05:00
Samuel Attard
08066581b0
fix: set cancelId to 1 when defaultId == 0 and no 'cancel' button ( #17123 )
2019-02-27 08:24:13 +00:00
Milan Burda
5a99ea4c46
refactor: merge ipcMainUtils.handle / handleSync ( #17062 )
2019-02-26 15:48:26 -08:00
Shelley Vohr
d9c7735a04
chore: augment promisifyMultiArg deprecation ( #17066 )
2019-02-25 18:25:25 -08:00
Thomas Beverley
1674388028
Fix webContents.print() ( #17052 )
2019-02-25 13:30:21 +00:00
ZYSzys
a40d826b11
chore: remove unused catch bindings ( #16121 )
2019-02-21 09:26:07 +00:00
Shelley Vohr
3edc497d3d
feat: show user gesture type in click event ( #16954 )
2019-02-20 12:20:24 +00:00
Milan Burda
7e7abc28f5
feat: promisify netLog.stopLogging ( #16862 )
2019-02-19 10:48:27 +00:00
Samuel Attard
3b74837020
refactor: Split 'Event' docs/types into more specific Event types ( #17038 )
...
* Event = Base event type (with preventDefault)
* IpcMainEvent = Event that ipcMain emits (with sender, reply, etc.)
* IpcRendererEvent = Event that ipcRenderer emits (with sender,
senderId, etc.)
* KeyboardEvent = Event that we emit with keyboard flags (ctrlKey,
altKey, etc.)
This will dramatically improve peoples TS experience with IPC events
2019-02-19 09:24:19 +00:00
Milan Burda
975a035d34
chore: re-enable devtools renderer sandbox ( #16864 )
...
* chore: re-enable devtools renderer sandbox
* chore: enable sandbox for chrome extension background script host renderers
2019-02-15 15:10:32 +05:30
Samuel Attard
5790869a3f
chore: refactor browser IPC into TS and app API into TS ( #16921 )
...
* chore: refactor browser IPC into typescript
* chore: refactor app.ts into Typescript
* Refactors app.dock into cpp
* Removes app.launcher which has not existed for 3 years
* Removes 2 deprecated APIs (that have been deprecated for more than one
major)
* Refactors deprecate.ts as well
2019-02-14 14:29:20 -08:00
deepak1556
005b7d8099
Print Preview: Add validity check for kSettingPagesPerSheet.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1381133
2019-02-14 23:59:25 +05:30
deepak1556
547add94d0
Make //ui/base/idle API synchronous
...
https://chromium-review.googlesource.com/c/chromium/src/+/1379183
2019-02-14 23:59:23 +05:30
Shelley Vohr
de27911661
feat: promisify webContents.savePage() ( #16742 )
...
* feat: promisify webContents.savePage()
* no need to make compatible w callbacks, we're breaking it
* fix promise resolve type
* address feedback from review
* fix promise return text
* update smoke test
2019-02-14 09:03:28 -08:00
Stewart Lord
84ef9cae6c
fix: send chrome.runtime/tabs.sendMessage
result to correct sender ( #16945 )
...
Additionally, use `.once` instead of `.on` for result specific listeners.
2019-02-14 06:07:55 -10:00
Milan Burda
2492f0bcac
refactor: promisify prototype methods ( #16935 )
2019-02-14 03:40:24 -10:00
Shelley Vohr
fed5b99a9f
feat: promisify contentTracing.getTraceBufferUsage() ( #16600 )
...
* feat: promsify contentTracing.getTraceBufferUsage()
* deprecate getTraceBufferUsage
* address feedback from review
* properly deprecate
2019-02-13 13:24:57 -08:00
Milan Burda
1f458eb177
feat: promisify debugger.sendCommand() ( #16861 )
...
* remove duplicate entry for desktopCapturer.getSources
* feat: promisify debugger.sendCommand
2019-02-13 07:23:53 -10:00
Samuel Maddock
8f6a543398
feat: add chrome.runtime.getManifest ( #16891 )
...
* feat: add chrome.runtime.getManifest
* Add test for chrome.runtime.getManifest
* Use IPC utils for getManifest internals
2019-02-13 07:16:12 -10:00
Samuel Attard
01c442de64
refactor: convert more files to typescript ( #16820 )
2019-02-12 04:22:33 -10:00
Milan Burda
d8ba1278d1
chore: disable the remote module in devtools / chrome extension background scripts ( #16866 )
...
* cache isRemoteModuleEnabled
* chore: disable the remote module in devtools / chrome extension background scripts
2019-02-11 10:42:37 -10:00
Milan Burda
36ce3e9546
feat: promisify webContents.printToPDF() ( #16795 )
2019-02-11 09:20:04 -10:00
Milan Burda
7a3d220347
refactor: implement Chrome Extension APIs without the remote module ( #16686 )
...
* refactor: implement Chrome Extension APIs without the remote module
* remove unused potentiallyRemoteRequire
2019-02-10 10:38:14 -08:00
Milan Burda
3f52e18a38
chore: add menu-will-close comment explaining setTimeout ( #16794 )
2019-02-08 13:38:03 -08:00
Milan Burda
1632c4b837
refactor: implement chrome.i18n.getMessage() without the remote module ( #16739 )
...
* refactor: implement chrome.i18n.getMessage() without the remote module
* replace navigator.language with app.getLocale()
2019-02-08 12:07:09 -08:00
Samuel Attard
db11b9b13b
fix: restore accidentally removed chrome-extension require ( #16819 )
2019-02-07 12:38:57 -08:00
Samuel Attard
4f8ebafa97
chore: dont log 100000000 chars of URL ( #16800 )
2019-02-07 08:50:47 -08:00
Samuel Attard
26df9992cf
build: use typescript for internal Electron JS code ( #16441 )
2019-02-06 10:27:20 -08:00
Shelley Vohr
858781ba83
feat: allow Menu.buildFromTemplate() to accept MenuItems ( #16697 )
...
* feat: allow Menu.buildFromTemplate to accept MenuItems
* add another spec
* fix linter error
* add submenu spec
2019-02-06 10:04:40 -08:00
Milan Burda
4211a9c69f
refactor: use ipcRendererUtils.invokeSync / ipcMainUtils.handleSync ( #16759 )
2019-02-06 09:53:28 -08:00
Milan Burda
6d674eebb1
refactor: crashReporterInit ( #16729 )
2019-02-05 12:56:44 -08:00
Shelley Vohr
f303caa87c
refactor: remove ServiceWorker APIs from WebContents ( #16717 )
2019-02-04 22:22:46 -08:00
Samuel Attard
af64140100
refactor: enforce naming of ipcMainInternal ( #16689 )
2019-02-04 14:49:53 -08:00
Milan Burda
7dc565fc2e
refactor: implement inspector APIs without the remote module ( #16607 )
2019-02-01 19:56:46 +01:00
michtsu
392458b252
Add devtools API to inspect shared worker. ( #16615 )
2019-02-01 10:44:24 -08:00
Charles Kerr
76dcbcd6ea
chore: fix 'browserView' typo ( #16621 )
2019-01-30 21:07:08 -08:00
Shelley Vohr
ba57e1d991
feat: promisify contentTracing recording APIs ( #16584 )
...
* feat: promisify contentTracing.startRecording()
* feat: promisify contentTracing.stopRecording()
* test: convert specs for new promisified apis
* chore: deprecate and ensure legacy tests work
2019-01-30 18:53:55 -08:00
Shelley Vohr
641b47f384
feat: promisify contentTracing.getCategories() ( #16583 )
...
* feat: promisify contentTracing.getCategories()
* deprecate contentTracing/getCategories
2019-01-30 12:39:55 -08:00
Milan Burda
dfcee48f81
fix: don't forward IPC filtering events to app for dev-tools and extensions ( #16565 )
2019-01-30 08:20:03 -08:00
Milan Burda
fa5442f211
fix: execute session preload scripts in sandboxed renderers ( #16538 )
2019-01-29 10:16:46 +09:00
Shelley Vohr
d105dcc0d3
feat: promisify webContents.hasServiceWorker() ( #16535 )
...
* feat: promisify contents.hasServiceWorker()
* spec: add initial test for hasServiceWorker()
2019-01-26 10:23:16 -08:00
Shelley Vohr
5a35c3a279
chore: fix promisify helper ( #16544 )
...
* chore: fix promise deprecation helper
* fix deprecations
* update deprecation tests
2019-01-25 14:23:24 -08:00
Charles Kerr
8396a2d504
feat: promisify cookies api ( #16464 )
...
* feat: promisify the Cookie API
* chore: update specs to test promisified cookies
* chore: add deprecate wrapper for cookie callback API
* docs: update docs to cookie promise changes
* chore: remove redundant namespace use
* docs: improve cookie example
* docs: restore docs for cookie callback API
* chore: restore cookie callback tests
* fix: syntax of cookie promise return types
2019-01-25 12:11:35 -06:00
Milan Burda
cc90919384
refactor: pass internal flag via IPC message struct for consistency ( #16490 )
2019-01-23 08:24:57 -08:00
Samuel Attard
f3e30c7ae3
Merge remote-tracking branch 'origin/chromium-upgrade/72'
2019-01-22 12:01:18 -08:00
Samuel Attard
0b85fb7ea2
Revert "feat: upgrade to Chromium 72.0.3626.52 ( #16334 )"
...
This reverts commit 1918e76913
.
2019-01-22 12:01:04 -08:00
Samuel Attard
58a6fe13d6
feat: preloads and nodeIntegration in iframes ( #16425 )
...
* feat: add support for node / preloads in subframes
This feature has delibrately been built / implemented in such a way
that it has minimum impact on existing apps / code-paths.
Without enabling the new "nodeSupportInSubFrames" option basically none of this
new code will be hit.
The things that I believe need extra scrutiny are:
* Introduction of `event.reply` for IPC events and usage of `event.reply` instead of `event.sender.send()`
* Usage of `node::FreeEnvironment(env)` when the new option is enabled in order to avoid memory leaks. I have tested this quite a bit and haven't managed to cause a crash but it is still feature flagged behind the "nodeSupportInSubFrames" flag to avoid potential impact.
Closes #10569
Closes #10401
Closes #11868
Closes #12505
Closes #14035
* feat: add support preloads in subframes for sandboxed renderers
* spec: add tests for new nodeSupportInSubFrames option
* spec: fix specs for .reply and ._replyInternal for internal messages
* chore: revert change to use flag instead of environment set size
* chore: clean up subframe impl
* chore: apply suggestions from code review
Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>
* chore: clean up reply usage
* chore: fix TS docs generation
* chore: cleanup after rebase
* chore: rename wrap to add in event fns
2019-01-22 11:24:46 -08:00
Jeremy Apthorp
92b9525cfd
feat: enable mixed-sandbox mode by default ( #15894 )
2019-01-22 10:44:28 -08:00
Jeremy Apthorp
1918e76913
feat: upgrade to Chromium 72.0.3626.52 ( #16334 )
2019-01-22 10:39:32 -08:00
Cheng Zhao
03d499bf34
fix: detach webview instead of destroying it
...
Chromium no longer cleans up everything when a guest webcontents is
destroyed, we have to force detaching it and let Chromium destroy everything.
2019-01-22 10:32:06 -08:00
Milan Burda
6cba2c50a2
feat: make ipc-message
and ipc-message-sync
events public ( #16468 )
2019-01-22 08:47:58 -08:00
Milan Burda
7d71ad6f91
fix: takeHeapSnapshot() using public IPC channel for internal implementation ( #16480 )
2019-01-22 17:32:24 +09:00
Shelley Vohr
3ca87d205f
feat: make zoomLevel/zoomFactor sync ( #16410 )
...
* feat: make zoomLevel/zoomFactor sync
* update ts defs dep
2019-01-20 23:40:27 -08:00
Milan Burda
7d4a1223fd
feat: add preload-error
event to webContents
( #16411 )
2019-01-18 12:03:43 +01:00
Shelley Vohr
f105c84349
test: ensure legacy callback functions work ( #16436 )
...
* test: test legacy callback functions
* add TODO removal comments
* fix callback spec
2019-01-17 14:17:16 -08:00
Shelley Vohr
720197f9c8
fix: correctly handle IPC for promise-based methods ( #16433 )
2019-01-17 12:08:54 -08:00
Shelley Vohr
1f2b02c18f
feat: promisify protocol.isProtocolHandled() ( #16423 )
...
* feat: promisify protocol
* fix base::Bind and specs
* update documentation
* make callback-compatible
* async awaitify tests
2019-01-17 09:05:10 -08:00
Milan Burda
23d44e322d
feat: use default-app behavior in packaged apps ( #16310 )
...
Unify the behavior between default app and packaged apps:
- create default application menu unless the app has one
- default window-all-closed handling unless the app handles the event
2019-01-15 21:35:53 +01:00
Milan Burda
52e257668d
fix: windowmenu did not show the window list on macOS ( #16387 )
2019-01-14 17:27:52 +01:00
Milan Burda
eb02a422de
feat: add fileMenu
/ viewMenu
/ appMenu
roles ( #16328 )
2019-01-10 14:32:03 +01:00
Milan Burda
349a3c20ae
feat: add additional remote APIs filtering ( #16293 )
2019-01-08 14:27:56 -08:00
Milan Burda
5c250455ad
refactor: pass isWebViewTagEnabled via ELECTRON_BROWSER_SANDBOX_LOAD ( #16238 )
2019-01-08 10:12:34 +01:00
Shelley Vohr
b71a5a5955
fix: register accelerator if role has no registerAccelerator ( #16309 )
...
* fix: register accelerator if role has no registerAccelerator
* ensure roles[role].registerAccelerator is defined
2019-01-07 16:01:03 -08:00
Milan Burda
6f117b8e0c
feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue() ( #16282 )
...
* feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue()
* add more tests
* refactor: move appendSwitch / appendArgument to command_line module
* replace AppendSwitchASCII with AppendSwitchNative
* remove castArgs
2019-01-07 07:48:27 -08:00
Milan Burda
a0cdcc5f8d
security: improve IPC validation in guest-view-manager
2019-01-05 00:06:47 +01:00
Milan Burda
547097b036
security: allow to block desktopCapturer.getSources() calls ( #15964 )
...
* security: allow to block desktopCapturer.getSources() calls
* return empty instead of error
* fix: release resources of DesktopCapturer on exit
2018-12-20 11:44:30 +09:00
Milan Burda
c65a0d90b8
chore: misc cleanup ( #16037 )
2018-12-12 15:31:16 -06:00
Milan Burda
607b53c883
security: block chrome.tabs.executeScript() for non chrome-extension: URLs ( #15929 )
2018-12-11 10:45:46 +01:00
Benjamin Pasero
c74ae107f1
fix: do not print an error for an expected condition ( #15991 ) ( #15992 )
2018-12-10 12:06:26 -08:00
Shelley Vohr
4b18a38e9f
chore: simplify promisify helper ( #15952 )
...
chore: simplify promisify helper
2018-12-10 08:13:09 -08:00
Cheng Zhao
db2fda1b6f
chore: make rpc-server reply to sender frame instead of the main frame ( #15973 )
...
* chore: make rpc-server reply to frame
* fix: check IsRenderFrameLive
2018-12-10 09:37:42 +09:00
Jeremy Apthorp
442c1b22e3
feat: webContents.loadURL returns a promise ( #15855 )
2018-12-06 12:16:19 -08:00
Shelley Vohr
3f15f51615
feat: promisify app.getFileIcon() ( #15742 )
2018-12-05 08:50:12 -08:00