Fedor Indutny
55e7a47d70
fix: always terminate active Node Streams ( #43056 )
...
`.destroy()` is an important method in the lifecycle of a Node.js
Readable stream. It is typically called to reclaim the resources
(e.g., close file descriptor). The only situations where calling
it manually isn't necessary are when the following events are
emitted first:
- `end`: natural end of a stream
- `error`: stream terminated due to a failure
Prior to this commit the ended state was incorrectly tracked together
with a pending internal error. It led to situations where the request
could get aborted during a read and then get marked as ended (having
pending error).
With this change we disentangle pending "error" and "destroyed" cases to
always properly terminate an active Node.js Readable stream.
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
2024-07-27 12:25:43 -05:00
Charles Kerr
f36ceae024
chore: migrate base::StringPiece to std::string_view ( #40915 )
...
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
2024-01-10 19:00:37 -06:00
Milan Burda
892c9d78a3
chore: replace absl::optional<T> with std::optional<T> ( #40928 )
...
* chore: replace absl::optional<T> with std::optional<T>
* IWYU
2024-01-10 16:23:35 -06:00
Jeremy Rose
fda8ea9277
feat: add protocol.handle ( #36674 )
2023-03-27 10:00:55 -07:00
electron-roller[bot]
08ccc81574
chore: bump chromium to 107.0.5274.0 (main) ( #35375 )
...
* chore: bump chromium in DEPS to 106.0.5247.1
* chore: update can_create_window.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3805043
content/renderer/render_view_impl.cc was removed
* chore: update patches/chromium/printing.patch
Normal code shear.
* chore: update patches/chromium/add_contentgpuclient_precreatemessageloop_callback.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3764862
fix minor code shear that caused the patch to not apply
* chore: update patches/chromium/picture-in-picture.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3781646
Normal code shear.
* chore: update patches/chromium/allow_disabling_blink_scheduler_throttling_per_renderview.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3805043
content/renderer/render_view_impl.cc was removed
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3792324
Normal code shear.
* chore: update patches/chromium/feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
Normal code shear.
* chore: update patches/chromium/fix_patch_out_profile_refs_in_accessibility_ui.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3798548
Normal code shear.
* chore: update patches/chromium/build_disable_print_content_analysis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3810473
Normal code shear.
* chore: short-circuit_permissions_checks_in_mediastreamdevicescontroller.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3807504
Normal code shear.
* chore: update patches
* chore: bump chromium in DEPS to 106.0.5249.0
* chore: bump chromium in DEPS to 107.0.5250.0
* chore: bump chromium in DEPS to 107.0.5252.0
* chore: bump chromium in DEPS to 107.0.5254.0
* chore: bump chromium in DEPS to 107.0.5256.1
* chore: update v8 patches
* chore: update chromium patches
* [CodeHealthRotation] base::Value::Dict (v2) migration for //c/b/ui/zoom
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3778239
* Add support for snapped window states for lacros
https://chromium-review.googlesource.com/c/chromium/src/+/3810538
* webui: Migrate /chrome/browser/ui/webui URLDataSources to GetMimeType(GURL)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3774560
* Provide explicit template arguments to blink::AssociatedInterfaceRegistry::AddInterface
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3773459
* Make WebScriptExecutionCallback base::OnceCallback
Refs
https://chromium-review.googlesource.com/c/chromium/src/+/3676532
https://chromium-review.googlesource.com/c/chromium/src/+/3724623
https://chromium-review.googlesource.com/c/chromium/src/+/3675752
* Add implementation of reduce accept language service
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3687391
* Add PermissionResult in //content/public.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3807504
* [Extensions] Add new Webstore domain to extension URLs and clients
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3793043
* chore: update node patches
* chore: fix lint
* chore: update filenames.libcxx.gni
* fixup! Make WebScriptExecutionCallback base::OnceCallback
* chore: bump chromium in DEPS to 107.0.5266.1
* chore: bump chromium in DEPS to 107.0.5268.0
* chore: bump chromium in DEPS to 107.0.5270.1
* chore: update patches
* 3848842: [DevTools] Added 'printing-in-progress' error code.
https://chromium-review.googlesource.com/c/chromium/src/+/38488
* 3855766: PA: Move the allocator shim files into partition_allocator/shim/ | https://chromium-review.googlesource.com/c/chromium/src/+/3855766
* Change gfx::Rect to blink::mojom::WindowFeatures in AddNewContents and some related functions.
https://chromium-review.googlesource.com/c/chromium/src/+/3835666
* Use base::FunctionRef for the various ForEachRenderFrameHost helpers.
https://chromium-review.googlesource.com/c/chromium/src/+/3767487
* [loader] Send cached metadata as part of OnReceiveResponse
https://chromium-review.googlesource.com/c/chromium/src/+/3811219
* 3832927: [json-schema-compiler] Support abs::optional<int>
https://chromium-review.googlesource.com/c/chromium/src/+/3832927
* Use unique_ptr for BrowserPluginGuestDelegate::CreateNewGuestWindow
https://chromium-review.googlesource.com/c/chromium/src/+/3847070
* 3847044: [Android] Dismiss select popup upon entering fullscreen
https://chromium-review.googlesource.com/c/chromium/src/+/3847044
* chore: update patches
* chore: add missing header
* Migration of chrome/ BrowserContextKeyedServiceFactory to ProfileKeyedServiceFactory Part 12
https://chromium-review.googlesource.com/c/chromium/src/+/3804581
* 3786946: cast pwrite64 arg to long to avoid compilation error on arm
https://chromium-review.googlesource.com/c/linux-syscall-support/+/3786946
* chore: update patches after rebase
* 3846114: float: Implement for lacros p2.
https://chromium-review.googlesource.com/c/chromium/src/+/3846114
* 3825237: Enable -Wunqualified-std-cast-call
https://chromium-review.googlesource.com/c/chromium/src/+/3825237
* chore: bump chromium in DEPS to 107.0.5272.0
* chore: update patches
* 3835746: Rename PepperPluginInfo to ContentPluginInfo
https://chromium-review.googlesource.com/c/chromium/src/+/3835746
* 3852542: Plumb drag-image rect from blink to browser to RenderWidgetHostImpl
https://chromium-review.googlesource.com/c/chromium/src/+/3852542
* 3826169: [json-schema-compiler] Support abs::optional<bool>
https://chromium-review.googlesource.com/c/chromium/src/+/3826169
Also 3840687: [json-schema-compiler] Support abs::optional<double>
https://chromium-review.googlesource.com/c/chromium/src/+/3840687
* 3857319: Reland "Remove PrefService::Get"
https://chromium-review.googlesource.com/c/chromium/src/+/3857319
* 3854614: Rework LinuxUi ownership and creation
https://chromium-review.googlesource.com/c/chromium/src/+/3854614
* chore: bump chromium in DEPS to 107.0.5274.0
* 3866104: [DownloadBubble] Change download notifications in exclusive_access
https://chromium-review.googlesource.com/c/chromium/src/+/3866104
* chore: update patches
* chore: disable optimization guide for preconnect feature
* 3860569: Enable -Wshadow on Linux.
https://chromium-review.googlesource.com/c/chromium/src/+/3860569
* chore: update patches after rebase
* fixup: update to accomodate Wc++98-compat-extra-semi flag
* Revert "fixup! Make WebScriptExecutionCallback base::OnceCallback"
This reverts commit 0866fe8648671f04e4ea45ceed85db6e4a3b260b.
* fixup! Make WebScriptExecutionCallback base::OnceCallback
* fixup! Make WebScriptExecutionCallback base::OnceCallback
* 3840937: [sandbox] Merge V8_SANDBOXED_POINTERS into V8_ENABLE_SANDBOX
https://chromium-review.googlesource.com/c/v8/v8/+/3840937
* fixup! chore: update can_create_window.patch
* chore: update patches
* 53946: Track SSL_ERROR_ZERO_RETURN explicitly.
https://boringssl-review.googlesource.com/c/boringssl/+/53946
* fixup: Migration of chrome/ BrowserContextKeyedServiceFactory to ProfileKeyedServiceFactory Part 12
https://chromium-review.googlesource.com/c/chromium/src/+/3804581
* 3805932: [headless] Added print compositor support for OOPIF printing.
https://chromium-review.googlesource.com/c/chromium/src/+/3805932
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2022-09-07 09:46:37 +02:00
electron-roller[bot]
470396d6ac
chore: bump chromium to 104.0.5073.0 (main) ( #34272 )
2022-06-01 08:12:47 +02:00
Jeremy Rose
d8a7219d07
chore: stop using v8::Locker everywhere ( #34078 )
2022-05-05 11:50:21 -07:00
electron-roller[bot]
28ada6ea8b
chore: bump chromium to 100.0.4857.0 (main) ( #32419 )
...
* chore: bump chromium in DEPS to 99.0.4819.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4824.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4827.0
* chore: update patches
* 3352511: PiP: Add inkdrop and pointer cursor to PiP window buttons
https://chromium-review.googlesource.com/c/chromium/src/+/3352511
* 3309164: webhid: Show FIDO devices in the chooser if allowed
https://chromium-review.googlesource.com/c/chromium/src/+/3309164
* 3297868: hid: Add experimental HIDDevice.forget()
https://chromium-review.googlesource.com/c/chromium/src/+/3297868
* 3362491: [Extensions] Move i18n API to //extensions
https://chromium-review.googlesource.com/c/chromium/src/+/3362491
* MCC Refactor step0: Allow embedders to register associated_interface binders with RenderFrameHostImpl::associated_registry_.
https://chromium-review.googlesource.com/c/chromium/src/+/3281481
* 3352616: [Gtk] Remove libgtk from the link-line
https://chromium-review.googlesource.com/c/chromium/src/+/3352616
* 3249211: Clear-Site-Data support for partitioned cookies
https://chromium-review.googlesource.com/c/chromium/src/+/3249211
* [Extensions][COIL] Use [allow|block]list in //extensions/common
https://chromium-review.googlesource.com/c/chromium/src/+/3372668
* Begin ScopedUserPrefUpdate migration to modern base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3376154
* [Code Health] Refactor PrefService GetDict + GetList to use base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3343526
* 3354997: [CodeHealth] Remove deprecated SetDictionary method
https://chromium-review.googlesource.com/c/chromium/src/+/3354997
* 3287323: Add LacrosPrefStore for lacros settings
https://chromium-review.googlesource.com/c/chromium/src/+/3287323
* 3365916: [PA] Clean up remaining lazy commit code
https://chromium-review.googlesource.com/c/chromium/src/+/3365916
* [MPArch] Target the external protocol error at the responsible frame.
https://chromium-review.googlesource.com/c/chromium/src/+/3011560
* Pass origin to RegisterNonNetworkSubresourceURLLoaderFactories
https://chromium-review.googlesource.com/c/chromium/src/+/3350608
* Linux: Send OSCrypt raw encryption key to the Network Service
https://chromium-review.googlesource.com/c/chromium/src/+/3320484
* [PlzServiceWorker] Remove remaining references to PlzServiceWorker.
https://chromium-review.googlesource.com/c/chromium/src/+/3359441
* chore: fixup for lint
* 3327621: Fix tablet mode detection for Win 11.
https://chromium-review.googlesource.com/c/chromium/src/+/3327621
* 3342428: ax_mac: move AXTextMarker conversion utils under ui umbrella
https://chromium-review.googlesource.com/c/chromium/src/+/3342428
* 3353974: Mac: Use base::Feature for overlay features
https://chromium-review.googlesource.com/c/chromium/src/+/3353974
* chore: bump chromium in DEPS to 99.0.4828.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4837.0
* chore: update patches
* chore: update patches
* 3379142: Drop FALLTHROUGH macro
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3379142
* 3381749: C++17: Allow use of std::map::try_emplace and std::map::insert_or_assign
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3381749
* chore: bump chromium in DEPS to 99.0.4839.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4840.0
* chore: bump chromium in DEPS to 99.0.4844.0
* 3395881: [api] Deprecate Local<v8::Context> v8::Object::CreationContext()
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3395881
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4845.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4847.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4849.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4851.0
* chore: bump chromium in DEPS to 100.0.4853.0
* update patches
* chore: update patches
* update patches
* 3383599: Fonts Access: Remove prototype that uses a font picker.
https://chromium-review.googlesource.com/c/chromium/src/+/3383599
* 3404768: Remove ALLOW_UNUSED macros
https://chromium-review.googlesource.com/c/chromium/src/+/3404768
* 3374762: Remove ignore_result.h
https://chromium-review.googlesource.com/c/chromium/src/+/3374762
* 3399305: [unseasoned-pdf] Apply proper frame offsets for touch selections
https://chromium-review.googlesource.com/c/chromium/src/+/3399305
* 3402210: [Extensions] Don't trigger unload event for already unloaded extension
https://chromium-review.googlesource.com/c/chromium/src/+/3402210
* 3410912: Combine URLLoaderClient OnReceiveResponse and OnStartLoadingResponseBody.
https://chromium-review.googlesource.com/c/chromium/src/+/3410912
* 3370428: Make the AuthSchemes policy support dynamic refresh
https://chromium-review.googlesource.com/c/chromium/src/+/3370428
* 3407603: Finish ScopedUserPrefUpdate migration to modern base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3407603
* 3378352: ozone/x11: move code from //ui/p/x11 to //ui/ozone/p/x11
https://chromium-review.googlesource.com/c/chromium/src/+/3378352
* 3370810: Delete chrome/service, AKA the Cloud Print service process.
https://chromium-review.googlesource.com/c/chromium/src/+/3370810
* chore: bump chromium in DEPS to 100.0.4855.0
* chore: update patches
* fixup! 3370810: Delete chrome/service, AKA the Cloud Print service process.
* revert 3348007 to fix windows build
* 3318572: [Code health] Fix gn check errors in //extensions/browser:*
https://chromium-review.googlesource.com/c/chromium/src/+/3318572
* fix printing.patch
* fix iwyu issue
* 3408515: win: Make ShorcutOperation an enum class and modernize names
https://chromium-review.googlesource.com/c/chromium/src/+/3408515
* 3388333: [UIA] Remove dead code accessibility_misc_utils.h/cc
https://chromium-review.googlesource.com/c/chromium/src/+/3388333
* fix windows build? i hope
* patch gn visibility of //ui/ozone/platform/x11
* missing include base/logging.h
* use BUILDFLAG for USE_NSS_CERTS
https://chromium-review.googlesource.com/c/chromium/src/+/3379123
* defined(OS_*) ==> BUILDFLAG(IS_*)
https://bugs.chromium.org/p/chromium/issues/detail?id=1234043
* fixup! 3404768: Remove ALLOW_UNUSED macros
* another attempt to fix windows build
* temporarily disable the custom scheme service worker test
https://github.com/electron/electron/issues/32664
* fix loading mv3 extensions
not sure what cl broke this unfort.
* fixup! 3404768: Remove ALLOW_UNUSED macros
* patch nan
https://chromium-review.googlesource.com/c/v8/v8/+/3395880
* fix node test
* fix nullptr in FindPdfFrame
* patch perfetto to fix build issue on win-ia32
https://source.chromium.org/chromium/_/android/platform/external/perfetto.git/+/bc44c3c7533c00e56f88c06c592d634aecc884be
* fix build for linux-x64-testing-no-run-as-node
* fix patch
* skip <webview>.capturePage() test
https://github.com/electron/electron/issues/32705
* test: fix failing tests of focus/blur events of WebContents (#32711 )
* inherit stdio from app module test child processes
this prevents them from timing out due to full stdout buffers
* test to see if we can get better logs on windows ci
* try again for appveyor log things
* skip contentTracing tests on ia32
* ci: disable gpu compositing
* drop applied patch
* fix merge fail
* Revert "ci: disable gpu compositing"
This reverts commit 0344129fcb19ea3e87e06c1110d751f22eba3fec.
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2022-02-09 18:58:52 -08:00
David Sanders
77ecc7d432
chore: fix typos in comments ( #29362 )
2021-05-27 11:48:03 -07:00
Samuel Attard
77ad17b383
refactor: CreateDataPipe deprecated form was removed
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2698090
2021-03-05 16:42:15 -08:00
Electron Bot
ca75bca667
chore: bump chromium to 90.0.4415.0 (master) ( #27694 )
...
* chore: bump chromium in DEPS to 520c02b46668fc608927e0fcd79b6a90885a48bf
* chore: bump chromium in DEPS to 90.0.4414.0
* resolve chromium conflicts
* resolve v8 conflicts
* fix node gn files
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2676903: [mojo] Remove most legacy Binding classes.
https://chromium-review.googlesource.com/c/chromium/src/+/2676903
* 2644847: Move self-deleting URLLoaderFactory base into //services/network.
https://chromium-review.googlesource.com/c/chromium/src/+/2644847
* 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* 2672923: Remove RAPPOR reporting infrastructure.
https://chromium-review.googlesource.com/c/chromium/src/+/2672923
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2655126: Convert FrameHostMsg_ContextMenu and FrameMsg_ContextMenuClosed|CustomContextMenuAction to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/2655126
* 2628705: Window Placement: Implement screen.isExtended and change event
https://chromium-review.googlesource.com/c/chromium/src/+/2628705
* 2643161: Refactor storage::kFileSystem*Native*
https://chromium-review.googlesource.com/c/chromium/src/+/2643161
* fix build
* only remove the biggest subdir of //ios
* chore: bump chromium in DEPS to 90.0.4415.0
* update patches
* update sysroots
* 2686147: Remove WebContentsObserver::RenderViewCreated().
https://chromium-review.googlesource.com/c/chromium/src/+/2686147
* 2596429: Fixing how extension's split and spanning modes affect OriginAccessList.
https://chromium-review.googlesource.com/c/chromium/src/+/2596429
* 2686026: [mojo] Delete AssociatedInterfacePtr (replaced by AssociatedRemote)
https://chromium-review.googlesource.com/c/chromium/src/+/2686026
* 2651705: Move ui/base/dragdrop/file_info to ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/2651705
* 358217: drawBitmap is deprecated
https://skia-review.googlesource.com/c/skia/+/358217
* fix gn check
* 2678098: Use gen/front_end as input to generate_devtools_grd
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678098
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* fixup 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* fixup build_add_electron_tracing_category.patch
* 2673415: [base] Prepare CrashReporterClient for string16 switch
https://chromium-review.googlesource.com/c/chromium/src/+/2673415
* 2673413: Add CursorFactoryWin to handle Cursors on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2673413
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* fix mas gn check
* update patch after merge
* Update node for .mjs files
* build: load v8_prof_processor dependencies as ESM
* chore: add patch to fix linux 32bit
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-03-04 09:27:05 -08:00
Milan Burda
ddf3ef0a5f
refactor: use C++11 class member variable initialization ( #27477 )
2021-01-26 12:16:21 -06:00
David Sanders
b194030a34
chore: cleanup some typos in comments ( #25770 )
2020-10-13 10:25:21 -07:00
Paul Frazee
509740c357
fix: Close protocol response streams when aborted ( #24014 )
2020-07-21 09:51:38 +09:00
Paul Frazee
81d09bea44
fix: correctly handle nexttick scheduling in stream reads ( #24022 )
2020-06-11 09:55:59 -07:00
Jeremy Apthorp
19314d3caf
fix: remove catch-all HandleScope ( #22531 )
2020-03-10 18:16:58 -07:00
Jeremy Apthorp
d68f17b32c
fix: stream protocols not completing ( #21733 )
2020-01-13 10:28:21 -08:00
Electron Bot
0f2f9a580a
chore: bump chromium to 94cc24d3bb17a7406ba6c6cc6dc29 (master) ( #21485 )
2019-12-13 12:13:12 -08:00
Electron Bot
49b47ee4ed
chore: bump chromium to f755b70e34659441e72c1a928a406 (master) ( #21000 )
2019-12-10 16:22:35 -08:00
Jeremy Apthorp
4045852e6f
fix: stream protocols sometimes flake out ( #21113 )
2019-11-18 10:47:29 -08:00
Jeremy Apthorp
593f1774e9
fix: backport Node nested microtask fix ( #20303 )
2019-09-25 17:38:50 -04:00
Cheng Zhao
2c23e44ed9
chore: remove native_mate (Part 3) ( #20131 )
...
* use gin converter in atom_api_menu
* please only put necessary includes in header
Having include in header means they have dependency relationship,
putting arbitrary includes really really really really really makes
refacoring much harder.
* remove some simple uses of callback_converter_deprecated.h
* use gin callback converter in file_dialog code
* use gin in ErrorThrower
* use gin in atom_bundle_mover
* fix mistake in node stream
* deprecate native_mate version of event_emitter_caller
* use gin in node_bindings
* remove usages of native_mate event_emitter_caller.h except for EventEmitter
* fix compilation on Windows
* gin::Arguments behaves differently on GetNext
* just use StringToV8
2019-09-06 14:52:54 +09:00
Cheng Zhao
81ae154714
chore: remove native_mate (Part 2) ( #20106 )
...
* add notice to files being removed
* add gin version of function_template.h
* rename callback.h to avoid confliction
* add gin version of callback_converter
* add gin converter for OnceCallback
* remove callback_converter_gin_adapter.h
* remove gin_util.h and gin_utils.h
* fix lint warning
* add helper for setting methods
2019-09-04 08:45:25 -07:00
Heilig Benedek
3f49f984e6
fix: race condition in NodeStreamLoader ( #19811 )
...
* fix: race condition in NodeStreamLoader
* nit: add comments
2019-08-21 12:23:46 +09:00
Electron Bot
bd526f97a5
chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) ( #19166 )
2019-07-24 15:58:51 -07:00
Samuel Attard
34c4c8d508
refactor: rename the atom namespace to electron
2019-06-19 17:33:28 -07:00
Samuel Attard
2160c1fcc9
refactor: replace includes for atom with shell
2019-06-19 17:33:28 -07:00
Samuel Attard
d7f07e8a80
refactor: rename the atom directory to shell
2019-06-19 17:33:28 -07:00
