trop[bot]
3764c4d0b3
docs: Make ipcRenderer and ipcMain listener API docs consistent ( #44711 )
...
* docs: Make ipcRenderer and ipcMain listener API docs consistent
Co-authored-by: Will Anderson <will@itsananderson.com>
* test: add some unit tests for ipcRenderer/ipcMain listener behavior
Co-authored-by: Will Anderson <will@itsananderson.com>
* fix: Mark on/off methods as primary and addListener/removeListener as aliases
Co-authored-by: Will Anderson <will@itsananderson.com>
* fix: clear all listeners before running ipcMain removeAllListeners tests
Co-authored-by: Will Anderson <will@itsananderson.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Will Anderson <will@itsananderson.com>
2024-11-19 09:47:45 +01:00
trop[bot]
d5ece2a033
docs: document why to use the loadBrowserProcessSpecificV8Snapshot fuse ( #44709 )
...
Fixes #44450
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2024-11-18 17:51:10 -06:00
trop[bot]
5fc13009cb
fix: utilityProcess pid should be undefined after exit ( #44695 )
...
fix: utilityProcess pid should be undefined after exit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-18 14:44:14 +01:00
trop[bot]
2ee65f9c10
fix: revert required portal version for file chooser dialogs ( #44681 )
...
* feat: add support for configuring xdg portal version at runtime
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* doc: update command-line-switches.md
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* doc: update command-line-switches.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Robo <hop2deep@gmail.com>
* doc: required portal version for defaultPath support
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Robo <hop2deep@gmail.com>
* doc: update more occurrances
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* fix: remove warning from save dialogs
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* doc: update command-line-switches.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Robo <hop2deep@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-11-15 11:30:06 -05:00
trop[bot]
66bf0732dc
chore: remove executable flag from docs/api/app.md file permissions ( #44580 )
...
chore: set docs/api/app.md file permissions to 644
md files should not be executable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-05 12:12:40 -05:00
trop[bot]
5a09ca8d1e
docs: clarify that sessions use cache by default ( #44576 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2024-11-05 10:39:58 -06:00
trop[bot]
ab619ff231
docs: capitalize POSIX and Windows correctly ( #44559 )
...
* docs: capitalize POSIX correctly
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* docs: capitalize Windows correctly
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-04 16:43:05 -05:00
trop[bot]
434363de26
docs: fix apostrophe typo "Electrons" -> "Electron's" ( #44537 )
...
s/Electrons/Electron's/
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-03 09:33:10 -06:00
trop[bot]
5498eaa29d
docs: add custom titlebar example ( #44506 )
...
* docs: add custom titlebar example
* docs: add links and other small edits
* docs: add panel window docs
* docs: remove panel example
* docs: specify expected emphasis style
* docs: responding to feedback
* docs: fix section names in links
* docs: rework baseWindow note
* docs: making window customization its own section
* responding to feedback
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Anny Yang <anny@electronjs.org>
2024-11-01 12:47:51 -05:00
trop[bot]
5d5c18b7a6
fix: update shell.openExternal to correctly focus on external window ( #44469 )
...
* Revert "docs: fix `win.getContentView(`) return type (#44464 )"
This reverts commit b11c6cf9bf
2024-10-31 12:05:44 +01:00
trop[bot]
13dacf6a32
docs: fix win.setContentView() arg type ( #44481 )
...
fix: setContentView type
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-30 16:26:12 -04:00
trop[bot]
b11c6cf9bf
docs: fix win.getContentView() return type ( #44464 )
...
docs: fix win.getContentView() return type
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-29 17:00:13 -04:00
trop[bot]
b9b982cd7d
docs: clarify utilityProcess child.pid value ( #44363 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-22 19:22:02 +02:00
Niklas Wenzel
72802c374b
docs: add section on resource management to base-window.md ( #43610 )
2024-10-15 11:49:54 -04:00
George Xu
9ecb848c67
docs: update timelines for E34 ( #44210 )
...
update dates for e34
2024-10-14 10:52:18 -04:00
Sam Maddock
8b3d70a2a3
feat: add WebFrameMain detached property ( #43473 )
...
* feat: add WebFrameMain detached property
fix: throw instead of returning null senderFrame
test: detached frames
fix: ensure IPCs of pending deletion RFHs are dispatched
fix: lookup WFM by FTN ID to dispatch IPCs
feat: add frame.isDestroyed()
return null
fix: return undefined
docs: add null to all frame properties
refactor: option c, return null and emit warning
refactor: add routingId & processId to navigation events
test: null frame property
docs: clarify warning message
better wording
clarify null frame
fix: browserwindow spec
* maybe fix 🤷
* fix: use updated util #43722
* docs: add notice for frame change of behavior
* docs: clarify why frame properties may be null
* lint
* wip
* fix: content::FrameTreeNodeId lookup and converter
* refactor: avoid holey array deoptimization
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-11 18:33:53 -04:00
Niklas Wenzel
5400c04e43
docs: clarify interplay between utility process events ( #44015 )
2024-10-11 10:25:25 -04:00
Keeley Hammond
08d315da14
refactor: revert url::DomainIs() for cookie domains ( #44153 )
...
build: revert DomainIs refactor
2024-10-08 18:39:37 -07:00
Robo
f68184a9f9
feat: add error event for utility process ( #43774 )
...
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-27 10:17:06 +09:00
John Kleinschmidt
40cae71df8
test: re-enable tests that were disabled in chromium rolls ( #43968 )
...
* test: fix should support base url for data urls test
Caused by https://chromium-review.googlesource.com/c/chromium/src/+/5802682
* test: fixup extensions can cancel http requests
* chore: document custom protocol handling on Windows change due to Non-Special Scheme URLs shipping
https://chromium-review.googlesource.com/c/chromium/src/+/5802682
2024-09-26 08:53:27 -04:00
Samuel Attard
74af96da16
build: update some build dependencies ( #43882 )
...
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
2024-09-26 00:12:11 -07:00
Erick Zhao
fb5baec6d5
docs: add advanced specification for Squirrel updater ( #43234 )
...
* docs: add advanced specification for Squirrel updater
* address feedback
2024-09-23 10:20:43 -07:00
Alice Zhao
ceea1225a2
docs: navigation history example ( #42980 )
...
* docs: add fiddle example
* docs: add tutorial guide
* refactor: PR review comments
* refactor: add eof
* refactor: render navigation history and make demo better.
* refactor: fix broken links
* refactor: add eof newline
* docs: review feedback :)
* chore: lint add space around list
* doc: transformURL
2024-09-23 10:18:26 -07:00
Charles Kerr
bcb7362ab9
docs: document Windows pitfall when updating patches ( #43787 )
2024-09-19 23:35:21 -05:00
Niklas Wenzel
8f0dffea9e
docs: document View.removeChildView edge case ( #43673 )
2024-09-16 11:32:03 +02:00
Piotr Płaczek
29c2744e57
feat: hide menu bar on windows fullscreen ( #43402 )
...
* feat: hide menu bar on windows fullscreen
* test: state prior to html fullscreen transition
* refactor: restore `#ifdef` for readability
Reference: https://github.com/electron/electron/pull/43402#discussion_r1729356262
* docs: menu bar behavior changed
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-12 20:13:04 +02:00
Keeley Hammond
309d5dade3
feat: add support for system picker in setDisplayMediaRequestHandler ( #43581 )
...
* tmp
* feat: add support for system picker in setDisplayMediaRequestHandler
* oops
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* stuff
* well...
* seems legit
* chore: update patch to handle screenCapturer
* feat: modify API to use useSystemPicker
* fix: gate ScreenCaptureKitPicker to macos 15 or higher
* fix: don't use native picker with legacy media selection
* chore: code review, boolean set & docs update
* fix: add cancelCallback
* docs: clarify session & desktopCapturer docs
---------
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: Samuel Attard <sam@electronjs.org>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-09-10 16:05:57 -07:00
Kilian Valkhof
32d5f9e3ef
docs: explain ipcRenderer behavior in context-bridge.md ( #43455 )
...
* docs: explain ipcRenderer behavior in context-bridge.md
* Update context-bridge.md
* Update context-bridge.md
* Update docs/api/context-bridge.md
Co-authored-by: Erik Moura <erikian@erikian.dev>
* Update context-bridge.md
* Update context-bridge.md
* Update context-bridge.md
* Update docs/api/context-bridge.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update docs/api/context-bridge.md
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
---------
Co-authored-by: Erik Moura <erikian@erikian.dev>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-09-05 16:48:22 -04:00
Shelley Vohr
3a5a1ea7bd
docs: titleBarOverlay is defined as a BaseWindow ctor option ( #43430 )
...
docs: titleBarOverlay is defined as a BaseWindow ctor option
2024-08-23 11:02:43 -04:00
reito
1aeca6fd0e
feat: GPU shared texture offscreen rendering ( #42953 )
...
* feat: GPU shared texture offscreen rendering
* docs: clarify texture infos that passed by the paint event.
* feat: make gpu osr spec test optional
* fix: osr image compare
* fix: remove duplicate test
* fix: update patch file
* fix: code review
* feat: expose more metadata
* feat: use better switch design
* feat: add warning when user forget to release the texture.
* fix: typo
* chore: update patch
* fix: update patch
* fix: update patch description
* fix: update docs
* fix: apply suggestions from code review
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: apply suggested fixes
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-22 19:23:13 -05:00
Shelley Vohr
50ce448556
fix: menu should allow focused BaseWindow where possible ( #43404 )
...
fix: menu should allow focused BaseWindow
2024-08-22 14:13:30 -04:00
Alexander Cyon
b27dc7514e
fix: documentation spelling errors ( #43366 )
...
chore: fix typos in 'docs/' folder.
2024-08-22 15:44:55 +02:00
Shelley Vohr
755c6640fd
docs: clarify icon value in Notification ( #43377 )
...
* docs: clarify icon value in Notification
* Update docs/api/notification.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-08-21 19:38:06 -05:00
David Sanders
b7af0537c8
docs: update timelines for E33 ( #43389 )
2024-08-20 15:47:32 -07:00
Keeley Hammond
7da9c0b2f7
docs: update window customization tutorial ( #43388 )
2024-08-20 15:29:01 -07:00
Vít Černý
189675575c
feat: extend navigationHistory API ( #42014 )
...
* feat: extend navigationHistory API
* refactor: simplify index checking
* refactor: rename 'getHistory' and 'replaceHistory' methods of navigationHistory
* refactor: rename delete*() methods to remove*()
* feat: remove navigationHistory.replaceHistory()
* tests: add tests for removeEntryAtIndex and getAllEntries
2024-08-19 15:46:04 -04:00
Piotr Płaczek
4d51edc504
docs: api history ( #42982 )
...
* feat(api-history): api history schema
Reference: f36e0a8483/text/0004-api-history-schema.mdhttps://github.com/electron/electron/pull/42982/files#r1692532877
* docs(api-history): schema word choice
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Reference: 0b1b6a7cc0https://github.com/electron/electron/pull/42982#discussion_r1692539906
* docs(api-history): Always use double quotes for descriptions
* docs(api-history): `styleguide.md` improvements
* docs(api-history): copy `ipc-renderer.md` change to `context-bridge.md`
* docs(api-history): `styleguide.md` placement
* docs(api-history): add migration guide
* docs(api-history): remove confusing `breaking-changes-header` in `browser-view.md`
Reference: 7b03c0703d (r1703444772)https://github.com/electron/electron/pull/42982#discussion_r1703441001
* docs(api-history): update `breaking-changer-header`
Reference: https://github.com/electron/electron/pull/43217
* docs(api-history): deprecate `browser-view.md`
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-08-19 11:17:10 -07:00
Shelley Vohr
d7689bb9b5
docs: expand dialog window to BaseWindow ( #43334 )
...
docs: expand dialog window to BaseWindow
2024-08-16 10:49:10 -04:00
Robo
9b166b3ed4
feat: support app#login event for utility process net requests ( #42631 )
...
* feat: support app#login event for utility process net requests
* chore: address review feedback
* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
2024-08-14 11:36:47 +09:00
David Sanders
62406708cd
docs: fix formatting in fuses tutorial ( #43303 )
2024-08-13 15:27:44 -04:00
Shelley Vohr
d294871980
chore: deprecate textured BrowserWindow type option on macOS ( #43133 )
2024-08-12 10:32:35 +02:00
Charles Kerr
c35739d60d
refactor: use url::DomainIs() to check cookie domains ( #43262 )
...
* test: add tests to exercise pre-exsiting cookie domain matching behavior
* refactor: use url::DomainIs() to match cookie domains
* docs: fix typo
2024-08-09 18:35:18 -05:00
Felix Rieseberg
3fabf7837e
docs: Document ideal iconPath size ( #43149 )
2024-08-07 11:43:05 +02:00
Piotr Płaczek
f42331f277
docs: add missing deprecations to breaking-changes.md ( #43217 )
...
* docs: deprecate `BrowserView`
Reference: https://github.com/electron/electron/pull/35658
* docs: deprecate `webContents.goToIndex(index)`
Reference: https://github.com/electron/electron/pull/41752/files#diff-18ed6a5b5a9084c976509502962b7f05989a8bd13a2ba3dc02868056938c03b6R1165-R1167
* docs: deprecate some protocol methods
Reference: https://github.com/electron/electron/pull/36674/files#diff-74861ecada868821b139e79f244ea32b840a93f60de572d585117a0ff8d165c8R380
2024-08-06 09:07:36 -07:00
Charles Kerr
5b18cc46bc
chore: bump chromium to 129.0.6630.0 (main) ( #43087 )
...
* chore: bump chromium in DEPS to 129.0.6623.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
remove the changes to media/audio/mac/audio_manager_mac.cc,
since upstream has also made this change now.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5738654
* chore: update fix_disable_scope_reuse_associated_dchecks.patch
We had been removing a couple of `DCHECK`. Upstream changed their
code to limit when these `DCHECK`s get called, so let's see if our
change is still needed.
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5739076
* chore: e patches all
* Bump the Chrome macOS deployment target to 11.0
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5734361
BREAKING CHANGE: Bump the Chrome macOS deployment target to 11.0
* src: stop using deprecated fields of `v8::FastApiCallbackOptions`
Xref: d0000b118dhttps://chromium-review.googlesource.com/c/v8/v8/+/5741336
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5741199
* fixup! chore: update fix_disable_scope_reuse_associated_dchecks.patch
chore: re-disable DCHECKs
yep, it is still needed
* refactor use non-deprecated variant of openApplicationAtURL
old version is deprecated now in macOS 11
Xref: https://developer.apple.com/documentation/appkit/nsworkspace/1534810-launchapplicationaturl
Xref: https://developer.apple.com/documentation/appkit/nsworkspace/3172700-openapplicationaturl
* chore: bump chromium in DEPS to 129.0.6626.0
* chore: e patches all
* chore: disable NSUserNotification deprecation errors
* chore: disable NSWindowStyleMaskTexturedBackground deprecation errors
Xref: https://github.com/electron/electron/issues/43125
* chore: disable deprecation errors in platform_util_mac.mm
* chore: disable launchApplication deprecation errors
* chore: bump chromium in DEPS to 129.0.6630.0
* chore: update refactor_expose_file_system_access_blocklist.patch
apply patch manually due to context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5745444
* chore: update deps_add_v8_object_setinternalfieldfornodecore.patch
no manual changes. patch applied with fuzz 1 (offset -5 lines)
* chore: e patches all
* fix: add clang_x64_v8_arm64/snapshot_blob.bin to the zip manifest
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5746173
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-08-02 09:02:11 -05:00
Tingsong (Terrence) Ou
7c79221a54
docs: fixed broken electron-fiddle links in the "Tutorial - Publishing and Updating" doc ( #43129 )
...
fixed electron-fiddle build and config links
2024-08-01 20:28:50 -05:00
Shelley Vohr
791e6df82a
docs: update Node.js stable release policy ( #43100 )
...
* docs: update Node.js stable release policy
* Update docs/tutorial/electron-timelines.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-07-31 16:33:58 +02:00
Shelley Vohr
5669a40d5c
feat: add transparency checking to nativeTheme ( #42862 )
...
* feat: add transparency checking to nativeTheme
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4684870
* chore: deprecate previous function
* chore: fix lint
2024-07-24 14:38:22 +02:00
Shelley Vohr
9fc760bc4c
docs: note macOS fullscreen events in fullscreen query ( #42997 )
...
docs: note macOS fullscreen events in fs query
2024-07-23 16:40:59 -04:00
Shelley Vohr
3c9d4452c6
docs: improve desktop capture example ( #42957 )
2024-07-23 11:55:23 +02:00
