trop[bot]
eecca2cb19
fix: revert enabling WASM trap handlers in all Node.js processes ( #48975 )
...
Revert "fix: enable wasm trap handlers in all Node.js processes (#48788 )"
This reverts commit ca0b46b4130a8b48ab0b402ea16efe1ce655044f.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2025-11-14 18:56:50 -08:00
trop[bot]
d62c324567
fix: enable wasm trap handlers in all Node.js processes ( #48837 )
...
* fix: enable wasm trap handlers in all Node.js processes
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* fix: separate registrations to account for featurelist init
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* build: add missing header for SetStackDumpFirstChanceCallback
* fix: pdf spec
delay load pdfjs-dist which compiles wasm on load, trap handlers
will be initialized once the user script starts but before app#ready.
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-11-11 18:45:57 +09:00
trop[bot]
60826e6c7b
chore: bump chromium to 141.0.7390.7 (39-x-y) ( #48276 )
...
* chore: bump chromium in DEPS to 141.0.7381.3
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: bump chromium in DEPS to 141.0.7382.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: bump chromium in DEPS to 141.0.7384.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 141.0.7386.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* Move devtools_page and chrome_url_overrides handlers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6862700
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Reland "[api] Advance deprecation of GetIsolate"
Refs https://chromium-review.googlesource.com/c/v8/v8/+/6875273
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Move "system integrated UI" concept out of NativeTheme.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6867375
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: update patches
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Reland "[PermissionOptions] Return PermissionResult in callback for requests"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6851838
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Reland "[exit-time-destructors] Enable by default"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6859042
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: update patches
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Revoke Read access after removing file via FileSystemAccess API
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6677249
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: IWYU
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Accept an object for `dispatchHttpRequest` params
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6877528
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: IWYU
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Pass navigation UI parameters on EnterFullscreen in EAM
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6874923
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: rm band-aid_over_an_issue_with_using_deprecated_nsopenpanel_api.patch
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* Remove unused PreHandleMouseEvent
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6880411
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* 6878583: siso: update to version 1.4.1
https://chromium-review.googlesource.com/c/chromium/src/+/6878583
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Fold native_theme_browser into native_theme.
https://chromium-review.googlesource.com/c/chromium/src/+/6882627
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Reland "[exit-time-destructors] Enable by default
https://chromium-review.googlesource.com/c/chromium/src/+/6859042
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: update filenames.libcxx.gni
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: IWYU
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: chore: IWYU
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Reland "[exit-time-destructors] Enable by default
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Reland "[exit-time-destructors] Enable by default
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Remove common_theme.*; place its method in NativeTheme instead.
https://chromium-review.googlesource.com/c/chromium/src/+/6886029
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Reland "[exit-time-destructors] Enable by default
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Better track when WebPreferences need updates for color-related changes.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6886797
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* chore: bump chromium in DEPS to 141.0.7390.7
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* 6904664: Reland "Make BrowserContext::GetPath() const"
https://chromium-review.googlesource.com/c/chromium/src/+/6904664
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Restore read access after certain file modification operations
https://chromium-review.googlesource.com/c/chromium/src/+/6861041
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Move "system integrated UI" concept out of NativeTheme.
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: Reland "[exit-time-destructors] Enable by default
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: update patches
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* 6906096: Remove GetSysSkColor().
https://chromium-review.googlesource.com/c/chromium/src/+/6906096
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Inline implementation of SysColorChangeListener into the lone user.
https://chromium-review.googlesource.com/c/chromium/src/+/6905083
Also 6906096: Remove GetSysSkColor(). | https://chromium-review.googlesource.com/c/chromium/src/+/6906096
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup: 6906096: Remove GetSysSkColor()
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2025-09-08 17:08:42 -04:00
Shelley Vohr
6101025368
fix: net.isOnline always true in utility processes ( #48111 )
...
* fix: net.isOnline always true in utilityProcesses
* Update shell/services/node/node_service.cc
Co-authored-by: Robo <hop2deep@gmail.com>
---------
Co-authored-by: Robo <hop2deep@gmail.com>
2025-08-22 14:30:41 +02:00
Charles Kerr
2255bb620a
refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 2) ( #47879 )
...
* refactor: add a v8::Isolate* arg to Constructible::GetConstructor()
* refactor: add a v8::Isolate* arg to NodeBindings::Initialize()
This is needed for the GetConstructor() call
* refactor: avoid v8::Context::GetIsolate() call in GetIpcObject() by taking it as an arg
* refactor: avoid v8::Context::GetIsolate() call in ipc_native::EmitIPCEvent() by taking it as an arg
2025-07-28 10:22:27 -05:00
Charles Kerr
39cca586f6
refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) ( #47760 )
...
* refactor: avoid redundant GetIsolate() calls in NodeBindings::CreateEnvironment()
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/6563615
* refactor: use v8::Isolate::GetCurrent() in Initialize() methods
* refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment()
* fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods
* refactor: add v8::Isolate* arg to RendererClientBase::DidCreateScriptContext()
* fixup! refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment()
* fixup! fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods
refactor: prefer JavascriptEnvironment::GetIsolate() in the browser layer
2025-07-21 16:34:38 +02:00
Robo
626895848e
fix: utilityProcess running user script after process.exit is called ( #47469 )
...
* fix: utilityProcess running user script after process.exit is called
* docs: update breaking changes
* chore: update spec
* chore: update spec/api-utility-process-spec.ts
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* chore: remove interface bound checks
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2025-06-18 04:36:22 +09:00
Shelley Vohr
c2ae4afb8f
fix: destroy parent port backend when JS env exits ( #46437 )
...
* fix: destroy parent port backend when JS env exits
* fix: close parent port before destroying
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-04-04 11:02:54 -05:00
Shelley Vohr
c0e180758b
fix: don't crash Utility Processes on unhandled rejections ( #45921 )
...
* fix: don't crash on unhandled rejections
* Update docs/breaking-changes.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-03-14 09:09:02 -05:00
Robo
137a552641
fix: support for v8.setHeapSnapshotNearHeapLimit api ( #45606 )
...
* fix: support for v8.setHeapSnapshotNearHeapLimit api
* docs: add support
2025-02-14 10:00:39 -06:00
Robo
f68184a9f9
feat: add error event for utility process ( #43774 )
...
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-27 10:17:06 +09:00
Robo
9b166b3ed4
feat: support app#login event for utility process net requests ( #42631 )
...
* feat: support app#login event for utility process net requests
* chore: address review feedback
* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
2024-08-14 11:36:47 +09:00
Shelley Vohr
7f3dc7d4ce
fix: utilityProcess exit codes ( #42297 )
2024-06-07 10:06:00 +02:00
Devraj Mehta
8c71e2adc9
feat: add net module to utility process ( #40017 )
...
* chore: initial prototype of net api from utility process
* chore: update url loader to work on both browser and utility processes
* chore: add net files to utility process bundle
* chore: re-add app ready check but only on main process
* chore: replace browser thread dcheck's with sequence checker
* refactor: move url loader from browser to common
* refactor: move net-client-request.ts from browser to common
* docs: add utility process to net api docs
* refactor: move net module app ready check to browser only
* refactor: switch import from main to common after moving to common
* test: add basic net module test for utility process
* refactor: switch browser pid with utility pid
* refactor: move electron_api_net from browser to common
* chore: add fetch to utility net module
* chore: add isOnline and online to utility net module
* refactor: move net spec helpers into helper file
* refactor: break apart net module tests
Adds two additional net module test files: `api-net-session-spec.ts` for
tests that depend on a session being available (aka depend on running on
the main process) and `api-net-custom-protocols-spec.ts` for custom
protocol tests. This enables running `api-net-spec.ts` in the utility
process.
* test: add utility process mocha runner to run net module tests
* docs: add utility process to net module classes
* refactor: update imports in lib/utility to use electron/utility
* chore: check browser context before using in main process
Since the browser context supplied to the SimpleURLLoaderWrapper can now
be null for use in the UtilityProcess, adding a null check for the main
process before use to get a more sensible error if something goes wrong.
Co-authored-by: Cheng Zhao <github@zcbenz.com>
* chore: remove test debugging
* chore: remove unnecessary header include
* docs: add utility process net module limitations
* test: run net module tests in utility process individually
* refactor: clean up prior utility process net tests
* chore: add resolveHost to utility process net module
* chore: replace resolve host dcheck with sequence checker
* test: add net module tests for net.resolveHost
* docs: remove utility process limitation for resolveHost
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Cheng Zhao <github@zcbenz.com>
2024-01-04 16:20:37 -05:00
David Sanders
cf5f0419f1
chore: fix some typos ( #40506 )
2023-11-12 19:51:56 -08:00
Charles Kerr
a1c44a18e2
fix: NodeService order-of-destruction issue ( #39783 )
...
* refactor: make ElectronRendererClient::node_bindings_ a const ptr
refactor: make ElectronRendererClient::electron_bindings_ a const ptr
* fix: order-of-destruction bug in NodeService
js_env_ depends on the uv_loop from node_bindings_, but is destroyed after node_bindings_
* chore: revert unintentional commit
2023-09-12 12:27:14 +02:00
Charles Kerr
35969939a1
refactor: node::Environment self-cleanup ( #39604 )
...
* chore: savepoint
* chore: turn raw_ptr tests back off
2023-08-23 09:56:16 -04:00
Charles Kerr
5ad8b4b7d1
chore: remove unused std includes ( #38767 )
2023-06-14 11:07:18 -07:00
electron-roller[bot]
de192c2db2
chore: bump node to v18.16.0 (main) ( #37973 )
...
* chore: bump node in DEPS to v18.16.0
* build,test: add proper support for IBM i
https://github.com/nodejs/node/pull/46739
* lib: enforce use of trailing commas
https://github.com/nodejs/node/pull/46881
* src: add initial support for single executable applications
https://github.com/nodejs/node/pull/45038
* lib: do not crash using workers with disabled shared array buffers
https://github.com/nodejs/node/pull/41023
* src: remove shadowed variable in OptionsParser::Parse
https://github.com/nodejs/node/pull/46672
* src: allow embedder control of code generation policy
https://github.com/nodejs/node/pull/46368
* src: allow optional Isolate termination in node::Stop()
https://github.com/nodejs/node/pull/46583
* lib: fix BroadcastChannel initialization location
https://github.com/nodejs/node/pull/46864
* chore: fixup patch indices
* chore: sync filenames.json
* fix: add simdutf dep to src/inspector BUILD.gn
- https://github.com/nodejs/node/pull/46471
- https://github.com/nodejs/node/pull/46472
* deps: replace url parser with Ada
https://github.com/nodejs/node/pull/46410
* tls: support automatic DHE
https://github.com/nodejs/node/pull/46978
* fixup! src: add initial support for single executable applications
* http: unify header treatment
https://github.com/nodejs/node/pull/46528
* fix: libc++ buffer overflow in string_view ctor
https://github.com/nodejs/node/pull/46410
* test: include strace openat test
https://github.com/nodejs/node/pull/46150
* fixup! fixup! src: add initial support for single executable applications
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-04-18 22:23:11 +02:00
Shelley Vohr
6395898a79
refactor: use associated v8::Context for event setup ( #37355 )
...
refactor: use associated v8::Context for event setup
2023-02-22 10:03:46 +01:00
Shelley Vohr
478ce96914
fix: avoid using v8 on Isolate termination ( #35766 )
...
* fix: avoid using v8 on Isolate termination
* chore: refactor for review
---------
Co-authored-by: electron-patch-conflict-fixer[bot] <83340002+electron-patch-conflict-fixer[bot]@users.noreply.github.com>
2023-02-09 09:48:49 +01:00
Robo
da0fd286b4
feat: UtilityProcess API ( #34980 )
...
* chore: initial scaffolding
* chore: implement interface and docs
* chore: address code style review
* fix: cleanup of utility process on shutdown
* chore: simplify NodeBindings::CreateEnvironment
* chore: rename disableLibraryValidation => allowLoadingUnsignedLibraries
* chore: implement process.parentPort
* chore(posix): implement stdio pipe interface
* chore(win): implement stdio interface
* chore: reenable SetNodeOptions for utility process
* chore: add specs
* chore: fix lint
* fix: update kill API
* fix: update process.parentPort API
* fix: exit event
* docs: update exit event
* fix: tests on linux
* chore: expand on some comments
* fix: shutdown of pipe reader
Avoid logging since it is always the case that reader end of
pipe will terminate after the child process.
* fix: remove exit code check for crash spec
* fix: rm PR_SET_NO_NEW_PRIVS for unsandbox utility process
* chore: fix incorrect rebase
* fix: address review feedback
* chore: rename utility_process -> utility
* chore: update docs
* chore: cleanup c++ implemantation
* fix: leak in NodeServiceHost impl
* chore: minor cleanup
* chore: cleanup JS implementation
* chore: flip default stdio to inherit
* fix: some api improvements
* Support cwd option
* Remove path restriction for modulePath
* Rewire impl for env support
* fix: add tests for cwd and env option
* chore: alt impl for reading stdio handles
* chore: support message queuing
* chore: fix lint
* chore: new UtilityProcess => utilityProcess.fork
* fix: support for uncaught exception exits
* chore: remove process.execArgv as default
* fix: windows build
* fix: style changes
* fix: docs and style changes
* chore: update patches
* spec: disable flaky test on win32 arm CI
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-10-19 22:49:49 -07:00
