David Sanders
0fddfd1b28
ci: auto comment on new issues for unsupported majors ( #42856 )
2024-07-15 15:25:47 -04:00
John Kleinschmidt
3a6a201534
build: fixup GHA running on fork PRs ( #42880 )
...
* chore: update build-tools for GHA
* chore: don't rely on environment variables for source cache location
2024-07-13 13:38:03 -04:00
Samuel Attard
53d7cca7a2
build: use new arc runner names ( #42881 )
2024-07-12 22:22:49 -07:00
David Sanders
7dd6d7697d
chore: allow multiple OS selection on bug reports ( #42854 )
2024-07-11 13:23:43 -07:00
John Kleinschmidt
514e9bbb04
build: update build-tools for GHA ( #42870 )
...
chore: update build-tools for GHA
2024-07-11 16:18:26 -04:00
Shelley Vohr
dab006b1cf
ci: fix Nan test failure on Linux ( #42863 )
...
ci: Nan test failure on Linux
2024-07-11 10:47:02 -04:00
John Kleinschmidt
1a9f99b3ed
chore: speed up azcopy on src cache ( #42742 )
2024-07-09 16:20:18 -04:00
dependabot[bot]
34e7648478
build(deps): bump github/codeql-action from 3.25.10 to 3.25.11 ( #42832 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.10 to 3.25.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](23acc5c183...b611370bb5
2024-07-09 11:27:37 +02:00
dependabot[bot]
c2ea3881fc
build(deps): bump actions/upload-artifact from 4.3.3 to 4.3.4 ( #42833 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](65462800fd...0b2256b8c0
2024-07-09 11:25:07 +02:00
Shelley Vohr
5bff883c40
chore: clean up outdated goma references ( #42762 )
2024-07-05 09:44:34 +02:00
electron-roller[bot]
8a8241163d
chore: bump chromium to 128.0.6558.0 (main) ( #42413 )
...
* chore: bump chromium in DEPS to 127.0.6526.0
* chore: update network_service_allow_remote_certificate_verification_logic.patch
manually apply patch due to minor upstream shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5598454
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
No manual changes; patch applied with fuzz 1
* chore: update refactor_expose_file_system_access_blocklist.patch
No manual changes; patch applied with fuzz 2
* chore: update revert_heap_add_checks_position_info.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 127.0.6527.0
* chore: update patches
* chore: bump chromium in DEPS to 127.0.6529.0
* chore: bump chromium in DEPS to 127.0.6531.0
* chore: update patches
* 5596349: Remove PDF OCR toggle from settings.
https://chromium-review.googlesource.com/c/chromium/src/+/5596349
* 5585932: [video-pip] Add minimize button to video picture-in-picture window
https://chromium-review.googlesource.com/c/chromium/src/+/5585932
* 5604487: Reland "[api] Deprecate v8::FunctionCallbackInfo::Holder() for real"
https://chromium-review.googlesource.com/c/v8/v8/+/5604487
* 5581721: [DEPS] Update clang-format location
https://chromium-review.googlesource.com/c/chromium/src/+/5581721
* 5597904: [Windows] Remove ConvertToLongPath from Sandbox Utilities.
https://chromium-review.googlesource.com/c/chromium/src/+/5597904
ResolveNTFunctionPtr was removed in this CL.
* fix: visibility state specs on macOS
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5605407
* Revert "fix: visibility state specs on macOS"
This reverts commit 1eee30a33dfafeec86cdd09526a07b01abca2ed6.
* temp: disable occlusion checker on macOS
* chore: bump chromium in DEPS to 128.0.6535.0
* chore: update patches
* [Extensions] Move some scriptings files out of the API directory.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5606682
* fix[node]: do not use soon-to-be-deprecated V8 API
* fix: update api_remove_allcan_read_write.patch
* chore: update patches
* chore: update patches
* chore: fix lf mismatch in api_remove_allcan_read_write.patch
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6538.0
* chore: update v8 patches
* chore: update patches
* ui/gl/features.gni: Set use_egl=true unconditionally.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5569748
Refs https://issues.chromium.org/issues/344606399
* chore: bump chromium in DEPS to 128.0.6540.0
* chore: bump chromium in DEPS to 128.0.6541.0
* chore: update patches
* chore: fix nan read/write patch
* chore: bump chromium in DEPS to 128.0.6543.0
* 5626254: Use sandbox_type instead of process_type | https://chromium-review.googlesource.com/c/chromium/src/+/5626254
* chore: update patches
* rework nan patches
* 5621488: Apply consistent naming conventions to zoom values | https://chromium-review.googlesource.com/c/chromium/src/+/5621488
* chore: bump chromium in DEPS to 128.0.6544.0
* 5605693: Remove files from third_party/ninja | https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* chore: update patches
* chore: maybe fix nan patch, part 3
* chore: delete nan patch
* chore: re-add nan patch (attempt 2)
* chore: add test patch
* fixup! add test patch
* chore: bump chromium in DEPS to 128.0.6549.0
* chore: bump chromium in DEPS to 128.0.6551.0
* 5637699: Add command line to ASAN Additional Info section | https://chromium-review.googlesource.com/c/chromium/src/+/5637699
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6553.0
* chore: bump chromium in DEPS to 128.0.6555.0
* fix: add property query interceptors
* chore: bump chromium in DEPS to 128.0.6557.0
* 5583182: Automatic Fullscreen: Prototype Permissions API query support | https://chromium-review.googlesource.com/c/chromium/src/+/5583182
* 5613297: Move render input router and related dependencies to //components/input | https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* chore: update patches
* test: skip methodswithdata-test.js nan test
* chore: bump chromium in DEPS to 128.0.6558.0
* chore: update patches
* build: reference correct ninja cipd ref
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* update libcxx filenames
* refactor: CursorManager moved to //components/input
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* refactor: spanify mojo Read/WriteData methods
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5619291
* refactor: remove constexpr from KeyboardCodeFromKeyIdentifier
Ref: unknown
Added TODO to investigate after
* chore: update patches
* refactor: improve type safety of a11y ids
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5614590
* chore: disable tls node tests that don't apply given boringssl tls configuration
Ref: https://boringssl-review.googlesource.com/c/boringssl/+/68487
* chore: add patch to fix nan v8 incompat with NamedPropertyHandlerConfiguration and IndexedPropertyHandlerConfiguration
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/5630388
* fix: limit subspan length per feedback
* Fix incorrect CalculateInsetsInDIP check
* 5645742: Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""
https://chromium-review.googlesource.com/c/chromium/src/+/5645742
* chore: more Windows logging
* 5617471: Add NPU blocking to chromium blocklist
https://chromium-review.googlesource.com/c/chromium/src/+/5617471
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-02 09:51:33 +02:00
Keeley Hammond
3ac57e17d5
build: fix clang format/lint ( #42715 )
...
* build: fix clang format path
* fix: use gclient sync instead of gclient runhooks
Refs https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5659261
* fix: use gclient sync instead of gclient runhooks in GHA
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-06-28 13:30:07 -07:00
Shelley Vohr
398dde9dfb
build: use inputs for target_arch in build ( #42684 )
2024-06-27 08:11:10 -07:00
Keeley Hammond
912706b23a
build: strip linux release binaries ( #42675 )
2024-06-26 17:41:36 -07:00
Keeley Hammond
a8baa6f1ad
build: remove CircleCI from release pipeline ( #42651 )
...
* build: remove CircleCI from release pipeline
* build: remove IS_GHA_RELEASE and CHECK_DIST_MANIFEST
2024-06-25 14:25:04 -07:00
Keeley Hammond
66b8b79229
build: turn on GitHub Actions by default for all branches and pull requests ( #42623 )
...
* build: turn GitHub Actions on by default for push and pull_request
* build: try env var build-image-sha
* build: use ternery for input vs default
* build: pain
* build: modify setup to cascade build-image-sha
* build: move outputs into setup step
* build: add SAS key generation on re-run
* build: only build on push, not pull_request
* build: only build on push for main & release branches, build on PR for everything else
* build: rebase with main, handle asan build
* build: add exit 1, sha value
2024-06-24 12:06:13 +02:00
Keeley Hammond
edb939ae80
build: Add ASan Linux build to Actions build/test ( #42545 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-06-20 12:11:53 +02:00
Shelley Vohr
18abeb3add
build: re-enable self-cert codesigning on x64 macOS ( #42576 )
...
build: re-enable self-cert codesigning
2024-06-19 10:28:07 -04:00
Keeley Hammond
6d2c72b14e
build: correct GCLIENT_EXTRA_ARGS in linux-publish ( #42575 )
2024-06-18 21:54:20 -07:00
Keeley Hammond
71338140a4
build: add symbol_level=1 to GN_BUILDFLAG_ARGS on release ( #42571 )
...
* build: add symbol_level=1 to GN_BUILDFLAG_ARGS on release
* build: move to GN_EXTRA_ARGS, remove GN_BUILDFLAG_ARGS
2024-06-18 14:03:53 -07:00
David Sanders
2e4857fbcb
ci: auto close non-maintainer PRs that touch lockfiles ( #42534 )
2024-06-18 15:30:08 -04:00
dependabot[bot]
540a42fb96
build(deps): bump github/codeql-action from 3.25.7 to 3.25.10 ( #42540 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.7 to 3.25.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f079b84933...23acc5c183
2024-06-18 12:14:56 +02:00
dependabot[bot]
b8512a0cd9
build(deps): bump actions/checkout from 4.1.6 to 4.1.7 ( #42539 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](a5ac7e51b4...692973e3d9
2024-06-18 12:14:15 +02:00
Samuel Attard
e217b063a5
build: fix nan/node tests on GHA ( #42548 )
2024-06-18 10:49:39 +02:00
dependabot[bot]
db9742a1ff
build(deps): bump mikefarah/yq from 4.44.1 to 4.44.2 ( #42541 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.1 to 4.44.2.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](557dcb87b8...f15500b20a
2024-06-17 16:34:32 -07:00
Samuel Attard
a0a13ad623
build: fix macOS tests on GHA ( #42524 )
...
* build: use --frozen-lockfile
* build: don't include src/electron in src artifacts
* Use mac intel runner for mac-x64 tests
* test: debug mac tests not exiting
* skip navigator.serial tests on GHA
* TCC magic
* Fix release notes tests needing ELECTRON_GITHUB_TOKEN
* Add Azure env vars to gn check pipeline segment
* use RO token for tests
* temporarily disable codesign tests
* test: disable LoginItemSettings on x64 macOS
* test: bump up time on protocol test for slower machines
* fixup: use RO token for tests
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-06-17 16:33:44 -07:00
Shelley Vohr
1a4d58a9fb
build: run GN Check everywhere ( #42515 )
...
* build: run GN Check everywhere
* build: remove gn check matrix
---------
Co-authored-by: Samuel Attard <sam@electronjs.org>
2024-06-17 08:58:29 -07:00
Samuel Attard
2b259bd69e
build: de-dupe load build tools into composite action ( #42518 )
2024-06-17 11:26:18 +02:00
Samuel Attard
a371c2cd54
build: fix GHA arm tests ( #42514 )
2024-06-16 10:59:51 -07:00
Shelley Vohr
6bf83b389b
build: add GN check step ( #42508 )
...
* build: add GN check step
* Remove extra loggin
* Fix BUILD_TOOLS_SHA
* Fix concurrency group naming
2024-06-14 15:29:11 -05:00
Samuel Attard
2c985366c8
build: fix dubious ownership error in version bumper spec ( #42509 )
2024-06-14 13:47:58 -05:00
Keeley Hammond
429d50bb18
build: add production-release environment to publish jobs ( #42483 )
...
* build: move publish workflows to use production environment
* build: pass in target_cpu to GN_EXTRA_ARGS on Linux
2024-06-14 11:14:38 -05:00
Keeley Hammond
5b98be3ccb
build: add docs-only path gating to GHA ( #42499 )
...
* build: add docs only workflow
* build: add path filtering action
* build: add actions/checkout
* build: explicitly set shell to bash -_-
* build: why regex when you could do something much dumber
* build: correct conditionals
* test: (do not merge) add base for testing
* test: remove git base (used for testing)
2024-06-14 11:08:41 -05:00
John Kleinschmidt
5397560ab3
build: adjust concurrency for release branches ( #42507 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-06-14 11:08:21 -05:00
Samuel Attard
c2c3673e8a
build: fix linux tests ( #42496 )
...
* build: use runuser for electron spec runner
* chown
* run tests in priv
* fixed
* build: setup testing on arm for GHA
* no build-tools for test
* start xvfb for the right user
* no more gn-build-type
* debug env
* ue xvfb-run
* use 8 core for node tests
* build: do test sharding on linux
* fix: disable hung node test
* build: index splits are hard
* build: use --init to reap children
* allow write junit
* use custom xvfb wrapper
* pipefail
* dont kill xvfb, its already dead
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-06-14 10:57:28 -05:00
Shelley Vohr
c1094013eb
build: allow running only mac, lint, or linux ( #42504 )
...
build: allow running only mac or linux
2024-06-14 10:08:04 -05:00
Keeley Hammond
8650682c5b
build: revert removal of CIPD patch from depot tools ( #42500 )
...
Revert "build: remove the CIPD patch from depot tools (#42484 )"
This reverts commit a0a8bd2222
2024-06-14 09:11:30 -05:00
Shelley Vohr
422511753f
build: use BUILD_TYPE from env ( #42498 )
...
build: use BUILD_TYPE from env
2024-06-14 06:47:18 -05:00
Samuel Attard
9f862af743
build: add lint GHA job ( #42494 )
2024-06-13 22:14:49 -05:00
John Kleinschmidt
16b2a09787
build: only load SDK for mac builds ( #42485 )
2024-06-13 17:49:38 -05:00
Keeley Hammond
ad8e89de01
build: fix v8 toolchain for macOS x64 ( #42492 )
...
build: do better
2024-06-13 17:14:57 -05:00
Keeley Hammond
c41ded2e89
build: remove gclient-extra-args from publish jobs ( #42491 )
...
build: remove gclient-extra-args from publish ymls
2024-06-13 17:11:47 -05:00
Samuel Attard
cfdc623c4d
build: pin and dedupe build image sha ( #42488 )
2024-06-13 16:35:47 -05:00
Keeley Hammond
9e066e7b74
build: add v8_toolchain to darwin/x64 ( #42487 )
...
build: add v8_toolchain to darwin/x64
2024-06-13 16:35:20 -05:00
Shelley Vohr
9fe1b05025
build: upload separate artifact for src files ( #42486 )
2024-06-13 16:35:13 -05:00
Keeley Hammond
a0a8bd2222
build: remove the CIPD patch from depot tools ( #42484 )
...
* build: try to remove the CIPD patch from depot tools
* build: remove cipd patch from GHA
2024-06-13 16:06:16 -05:00
Samuel Attard
b92a4023c1
build: unify pipelines ( #42482 )
2024-06-13 16:02:38 -05:00
Shelley Vohr
0affad3be6
build: add several missing test steps for GHA ( #42479 )
2024-06-13 14:26:20 -05:00
Shelley Vohr
30885e5f9f
build: add Linux GHA test step ( #42460 )
...
* build: add Linux GHA test step
* Switch to medium AKS runners
* Add missing BUILD_TYPE to restore-artifact
* Fix untar to current dir
* Remove known hosts logic
* Add missing Node.js headers step
* Fix for active SSH sessions
* Fix storing artifacts
* Build on x64 for test
2024-06-13 14:14:33 -05:00
Keeley Hammond
75d0e725be
build: fix conditional for sas token ( #42481 )
2024-06-13 09:43:06 -05:00
Keeley Hammond
42266546eb
build: move hunspell generation to Linux ( #42480 )
2024-06-13 09:37:36 -05:00
Samuel Attard
f72096194f
build: reuse checkout steps across mac and linux ( #42475 )
2024-06-13 09:09:35 -05:00
Keeley Hammond
a4f201a5f3
build: add needed steps/tweaks to Linux publish job ( #42477 )
...
* build: add libcxx to Linux publish
* build: temp change ref to branch
* build: remove hunspell dictionaries
* build: modify release build script for linux
* build: switch back to main
2024-06-12 23:13:17 -05:00
Shelley Vohr
5abefc5dc3
build: use GN_EXTRA_ARGS on macOS ( #42473 )
...
* build: use GN_EXTRA_ARGS on macOS
* Switch back to main
2024-06-12 22:12:30 -05:00
Keeley Hammond
9d6c894e89
build: save/restore cache on Linux builds ( #42472 )
...
* build: update checkout and cache restore for Linux
* build: clean up variables
* build: temporarily set ref to branch
* build: actually check if cache exists or not and correctly store it
* build: correct cache paths
* build: restore electron_node/deps/v8
* build: restore sha to @main, not branch
* build: remove cache_key and use $DEPSHASH
* build: remove sas, backup_cache logic
* build: revert openssl deletion
2024-06-12 17:41:07 -05:00
Samuel Attard
08bd588e71
build: use dynamic RO sas token provided by sas-sidecar ( #42470 )
2024-06-12 16:04:28 -05:00
Shelley Vohr
2afe657873
build: cleanup to macos pipeline ( #42445 )
...
* build: cleanup to macos pipeline
* Fix generated artifact key finding
* Fix cache restore key
* Switch ref to main
* Use artifacts for build artifact persisting
* Fix TARGET_ARCH env var in test
* Remove npm install
2024-06-12 14:58:47 -05:00
Keeley Hammond
f6a9c55907
build: remove unneeded installs/secrets ( #42467 )
...
build: remove unneeded azure installs/secrets
2024-06-12 14:53:18 -05:00
Keeley Hammond
1cb63b4d77
build: use the linux aks for macos checkout/cache ( #42447 )
...
* build: use the linux aks for checkout/cache
* build: use latest container sha
* build: persist the AKS cache (first try)
* build (do not merge): use current branch for workflows
* build: do not check for existing cache
* build: try to move src into /var/portal
* build: add AZURE_AKS_CACHE_SHARE_NAME & AZURE_AKS_CACHE_STORAGE_ACCOUNT
* build: add volumes: /mnt/cross-instance-cache
* build: temporarily skip cache exists checks
* build: reset to aks-linux-large, upload/download tar
* build: pass detailed credentials into download
* build: be better
* build: add skip if cache exists, declare env vars earlier
* build: add quotes
* build: change to connection-string
* build: remove connection string
* build: migrate to azcopy
* build: lol
* build: revert ref to @main
2024-06-12 14:21:19 -05:00
Shelley Vohr
ffe1d70f1d
build: add Linux GHA build step ( #42432 )
...
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-06-12 14:16:49 -05:00
Keeley Hammond
eacdf56e0b
build: build ffmpeg on MAS publish ( #42448 )
2024-06-11 14:43:11 -05:00
Shelley Vohr
92de23bb3c
build: initial Linux pipeline checkout ( #42429 )
...
* build: create config for GHA build linux
* build: restructure linux pipeline files
* build (do not merge): don't run CircleCI or Appveyor
* build: run on push
* build: add checkout step
* build: fix .yml syntax
* Remove Azure CLI install
* Revert "build (do not merge): don't run CircleCI or Appveyor"
This reverts commit eb55e317bc74f2e5fa596ac90814d753d4fb6124.
* build: change pipeline SHA to main
* chore: update patches
---------
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-06-10 14:39:34 -05:00
Shelley Vohr
ff4494c18f
build: allow kicking build with workflow_dispatch ( #42420 )
...
* build: allow kicking build with workflow_dispatch
* build: ensure macOS build works
* fix: no upload in build
* build: add target_cpu to MAS config
---------
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-06-10 11:55:16 -05:00
Shelley Vohr
84e15e2d04
build: Azure CLI install step not needed ( #42410 )
2024-06-07 10:05:15 -07:00
Shelley Vohr
d97dcf388a
build: add missing ELECTRON_ARTIFACTS_BLOB_STORAGE env var ( #42402 )
...
build: add missing ELECTRON_ARTIFACTS_BLOB_STORAGE env var
2024-06-07 11:46:30 +02:00
Shelley Vohr
1c6d7d7ece
build: fix depot_tools patch ( #42388 )
...
build: fix depot_tools patch
2024-06-06 22:49:59 +02:00
Keeley Hammond
6ccb9861f6
build: increase fetch-deps ( #42387 )
...
* build: use fetch-depth: 0 and fetch-tags
* debug: readd tmate SSH debugging
* build: run SSH by default, remove debug conditional
* build: remove redundent fetch-tags
* build: pin tmate to SHA
* build: remove tmate action
2024-06-06 12:09:50 -07:00
Keeley Hammond
c9349a2590
build: [GHA] cross-compile x64 MacOS jobs on arm64 ( #42370 )
...
* build: split x64 mas/darwin to run concurrently
* Retry src cache download on failure
* build: gate FFMpeg, etc, to release & darwin
* build: cross-compile x64 on arm hardware
* chore (do not merge): comment out CircleCI config
* build: fix FFMpeg conditional but harder
* build: add fetch-deps to checkout
* build: correctly add target_arch to MAS configs
* build: correct target arch
* build: consolidate darwin/mas back into single runner per arch
* build: re-enable CircleCI
* Add missing ELECTRON_OUT_DIR for upload
* Add missing ELECTRON_GITHUB_TOKEN to secrets
* build: (do not merge) run only darwin
* build: remove seperate upload step
* build: re-enable mas, remove upload seperate job
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-06-05 23:06:25 -07:00
dependabot[bot]
b74d3e14b0
build(deps): bump github/codeql-action from 3.25.6 to 3.25.7 ( #42354 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.6 to 3.25.7.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](9fdb3e4972...f079b84933
2024-06-04 11:12:16 +02:00
dependabot[bot]
01bf60bf66
build(deps): bump actions/upload-artifact from 4.3.1 to 4.3.3 ( #42355 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.1 to 4.3.3.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.1...65462800fd760344b1a7b4382951275a0abb4808 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-04 11:11:56 +02:00
dependabot[bot]
1c36b8b390
build(deps): bump actions/checkout from 4.1.1 to 4.1.6 ( #42356 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.6.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.1...a5ac7e51b41094c92402da3b24376905380afc29 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-04 11:11:46 +02:00
Keeley Hammond
5f8a490a00
build: add release config/dsymutil fix, test-releases for GHA ( #42350 )
...
* build: add publishing workflow for GHActions
* build: add test repo/bucket for uploads
* build: clean up conditionals, add macos-14-large, review comments
* build: remove host_cpu var from GCLIENT_EXTRA_ARGS
* build: use GN_CONFIG
* remove: hardcode release gn config
* Fix GN args import for release
* Use BUILD_TOOLS_SHA when cloning build-tools in test
* build: create test release in prepare-release
* build: fix GN_CONFIG for mas builds
* Fix dsymutil arch resetting
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-06-03 11:43:54 -07:00
Keeley Hammond
361b37592a
build: add GitHub Actions publishing pipeline for macOS ( #42236 )
...
* build: add publishing workflow for GHActions
* build: add test repo/bucket for uploads
* build: clean up conditionals, add macos-14-large, review comments
* build: remove host_cpu var from GCLIENT_EXTRA_ARGS
2024-05-31 10:58:39 -07:00
dependabot[bot]
0285ff0c0f
build(deps): bump dsanders11/project-actions from 1.2.0 to 1.3.0 ( #42230 )
...
---
updated-dependencies:
- dependency-name: dsanders11/project-actions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-23 11:14:23 +02:00
dependabot[bot]
f6bdbd6000
build(deps): bump github/codeql-action from 3.25.5 to 3.25.6 ( #42229 )
...
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-23 11:14:12 +02:00
dependabot[bot]
23a5d8b64a
build(deps): bump mikefarah/yq from 4.43.1 to 4.44.1 ( #42228 )
...
---
updated-dependencies:
- dependency-name: mikefarah/yq
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-20 20:41:47 -07:00
Shelley Vohr
af9a59cc40
build: cancel in-progress runs on new commits ( #42193 )
2024-05-15 23:45:54 +02:00
dependabot[bot]
4e70213037
build(deps): bump dsanders11/github-app-commit-action from 1.1.0 to 1.4.0 ( #42161 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.1.0 to 1.4.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](1dd0a2d22c...48d2ff8c1a
2024-05-14 10:53:15 -04:00
dependabot[bot]
45cc31fd2f
build(deps): bump github/codeql-action from 3.25.3 to 3.25.5 ( #42160 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.3 to 3.25.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d39d31e687...b7cec75265
2024-05-14 10:52:54 -04:00
dependabot[bot]
03e259dc25
build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 ( #42159 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.1 to 2.3.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](0864cf1902...dc50aa9510
2024-05-14 10:51:35 +02:00
dependabot[bot]
e4d89ba2b4
build(deps): bump amannn/action-semantic-pull-request from 5.4.0 to 5.5.2 ( #42158 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.4.0 to 5.5.2.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](e9fabac35e...cfb60706e1
2024-05-14 10:50:36 +02:00
David Sanders
188196e78c
ci: auto label bug issues with version label ( #42044 )
2024-05-13 10:49:23 +02:00
dependabot[bot]
0725f5c5cf
build(deps): bump mikefarah/yq from 4.40.7 to 4.43.1 ( #42074 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.40.7 to 4.43.1.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bb66c9c872...c35ec752e3
2024-05-10 11:33:15 +02:00
dependabot[bot]
793276ac87
build(deps): bump slackapi/slack-github-action from 1.25.0 to 1.26.0 ( #42076 )
2024-05-08 13:36:33 +02:00
dependabot[bot]
a059dd7b69
build(deps): bump github/codeql-action from 3.24.0 to 3.25.3 ( #42073 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.0 to 3.25.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e8893c57a1...d39d31e687
2024-05-08 10:43:29 +02:00
dependabot[bot]
53a4484372
build(deps): bump actions-cool/issues-helper from 3.3.3 to 3.6.0 ( #42075 )
...
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper ) from 3.3.3 to 3.6.0.
- [Release notes](https://github.com/actions-cool/issues-helper/releases )
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md )
- [Commits](275328970d...a610082f8a
2024-05-08 10:42:32 +02:00
Christian Clauss
8cfc4b9d50
ci: keep GitHub Actions up to date with GitHub's Dependabot ( #42042 )
...
* Keep GitHub Actions up to date with GitHub's Dependabot
Fixes software supply chain safety warnings like at the bottom right of
https://github.com/electron/electron/actions/runs/8619491231
* [Keeping your actions up to date with Dependabot](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot )
* [Configuration options for the dependabot.yml file - package-ecosystem](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem )
* Apply suggestion from code review
* chore: fully remove groups
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-05-07 19:25:46 -04:00
Shelley Vohr
b95d0f7623
build: use env var for build-tools pinning ( #41969 )
2024-04-29 10:07:42 -04:00
Shelley Vohr
b41da150ca
build: add GitHub Actions testing pipeline for macOS ( #41812 )
...
* build: test the Mac runner space
* build: baby steps, super basic checkout
* chore: simplify depot-tools
* build: try a sync
* build: fix path
* build: pass different URL for sync
* build: gclient sync with --verbose
* debug: add logging for mtime cache
* build: add psuedocode for Azure workflow, add workflow_dispatch
* build: enable ssh access to runners
* build: test azure upload without full sync
* build: full sync and cache upload test
* build (WIP): mock out download logic
* build: remove sync, try disk space prune
* build: lets try it again, lads
* ci: add cache downloading wip
* fix: correct json parsing
* chore: use depshash and fix output syntax
* chore: rework depshash state and delete more
* refactor: split checkout to Linux runner
* fix: depot_tools get on Linux
* fix: add infra/3pp/tools/swift-format handling
* chore: move to patch file in build as well
* chore: misc cleanup of env steps
* chore: add fix sync step
* build: use tar file, strip .git dirs
* build: set GIT_CACHE_PATH outside of src
* ci: fix cache prefix, add check for ssh debug
* fix: fix tar pack/unpack
* build: add reclient support & ninja build step
* chore: clean up reclient round 1
* fix: grab ELECTRON_RBE_JWT from secrets
* chore: run tmate if debug logging enabled
* chore: move ulimit setting
* fix: missing GN gen env vars
* fix: workaround packed-refs issue
* chore: fixup PATH usage
* chore: remove GIT_CACHE env var
* fix: call pack refs manually
* fix: add RBE_experimental_credentials_helper_args
* chore: whoops we need electron_node/deps/v8 actually
* fix: we need electron_node/deps/openssl too
* build: load build-tools & xcode
* build: add dist, chromedriver & mksnapshot
* build: add test job, download artifacts
* Cache non-generated build artifacts
* chore: set download path explicitly
* chore: load-xcode is called by e build
* Add codesigning certificate step
* Add Test Step
* Try without codesigning just to get tests running
* Add depot_tools to PATH in test
* Persist src/buildtools/mac
* chore: use script/yarn test directly
* Build Node.js Headers for caching
* Add initial matrix for mas build
* Fix GN_EXTRA_ARGS generation syntax
* Fix BUILD_TYPE interpolation
* Use matrix in test correctly
* feat: add publish config, alter release-build script
* build: force trigger the first workflow
* build: oops
* Ensure env vars escaped
* Move GN_EXTRA_ARGS to gn gen step
* chore: rename yml to match convention
* ci: fix helperPath calls in action configs
* chore: try setting directly
* fix: switch to mas config
* chore: Testing -> Default
* Re-enable darwin build
* Use mas JSON config
* refactor: extract artifact logic to bash scripts
* refactor: build MAS after darwin
* chore: move to script/actions
* chore: use Node.js 20.11.x
* Don't fail-fast in tests
* build: tweak release script
* build: remove macos-publish.yml
* build: change action to trigger on publish workflow dispatch
* chore: remove SSH debugging using action-tmate
* build: do not disable CircleCI config
* chore: switch away from cURL for AzureCLI
* chore: move evm.mas.json to .github/workflows/config
* chore: remove publish logic from initial build flow
* build: add patchup check for non-release builds
* build: pin build-tools to sha 2bb63e2
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-04-24 10:29:19 -07:00
Samuel Attard
6e36153799
build: fix potential source of errors in issue workflow ( #41715 )
2024-03-27 09:50:55 -07:00
David Sanders
dd3fd78e63
ci: automatically add the 'has-repro-gist' label ( #41646 )
...
ci: automatically add the 'has-gist-repro' label
2024-03-21 10:22:14 -04:00
David Sanders
00da7279cb
ci: set issue status to triaged on status/{confirmed,reviewed} label ( #41645 )
2024-03-21 09:43:40 -04:00
David Sanders
9565b7de74
chore: set wg-releases as CODEOWNER for AppVeyor configs ( #41485 )
2024-03-01 15:53:30 -05:00
David Sanders
13e601e35c
ci: verified commits for appveyor update PR ( #41470 )
2024-02-28 21:36:56 -08:00
David Sanders
7e241eef7c
ci: update GitHub actions workflow dependencies ( #41321 )
2024-02-14 11:13:03 +01:00
David Sanders
679a6589cd
chore: add extra links to issue template chooser ( #41135 )
2024-01-29 09:51:43 -05:00
Michaela Laurencin
03a3deca18
ci: add stale-exempt label to exempt issues from automation ( #41031 )
2024-01-18 16:57:49 -05:00
David Sanders
c2c64d27fd
ci: fix missing inputs for release project board automation ( #40726 )
2024-01-10 13:25:11 +01:00
David Sanders
93fdc8d33c
ci: roll back the link release project board to repo automation ( #40716 )
...
* ci: roll back the link release project board to repo automation
* ci: add workflow_dispatch
2023-12-06 20:58:41 -08:00
David Sanders
66b4b21646
ci: tweak new release board workflow ( #40680 )
...
* ci: tweak new release board workflow
* ci: fix workflow
2023-12-04 10:18:14 -05:00
