Cheng Zhao
136cf389e8
fix: use context counter as contextId (backport 3-0-x)
...
For sandboxed renderer it may not have a node::Environment in the context,
using a increasing counter as contextId works for all cases.
2018-07-19 11:27:41 -07:00
John Kleinschmidt
8f8d198c5a
Merge pull request #13539 from trop-bot/3-0-x-bp-enable-webview-in-sandbox-renderer-1530547750986
...
Backport (3-0-x) - Enable webview in sandbox renderer
2018-07-17 10:01:40 -04:00
Jeremy Apthorp
041c952574
fix: enable spell checking, which broke in upgrade to ch66
...
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.
Added the first (!) test for spellchecking, too.
Fixes #13608 .
[1]: 03563dd163
2018-07-12 13:28:15 -07:00
Hari Juturu
32e40cb4c3
Enable webview in sandbox renderer Security: Inherit embedder prefs onto webview
2018-07-02 16:09:17 +00:00
Milan Burda
28fd571d0c
refactoring: use std::make_unique<T> ( #13245 )
2018-06-18 16:32:55 +09:00
Thiago de Arruda
6ff111a141
perf: don't use JSON to send the result of ipcRenderer.sendSync
. ( #8953 )
...
* Don't use JSON to send the result of `ipcRenderer.sendSync`.
- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
to wrap/unwrap return values to/from array, instead of
serializing/deserializing JSON.
This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).
A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory. This difference
tends increases with larger buffers.
* Don't base64 encode Buffers
* Don't allocate V8ValueConverter on the heap
* Replace hidden global.sandbox with NodeBindings::IsInitialized()
* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter
* Refactor problematic test to make it more reliable
* Add tests for NaN and Infinity
2018-06-13 17:38:31 +10:00
Milan Burda
6ad0a22602
Add process.getHeapStatistics() ( #13183 )
2018-06-10 22:00:36 +10:00
Charles Kerr
b89fe86fa1
Merge pull request #13050 from electron/3.0.0-deprecations
...
chore: removal of 3.0.0 deprecations
2018-05-30 09:25:36 +02:00
Milan Burda
45e78728bd
chore: move more constants to options_switches.h/cc ( #13093 )
...
* Add options::kNativeWindowOpen
* Add options::kSandbox
* Add options::kPlugins
* Add options::kWebSecurity
* Add options::kAllowRunningInsecureContent
* Add options::kOffscreen
2018-05-29 03:09:51 -05:00
Shelley Vohr
94e825378c
remove webFrame.registerURLSchemeAsSecure() deprecation
2018-05-23 09:33:57 -07:00
Milan Burda
2337237d58
Refactoring: use C++11 class member variable initialization
2018-05-22 00:18:38 +02:00
Jeremy Apthorp
73ac019882
Fix up #includes to work with both GYP and GN
2018-05-10 13:38:40 -07:00
Jeremy Apthorp
118da36b52
Send document-start/end to the right context when contextIsolation=true ( #12738 )
2018-05-04 23:39:54 -07:00
Jeremy Apthorp
78ab97ab04
Fix crash when releasing a script context that never had node injected ( #12741 )
2018-05-01 20:00:46 -04:00
bughit
4fcd178c36
expose WebFrame#routingId ( #12614 )
...
* expose WebFrame#routingId and pass it to WebContents frame specific events along with frameProcessId; add WebContets.did-start-navigation event
* fix compilation error on ia32 Windows
2018-04-26 19:17:55 +09:00
Robo
ff571f3b5d
Part I: Move from base::Bind to base::BindOnce and remove unneeded base::Passed ( #12661 )
2018-04-20 19:55:05 +09:00
Jeremy Apthorp
f1587da480
[chromium-style] out-of-line default constructors and destructors
2018-04-19 11:12:58 -07:00
Jeremy Apthorp
e6695cf2ec
[chromium-style] override / virtual warnings
2018-04-19 11:12:10 -07:00
Jeremy Apthorp
a635f078c6
[chromium-style] auto variable type must not deduce to a raw pointer type
2018-04-19 11:10:52 -07:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
Shelley Vohr
53bdf22c85
clang-format atom files
2018-04-18 20:48:45 -04:00
Robo
ad2baccefa
tools: pass custom template for js2c ( #12593 )
...
* Update node v9.7.0 ref
* tools: pass custom template to node/tools/js2c.py
2018-04-13 08:20:04 -04:00
Shelley Vohr
d722008367
remove unnecessary ptr_util.h include
2018-04-12 22:34:26 -04:00
Shelley Vohr
b05932310b
replace base::MakeUnique with std::make_unique
2018-04-12 08:48:32 -04:00
OJ Kwon
4c51c03779
feat(performspellcheck): queue spell check request asynchronously ( #12112 )
...
* feat(spellcheckrequest): implement spellcheckrequest
* feat(performspellcheck): queue spell check request asynchronously
2018-04-09 15:18:50 +09:00
Cheng Zhao
c75dd93b92
Move AutofillPopup from NativeWindow to WebContents ( #12514 )
2018-04-05 09:53:51 +09:00
Jeremy Apthorp
a7352e57d5
WebFrame.setVisualZoomLevelLimits sets user-agent scale constraints ( #12488 )
...
Fixes #11216 .
2018-04-02 18:20:13 -04:00
Nitish Sakhawalkar
9d1527b1df
Fix context menu for sandbox devtools ( #11933 )
2018-03-22 16:15:57 +09:00
deepak1556
4b39d17e5f
move pdf viewer behind feature flag
2018-03-20 10:13:17 +03:00
Cheng Zhao
94fce43ed9
Emit document-start for the correct env
...
This fixes the crash in RunScriptsAtDocumentStart when "affinity" option
is specified. Previously we were assuming only one main frame exists in
the renderer process, but the "affinity" option breaks this option.
There is also a bug that "node::Environment::GetCurrent" does not return
nullptr for context without a env in it, I'm not sure whether it is a
bug of Node or V8.
2018-03-20 10:13:17 +03:00
deepak1556
b08d086b0f
fix stale rebase
2018-03-20 10:13:16 +03:00
deepak1556
719980a948
REVIEW: remove device emulation ipc dependecny on rvh
2018-03-20 10:13:15 +03:00
deepak1556
5684f8886f
REVIEW: move ipc use from rvh to rfh
2018-03-20 10:13:15 +03:00
Samuel Attard
f80b328937
WebExceptionCode has been removed
2018-03-20 10:13:14 +03:00
deepak1556
2bf1131dab
add NOLINT rule for include order in renderer_client_base
2018-03-09 15:19:07 +05:30
deepak1556
3cfe66e4c3
move ipc use from rvh to rfh
2018-03-09 15:01:09 +05:30
Charles Kerr
0d12fc3033
Make the linter happy
2018-03-09 17:03:00 +09:00
Samuel Attard
a9dcce82ed
Ensure that a document has been created before sending IPC messages
...
* Reverts 370476c4af
in favor of moving the previous logic to the new RenderFrameObserver instead of RenderViewObserver
Fixes #12045
2018-03-09 14:24:56 +11:00
Hari Juturu
2f4fd3324b
Preload doesn't load in sandboxed render if preload path contains special chars ( #12037 )
...
* Adding missing headers
* adding ut
* Removing the file path exists check
* fixing test
* exposing window.require in UT
2018-03-07 11:40:00 -05:00
Cheng Zhao
fdd66bd76d
Merge pull request #11607 from bughit/frame_navigation_api
...
frame navigation API
2018-02-26 15:50:11 +09:00
Cheng Zhao
ccf30e0934
Coding style fixes
2018-02-26 15:19:44 +09:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
Aleksei Kuzmin
b02edd014a
Rename CompositionUnderline to ImeTextSpan
...
https://chromium-review.googlesource.com/609524
2018-02-23 10:21:23 +09:00
bughit
88b887fe47
frame navigation API
2018-02-21 18:50:15 -05:00
Cheng Zhao
f7ec346e9f
Merge pull request #11956 from brenca/transparent-window-devtools-fix
...
Fix transparent windows losing transparency when devtools detaches
2018-02-21 19:54:35 +09:00
Heilig Benedek
6f2609f9d2
Remove outdated comments
2018-02-21 11:28:53 +01:00
Shelley Vohr
211b542ae4
remove setZoomLevelLimits
2018-02-20 08:57:48 -05:00
Heilig Benedek
d31d2087a3
use SK_ColorTRANSPARENT as the default color to fix issue with transparent window devtools detach
2018-02-19 15:07:28 +01:00
shelley vohr
a55fd06aa2
Revert "Merge pull request #11737 from kwonoj/feat-cache-capacity" ( #11906 )
...
This reverts commit 181169b743
, reversing
changes made to baced3152f
.
2018-02-13 10:49:27 -05:00
Samuel Attard
181169b743
Merge pull request #11737 from kwonoj/feat-cache-capacity
...
feat(webframe): export set cache capacity interface
2018-02-13 06:02:25 +11:00