trop[bot]
941965016e
fix: WebContentsView removal should compare directly ( #44671 )
...
* fix: WebContentsView removal should compare directly
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fixup view comparision
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: use erase_if
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Apply review suggestions
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-15 13:09:38 +01:00
Keeley Hammond
b88e1aba10
refactor: unfilter unresponsive events ( #44667 )
...
refactor: unfilter unresponsive events (#44629 )
* feat: internal -unresponsive event
* Reland "refactor: JSify BrowserWindow unresponsive handling"
This reverts commit ef7ae78ed4
2024-11-14 16:59:22 -08:00
trop[bot]
040e9c317e
fix: WCO buttons hidden on Linux in fullscreen ( #44640 )
...
Closes https://github.com/electron/electron/issues/44569 .
Fixes an issue where the WCO buttons were hidden on Linux in fullscreen mode
but not on Windows or macOS. The Windows behavior is the expected one, so this
commit makes the Linux behavior consistent.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-13 16:54:37 +01:00
trop[bot]
eddae27077
fix: add theme data source for devtools. ( #44635 )
...
* fix: add theme data source for devtools.
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* chore: add ut.
Co-authored-by: bill.shen <shenyb32768@gmail.com>
* chore: remove recording histograms
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* fix: add theme data source for devtools.
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* chore: separate files
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* chore: separate files
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* chore: remove pragma once
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
* chore: fix lint issue.
Co-authored-by: bill.shen <shenyb32768@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
2024-11-13 16:04:39 +01:00
trop[bot]
2f20dbea55
fix: segfault when moving WebContentsView between BrowserWindows ( #44613 )
...
* fix: segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: actually enable fix
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* fixup segfault when moving WebContentsView between BrowserWindows
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-11 22:09:29 -05:00
reito
65cd09ffaf
feat: GPU shared texture offscreen rendering (33-x-y) ( #44511 )
...
* feat: GPU shared texture offscreen rendering
* fix: EmitWarning in node utils.
Signed-off-by: reito <cnschwarzer@qq.com>
* fix: resolve conflict and reformat
---------
Signed-off-by: reito <cnschwarzer@qq.com>
2024-11-07 09:41:09 -05:00
trop[bot]
bd81baaf04
fix: remove use of banned std::to_string() ( #44563 )
...
Use base::NumberToString() instead
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#std_sto_i_l_ul_ll_ull_f_d_ld_to_string_banned
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-04 18:00:39 -06:00
trop[bot]
fcf0c115cb
chore: remove use of banned absl::optional ( #44551 )
...
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5805666
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-04 16:40:21 -05:00
trop[bot]
7930412006
refactor: remove unused C string ToV8() gin converter ( #44522 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-11-02 10:34:39 -05:00
trop[bot]
ae9f2df082
feat: add WebFrameMain detached property ( #44209 )
...
* feat: add WebFrameMain detached property
fix: throw instead of returning null senderFrame
test: detached frames
fix: ensure IPCs of pending deletion RFHs are dispatched
fix: lookup WFM by FTN ID to dispatch IPCs
feat: add frame.isDestroyed()
return null
fix: return undefined
docs: add null to all frame properties
refactor: option c, return null and emit warning
refactor: add routingId & processId to navigation events
test: null frame property
docs: clarify warning message
better wording
clarify null frame
fix: browserwindow spec
* maybe fix 🤷
* fix: use updated util #43722
* docs: add notice for frame change of behavior
* docs: clarify why frame properties may be null
* lint
* wip
* fix: content::FrameTreeNodeId lookup and converter
* refactor: avoid holey array deoptimization
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
2024-10-31 12:07:50 +01:00
trop[bot]
4f13824bc9
perf: remove isolate scope from DidProcessTask() ( #44473 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-31 11:30:24 +01:00
trop[bot]
d435ff9128
fix: keep gdk_pixbuf a dynamic dependency ( #44436 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-10-29 00:32:40 -05:00
trop[bot]
ec070e57e0
fix: crash on netlog connection error ( #44420 )
...
* fix: crash on netlog connection error
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* refactor: remove default PromiseBase constructor
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* Revert "refactor: remove default PromiseBase constructor"
This reverts commit 9292324a0d5f9e63ba8f73f63dfff1d48eb2f38f.
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* remove dcheck
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2024-10-28 14:37:58 +01:00
trop[bot]
964c1a1df8
fix: -Wunsafe-buffer-usage warning in didRegisterForRemoteNotificationsWithDeviceToken ( #44381 )
...
* chore: move as_byte_span() to new shell/common/mac_util.h
this way it can be used by multiple mm files
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: -Wunsafe-buffer-usage warnings in UNNotificationResponseToNSDictionary
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use base::HexEncode() instead of rolling our own
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
fix: move mac_util to the right place in filenames.gni
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-23 20:44:47 -05:00
trop[bot]
739df86774
fix: respect setAlwaysOnTop before showInactive on Linux under X11 ( #44324 )
...
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44078 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <31829097+cptpcrd@users.noreply.github.com>
2024-10-18 17:20:13 -04:00
trop[bot]
e1419b2fdf
fix: ensure utilityProcess only emits one 'exit' event ( #44266 )
...
fix: ensure utilityProcess only emits one exit
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-10-16 15:01:09 -04:00
trop[bot]
6b458c78b0
fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() ( #44260 )
...
* fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211 )
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-16 15:03:38 +02:00
trop[bot]
258a4a76cf
fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream ( #44223 )
...
* chore: rename v8_value_serializer.cc,h to v8_util.cc,h
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* feat: add electron::util::as_byte_span(v8::Local<v8::ArrayBuffer>)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: -Wunsafe-buffer-usage warnings in ChunkedDataPipeReadableStream::ReadInternal()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5619253
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: restore node buffer span util
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove redundant span wrapper
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-14 11:37:40 -05:00
trop[bot]
7887395e92
fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers ( #44208 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-11 18:31:27 -05:00
trop[bot]
5244fcecd3
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #44163 )
...
fixup e8948397
2024-10-09 16:30:45 -05:00
trop[bot]
4e6e77d696
refactor: revert url::DomainIs() for cookie domains ( #44154 )
2024-10-08 20:34:55 -07:00
trop[bot]
479caedc8a
fix: remove use of deprecated API base::Hash() ( #44103 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 19:14:02 -05:00
trop[bot]
86d86768b3
fix: deprecated API and -Wunsafe-buffer-usage warnings in AsarFileValidator ( #44105 )
...
* refactor: const correctness
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: extract-method AsarFileValidator::EnsureHashExists()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use span API in AsarFileValidator::OnRead()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: replace use of deprecated crypto API
https://crbug.com/364687923
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! refactor: use span API in AsarFileValidator::OnRead()
fix: electron-ia32-testing FTBFS
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 19:13:34 -05:00
trop[bot]
dd8c3b8dd9
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI ctor ( #44074 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronAccessibilityUI constructor
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-01 16:14:46 -05:00
trop[bot]
e019b37231
fix: -Wunsafe-buffer-usage warnings in AddComponentResourceEntries() ( #44031 )
...
fix: -Wunsafe-buffer-usage warnings in ElectronComponentExtensionResourceManager::AddComponentResourceEntries()
just replace pointer-and-length args with a span
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-30 14:40:42 -05:00
trop[bot]
c8788f8217
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() ( #44028 )
...
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: savepoint
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: savepoint
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: savepoint
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: savepoint
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove logging
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: unconditionally write
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: naming
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add code comments
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: more code comments
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove unrelated changes
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove redundant static keyword on function in anonymous namespace
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: naming
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: naming
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: naming
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: slightly more explicit typing
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove unused #includes
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-30 11:59:24 -04:00
trop[bot]
4d16326b4d
fix: FTBFS when building with enable_plugins = false ( #44025 )
...
* fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
it fails to build from source with this error:
../../content/public/browser/plugin_service.h:17:2: error: "Plugins should be enabled"
17 | #error "Plugins should be enabled"
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: FTBFS in printing_utils.cc when ENABLE_PDF is false
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! fix: do not build electron_plugin_info_host_impl.cc when plugins are disabled
fix BUILD.gn linting
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-30 06:23:18 -05:00
Charles Kerr
5836ea1a78
feat: add error event for utility process (33-x-y) ( #43997 )
...
* feat: add error event for utility process (#43774 )
* feat: add error event for utility process
* chore: use public report api
* chore: fix lint
* doc: mark error event as experimental
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fixup! feat: add error event for utility process (#43774 )
remove #include "electron/mas.h"
this header did not exist before c1c8fbfd9
2024-09-29 17:12:15 -05:00
Charles Kerr
a44059aa05
fix: ensure correct WebContents when checking PDFReadyToPrint (33-x-y) ( #43998 )
...
* fix: ensure correct `WebContents` when checking `PDFReadyToPrint` (#43943 )
* fix: ensure correct WebContents when checking PDFReadyToPrint
* test: fix paths on Windows
* Update spec/api-web-contents-spec.ts
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-27 17:05:42 -04:00
trop[bot]
481f9b25a7
chore: remove unused nogncheck includes ( #43991 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 21:49:42 -05:00
trop[bot]
9ca68e2b8c
perf: build g_dgettext domain name at compile time ( #43987 )
...
perf: build GettextPackage name at compile time
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 17:07:21 -05:00
trop[bot]
9ef7ec02e5
fix: replace deprecated libnotify API calls ( #43983 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 13:59:21 -04:00
trop[bot]
6973af4f7a
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43980 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 11:21:24 -05:00
electron-roller[bot]
d62097e067
chore: bump chromium to 130.0.6723.6 (33-x-y) ( #43453 )
...
* chore: bump chromium in DEPS to 130.0.6673.0
* chore: bump chromium in DEPS to 130.0.6675.0
* chore: bump chromium in DEPS to 130.0.6677.2
* chore: bump chromium in DEPS to 130.0.6679.1
* chore: bump chromium in DEPS to 130.0.6681.1
* chore: bump chromium in DEPS to 130.0.6683.2
* chore: bump chromium in DEPS to 130.0.6685.0
* chore: bump chromium in DEPS to 130.0.6687.0
* chore: bump chromium in DEPS to 130.0.6689.0
* chore: bump chromium in DEPS to 130.0.6691.1
* chore: bump chromium in DEPS to 130.0.6693.1
* chore: bump chromium in DEPS to 130.0.6695.1
* chore: bump chromium in DEPS to 130.0.6697.1
* chore: bump chromium in DEPS to 130.0.6699.1
* chore: bump chromium in DEPS to 130.0.6701.1
* chore: bump chromium in DEPS to 130.0.6703.1
* chore: bump chromium in DEPS to 130.0.6705.1
* chore: bump chromium in DEPS to 130.0.6707.1
* chore: bump chromium in DEPS to 130.0.6709.1
* chore: bump chromium in DEPS to 130.0.6711.1
* chore: bump chromium in DEPS to 130.0.6713.1
* chore: bump chromium in DEPS to 130.0.6715.2
* chore: bump chromium in DEPS to 130.0.6717.0
* chore: bump chromium in DEPS to 130.0.6719.1
* chore: bump chromium in DEPS to 130.0.6720.1
* chore: bump chromium in DEPS to 130.0.6723.1
* chore: bump chromium in DEPS to 130.0.6723.4
* chore: bump chromium in DEPS to 130.0.6723.6
* chore: bump chromium to 130.0.6695.0 (main) (#43454 )
* chore: bump chromium in DEPS to 130.0.6673.0
* chore: bump chromium in DEPS to 130.0.6675.0
* chore: bump chromium in DEPS to 130.0.6677.2
* chore: bump chromium in DEPS to 130.0.6679.0
* 5802981: [Partitioned Popins] UKM
https://chromium-review.googlesource.com/c/chromium/src/+/5802981
* 5799275: ash: Create //chrome/browser/ui/ash/web_view
https://chromium-review.googlesource.com/c/chromium/src/+/5799275
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5805208: Move third_party/jacoco to a cipd/ subdirectory.
https://chromium-review.googlesource.com/c/chromium/src/+/5805208
* chore: fixup patch indices
* 5771091: Introduce InputManager class for handling input in Viz.
https://chromium-review.googlesource.com/c/chromium/src/+/5771091
* 5498921: [Permission] Remove SubscribeToPermissionStatusChange from PermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5498921
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5801311: Don't use int for bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5801311
* 5548827: [Web Install] Define the web-app-installation PermissionPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/5548827
* 5786325: Add Infrastructure for Hand tracking permission
https://chromium-review.googlesource.com/c/chromium/src/+/5786325
* chore: fixup patch indices
* chore: bump chromium in DEPS to 130.0.6681.0
* [Views AX] Move BrowserAccessibility* to //ui/accessibility/platform
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5520052
* chore: e patches all
* Don't have default arguments on virtual functions in render_frame_host.h
https://chromium-review.googlesource.com/c/chromium/src/+/5809399
* test: log if loadURL fails in base url test
* chore: bump chromium in DEPS to 130.0.6683.2
* chore: fix support_mixed_sandbox_with_zygote.patch
content: restore old DisableJit behavior
https://chromium-review.googlesource.com/c/chromium/src/+/5804255
* chore: update patch indices
* chore: bump chromium in DEPS to 130.0.6685.0
* Parallel process launching
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* chore: update feat_expose_documentloader_setdefersloading_on_webdocumentloader.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 130.0.6687.0
* chore: bump chromium in DEPS to 130.0.6689.0
* chore: bump chromium in DEPS to 130.0.6691.0
* chore: bump chromium in DEPS to 130.0.6693.0
* chore: update patches
* chore: bump chromium in DEPS to 130.0.6695.0
* chore: free up macos disk space as soon as possible
* 5824143: Use checked in source lists for third_party/boringssl
https://chromium-review.googlesource.com/c/chromium/src/+/5824143
* chore: update patches
* 5824122: Extensions: Add a new view type enum for developer tools contexts
https://chromium-review.googlesource.com/c/chromium/src/+/5824122
* 5806109: Option for JavaScriptExecuteRequestForTests() to ignore content settings
https://chromium-review.googlesource.com/c/chromium/src/+/5806109
* build: free up disk space on gn check too
* 5799369: [Refactoring] Make allow_http1_for_streaming_upload flags false.
https://chromium-review.googlesource.com/c/chromium/src/+/5799369
* fixup! 5015584: Parallel process launching | https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* Disable failing test for short-term
See: https://github.com/electron/electron/issues/43730
* oops
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
(cherry picked from commit 4bcbc955dd#43772 )
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
(cherry picked from commit 02fd8bbcc1https://chromium-review.googlesource.com/c/chromium/src/+/5844369
(cherry picked from commit 0ac4852763f0dce3468d30907620211f34c4104b)
* (multiple CLs): Use an opaque type for FrameTreeNode IDs
5807683: Use an opaque type for FrameTreeNode IDs, part 1 | https://chromium-review.googlesource.com/c/chromium/src/+/5807683
5829746: Use an opaque type for FrameTreeNode IDs, part 2 | https://chromium-review.googlesource.com/c/chromium/src/+/5829746
5836903: Use an opaque type for FrameTreeNode IDs, part 7 | https://chromium-review.googlesource.com/c/chromium/src/+/5836903
5837249: Use an opaque type for FrameTreeNode IDs, part 8 | https://chromium-review.googlesource.com/c/chromium/src/+/5837249
5836564: Use an opaque type for FrameTreeNode IDs, part 12 | https://chromium-review.googlesource.com/c/chromium/src/+/5836564
5837180: Use an opaque type for FrameTreeNode IDs, part 15 | https://chromium-review.googlesource.com/c/chromium/src/+/5837180
(cherry picked from commit 1dd67f5241a3a24ea5a20f11efefdd2afc520a26)
* 5822889: [task] Make GetForegroundTaskRunner non-virtual
https://chromium-review.googlesource.com/c/v8/v8/+/5822889
(cherry picked from commit ae1e7232a35260cce8c4303d5f9809aa166bf19b)
* 5833297: Remove unused inner WebContents attach params
https://chromium-review.googlesource.com/c/chromium/src/+/5833297
(cherry picked from commit 390bb42e39eba66cd86221461d2822bbd85012df)
* 5806403: Shift PowerMonitor to non static
https://chromium-review.googlesource.com/c/chromium/src/+/5806403
(cherry picked from commit 128e3826e13768e89c7f5117de451ebd2b3ec9a4)
* 5666874: [3/N] Remove old OnPowerChange in PowerObserver
https://chromium-review.googlesource.com/c/chromium/src/+/5666874
(cherry picked from commit 6ea6ea14ae23ced6465b94fd753f8c80ced4b13b)
* 5829085: [v8] Differentiate between UserVisible and BestEffort task runners
https://chromium-review.googlesource.com/c/chromium/src/+/5829085
(cherry picked from commit 1db28ee4a51fb2593e4c11bcaa538a6524abe48c)
* 5791112: [webrtc] Use `c/b/permissions/system` for system permissions
https://chromium-review.googlesource.com/c/chromium/src/+/5791112
(cherry picked from commit 50d4a71923ca99653bf5733145bdc6e21f783b2d)
* fixup! (multiple CLs): Use an opaque type for FrameTreeNode IDs
(cherry picked from commit 9271130e160d479b3d286d295045b9d4acd2005c)
* fixup! 5791112: [webrtc] Use `c/b/permissions/system` for system permissions https://chromium-review.googlesource.com/c/chromium/src/+/5791112
(cherry picked from commit db2c8c69d0c7bdee881997847dfc3c8abf32197c)
* 5825636: [Extensions] Create WebContentsObservers with ExtensionsBrowserClient
https://chromium-review.googlesource.com/c/chromium/src/+/5825636
(cherry picked from commit f2c3d09ccd141dbe2f4b62957b72f98bf8a010ae)
* 5854811: Use kNotAllowedError instead of kSecurityError for Web MIDI
https://chromium-review.googlesource.com/c/chromium/src/+/5854811
* test: fix should support base url for data urls test
Caused by https://chromium-review.googlesource.com/c/chromium/src/+/5802682
* test: fixup extensions can cancel http requests
* chore: document custom protocol handling on Windows change due to Non-Special Scheme URLs shipping
https://chromium-review.googlesource.com/c/chromium/src/+/5802682
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
2024-09-26 11:12:12 +02:00
trop[bot]
53cc8aef9b
fix: close all open sheets before closing window on macOS ( #43952 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <beutner.john@gmail.com>
2024-09-25 13:30:56 -05:00
trop[bot]
0ffafbc295
test: ensure sender-pid hint is set in Linux notifications ( #43949 )
...
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 13:09:32 -05:00
trop[bot]
134176a1d1
fix: detach native view when its removed from parent on macOS ( #43922 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cezary Kulakowski <cezary@openfin.co>
2024-09-25 13:17:59 +02:00
trop[bot]
d2bd4cf91c
fix: crash when focusing WebView webContents ( #43932 )
...
fix: crash when focusing WebView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-25 06:16:49 -05:00
trop[bot]
f609d77e29
refactor: add SerialChooserController::web_contents_ ( #43920 )
...
Add a `base::WeakPtr<WebContents>` field to SerialChooserController and
stop subclassing from WebContentsObserver. This follows the Observer docs:
> don't create a `WebContentsObserver` just to be able to check
> for a null `WebContentsObserver::web_contents()`.
> Use a `base::WeakPtr<WebContents>` instead.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-24 08:26:29 -05:00
trop[bot]
ae6d5c4661
refactor: hide printing impl details in api::WebContents ( #43917 )
...
* refactor: move api::WebContents::OnGetDeviceNameToUse() into an anonymous namespace
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move api::WebContents::OnPDFCreated() into an anonymous namespace
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unused #include
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-24 10:11:56 +02:00
trop[bot]
d35b848f95
refactor: remove C-style void arg type for no-arg functions ( #43919 )
...
A small cleanup to remove use of the C-style function declaration idiom.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-24 00:36:20 -07:00
trop[bot]
7f473f2fba
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #43820 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-22 07:11:49 -05:00
trop[bot]
3ee3844bdb
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43804 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-19 22:11:48 -05:00
trop[bot]
78ede09ecd
chore: fix compile issue about ambiguous error of multiple methods named 'highlight'. ( #43800 )
...
chore: fix ambiguous error of multiple methods named 'highlight'
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-09-19 07:20:56 -05:00
Charles Kerr
5c92ea76e9
refactor: reduce code duplication in gin_helper::Promise (33-x-y) ( #43778 )
...
refactor: reduce code duplication in gin_helper::Promise (#43716 )
* refactor: move scope scaffolding into SettletScope
idea stolen from SpellCheckScope
* refactor: move impl of PromiseBase::RejectPromise() to the cc file
* chore: remove unused #include
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-19 13:01:13 +02:00
Charles Kerr
d3cfe7aacb
chore: iwyu mojom-forward header files (33-x-y) ( #43777 )
...
chore: iwyu mojom-forward header files (#43741 )
* chore: iwyu mojom.h headers
* fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
* fixup! fixup! chore: iwyu mojom.h headers
make previously-indirect include dependency direct
2024-09-19 09:58:45 +02:00
trop[bot]
12bb7093e2
fix: resizing border on Linux WCO caption buttons ( #43744 )
...
Closes https://github.com/electron/electron/issues/43714 .
Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-17 15:33:28 +02:00
trop[bot]
6b4f269d22
fix: prevent loading spinner when launching utility process on Windows ( #43731 )
...
fix: prevent spinning cursor when launching utility process on Windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2024-09-17 11:51:12 +02:00
Charles Kerr
d11c840cf0
refactor: add EmitWarning(v8::Isolate*) helper ( #43736 )
...
refactor: add `EmitWarning(v8::Isolate*)` helper (#43722 )
* refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove EmitWarning(node::Environment*, ...)
* chore: add code comments
* fixup! refactor: add EmitWarning(Isolate*, ...) warning
* chore: remove unused node #includes
2024-09-17 11:50:48 +02:00
trop[bot]
748f293400
refactor: remove use of deprecated API BuildServiceInstanceFor() ( #43707 )
...
* refactor: update BadgeManagerFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update NetworkContextServiceFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update ElectronExtensionSystemFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update UsbChooserContextFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update UsbHidChooserContextFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update SerialChooserContextFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: update FileSystemAccessPermissionContextFactory
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* empty commit
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-13 15:26:10 -05:00
