Cheng Zhao
2837b730f2
Fix network_delegate.cc
2015-03-08 19:47:12 -07:00
Cheng Zhao
95f0f25dc4
Fix inspectable_web_contents_impl.cc
2015-03-08 19:38:40 -07:00
Cheng Zhao
a5026907e4
Implement PlatformNotificationService
2015-03-08 19:37:13 -07:00
Cheng Zhao
99e2dbd6e8
Fix inspectable_web_contents_impl.h
2015-03-08 19:13:17 -07:00
Cheng Zhao
8467fee8d8
Fix devtools_manager_delegate.cc
2015-03-08 19:07:53 -07:00
Cheng Zhao
c0356f0269
Fix ui/gfx/geometry headers
2015-03-08 19:02:38 -07:00
Cheng Zhao
5e4c90f264
NotificationError is discarded
2015-02-03 10:57:33 -08:00
Cheng Zhao
1c65f5d7d9
Fix cpplint warning
2015-02-03 10:57:25 -08:00
Cheng Zhao
c874219101
Use the new devtools API
2015-02-03 10:57:25 -08:00
Cheng Zhao
dc01ba5a72
scoped_ptr.PassAs is deprecated
2015-02-03 10:57:25 -08:00
Cheng Zhao
02d632c4f7
Fix change of ShowDesktopNotification API
2015-02-03 10:57:25 -08:00
Cheng Zhao
98bf5bf3ed
Implement CheckMediaAccessPermission
...
Part of the fixes for #1017 .
2015-01-23 15:13:04 -08:00
Cheng Zhao
4bbe026d48
register DIR_CACHE and DIR_USER_CACHE in path service
2015-01-18 21:00:47 -08:00
Cheng Zhao
c9463d815c
linux: Override DIR_APP_DATA before loading .js
2015-01-18 17:34:36 -08:00
Cheng Zhao
76e3d56760
Make DIR_APP_DATA available on Linux
2015-01-18 17:19:25 -08:00
Cheng Zhao
5b4e5a7e55
Override DIR_USER_DATA as data path
2015-01-18 16:59:57 -08:00
Cheng Zhao
964e1d6bb6
Override DIR_APP_DATA on Linux
2015-01-18 16:42:32 -08:00
Cheng Zhao
167995119a
Use current exe's icon as default window icon.
...
Fixes atom/atom-shell#863 .
2015-01-15 15:30:04 -08:00
Cheng Zhao
0e0079956c
Add support for --ignore-certificate-errors
2015-01-06 20:36:20 -08:00
Cheng Zhao
1166a56ceb
Add a way to custom http cache backend
2015-01-05 13:29:16 -08:00
Cheng Zhao
ff0afc688d
Fix devtools window can not minimize
...
Closes atom/atom-shell#941 .
2015-01-04 22:32:49 -08:00
Cheng Zhao
51ef072de5
Implement GetDevToolsManagerDelegate, fixes atom/atom-shell#969
2015-01-02 15:18:24 -08:00
Cheng Zhao
dc86ab58a9
Remove DownloadManagerDelegate
...
Having a partial implemented DownloadManagerDelegate will cause crashes under
certain places.
2014-12-17 13:13:19 -08:00
Cheng Zhao
2c81fb4719
Fix compilation warnings due to API changes
2014-12-09 22:39:44 -08:00
Cheng Zhao
289d3b54f3
Add DevToolsManagerDelegateA
2014-12-09 22:39:44 -08:00
Cheng Zhao
8ec5b5ad20
DevToolsClientHost is discarded
2014-12-09 22:39:44 -08:00
Cheng Zhao
06eff5cd8c
linux: Add a way to set WM_CLASS for devtools window
2014-11-24 16:03:55 +08:00
Cheng Zhao
601ee75bcf
linux: Use native window frame for devtools
...
Fixes atom/atom-shell#646 .
2014-11-06 19:08:41 +08:00
Cheng Zhao
c4aebe3ba1
No need to write "virtual" when we have "override"
2014-11-06 19:08:41 +08:00
Frank Hale
513d84cd3e
Make devtools window maximizable
2014-11-03 11:10:14 -05:00
Cheng Zhao
dbfa9b5660
mac: Clean delegate before releasing window
2014-11-03 22:12:33 +08:00
Cheng Zhao
b75dc9b08d
mac: Close the devtools window before releasing it
...
Sometime simply releasing it may leave it open for a while.
2014-11-03 22:05:16 +08:00
Cheng Zhao
92244500c6
mac: Clean delegate after closing window
2014-11-03 21:46:59 +08:00
Cheng Zhao
74025ee985
Enable setting devtools to not able to dock
2014-11-03 21:32:11 +08:00
Cheng Zhao
6b49e23312
Fix leaking WebContents from devtools.
2014-10-27 16:42:54 +08:00
Cheng Zhao
7b39673215
No need for "virtual" when "override" is used
2014-10-27 16:39:54 +08:00
Cheng Zhao
f809fef22d
OVERRIDE => override
2014-10-23 11:10:39 +08:00
Cheng Zhao
6d62b0960e
Fix building on Linux
2014-10-13 11:03:37 +08:00
Cheng Zhao
733931c7ad
Fix loading devtools
2014-10-11 19:00:30 +08:00
Cheng Zhao
5bec155c81
Adapt to API changes of Chrome 38
2014-10-11 16:38:27 +08:00
Cheng Zhao
09678cc485
Clean the callback after executed
2014-10-01 15:18:34 +08:00
Cheng Zhao
ea28f518d3
Add handling of user media requests
2014-10-01 11:07:29 +08:00
Cheng Zhao
30025fe6ef
Set toolbar color for devtools.
2014-09-09 18:28:02 +08:00
Cheng Zhao
c58bf15345
mac: Send focus/blur event to devtools web contents.
2014-09-09 17:57:23 +08:00
Cheng Zhao
a6627a7286
Add a method in InspectableWebContentDelegate to set icon for devtools window.
2014-09-09 15:29:35 +08:00
Cheng Zhao
f013a98920
views: Use new devtools resizing strategy.
2014-09-01 20:09:08 +08:00
Cheng Zhao
2a8691d981
mac: Use new devtools resizing strategy.
2014-09-01 19:18:12 +08:00
Cheng Zhao
4107089363
Use new devtools resizing strategy from Chrome 37.
2014-09-01 19:15:07 +08:00
Cheng Zhao
f8c8c415eb
Fix cpplint warnings.
2014-08-31 20:05:14 +08:00
Cheng Zhao
6010539914
Don't create empty url request job factory.
2014-08-31 19:57:15 +08:00
Cheng Zhao
dca1c51b32
Fix API changes of Chrome37.
2014-08-31 18:43:01 +08:00
Cheng Zhao
47bc6a29a7
Print console output of devtools.
2014-08-28 12:53:35 +08:00
Cheng Zhao
20efd82c98
Implement zoom messages for devtools.
2014-08-26 15:07:06 +08:00
Cheng Zhao
6e420d5137
Cleanup URLRequestContextGetter.
...
In brightray line length limit is 100 so we could make code formatted more
tidy.
2014-08-20 15:26:53 +08:00
Cheng Zhao
3fefdcba0d
Move creation of URLRequestJobFactoryImpl into default delegate.
2014-08-20 14:48:02 +08:00
Cheng Zhao
c30f11f38c
Add Delegate for URLRequestContextGetter.
2014-08-20 14:39:09 +08:00
Cheng Zhao
44bfa328f1
Add --proxy-server switch.
2014-08-20 11:49:18 +08:00
Cheng Zhao
d136c44792
Add --no-proxy-server switch.
2014-08-20 11:44:45 +08:00
Cheng Zhao
8c73e6aba4
Implement --host-resolver-rules switch.
2014-08-15 12:42:11 +08:00
Cheng Zhao
052ddd961f
Implement --host-rules switch.
2014-08-15 12:30:50 +08:00
Cheng Zhao
b06970fda0
Remove unneeded headers and declarations.
2014-08-13 17:39:25 +08:00
Cheng Zhao
da3bafd490
Pass parameter by pointers when creating job factory.
...
1. The caller needs to modify protocol_handlers.
2. We need to make sure protocol_handlers and interceptors are not touched
if user doesn't create a job factory.
2014-08-13 17:31:33 +08:00
Cheng Zhao
604361f93d
Pass ProtocolHandlerScopedVector by value.
2014-08-13 16:16:01 +08:00
Cheng Zhao
b95b621dfc
Add url_request_context_getter getter for BrowserContext.
2014-08-13 16:09:32 +08:00
Cheng Zhao
3f9f778274
Clean handlers when custom job factory is used.
2014-08-13 16:05:22 +08:00
Cheng Zhao
2d03c983e4
Give user a chance to create custom URLRequestJobFactory.
2014-08-13 15:48:16 +08:00
Cheng Zhao
d01aa51686
using content::BrowserThread
2014-08-13 15:11:23 +08:00
Cheng Zhao
f05199d4e4
Don't be too strict on media requests.
2014-08-11 23:22:49 +08:00
Cheng Zhao
eafa888757
Enable devtools experiments.
2014-08-11 10:42:50 +08:00
Cheng Zhao
760f7ed24f
Fix "warning: field 'widget_' is uninitialized when used here".
2014-08-09 09:34:06 +08:00
Cheng Zhao
4ed7934567
mac: Close devtools when web contents is destroyed.
...
After the BRYInspectableWebContentsView is added as subview to other
NSWindow owned by users, the view_ would not be dealloc when the web
contents got destroyed, which made the devtools window a ghost.
2014-08-08 12:45:26 +08:00
Cheng Zhao
f455798c05
Fix cpplint warnings.
2014-08-07 10:50:50 +08:00
Cheng Zhao
e5a57b02d8
Focus on devtools when it is opened on Mac.
2014-08-07 10:48:02 +08:00
Haojian Wu
5a5c92ad2d
Add remote debugging support.
2014-07-30 22:19:05 +08:00
Cheng Zhao
7b6fbff40d
Implement BrowserClient::GetDefaultDownloadDirectory().
2014-07-28 17:48:55 +08:00
Cheng Zhao
a866718b49
Initialize ProxyResolverV8 at very early phrase.
...
In atom-shell we need to ensure node environment is initialized after the
ProxyResolverV8 has been initialized.
2014-07-28 15:28:38 +08:00
Cheng Zhao
a8e879d0c5
mac: Fix blank page after devtools is opened.
2014-07-28 12:40:38 +08:00
Cheng Zhao
f552dc7ba4
mac: Fix the notification presenter of new API.
2014-07-28 11:52:26 +08:00
Cheng Zhao
e52a089ec2
mac: Remove usages of WebContentsView.
2014-07-28 09:34:42 +08:00
Cheng Zhao
d47a94b1fe
DispatchBeforeUnload is now a method of WebContents.
2014-07-27 11:27:05 +00:00
Cheng Zhao
9821cd1f58
web_contents_view.h has been hidden from user.
2014-07-27 11:27:04 +00:00
Cheng Zhao
a98199511a
Implement GetGuestManagerDelegate.
2014-07-27 11:27:04 +00:00
Cheng Zhao
8bf3e084f1
Interface of ProxyResolverV8 has changed.
2014-07-27 11:27:04 +00:00
Cheng Zhao
bb87492897
No more need to init aura::Env.
2014-07-27 11:27:04 +00:00
Cheng Zhao
6dd580526e
Refactor notification presenter for new desktop notification interface.
2014-07-27 11:27:04 +00:00
Cheng Zhao
4e63780e4a
Prototype of WebContentsDestroyed has changed.
2014-07-27 10:27:19 +00:00
Cheng Zhao
a318b1c5d1
views: Use DesktopNativeWidgetAura for menu view.
2014-07-14 15:56:04 +08:00
Cheng Zhao
46e765f79b
Fix crash when closing docked devtools by clicking close button.
...
We need to send ack for the close message, so we should destroy web contents
after the beforeunload event has fired.
2014-07-13 10:08:28 +08:00
Cheng Zhao
9d4e977c01
win: Fix window frame on detached window.
2014-07-12 21:26:29 +08:00
Cheng Zhao
8d3f615e61
win: Setup font.
2014-07-12 19:46:26 +08:00
Cheng Zhao
0f5b427648
Always shows window frame except for maximized window on Unity.
2014-07-12 11:45:24 +08:00
Cheng Zhao
a080d2c5bb
Remove GetNativeView() when compiled with views toolkit.
2014-07-11 23:32:00 +08:00
Cheng Zhao
4b57e1f4f8
Warn about using GetNativeView() in views.
2014-07-11 23:14:20 +08:00
Cheng Zhao
891b7434db
Separate the message parsing into a new function.
2014-07-11 23:03:42 +08:00
Cheng Zhao
de08cc1d52
No need for custom dealloc.
2014-07-11 22:22:03 +08:00
Cheng Zhao
e553e11226
Use shortcut way to create scoped_ptr.
2014-07-11 21:55:57 +08:00
Cheng Zhao
739b352de6
Only init WMState on Linux.
2014-07-09 20:06:31 +08:00
Cheng Zhao
d5283b2337
Allow access FileSystem api in devtools.
...
It is required by the load/save feature of profilers.
2014-07-09 15:38:53 +08:00
Cheng Zhao
1fbeb11371
Send message ack to devtools.
2014-07-09 15:34:10 +08:00
Cheng Zhao
a5bb24284e
views: Follow WidgetDelegateView's convention on deleting self.
...
It could avoid invoking WidgetDelegate's methods when the delegate has been
deleted as a view.
2014-07-09 11:08:17 +08:00
Cheng Zhao
81d31b1d49
Remove Windows's devtools implementation.
2014-07-09 10:37:54 +08:00
Cheng Zhao
0a7b1fdd87
Add new devtools messages in Chrome 35.
2014-07-09 10:26:01 +08:00
Cheng Zhao
7a196933bb
views: Don't leak ViewsDelegate.
2014-07-09 10:26:01 +08:00
Cheng Zhao
651ebdde65
views: Remember bounds of devtools window.
2014-07-09 10:26:01 +08:00
Cheng Zhao
4fb4b2d7ba
views: Implement undocked devtools.
2014-07-09 10:26:01 +08:00
Cheng Zhao
e574bf6d0f
views: Initial docked devtools implementation.
2014-07-09 10:26:01 +08:00
Cheng Zhao
4048d491f0
views: Use chromium's custom frame view.
2014-07-09 10:26:01 +08:00
Cheng Zhao
da5daecb1d
Initialize aura environment.
2014-07-09 10:26:01 +08:00
Cheng Zhao
02f52f7e20
Allow override BrowserMainParts::InitProxyResolverV8.
2014-07-09 10:26:01 +08:00
Cheng Zhao
8f3546ed30
Initialize screen for aura.
2014-07-09 10:26:01 +08:00
Cheng Zhao
bad7b95ed7
Add ViewsDelegate, required when using views::Widget on aura.
2014-07-09 10:26:01 +08:00
Cheng Zhao
48ed03eb39
Initialize Linux UI.
2014-07-09 10:26:01 +08:00
Cheng Zhao
d4e81da19a
Make BrowserMainParts's overrides available on all platforms.
2014-07-09 10:26:01 +08:00
Cheng Zhao
7050b7944f
Remove devtools view on Linux.
...
GTK+ has been replaced, we need to rewrite the whole thing.
2014-07-09 10:24:10 +08:00
Cheng Zhao
563d6e87ff
Fix cpplint warning.
2014-07-09 10:24:10 +08:00
Cheng Zhao
1722532e6d
No need to remember dock state.
...
All devtools states are remembered by devtools itself now.
2014-07-09 10:24:10 +08:00
Cheng Zhao
7a2dc3fc4f
mac: Make focus back to browser window when devtools is closed.
2014-07-09 10:24:10 +08:00
Cheng Zhao
2efeaa268f
Place DevTools WebContents underneath inspected WebContents.
...
This commit has this strategy implemented on Mac.
See https://code.google.com/p/chromium/issues/detail?id=318751 .
2014-07-09 10:24:10 +08:00
Cheng Zhao
7d130c9697
mac: Revert to simplest undocked-only devtools.
...
This makes porting Chrome's devtools easier.
2014-07-09 10:24:10 +08:00
Adam Roben
8f367f6b35
More coding style fixes
2014-07-07 14:42:30 -04:00
Adam Roben
e86c409e6b
Update DevToolsWindow to use views and aura
...
This is required to make it work in Chrome 35.
2014-07-07 14:27:23 -04:00
Adam Roben
f65246b3cd
Fix coding style
2014-07-07 14:27:02 -04:00
Adam Roben
8f2a2e19b5
Really fix unused-variable warnings
...
I misunderstood how ALLOW_UNUSED is meant to be used. Using a macro like
MSV_WARNING_SUPPRESS() would be nice, but for some reason it isn't working for
me. So now we just manually reference the variable in the code.
2014-07-07 14:21:40 -04:00
Adam Roben
5b2a62627e
Silence unused variable warning on Windows
2014-07-07 13:55:10 -04:00
Adam Roben
6bae1f4b44
Set up a native screen on Windows
...
This is needed to prevent a crash inside aura::WindowTreeHost::InitCompositor.
2014-07-07 13:53:24 -04:00
Adam Roben
307d936d75
Update to use CR_* Windows message macros
...
See https://codereview.chromium.org/146833020 .
2014-06-27 13:40:33 -04:00
Adam Roben
918f38e13f
Fix long line
2014-06-27 11:59:01 -04:00
Adam Roben
51ac56e4c4
Update cookie store code for Chrome 35
...
See https://codereview.chromium.org/110883017
2014-06-27 11:54:28 -04:00
Adam Roben
afc889b883
Update NetworkDelegate for Chrome 35
2014-06-27 11:54:27 -04:00
Adam Roben
3a71958e16
Update MediaStreamDevicesController for Chrome 35
...
See https://codereview.chromium.org/180633008
2014-06-27 11:54:27 -04:00
Adam Roben
e003cc9a0a
Update MediaCaptureDevicesDispatcher for Chrome 35
...
See https://codereview.chromium.org/183743021
2014-06-27 11:54:27 -04:00
Adam Roben
5b788476a5
Update for move of string symbols into base::
2014-06-27 11:54:27 -04:00
Adam Roben
5b93dc74e6
Update BrowserContext for Chrome 35
2014-06-27 11:54:27 -04:00
Adam Roben
42b86242ea
Add support for Chrome 35's "protocol interceptors"
...
See https://codereview.chromium.org/187223003
2014-06-27 11:54:27 -04:00
Adam Roben
500861d63d
Update prefs code for Chrome 35
...
See https://codereview.chromium.org/64193003
2014-06-27 11:54:27 -04:00
Rus Maxham
cca71fce9f
less removal of whitespace
2014-06-23 13:16:01 -07:00
Rus Maxham
3acba90225
brightray namespaced frameAutosaveName
2014-06-23 13:12:20 -07:00
Rus Maxham
92a4b25e47
- remember position and size of developer tools window
2014-06-23 12:48:52 -07:00
Cheng Zhao
e71927c5da
Closing devtools window means it is not visible.
2014-06-17 16:51:46 +08:00
Cheng Zhao
1b274a1fd6
Add comments on the usage of attached devtools.
2014-06-10 12:44:30 +08:00
Cheng Zhao
9a70c9bb44
Enable undocked devtools.
2014-06-10 12:35:23 +08:00
Cheng Zhao
d70d24c360
Implement setting dock side.
2014-06-10 12:03:20 +08:00
Cheng Zhao
1943d88bdc
Handle focus correctly.
2014-06-10 11:37:07 +08:00
Cheng Zhao
bd0f9df96c
Put devtools in split view.
2014-06-10 10:29:39 +08:00
Cheng Zhao
566022cb66
ContainerView should manage itself.
2014-06-10 10:03:35 +08:00
Cheng Zhao
b0374b6a1d
Use views::View to represent web view.
2014-06-10 09:58:28 +08:00
Cheng Zhao
5e0dd5c687
Remove from notification center when web contents is destroyed.
2014-04-23 11:20:12 +08:00
Cheng Zhao
54060ed53d
Enable delegate to override SaveToFile and AppendToFile.
2014-04-05 09:21:47 +08:00
Cheng Zhao
d2ff5ad798
Provide a way to close devtools completely.
2014-03-20 09:26:21 +08:00
Cheng Zhao
5768ff6981
Enable delegate to change the dock side.
2014-03-04 19:47:33 +08:00
Cheng Zhao
e3aaaf2643
Add InspectableWebContentsDelegate.
2014-03-04 16:26:50 +08:00
Adam Roben
f7fb6371c2
Increase the open file limit on OS X to 1024
...
The default (256) is too low for pages that load a lot of resources all at
once. See https://codereview.chromium.org/125151 and bugs like
https://code.google.com/p/chromium/issues/detail?id=14137 and
https://code.google.com/p/chromium/issues/detail?id=151039 . The new limit
matches what Chrome itself uses.
2014-01-31 10:43:38 -05:00
Adam Roben
e8de51a8dd
Destroy ResourceContext on the IO thread
...
This matches content_shell and fixes a debug assertion (and maybe even a
crash).
2014-01-30 09:03:00 -05:00
Adam Roben
c4935acbb1
Fix debug assertions about transport_security_state
...
This code was added to content_shell in
https://chromiumcodereview.appspot.com/16501002 and we never picked it up.
2014-01-30 09:01:23 -05:00
Adam Roben
dcaaeacfe3
Fix assertions in Debug builds about using NetworkDelegate on the wrong thread
...
We have to create it on the IO thread.
2014-01-30 08:36:54 -05:00
Patrick Reynolds
967e8170f5
brevity and style
2013-12-19 16:01:01 -06:00
Patrick Reynolds
8d2b392f07
undo some ugly line wrapping
2013-12-19 13:39:37 -06:00
Patrick Reynolds
4e31c0011d
keep cpplint happy, mostly about line length
2013-12-19 13:06:05 -06:00
Patrick Reynolds
ef6d5dbf4e
authorship
2013-12-18 23:20:00 -06:00
Patrick Reynolds
c6424672f5
comments and cleanup
2013-12-18 23:14:36 -06:00
Patrick Reynolds
04d5ed25d8
call PostClose when notification closed by click
2013-12-18 23:14:36 -06:00
Patrick Reynolds
272b3c30d3
free notifications properly
2013-12-18 23:14:36 -06:00
Patrick Reynolds
a82e9f30ed
use libnotify to pop up notifications on Linux
2013-12-18 23:14:36 -06:00
Cheng Zhao
b1dc139e4b
Set the proxy service a bit earlier to avoid crash.
2013-12-15 15:00:52 +08:00
Adam Roben
dc3f2050c0
Merge pull request #44 from brightray/fix-devtools-flash
...
Fix flash of page while resizing devtools NSSplitView divider.
2013-12-12 07:36:16 -08:00
Cheng Zhao
e0b8935fda
Remove the unused dividerHidden property of GraySplitView.
2013-12-12 23:33:50 +08:00
Cheng Zhao
39f5f52423
Fix flash of page while resizing devtools NSSplitView divider.
2013-12-12 18:46:46 +08:00
Cheng Zhao
b080e5c52d
Rename IsDevToolsOpened to IsDevToolsViewShowing.
2013-12-10 18:38:35 -08:00
Cheng Zhao
7a5415a3b7
Fix IsDevToolsOpened when devtools is attched to pane on Linux.
2013-12-09 13:27:22 +00:00
Cheng Zhao
a8c5911094
Implement IsDevToolsOpened for Linux.
2013-12-09 09:03:41 +00:00
Cheng Zhao
de7892cd6e
Add API to get whether the devtools is opened.
2013-12-09 09:03:29 +00:00
Cheng Zhao
0a1f756ca6
Use "ProxyResolverV8" instead of "SystemProxyResolver" as proxy service.
...
SystemProxyResolver is untested and could cause random crashes.
2013-12-05 02:56:28 -08:00
Adam Roben
7e6f5aa734
Update for ui -> gfx moves in Chrome 31
...
See https://codereview.chromium.org/23769011 .
2013-12-02 13:00:39 -05:00
Adam Roben
ab8cb1e3a5
Update for changes to content::CreatePersistentCookieStore in Chrome 31
...
I just copied how Chrome initializes this object.
2013-12-02 13:00:39 -05:00
Adam Roben
cfeddb5bcb
Update for changes to net::FileProtocolHandler in Chrome 31
...
I just copied the way that Chrome initializes this object.
2013-12-02 13:00:39 -05:00
Adam Roben
265076f19a
Update for changes to devtools in Chrome 31
...
browser/devtools_embedder_message_dispatcher.* came from
chrome/browser/devtools, and were modified just enough to compile within
brightray.
2013-12-02 13:00:39 -05:00
Patrick Reynolds
711aa5282b
make BrowserContext::Initialize virtual
2013-11-27 15:55:06 -06:00
Adam Roben
89795c9b14
Stop the devtools from turning black when the window gets big enough
...
We need to use UnderlayOpenGLHostingWindow to show the devtools to ensure they
remain visible even when they get large.
2013-11-25 16:28:57 -05:00
Patrick Reynolds
470daa571c
back to reinterpret_cast
2013-11-17 22:27:23 -06:00
Patrick Reynolds
9f9aeac59f
safer casts, clearer if-else chain
2013-11-17 22:25:24 -06:00
Adam Roben
3d8b636f9e
Fix remaining cpplint errors in inspectable_web_contents_view_linux.cc
2013-11-17 19:21:50 -05:00
Adam Roben
cdbfff2fcf
Fix backwards typedef
2013-11-17 19:15:26 -05:00
Adam Roben
7b47a6152d
Fix cpplint errors in media_capture_devices_dispatcher.cc
2013-11-17 19:14:08 -05:00
Adam Roben
4938fc62ad
Fix most cpplint errors in inspectable_web_contents_view_linux.cc
2013-11-17 19:12:50 -05:00
Adam Roben
1595940723
Fix cpplint errors in devtools_window.cc
2013-11-17 19:05:21 -05:00
Adam Roben
0271ff1964
Fix cpplint errors in inspectable_web_contents_view_win.h
2013-11-17 19:03:41 -05:00
Adam Roben
073b1c164b
Fix cpplint errors in inspectable_web_contents_view_win.cc
2013-11-17 19:02:49 -05:00
Adam Roben
779dfd2baf
Fix most cpplint errors in devtools_window.h
...
It's still complaining about the non-const reference in BOOL&.
2013-11-17 19:01:36 -05:00
Adam Roben
6aec3006e6
Fix whitespace/comment errors
2013-11-17 18:56:07 -05:00
Adam Roben
236efa8be5
Fix cpplint errors in bry_application.h
2013-11-17 18:53:34 -05:00
Adam Roben
23bcf4099f
Fix cpplint errors in inspectable_web_contents_view_linux.h
2013-11-17 18:52:02 -05:00
Adam Roben
9f82d58761
Fix cpplint errors in web_ui_controller_factory.h
2013-11-17 18:46:23 -05:00
Adam Roben
7a362b7413
Fix cpplint errors in url_request_context_getter.h
2013-11-17 18:43:46 -05:00
Adam Roben
cf4d966958
Fix cpplint errors in notification_presenter_mac.h
2013-11-17 18:43:20 -05:00
Adam Roben
d4ad45334f
Turn off build/include_what_you_use
...
Chromium doesn't seem to use this rule.
2013-11-17 18:42:15 -05:00
Adam Roben
ec59df1a51
Fix cpplint errors in network_delegate.h
2013-11-17 18:36:34 -05:00
Adam Roben
cb684c5c6e
Fix cpplint errors in inspectable_web_contents_view_mac.h
2013-11-17 18:24:36 -05:00
Adam Roben
ea689b31a4
Fix cpplint errors in inspectable_web_contents_view.h
2013-11-17 18:23:13 -05:00
Adam Roben
877a1f0371
Fix cpplint errors in inspectable_web_contents_impl.h
2013-11-17 18:22:48 -05:00
Adam Roben
0805b414e9
Fix cpplint errors in inspectable_web_contents.h
2013-11-17 18:20:54 -05:00