mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
20858 commits 1 branch 183 tags 5.3 GiB
Commit graph

51 commits

Author SHA1 Message Date
Islam Sharabash
3b6f0d83e1 fix: allow stream protocols to return headers with multiple values (#14887) 
* fix: allow stream protocols to return headers with multiple values

This allows stream protocols to return headers with multiple values as
an array of values.

Fixes https://github.com/electron/electron/issues/14778

* Prefer ConvertFromV8

* Cleanup header conversion

1. Deduplicate the code by using a lambda
2. Remove duplicate calls to headers->Get(key)

* Fix broken test

Headers with multiple values are now being converted correctly, this
test asserted the wrong behavior.
 2018-10-25 11:34:20 +11:00
Jeremy Apthorp
4f540fe52a Replace DupCryptoBuffer with bssl::UpRef 
https://chromium-review.googlesource.com/c/chromium/src/+/1128194
 2018-10-09 14:38:00 -07:00
Aleksei Kuzmin
7fc3bcaa02 chore: run clang-format 
- atom/
 - brightray/
 - chromium_src/
 2018-09-19 17:18:10 +02:00
Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings (#14583) 
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
 2018-09-12 19:25:56 -05:00
Shelley Vohr
e9971173d4
fix: inline vector allocation (#13449) 
* fix: inline vector allocation

* remove size_t static cast
 2018-06-27 12:57:10 -07:00
Shelley Vohr
1dde9492c9
refactor: remove deprecated CreateWithCopiedBuffer (#13436) 
* refactor: remove deprecated CreateWithCopiedBuffer

* fix: add missing vector includes

* fix std::vector<char> allocation
 2018-06-26 15:08:27 -07:00
Shelley Vohr
c20e0c30a2 src: base::Value::HasKey(key) => base::Value::FindKey(key) (#13312) 2018-06-20 13:07:10 +10:00
deepak1556
f1e2304585 Remove OSCertHandle typedefs, use smart pointers for CRYPTO_BUFFER ownership. 
https://chromium-review.googlesource.com/c/chromium/src/+/775540
 2018-06-19 11:49:42 +10:00
Milan Burda
28fd571d0c refactoring: use std::make_unique<T> (#13245) 2018-06-18 16:32:55 +09:00
Shelley Vohr
c6f4bbd143
also format missing .cc files 2018-04-18 20:48:45 -04:00
deepak1556
d846c9006e Replace somemore uses of SetStringWithoutPathExpansion 2018-02-23 10:21:24 +09:00
Thiago de Arruda
32113bf7f9 Implement V8 -> C++ conversion of net::HttpResponseHeaders. 2017-11-13 15:20:40 -03:00
Thiago de Arruda
9c04d18387 Modify FillRequestDetails to pass headers dictionary. 2017-11-13 15:19:59 -03:00
Aleksei Kuzmin
cc350efbd8 Remove base::BinaryValue 
https://codereview.chromium.org/2799093006
 2017-08-15 16:19:20 +03:00
joshaber
736d6afe73 As you wish linter 2017-04-04 09:23:30 -04:00
joshaber
0cab8a3322 Put CertFromData in an anon namespace 2017-04-04 09:19:23 -04:00
joshaber
370cf815d9 Get rid of intermediates and rehydrate from issuerCert 2017-04-03 16:27:53 -04:00
joshaber
b0ef7ddf44 Use better iteration 2017-04-03 15:28:51 -04:00
joshaber
ee7389bb6d Rename to make VS happy 2017-03-31 22:57:56 -04:00
joshaber
bde2a597f3 Decode all the intermediates 2017-03-31 21:27:49 -04:00
joshaber
69defc5166 Encode all the intermediates 2017-03-31 21:27:33 -04:00
joshaber
302ca8669d Slightly better conversion 2017-03-31 15:44:47 -04:00
joshaber
141a5ad73f Maybe this is a valid conversion? 2017-03-31 14:16:26 -04:00
joshaber
deae70de4d Dummy out the certificate FromV8 converter 2017-03-31 13:53:31 -04:00
Greg Nolle
f767f0f048 Remove unnecessary ConvertToV8 calls. 2016-11-15 15:53:42 -08:00
Greg Nolle
5d028f9163 Expose extra certificate information: full breakdown of issuer and subject principals, as well as full structure of intermediate issuer certificates. 2016-11-15 15:53:42 -08:00
Greg Nolle
446399c3c1 Expose whole certificate chain to verify proc and certificate-error event. 2016-11-15 15:53:42 -08:00
ali.ibrahim
61278f9ace Fixing code review issues. 2016-10-25 12:41:01 +02:00
ali.ibrahim
de29f2dde5 Fixing build: removing constness on net::HttpResponseHeaders as otherwise we would need a change in libchromiumcontent. 2016-10-13 17:51:19 +02:00
ali.ibrahim
6f5b0a28c5 Fixing code review issues: function call formatting, renaming JS member variables, refactoring response headers conversion. 2016-10-13 17:14:23 +02:00
Cheng Zhao
9714348260 Merge pull request #6941 from deepak1556/blob_data_patch 
protocol: provide blob uuid with uploadData
 2016-09-16 17:01:15 +09:00
Cheng Zhao
f28e8d7168 Fix API changes of Chrome 53 2016-09-14 16:22:43 +09:00
deepak1556
2b0f632d51 provide blob uuid from upload data 2016-09-01 01:01:52 +05:30
Kevin Sawicki
6285500cdc Sort includes alphabetically 2016-08-26 15:30:02 -07:00
bridiver
94c60379d1 don't convert a string to an array buffer 2016-08-13 13:35:23 -07:00
Anthony Tseng
9e6f623a5c Using base::HexEncode() 2016-07-19 11:06:56 +08:00
Anthony Tseng
42eb0c3eae serial number in hex string 2016-07-18 23:42:42 +08:00
Anthony Tseng
02e89d60f1 Use CalculateFingerprint256() 2016-07-14 19:09:11 +08:00
Anthony Tseng
db39867ad9 Add more detail attributes for certificate-error 2016-07-13 22:14:47 +08:00
deepak1556
0e0235407b fill net::URLRequest details on IO thread 2016-06-09 10:39:18 +05:30
Cheng Zhao
7ba391da7c Update to API changes of Chrome 51 2016-05-23 10:59:39 +09:00
Cheng Zhao
5fae63a2f5 Fix compilation errors on OS X 2016-03-10 17:06:21 +09:00
Milan Burda
d2b48b2aa7 Fix crash in mate::Converter<const net::URLRequest*>::ToV8 
The net::URLRequest::url() method calls vector<GURL>::back(), which is undefined when the url_chain is empty
 2016-02-24 14:01:26 +01:00
Robo
dc0151099c session: provide uploadData with webrequest api when available 2016-01-27 18:39:40 +05:30
Cheng Zhao
fed94aada0 Make the webRequest listener asynchronous 2015-12-12 00:09:03 +08:00
Cheng Zhao
98ba1a24db Merge pull request #3640 from deepak1556/webrequest_api_patch 
session: add webrequest api
 2015-12-11 16:56:00 +08:00
Robo
658accab94 fix pointer usage 2015-12-11 00:25:25 +05:30
Robo
13b5cab738 session: add webrequest api 2015-12-09 20:14:18 +05:30
deepak1556
940289639e protocol: provide upload data when available 2015-12-09 20:10:57 +05:30
Robo
d072e61282 session: api to allow handling certificate verification 2015-11-13 01:27:30 +05:30