David Sanders
7dd6d7697d
chore: allow multiple OS selection on bug reports ( #42854 )
2024-07-11 13:23:43 -07:00
John Kleinschmidt
514e9bbb04
build: update build-tools for GHA ( #42870 )
...
chore: update build-tools for GHA
2024-07-11 16:18:26 -04:00
Shelley Vohr
dab006b1cf
ci: fix Nan test failure on Linux ( #42863 )
...
ci: Nan test failure on Linux
2024-07-11 10:47:02 -04:00
Shelley Vohr
4e10eeb87e
fix: desktopCapturer and screen source ids should match screen ids ( #42781 )
...
* fix: desktopCapturer screen source ids should match screen ids
* test: add a regression test
2024-07-10 16:32:29 -07:00
Shelley Vohr
fa6ce4f0f8
fix: High Contrast mode not working on Windows ( #42853 )
...
Closes https://github.com/electron/electron/issues/42609
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5324688
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5368321
2024-07-10 15:14:02 -07:00
Charles Kerr
f9d94211bb
refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener ( #42806 )
...
All the listener functions are empty stubs (and have been since d4e3c39
2024-07-10 15:32:50 +02:00
electron-roller[bot]
48fc352bcf
chore: bump node to v20.15.1 (main) ( #42841 )
...
* chore: bump node in DEPS to v20.15.1
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-07-10 14:52:06 +02:00
John Kleinschmidt
1a9f99b3ed
chore: speed up azcopy on src cache ( #42742 )
2024-07-09 16:20:18 -04:00
dependabot[bot]
34e7648478
build(deps): bump github/codeql-action from 3.25.10 to 3.25.11 ( #42832 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.10 to 3.25.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](23acc5c183...b611370bb5
2024-07-09 11:27:37 +02:00
dependabot[bot]
c2ea3881fc
build(deps): bump actions/upload-artifact from 4.3.3 to 4.3.4 ( #42833 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](65462800fd...0b2256b8c0
2024-07-09 11:25:07 +02:00
David Sanders
170b72ccfa
ci: fix CircleCI config ( #42829 )
...
* ci: fix CircleCI config
* ci: fix syntax error
2024-07-08 21:38:05 -04:00
Shelley Vohr
e54ffdf7ed
build: clean up BoringSSL patch ( #42730 )
2024-07-08 16:35:54 -04:00
Charles Kerr
e9db02948e
fix: multiple move() calls on the same unique_ptr ( #42788 )
2024-07-08 11:04:35 -04:00
Charles Kerr
27e3273f0a
refactor: minor electron browser context cleanup ( #42789 )
...
* refactor: make DevicePermissionMap private to electron::ElectronBrowserContext
refactor: make PartitionPath private to electron::ElectronBrowserContext
* refactor: remove unused forward declarations of v8 classes
* chore: forward declare gin::Arguments
* refactor: use unique_ptr operator bool
2024-07-08 16:49:41 +02:00
electron-appveyor-updater[bot]
e99e554655
build: update appveyor image to latest version ( #42771 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-08 12:56:52 +02:00
Charles Kerr
5ff91159cd
fix: dangling raw_ptr ElectronBrowserContext::extension_system_ ( #42785 )
...
The extension system is freed by the DestroyBrowserContextServices()
call in the destructor, so we need to zero out the pointer to avoid
a dangling raw_ptr error.
2024-07-08 12:56:03 +02:00
Charles Kerr
e89da2bad2
fix: dangling raw_ptr<Session> in UserDataLink ( #42786 )
...
* fix: dangling raw_ptr<Session> in UserDataLink
* chore: make linter happy
2024-07-08 12:55:48 +02:00
Shelley Vohr
cb2e7f130b
fix: potentially closed webContents in BrowserView ( #42633 )
2024-07-08 12:13:53 +02:00
Shelley Vohr
2f4a46f47a
fix: video and audio capture should be separate ( #42775 )
2024-07-08 10:11:40 +02:00
Shelley Vohr
ac074a5548
refactor: run Windows SelectFileDialog out of process ( #42758 )
...
* refactor: run Windows SelectFileDialog out of process
* fix: add missing IS_WIN guard
* refactor: use upstream SelectFileDialogFactory
* fix: build chrome/services/util_win/public/mojom target
2024-07-05 11:36:44 +02:00
electron-roller[bot]
19e030a6e8
chore: bump chromium to 128.0.6573.0 (main) ( #42766 )
...
* chore: bump chromium in DEPS to 128.0.6573.0
* chore: update patches
* 5665092: Remove default arguments on virtual functions in WebContents
https://chromium-review.googlesource.com/c/chromium/src/+/5665092
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-05 09:51:21 +02:00
Shelley Vohr
5bff883c40
chore: clean up outdated goma references ( #42762 )
2024-07-05 09:44:34 +02:00
Shelley Vohr
25eb1bd4b2
build: remove all publish & build on macOS ( #42763 )
2024-07-03 15:17:17 -04:00
electron-roller[bot]
07e6b34a07
chore: bump chromium to 128.0.6571.0 (main) ( #42749 )
...
* chore: bump chromium in DEPS to 128.0.6571.0
* 5636652: [4/n] Introduce RenderInputRouterClient and move InputRouterClient implementation to RenderInputRouter.
https://chromium-review.googlesource.com/c/chromium/src/+/5636652
* 5655811: Revert "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al"""
https://chromium-review.googlesource.com/c/chromium/src/+/5655811
* 5581006: [tracing] Forward startup tracing config as shmem
https://chromium-review.googlesource.com/c/chromium/src/+/5581006
* chore: fixup patch indices
* 5608450: [Views AX] Move Image Auto Captioning strings to ui/
https://chromium-review.googlesource.com/c/chromium/src/+/5608450
* 5648900: [Extensions] Move ExtensionAPIEnabledForServiceWorkerScript()
https://chromium-review.googlesource.com/c/chromium/src/+/5648900
* 5651681: Remove Web Speech API profanity masking
https://chromium-review.googlesource.com/c/chromium/src/+/5651681
* 5651361: `content::RenderFrame::GetBrowserInterfaceBroker`: return a const-ref.
https://chromium-review.googlesource.com/c/chromium/src/+/5651361
* 5604943: Start capture of toolbar after gesture end events are received
https://chromium-review.googlesource.com/c/chromium/src/+/5604943
* 5624392: [BRP] Enforce raw_ptr/ref in Renderer code
https://chromium-review.googlesource.com/c/chromium/src/+/5624392
* 5659259: Portals: Remove WebContentsView::TransferDragSecurityInfo
https://chromium-review.googlesource.com/c/chromium/src/+/5659259
* 5230721: Move ComposeStatus to components/compose
https://chromium-review.googlesource.com/c/chromium/src/+/5230721
* 5647894: [api] Cleanup usages of v8::ReturnValue<void>::Set[NonEmpty](..)
https://chromium-review.googlesource.com/c/v8/v8/+/5647894
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-03 11:15:35 -04:00
Charles Kerr
cf5fb4505e
refactor: make session::browser_context_ a const raw_ref ( #42728 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-07-02 17:53:36 -04:00
Erick Zhao
0a8eae9019
docs(autoUpdater): document static storage strategy ( #42690 )
...
* docs: `autoUpdater` static storage strategy
* summary must be followed by newline
* lint: fix whitespace for code blocks
* lint: `js` -> `javascript`
* bump
* `javascript` -> `js`
* bump
2024-07-02 19:06:38 +02:00
Erick Zhao
6cca75ac76
docs(autoUpdater): signing is only a pre-req on macOS ( #42709 )
...
docs: correctly state that signing is a pre-req for autoUpdater only on macOS
2024-07-02 19:06:25 +02:00
electron-appveyor-updater[bot]
67d7944271
build: update appveyor image to latest version ( #42748 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-07-02 10:38:43 -04:00
Shelley Vohr
1729a9868c
fix: use BlockedRequest struct to handle webRequest data ( #42647 )
...
Fixes an issue where Chromium could crash on a dangling unretained pointer in one of several webRequest functions. This was happening as a result of the fact that we had outstanding blocking requests continue to reference state owned by ProxyingWebsocket and ProxyingURLLoaderFactory after the requests were destroyed.
This had been going on for a few years, and was likely leading to some ongoing memory issues. To fix this, we need to ensure that all state is cleaned up in OnRequestWillBeDestroyed. I chose to create a new BlockedRequest struct to do so, which approximates the approach that upstream takes. The complexities of doing so also made our templated approach more trouble than it felt worth, so i pried that apart into separate handlers.
2024-07-02 14:02:49 +02:00
electron-roller[bot]
8a8241163d
chore: bump chromium to 128.0.6558.0 (main) ( #42413 )
...
* chore: bump chromium in DEPS to 127.0.6526.0
* chore: update network_service_allow_remote_certificate_verification_logic.patch
manually apply patch due to minor upstream shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5598454
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
No manual changes; patch applied with fuzz 1
* chore: update refactor_expose_file_system_access_blocklist.patch
No manual changes; patch applied with fuzz 2
* chore: update revert_heap_add_checks_position_info.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 127.0.6527.0
* chore: update patches
* chore: bump chromium in DEPS to 127.0.6529.0
* chore: bump chromium in DEPS to 127.0.6531.0
* chore: update patches
* 5596349: Remove PDF OCR toggle from settings.
https://chromium-review.googlesource.com/c/chromium/src/+/5596349
* 5585932: [video-pip] Add minimize button to video picture-in-picture window
https://chromium-review.googlesource.com/c/chromium/src/+/5585932
* 5604487: Reland "[api] Deprecate v8::FunctionCallbackInfo::Holder() for real"
https://chromium-review.googlesource.com/c/v8/v8/+/5604487
* 5581721: [DEPS] Update clang-format location
https://chromium-review.googlesource.com/c/chromium/src/+/5581721
* 5597904: [Windows] Remove ConvertToLongPath from Sandbox Utilities.
https://chromium-review.googlesource.com/c/chromium/src/+/5597904
ResolveNTFunctionPtr was removed in this CL.
* fix: visibility state specs on macOS
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5605407
* Revert "fix: visibility state specs on macOS"
This reverts commit 1eee30a33dfafeec86cdd09526a07b01abca2ed6.
* temp: disable occlusion checker on macOS
* chore: bump chromium in DEPS to 128.0.6535.0
* chore: update patches
* [Extensions] Move some scriptings files out of the API directory.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5606682
* fix[node]: do not use soon-to-be-deprecated V8 API
* fix: update api_remove_allcan_read_write.patch
* chore: update patches
* chore: update patches
* chore: fix lf mismatch in api_remove_allcan_read_write.patch
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6538.0
* chore: update v8 patches
* chore: update patches
* ui/gl/features.gni: Set use_egl=true unconditionally.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5569748
Refs https://issues.chromium.org/issues/344606399
* chore: bump chromium in DEPS to 128.0.6540.0
* chore: bump chromium in DEPS to 128.0.6541.0
* chore: update patches
* chore: fix nan read/write patch
* chore: bump chromium in DEPS to 128.0.6543.0
* 5626254: Use sandbox_type instead of process_type | https://chromium-review.googlesource.com/c/chromium/src/+/5626254
* chore: update patches
* rework nan patches
* 5621488: Apply consistent naming conventions to zoom values | https://chromium-review.googlesource.com/c/chromium/src/+/5621488
* chore: bump chromium in DEPS to 128.0.6544.0
* 5605693: Remove files from third_party/ninja | https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* chore: update patches
* chore: maybe fix nan patch, part 3
* chore: delete nan patch
* chore: re-add nan patch (attempt 2)
* chore: add test patch
* fixup! add test patch
* chore: bump chromium in DEPS to 128.0.6549.0
* chore: bump chromium in DEPS to 128.0.6551.0
* 5637699: Add command line to ASAN Additional Info section | https://chromium-review.googlesource.com/c/chromium/src/+/5637699
* chore: update patches
* chore: bump chromium in DEPS to 128.0.6553.0
* chore: bump chromium in DEPS to 128.0.6555.0
* fix: add property query interceptors
* chore: bump chromium in DEPS to 128.0.6557.0
* 5583182: Automatic Fullscreen: Prototype Permissions API query support | https://chromium-review.googlesource.com/c/chromium/src/+/5583182
* 5613297: Move render input router and related dependencies to //components/input | https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* chore: update patches
* test: skip methodswithdata-test.js nan test
* chore: bump chromium in DEPS to 128.0.6558.0
* chore: update patches
* build: reference correct ninja cipd ref
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5605693
* update libcxx filenames
* refactor: CursorManager moved to //components/input
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5613297
* refactor: spanify mojo Read/WriteData methods
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5619291
* refactor: remove constexpr from KeyboardCodeFromKeyIdentifier
Ref: unknown
Added TODO to investigate after
* chore: update patches
* refactor: improve type safety of a11y ids
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5614590
* chore: disable tls node tests that don't apply given boringssl tls configuration
Ref: https://boringssl-review.googlesource.com/c/boringssl/+/68487
* chore: add patch to fix nan v8 incompat with NamedPropertyHandlerConfiguration and IndexedPropertyHandlerConfiguration
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/5630388
* fix: limit subspan length per feedback
* Fix incorrect CalculateInsetsInDIP check
* 5645742: Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""
https://chromium-review.googlesource.com/c/chromium/src/+/5645742
* chore: more Windows logging
* 5617471: Add NPU blocking to chromium blocklist
https://chromium-review.googlesource.com/c/chromium/src/+/5617471
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-02 09:51:33 +02:00
Anny Yang
14303a0a71
docs: grammar fix in isBeingCaptured docs ( #42692 )
2024-07-01 15:01:27 -04:00
Chris Stringer
2b5342cb49
docs - Update net.md ( #42691 )
...
Update net.md
Changes heading level for net.resolveHost() entry to H3
2024-07-01 14:45:49 -04:00
Alice Zhao
e9a93a8c5c
fix: setTopBrowserView focus issue with reordering ( #42653 )
...
* fix: reorder top browser view instead of adding/removing
* fix: update browserViews order
* test: add a test for setTopBrowserView
2024-07-01 11:36:04 +02:00
Keeley Hammond
efff369639
build: remove MacOS x64 from CircleCI ( #42718 )
2024-07-01 11:34:37 +02:00
Keeley Hammond
3ac57e17d5
build: fix clang format/lint ( #42715 )
...
* build: fix clang format path
* fix: use gclient sync instead of gclient runhooks
Refs https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5659261
* fix: use gclient sync instead of gclient runhooks in GHA
---------
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2024-06-28 13:30:07 -07:00
Shelley Vohr
398dde9dfb
build: use inputs for target_arch in build ( #42684 )
2024-06-27 08:11:10 -07:00
Shelley Vohr
32e5012017
feat: enable Windows Control Overlay on Linux ( #41769 )
2024-06-27 14:56:36 +02:00
David Sanders
1d4b00692d
build: bump version in .nvmrc to 20 ( #42668 )
2024-06-27 13:46:11 +02:00
electron-roller[bot]
ec24b51808
chore: bump node to v20.15.0 (main) ( #42616 )
...
* chore: bump node in DEPS to v20.15.0
* doc: Add OpenSSL errors to API docs
https://github.com/nodejs/node/pull/34213
* test: crypto-rsa-dsa testing for dynamic openssl
https://github.com/nodejs/node/pull/52781
* src: allow preventing debug signal handler start
https://github.com/nodejs/node/pull/46681
* cli: allow running wasm in limited vmemory with --disable-wasm-trap-handler
https://github.com/nodejs/node/pull/52766
* chore: fixup indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-06-27 13:34:39 +02:00
Shelley Vohr
c628de52d9
fix: defaultPath should apply on all dialog types in Linux Portal ( #42655 )
...
fix: defaultPath should apply on all dialog types in Linux Portal dialogs
2024-06-27 11:07:26 +02:00
Shelley Vohr
2b31d8459d
fix: param passed to showSaveDialogSync on Linux ( #42652 )
...
fix: pass correct param to sync functions on Linux
2024-06-27 10:23:18 +02:00
Keeley Hammond
912706b23a
build: strip linux release binaries ( #42675 )
2024-06-26 17:41:36 -07:00
Samuel Attard
b31acfb706
docs: clarify security semantics of safeStorage ( #42666 )
...
* docs: clarify security semantics of safeStorage
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* Update safe-storage.md
* Update safe-storage.md
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2024-06-26 13:24:06 -07:00
Shelley Vohr
607b9b8f11
build: clean up upload-index-json error handling ( #42657 )
2024-06-26 09:25:58 -07:00
Keeley Hammond
a8baa6f1ad
build: remove CircleCI from release pipeline ( #42651 )
...
* build: remove CircleCI from release pipeline
* build: remove IS_GHA_RELEASE and CHECK_DIST_MANIFEST
2024-06-25 14:25:04 -07:00
Shelley Vohr
3534923bd2
build: account for subjectAndDescription null in patch linting ( #42636 )
...
fix: account for subjectAndDescription null in patch linting
2024-06-24 22:32:43 -07:00
Keeley Hammond
66b8b79229
build: turn on GitHub Actions by default for all branches and pull requests ( #42623 )
...
* build: turn GitHub Actions on by default for push and pull_request
* build: try env var build-image-sha
* build: use ternery for input vs default
* build: pain
* build: modify setup to cascade build-image-sha
* build: move outputs into setup step
* build: add SAS key generation on re-run
* build: only build on push, not pull_request
* build: only build on push for main & release branches, build on PR for everything else
* build: rebase with main, handle asan build
* build: add exit 1, sha value
2024-06-24 12:06:13 +02:00
Corbin Crutchley
243be0a638
docs: fix typo in ASAR integrity docs ( #42538 )
...
Fix typo in ASAR integrity docs
2024-06-22 20:26:23 +02:00
Charles Kerr
24d6c28b5a
chore: remove walkdir dev dependency ( #42591 )
2024-06-21 10:31:10 -04:00
George Xu
ba8ad4716b
feat: expose system preferences to utility process ( #42203 )
...
* chore: expose system preferences to utility process
* chore: add tests, doc changes and module-list update
* relative link
* use @
* fix test
* chore: disable linux test
* kick
* noop on windows utility process
2024-06-20 11:15:57 -04:00
