Jeremy Rose
b9464d89b8
fix: remove undocumented feature and flaky test for webview resize event ( #36154 )
2022-10-27 16:44:53 -07:00
daief
ff4816367e
refactor: handle uncaught promise error ( #35484 )
2022-10-27 16:16:26 +09:00
Jeremy Rose
625b4619d6
fix: resolve loadURL properly for in-page navigations ( #36129 )
2022-10-26 13:57:39 -07:00
Robo
da0fd286b4
feat: UtilityProcess API ( #34980 )
...
* chore: initial scaffolding
* chore: implement interface and docs
* chore: address code style review
* fix: cleanup of utility process on shutdown
* chore: simplify NodeBindings::CreateEnvironment
* chore: rename disableLibraryValidation => allowLoadingUnsignedLibraries
* chore: implement process.parentPort
* chore(posix): implement stdio pipe interface
* chore(win): implement stdio interface
* chore: reenable SetNodeOptions for utility process
* chore: add specs
* chore: fix lint
* fix: update kill API
* fix: update process.parentPort API
* fix: exit event
* docs: update exit event
* fix: tests on linux
* chore: expand on some comments
* fix: shutdown of pipe reader
Avoid logging since it is always the case that reader end of
pipe will terminate after the child process.
* fix: remove exit code check for crash spec
* fix: rm PR_SET_NO_NEW_PRIVS for unsandbox utility process
* chore: fix incorrect rebase
* fix: address review feedback
* chore: rename utility_process -> utility
* chore: update docs
* chore: cleanup c++ implemantation
* fix: leak in NodeServiceHost impl
* chore: minor cleanup
* chore: cleanup JS implementation
* chore: flip default stdio to inherit
* fix: some api improvements
* Support cwd option
* Remove path restriction for modulePath
* Rewire impl for env support
* fix: add tests for cwd and env option
* chore: alt impl for reading stdio handles
* chore: support message queuing
* chore: fix lint
* chore: new UtilityProcess => utilityProcess.fork
* fix: support for uncaught exception exits
* chore: remove process.execArgv as default
* fix: windows build
* fix: style changes
* fix: docs and style changes
* chore: update patches
* spec: disable flaky test on win32 arm CI
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-10-19 22:49:49 -07:00
Yusoo
dde513b0d3
fix: printToPDF default margins ( #36060 )
...
printToPDF default margins
The document printToPDF has a 1cm margin and this default value has been added in the code.
2022-10-19 10:16:28 +02:00
Shelley Vohr
ee7cf5a6d4
fix: webContents.printToPDF option plumbing ( #35975 )
...
fix: contents.printToPDF option plumbing
2022-10-11 16:06:34 -07:00
Darshan Sen
7493062555
test: add tests for valid electron module names ( #35931 )
...
* test: add tests for valid electron module names
https://github.com/electron/electron/pull/35915 landed without any
tests, so this change adds some. This also documents why these
variations exist.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
* fixup! doc: rephrase comment
Signed-off-by: Darshan Sen <raisinten@gmail.com>
* fixup! test: remove "Uncaught Error:" from error regex
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Signed-off-by: Darshan Sen <raisinten@gmail.com>
2022-10-11 15:59:23 +09:00
Samuel Attard
e31c96a564
fix: only override valid electron module names ( #35915 )
...
Fixes #33014
2022-10-06 19:14:03 +09:00
Jeremy Rose
f82a863f65
feat: replace scroll-touch* with generic input-event ( #35531 )
2022-09-27 12:47:46 -07:00
Samuel Maddock
c09c94fc98
feat: add WebContents.opener and webContents.fromFrame() ( #35140 )
...
* feat: add WebContents.opener
* feat: add webContents.fromFrame(frame)
* fix: unknown type name
* test: fix and add more fromFrame cases
* docs: clarified terminology
2022-09-26 12:37:08 -04:00
Milan Burda
f62aab76b3
fix: potential exception when calling webFrameMainBinding.fromIdOrNull() ( #35785 )
...
* fix: potential exception when calling webFrameMainBinding.fromIdOrNull()
* replace try/catch in getWebFrameForEvent
Co-authored-by: Milan Burda <miburda@microsoft.com>
2022-09-24 12:19:07 -07:00
Akshay Deo
dfc134de42
feat: add exposeInIsolatedWorld(worldId, key, api) to contextBridge ( #34974 )
...
* feat: add exposeInIsolatedWorld(worldId, key, api) to contextBridge
* Updates exposeInIslatedWorld worldId documentation
2022-09-21 13:17:10 -05:00
Milan Burda
99f4a42d41
chore: add missing .eslintrc.json files to limit imports properly ( #35719 )
2022-09-20 13:25:33 -05:00
Milan Burda
b3a744db8a
fix: potential "Object has been destroyed" error in BrowserWindow.getFocusedWindow ( #35520 )
2022-09-12 14:46:05 -07:00
electron-roller[bot]
d0e220cbce
chore: bump node to v16.17.0 (main) ( #35350 )
...
* chore: bump node in DEPS to v16.17.0
* chore: fixup asar patch
* lib: use null-prototype objects for property descriptors
https://github.com/nodejs/node/pull/43270
* src: make SecureContext fields private
https://github.com/nodejs/node/pull/43173
* crypto: remove Node.js-specific webcrypto extensions
https://github.com/nodejs/node/pull/43310
* test: refactor to top-level await
https://github.com/nodejs/node/pull/43500
* deps: cherry-pick two libuv fixes
https://github.com/nodejs/node/pull/43950
* src: slim down env-inl.h
https://github.com/nodejs/node/pull/43745
* util: add AggregateError.prototype.errors to inspect output
https://github.com/nodejs/node/pull/43646
* esm: improve performance & tidy tests
https://github.com/nodejs/node/pull/43784
* src: NodeArrayBufferAllocator delegates to v8's allocator
https://github.com/nodejs/node/pull/43594
* chore: update patch indices
* chore: update filenames
* src: refactor IsSupportedAuthenticatedMode
https://github.com/nodejs/node/pull/42368
* src: add --openssl-legacy-provider option
https://github.com/nodejs/node/pull/40478
* lib,src: add source map support for global eval
https://github.com/nodejs/node/pull/43428
* trace_events: trace net connect event
https://github.com/nodejs/node/pull/43903
* deps: update ICU to 71.1
https://github.com/nodejs/node/pull/42655
This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093
* lib: give names to promisified exists() and question()
https://github.com/nodejs/node/pull/43218
* crypto: add CFRG curves to Web Crypto API
https://github.com/nodejs/node/pull/42507
* src: fix memory leak for v8.serialize
https://github.com/nodejs/node/pull/42695
This test does not work for Electron as they do not use V8's
ArrayBufferAllocator.
* buffer: fix atob input validation
https://github.com/nodejs/node/pull/42539
* src: fix ssize_t error from nghttp2.h
https://github.com/nodejs/node/pull/44393
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2022-08-29 09:55:36 -04:00
Milan Burda
e85450b21a
fix: IPC emit order in -ipc-ports handler ( #35320 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2022-08-16 11:21:56 +09:00
Milan Burda
8424779906
refactor: don't expose deprecate as an internal module ( #35311 )
2022-08-15 17:09:33 +09:00
Milan Burda
8646bf8d30
chore: remove deprecated 'new-window' event ( #34526 )
2022-08-09 17:57:05 -04:00
Milan Burda
34b985c556
refactor: use optional chaining / nullish coalescing operator ( #35217 )
2022-08-08 10:11:04 +02:00
Jeremy Rose
6d859dcd7f
feat: add WebContents.ipc ( #34959 )
2022-08-03 16:55:12 -07:00
Jeremy Rose
3c63f075bd
chore: remove unused WebContents._sendToFrameInternal ( #35010 )
2022-07-21 10:25:54 -07:00
Milan Burda
d4e97483aa
refactor: only create webContents after 'will-attach-webview' ( #32941 )
2022-07-21 11:29:31 +02:00
Joan Xie
afd08c9450
feat: Enable APNS registration + notification delivery in macOS apps ( #33574 )
2022-07-12 08:38:49 -07:00
David Sanders
c418275228
chore: update Discord invite links ( #34730 )
2022-07-05 11:55:15 -04:00
David Sanders
98cd16d336
chore: fix typos ( #34731 )
2022-07-05 11:49:56 -04:00
Milan Burda
ba4893c248
refactor: load webFrame via process._linkedBinding in security-warnings.ts ( #34735 )
2022-06-27 10:28:35 +02:00
Milan Burda
f172136752
chore: remove undocumented page-title-set webview event ( #34533 )
2022-06-22 17:18:42 +09:00
Milan Burda
f3f327823e
chore: move main process only accessible API bindings away from common ( #34634 )
2022-06-21 16:34:56 +09:00
Milan Burda
0f528c1e43
chore: let result: ReturnType<typeof this._callWindowOpenHandler>; ( #34628 )
2022-06-21 10:39:41 +09:00
Josh Soref
ea4278754c
chore: fix spelling errors in multiple files ( #34574 )
...
* chore: fix spelling in .circleci
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in BUILD.gn
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in appveyor.yml
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in build
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in docs
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in lib
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in script
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in shell
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in spec
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in spec-main
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-06-16 16:46:11 +09:00
Milan Burda
f418a49857
chore: warn when using the deprecated new-window event ( #34528 )
2022-06-15 18:17:42 -07:00
Jeremy Rose
bad8d5e08a
fix: make preload calculation identical between sandbox & non-sandboxed ( #34531 )
2022-06-15 13:22:28 -07:00
Shelley Vohr
bed38e0985
fix: crash when setWindowOpenHandler callback throws ( #34523 )
...
* fix: crash when setWindowOpenHandler throws
* refactor: throw as process uncaughtException event
2022-06-14 12:22:23 -04:00
Shelley Vohr
93b39b92b5
refactor: printToPDF should be headless ( #33654 )
2022-05-31 08:21:25 +02:00
Milan Burda
9d3fc9c794
refactor: return options directly in makeBrowserWindowOptions() helper ( #34309 )
2022-05-24 10:23:16 +02:00
Shelley Vohr
dd6ce91f57
fix: call loadUrl when opening new windows from links ( #34159 )
...
* fix: call loadUrl when opening new windows from links
* spec: add regression test
2022-05-11 11:34:33 -07:00
Milan Burda
2091343b78
refactor: initialize member variables directly ( #34046 )
2022-05-04 16:30:05 +02:00
Robo
16f8d713ab
fix: apply senderFrame details to ipcMain port event ( #33756 )
2022-04-13 21:01:00 -07:00
electron-roller[bot]
59dd17f2cf
chore: bump chromium to 102.0.4989.0 (main) ( #33557 )
...
* chore: bump chromium in DEPS to 102.0.4975.0
* chore: bump chromium in DEPS to 102.0.4977.0
* chore: update patches
* Remove parameter of OnGpuProcessCrashed()
https://chromium-review.googlesource.com/c/chromium/src/+/3543396
* hid: Add exclusionFilters option to requestDevice
https://chromium-review.googlesource.com/c/chromium/src/+/3478175
* chore: bump chromium in DEPS to 102.0.4979.0
* chore: bump chromium in DEPS to 102.0.4981.0
* chore: update patches
* Deny notification/push permission for documents in non-standard StoragePartitions
https://chromium-review.googlesource.com/c/chromium/src/+/3257305
* Improve FrameTreeNode tracking in URLLoaderNetworkContext
https://chromium-review.googlesource.com/c/chromium/src/+/3341866
* fixup! Remove parameter of OnGpuProcessCrashed()
* chore: fix lint
* Reland "Use gfx::Insets[F]::TLBR() and gfx::Insets[F]::VH() in the rest of Chrome"
https://chromium-review.googlesource.com/c/chromium/src/+/3554236
* chore: bump chromium in DEPS to 102.0.4983.0
* Ensure EyeDropperView does not access a destroyed window
https://chromium-review.googlesource.com/c/chromium/src/+/3561542
* ci: don't delete dawn .git directory
83901: Adds a generated file with the dawn git hash encoded at build time. | https://dawn-review.googlesource.com/c/dawn/+/83901
* ci: update Windows toolchain
3550827: New toolchain for Windows 10 20348 SDK | https://chromium-review.googlesource.com/c/chromium/src/+/3550827
* chore: bump chromium in DEPS to 102.0.4985.0
* chore: update patches
* chore: bump chromium in DEPS to 102.0.4987.0
* chore: update patches
* 3563432: codehealth: remove uses of DictionaryValue in cbui/webui
https://chromium-review.googlesource.com/c/chromium/src/+/3563432
* chore: update patches after rebase
* Use gfx::Insets[F]::TLBR() and gfx::Insets[F]::VH() in the rest of Chrome
https://chromium-review.googlesource.com/c/chromium/src/+/3554236
* 3565724: Preserve "proper method names" as-is in error.stack.
https://chromium-review.googlesource.com/c/v8/v8/+/3565724
* chore: bump chromium in DEPS to 102.0.4989.0
* chore: update patches
* fixup ci: don't delete dawn .git directory for Windows
* 3560843: Remove multi-parameter version of gfx::Rect[F]::Inset()
https://chromium-review.googlesource.com/c/chromium/src/+/3560843
* 3572711: Remove unused IDS_PDF_TOOLTIP_ROTATE_CW resource.
https://chromium-review.googlesource.com/c/chromium/src/+/3572711
* 3572926: Reland "[Sysroot] Switch to Debian Bullseye stable"
https://chromium-review.googlesource.com/c/chromium/src/+/3572926
* build: fixup sysroots with electron specific dependencies
* fixup Remove multi-parameter version of gfx::Rect[F]::Inset()
* fixup 3565724: Preserve "proper method names" as-is in error.stack.
* fixup Remove multi-parameter version of gfx::Rect[F]::Inset()
* test: add spec for navigator.hid.requestDevice({ exclusionFilters: [...] }
* fixup 3565724: Preserve "proper method names" as-is in error.stack.
* ci: use python3 to get the windows toolchain profile
3525960: Explicitly run everything with python3 | https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3525960
* chore: add diagnostic logging
* fix: try calling process.crash()
* chore: remove logging
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2022-04-12 13:19:14 +02:00
Shelley Vohr
d1ea62c3e8
fix: getting focused window with destroyed webContents ( #33404 )
...
* fix: getting focused window with destroyed webContents
* fix: add extra safeguards
2022-03-29 12:22:58 -04:00
Calvin
594dc7e24a
chore: update node types version ( #33452 )
...
* chore: update node types version
* update express types to solve type conflict
* one more yarn.lock type bump
* update another types package to fix incompatible global declarations
* remove incompatible type magicks
* update our ambient types to match the node types
* fix test type
2022-03-28 14:37:35 -07:00
Fedor Indutny
06a00b74e8
fix: initialize asar support in worker threads ( #33216 )
...
* fix: initialize asar support in worker threads
Use `ObjectWrap` instead of gin's Wrap in `electron_api_asar.cc` because
gin isn't fully initialized (and apparently not possible to initialize
without ruining the isolate configuration and array buffer allocator) in
worker threads. In the worker thread call `setupAsarSupport` just as we
do for the main process.
* Update lib/asar/fs-wrapper.ts
Co-authored-by: Darshan Sen <raisinten@gmail.com>
* Update patches/node/worker_thread_add_asar_support.patch
Co-authored-by: Darshan Sen <raisinten@gmail.com>
* Add a test
Co-authored-by: Darshan Sen <raisinten@gmail.com>
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2022-03-22 20:37:55 -04:00
David Sanders
df8fd1b269
build: fix build by removing usage of removed preloadUrl ( #33319 )
2022-03-17 00:13:48 -07:00
Jeremy Rose
4342b7ff55
chore: remove awkward semi-documented preloadURL WebPreference ( #33228 )
2022-03-16 16:23:41 -07:00
Jeremy Rose
27527fe5ca
feat: warn that preloads will be sandboxed by default in v20 ( #32868 )
2022-03-08 15:39:53 -08:00
t57ser
41b2945ced
feat: add ability to configure if window should close when opener closes ( #31314 )
...
* feat: Added ability to configure if window should close when opener closes
* fix: check if embedder is destroyed
* fix: correctly take over closeWithOpener property
* chore: Added documentation
* Update docs/api/window-open.md
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
* chore: refactor
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* chore: changed property name from `closeWithOpener` to `outlivesOpener`
* dummy change to kick lint
* undo above
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2022-02-23 16:59:50 +09:00
David Sanders
1e8da899a3
chore: fix typos ( #32985 )
2022-02-21 10:27:45 +01:00
Milan Burda
db9ab80694
chore: update to latest TypeScript ( #32596 )
2022-01-31 20:37:40 +09:00
Matthew Rayermann
d26d337bb8
feat: add rawHeaders to IncomingMessage ( #31853 )
...
* Add response.rawHeaders to docs for IncomingMessage
* Remove trailing spaces
* Implement raw headers, add tests
* Fix lint issues
* Add example from NodeJS docs
* Fix lint issue in doc example
* Add missing #
2022-01-24 11:46:15 -05:00
Milan Burda
99ee1fc0eb
fix: will-attach-webview handler modifying params.instanceId does not break <webview> ( #32386 )
2022-01-12 16:41:20 +09:00
