Commit graph

28368 commits

Author SHA1 Message Date
trop[bot]
0a4b0de4f7
fix: ensure SetPluginCanSave updated in PDFs (#44020)
fix: ensure SetPluginCanSave updated in PDFs

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-30 14:52:14 +02:00
trop[bot]
c895d45a6d
ci: write test logging to console on Windows (#44006)
test: write logging to console on Windows

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-29 10:13:04 +02:00
trop[bot]
60e0355b73
fix: remove resize listener when BrowserWindow closed (#43999)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-27 14:46:03 -04:00
trop[bot]
6010fda0c7
perf: build g_dgettext domain name at compile time (#43986)
perf: build GettextPackage name at compile time

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 18:59:06 -05:00
trop[bot]
514fc26eb2
fix: replace deprecated libnotify API calls (#43982)
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.

Xref: 2fe1748295

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 17:08:12 -05:00
dependabot[bot]
af9969a3ff
build(deps): bump slackapi/slack-github-action from 1.25.0 to 1.27.0 (#43907)
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 1.25.0 to 1.27.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases)
- [Commits](6c661ce588...37ebaef184)

---
updated-dependencies:
- dependency-name: slackapi/slack-github-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-26 11:56:20 -04:00
trop[bot]
328afb8a09
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() (#43981)
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: don't change previous behavior for 0-height images

Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 10:55:35 -05:00
trop[bot]
a66e01b555
test: add tests dbus notification images (#43965)
Provide a NativeImage icon in the notification tests and then inspect
the DBus message payload's `image_data` hint to see if it's correct.
This adds test coverage for LibnotifyNotification::Show() and for
GdkPixbufFromSkBitmap().

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 09:56:22 -04:00
trop[bot]
e99de2b5c6
test: ensure sender-pid hint is set in Linux notifications (#43951)
test: expect a `sender-pid` hint in Linux notifications.

This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.

This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.

By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 14:02:07 -05:00
trop[bot]
6c1233a7d2
fix: close all open sheets before closing window on macOS (#43953)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <beutner.john@gmail.com>
2024-09-25 13:09:40 -05:00
dependabot[bot]
3c7a49fdb1
build(deps): bump actions/upload-artifact from 4.3.1 to 4.4.0 (#43910)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.1 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.1...50769540e7f4bd5e21e526ee35c689e35e0d6874)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 12:14:21 -05:00
trop[bot]
d241d1f3b3
refactor: remove C-style void arg type for no-arg functions (#43942)
refactor: remove C-style void arg type for no-arg functions (#43884)

A small cleanup to remove use of the C-style function declaration idiom.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 12:13:22 -05:00
dependabot[bot]
1495f01e2e
build(deps): bump mikefarah/yq from 4.40.7 to 4.44.3 (#43909)
Bumps [mikefarah/yq](https://github.com/mikefarah/yq) from 4.40.7 to 4.44.3.
- [Release notes](https://github.com/mikefarah/yq/releases)
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt)
- [Commits](bb66c9c872...bbdd97482f)

---
updated-dependencies:
- dependency-name: mikefarah/yq
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-25 11:45:58 -05:00
trop[bot]
ad82142eb0
fix: detach native view when its removed from parent on macOS (#43924)
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cezary Kulakowski <cezary@openfin.co>
2024-09-25 13:17:47 +02:00
trop[bot]
a5f4f08a9e
fix: crash when focusing WebView webContents (#43933)
fix: crash when focusing WebView

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-25 06:17:06 -05:00
trop[bot]
d8e3555e01
fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() (#43929)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 11:21:44 +02:00
Charles Kerr
f15fea8d03
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (31-x-y) (#43926)
* fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (#43803)

* empty commit
2024-09-25 11:21:15 +02:00
dependabot[bot]
615825f40e
build(deps): bump dsanders11/project-actions from 1.2.0 to 1.3.0 (#43906)
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/dsanders11/project-actions/releases)
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json)
- [Commits](82e99438bd...eb760c4889)

---
updated-dependencies:
- dependency-name: dsanders11/project-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-24 16:06:34 -05:00
dependabot[bot]
67590867c1
build(deps): bump actions/setup-node from 4.0.2 to 4.0.4 (#43908)
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.2 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](60edb5dd54...0a44ba7841)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 23:26:21 -07:00
trop[bot]
f387325079
fix: EyeDropper working in devtools (31-x-y) (#43895)
fix: EyeDropper working in devtools (#43685)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-23 22:36:18 -07:00
Samuel Attard
4e5de0ca44
build: add support for fetching github token from sudowoodo (#43888)
build: add support for fetching github token from sudowoodo (#43808)

* build: add support for fetching github token from sudowoodo

* chore: update release notes cache for tests

* build: support nightlies repo correctly

* build: post token
2024-09-23 13:56:29 -07:00
Shelley Vohr
2cc8a33f11
fix: createWindow shouldn't load URL for webContents (#43878) 2024-09-23 21:55:17 +02:00
dependabot[bot]
ec63fbf0b1
build(deps): bump actions/download-artifact from 4.1.7 to 4.1.8 (#43845)
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](65a9edc588...fa0a91b85d)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:55:47 -07:00
dependabot[bot]
5aaf470e78
build(deps): bump actions-cool/issues-helper from 3.3.3 to 3.6.0 (#43843)
Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper) from 3.3.3 to 3.6.0.
- [Release notes](https://github.com/actions-cool/issues-helper/releases)
- [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md)
- [Commits](275328970d...a610082f8a)

---
updated-dependencies:
- dependency-name: actions-cool/issues-helper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:55:31 -07:00
dependabot[bot]
a164109d50
build(deps): bump actions/checkout from 4.1.1 to 4.1.7 (#43839)
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v4.1.1...692973e3d937129bcbf40652eb9f2f61becf3332)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:54:12 -07:00
dependabot[bot]
6652a3e05c
build(deps): bump dsanders11/github-app-commit-action from 1.1.0 to 1.5.0 (#43833)
build(deps): bump dsanders11/github-app-commit-action

Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action) from 1.1.0 to 1.5.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases)
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json)
- [Commits](1dd0a2d22c...43de6da2f4)

---
updated-dependencies:
- dependency-name: dsanders11/github-app-commit-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:50:46 -07:00
dependabot[bot]
7fdf729ca2
build(deps): bump github/codeql-action from 3.24.0 to 3.26.8 (#43831)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.0 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](e8893c57a1...294a9d9291)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:49:52 -07:00
trop[bot]
334a3fbea6
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() (#43812)
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: add a DCHECK to confirm the BigBuffer is full

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-20 08:48:00 -05:00
trop[bot]
568314240e
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> (#43805)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-20 00:18:21 -05:00
Charles Kerr
48805ee46e
refactor: remove use of deprecated API BuildServiceInstanceFor() (31-x-y) (#43782)
refactor: remove use of deprecated API BuildServiceInstanceFor() (#43690)

* refactor: update BadgeManagerFactory

* refactor: update NetworkContextServiceFactory

* refactor: update ElectronExtensionSystemFactory

* refactor: update UsbChooserContextFactory

* refactor: update UsbHidChooserContextFactory

* refactor: update SerialChooserContextFactory

* refactor: update FileSystemAccessPermissionContextFactory
2024-09-19 10:01:00 +02:00
Charles Kerr
e62c322b2d
refactor: declare gin::Wrapper subclasses as final (#43783)
refactor: declare gin::Wrapper subclasses as final (#43527)

As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
2024-09-19 09:57:24 +02:00
trop[bot]
ea3c48e7c1
build: let darwin/mas run concurrently (#43790)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-18 16:36:24 -07:00
trop[bot]
062d3b8161
build: split darwin/mas macOS publish jobs (#43765)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-17 20:07:40 -07:00
trop[bot]
d519913bfa
build: improve logging on http errors during release process (#43760)
* build: improve logging on http errors during release process (#43756)

Co-authored-by: Samuel Attard <sam@electronjs.org>

* build: improve logging on http errors during release process (again) (#43757)

Co-authored-by: Samuel Attard <sam@electronjs.org>

* build: improve logging on http errors during release process (again, but more) (#43758)

Co-authored-by: Samuel Attard <sam@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sam@electronjs.org>
2024-09-17 20:05:56 -07:00
trop[bot]
c5e1a336f2
fix: resizing border on Linux WCO caption buttons (#43745)
Closes https://github.com/electron/electron/issues/43714.

Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-17 21:54:10 +02:00
trop[bot]
0846294d70
fix: in Emit(), don't leak converted Arg Local<Values> into caller's scope (#43748)
fix: Emit() should not leak converted arg handles into caller's HandleScope

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-17 14:40:13 -05:00
trop[bot]
c481be0028
ci: move Archaeologist to GHA (#43734)
* chore: move Archaeologist to GHA

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* chore: test archaelogist changes

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* Revert "chore: test archaelogist changes"

This reverts commit a575d6ef3a6495a71c03e9e2d15ec9bb329c5033.

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* chore: properly name steps in archaeologist-dig

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-17 11:49:51 -04:00
trop[bot]
ca2a30c484
docs: document View.removeChildView edge case (#43727)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2024-09-16 12:52:58 +02:00
trop[bot]
ee572aac74
refactor: avoid minor code repetition in native_image.cc (#43702)
chore: delegate handle creation in NativeImage::Resize()

chore: delegate handle creation in NativeImage::Crop()

chore: delegate handle creation in NativeImage::CreateEmpty()

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-12 20:13:39 +02:00
trop[bot]
f93cc252ba
fix: native View wrapper crash missing when adding child view (#43697)
fix: native View wrapper crash missing when adding child view

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-12 19:20:47 +02:00
trop[bot]
87f5d788c0
fix: -Wunsafe-buffer-usage warning in V8Serializer::Serialize() (#43674)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-10 22:18:31 -05:00
trop[bot]
99416b8576
perf: use v8::Local<v8::Object> as the key in ObjectCache (#43672)
* perf: use v8::Object* as direct keys instead of using hash + a linked list

* refactor: use v8::Local<v8::Object> as the key

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-10 15:43:44 -05:00
trop[bot]
2c3416627f
fix: restore Chromium default Content-Disposition header parsing (#43669)
* fix: restore Chromium default Content-Disposition header parsing

Co-authored-by: Milan Burda <milan.burda@gmail.com>

* Update api-web-request-spec.ts

Co-authored-by: Milan Burda <milan.burda@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2024-09-10 13:27:22 -04:00
trop[bot]
54899c3b4b
docs: update window customization tutorial (#43661)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-09-10 10:12:11 +02:00
trop[bot]
f292be6630
build: fix patchup logic only running on one platform (#43656)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-10 09:58:44 +02:00
trop[bot]
43687aca8a
fix: ensure bounds stability in OnWidgetBoundsChanged (#43658)
fix: ensure bounds stability in OnWidgetBoundsChanged

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-09 21:56:42 -05:00
trop[bot]
96fe03b200
test: add -pdf-ready-to-print event to WebContents for testing (#43651)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-09 21:56:16 -05:00
trop[bot]
4b5d29201c
chore: remove unused ConvertableToTraceFormatWrapper (#43653)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-09 21:55:42 -05:00
trop[bot]
f6bc0b0953
fix: -Wunsafe-buffer-usage warnings in asar file IO (#43649)
* fix: -Wunsafe-buffer-usage warnings in ScopedTemporaryFile::InitFromFile()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fix: -Wunsafe-buffer-usage warnings in Archive::Init()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-09 17:58:41 -05:00
trop[bot]
e4113ddd69
fix: out-of-scope Local handle in node::CallbackScope (#43641)
refactor: use an EscapableHandleScope

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-09 17:23:16 -05:00