Samuel Attard
08066581b0
fix: set cancelId to 1 when defaultId == 0 and no 'cancel' button ( #17123 )
2019-02-27 08:24:13 +00:00
Shelley Vohr
d9c7735a04
chore: augment promisifyMultiArg deprecation ( #17066 )
2019-02-25 18:25:25 -08:00
Thomas Beverley
1674388028
Fix webContents.print() ( #17052 )
2019-02-25 13:30:21 +00:00
ZYSzys
a40d826b11
chore: remove unused catch bindings ( #16121 )
2019-02-21 09:26:07 +00:00
Shelley Vohr
3edc497d3d
feat: show user gesture type in click event ( #16954 )
2019-02-20 12:20:24 +00:00
Milan Burda
7e7abc28f5
feat: promisify netLog.stopLogging ( #16862 )
2019-02-19 10:48:27 +00:00
Samuel Attard
5790869a3f
chore: refactor browser IPC into TS and app API into TS ( #16921 )
...
* chore: refactor browser IPC into typescript
* chore: refactor app.ts into Typescript
* Refactors app.dock into cpp
* Removes app.launcher which has not existed for 3 years
* Removes 2 deprecated APIs (that have been deprecated for more than one
major)
* Refactors deprecate.ts as well
2019-02-14 14:29:20 -08:00
deepak1556
005b7d8099
Print Preview: Add validity check for kSettingPagesPerSheet.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1381133
2019-02-14 23:59:25 +05:30
deepak1556
547add94d0
Make //ui/base/idle API synchronous
...
https://chromium-review.googlesource.com/c/chromium/src/+/1379183
2019-02-14 23:59:23 +05:30
Shelley Vohr
de27911661
feat: promisify webContents.savePage() ( #16742 )
...
* feat: promisify webContents.savePage()
* no need to make compatible w callbacks, we're breaking it
* fix promise resolve type
* address feedback from review
* fix promise return text
* update smoke test
2019-02-14 09:03:28 -08:00
Milan Burda
2492f0bcac
refactor: promisify prototype methods ( #16935 )
2019-02-14 03:40:24 -10:00
Shelley Vohr
fed5b99a9f
feat: promisify contentTracing.getTraceBufferUsage() ( #16600 )
...
* feat: promsify contentTracing.getTraceBufferUsage()
* deprecate getTraceBufferUsage
* address feedback from review
* properly deprecate
2019-02-13 13:24:57 -08:00
Milan Burda
1f458eb177
feat: promisify debugger.sendCommand() ( #16861 )
...
* remove duplicate entry for desktopCapturer.getSources
* feat: promisify debugger.sendCommand
2019-02-13 07:23:53 -10:00
Samuel Attard
01c442de64
refactor: convert more files to typescript ( #16820 )
2019-02-12 04:22:33 -10:00
Milan Burda
d8ba1278d1
chore: disable the remote module in devtools / chrome extension background scripts ( #16866 )
...
* cache isRemoteModuleEnabled
* chore: disable the remote module in devtools / chrome extension background scripts
2019-02-11 10:42:37 -10:00
Milan Burda
36ce3e9546
feat: promisify webContents.printToPDF() ( #16795 )
2019-02-11 09:20:04 -10:00
Shelley Vohr
858781ba83
feat: allow Menu.buildFromTemplate() to accept MenuItems ( #16697 )
...
* feat: allow Menu.buildFromTemplate to accept MenuItems
* add another spec
* fix linter error
* add submenu spec
2019-02-06 10:04:40 -08:00
Milan Burda
6d674eebb1
refactor: crashReporterInit ( #16729 )
2019-02-05 12:56:44 -08:00
Shelley Vohr
f303caa87c
refactor: remove ServiceWorker APIs from WebContents ( #16717 )
2019-02-04 22:22:46 -08:00
Samuel Attard
af64140100
refactor: enforce naming of ipcMainInternal ( #16689 )
2019-02-04 14:49:53 -08:00
michtsu
392458b252
Add devtools API to inspect shared worker. ( #16615 )
2019-02-01 10:44:24 -08:00
Charles Kerr
76dcbcd6ea
chore: fix 'browserView' typo ( #16621 )
2019-01-30 21:07:08 -08:00
Shelley Vohr
ba57e1d991
feat: promisify contentTracing recording APIs ( #16584 )
...
* feat: promisify contentTracing.startRecording()
* feat: promisify contentTracing.stopRecording()
* test: convert specs for new promisified apis
* chore: deprecate and ensure legacy tests work
2019-01-30 18:53:55 -08:00
Shelley Vohr
641b47f384
feat: promisify contentTracing.getCategories() ( #16583 )
...
* feat: promisify contentTracing.getCategories()
* deprecate contentTracing/getCategories
2019-01-30 12:39:55 -08:00
Milan Burda
dfcee48f81
fix: don't forward IPC filtering events to app for dev-tools and extensions ( #16565 )
2019-01-30 08:20:03 -08:00
Shelley Vohr
d105dcc0d3
feat: promisify webContents.hasServiceWorker() ( #16535 )
...
* feat: promisify contents.hasServiceWorker()
* spec: add initial test for hasServiceWorker()
2019-01-26 10:23:16 -08:00
Shelley Vohr
5a35c3a279
chore: fix promisify helper ( #16544 )
...
* chore: fix promise deprecation helper
* fix deprecations
* update deprecation tests
2019-01-25 14:23:24 -08:00
Charles Kerr
8396a2d504
feat: promisify cookies api ( #16464 )
...
* feat: promisify the Cookie API
* chore: update specs to test promisified cookies
* chore: add deprecate wrapper for cookie callback API
* docs: update docs to cookie promise changes
* chore: remove redundant namespace use
* docs: improve cookie example
* docs: restore docs for cookie callback API
* chore: restore cookie callback tests
* fix: syntax of cookie promise return types
2019-01-25 12:11:35 -06:00
Milan Burda
cc90919384
refactor: pass internal flag via IPC message struct for consistency ( #16490 )
2019-01-23 08:24:57 -08:00
Samuel Attard
58a6fe13d6
feat: preloads and nodeIntegration in iframes ( #16425 )
...
* feat: add support for node / preloads in subframes
This feature has delibrately been built / implemented in such a way
that it has minimum impact on existing apps / code-paths.
Without enabling the new "nodeSupportInSubFrames" option basically none of this
new code will be hit.
The things that I believe need extra scrutiny are:
* Introduction of `event.reply` for IPC events and usage of `event.reply` instead of `event.sender.send()`
* Usage of `node::FreeEnvironment(env)` when the new option is enabled in order to avoid memory leaks. I have tested this quite a bit and haven't managed to cause a crash but it is still feature flagged behind the "nodeSupportInSubFrames" flag to avoid potential impact.
Closes #10569
Closes #10401
Closes #11868
Closes #12505
Closes #14035
* feat: add support preloads in subframes for sandboxed renderers
* spec: add tests for new nodeSupportInSubFrames option
* spec: fix specs for .reply and ._replyInternal for internal messages
* chore: revert change to use flag instead of environment set size
* chore: clean up subframe impl
* chore: apply suggestions from code review
Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>
* chore: clean up reply usage
* chore: fix TS docs generation
* chore: cleanup after rebase
* chore: rename wrap to add in event fns
2019-01-22 11:24:46 -08:00
Jeremy Apthorp
92b9525cfd
feat: enable mixed-sandbox mode by default ( #15894 )
2019-01-22 10:44:28 -08:00
Milan Burda
6cba2c50a2
feat: make ipc-message
and ipc-message-sync
events public ( #16468 )
2019-01-22 08:47:58 -08:00
Milan Burda
7d71ad6f91
fix: takeHeapSnapshot() using public IPC channel for internal implementation ( #16480 )
2019-01-22 17:32:24 +09:00
Shelley Vohr
3ca87d205f
feat: make zoomLevel/zoomFactor sync ( #16410 )
...
* feat: make zoomLevel/zoomFactor sync
* update ts defs dep
2019-01-20 23:40:27 -08:00
Shelley Vohr
f105c84349
test: ensure legacy callback functions work ( #16436 )
...
* test: test legacy callback functions
* add TODO removal comments
* fix callback spec
2019-01-17 14:17:16 -08:00
Shelley Vohr
1f2b02c18f
feat: promisify protocol.isProtocolHandled() ( #16423 )
...
* feat: promisify protocol
* fix base::Bind and specs
* update documentation
* make callback-compatible
* async awaitify tests
2019-01-17 09:05:10 -08:00
Milan Burda
23d44e322d
feat: use default-app behavior in packaged apps ( #16310 )
...
Unify the behavior between default app and packaged apps:
- create default application menu unless the app has one
- default window-all-closed handling unless the app handles the event
2019-01-15 21:35:53 +01:00
Milan Burda
52e257668d
fix: windowmenu did not show the window list on macOS ( #16387 )
2019-01-14 17:27:52 +01:00
Milan Burda
eb02a422de
feat: add fileMenu
/ viewMenu
/ appMenu
roles ( #16328 )
2019-01-10 14:32:03 +01:00
Milan Burda
349a3c20ae
feat: add additional remote APIs filtering ( #16293 )
2019-01-08 14:27:56 -08:00
Shelley Vohr
b71a5a5955
fix: register accelerator if role has no registerAccelerator ( #16309 )
...
* fix: register accelerator if role has no registerAccelerator
* ensure roles[role].registerAccelerator is defined
2019-01-07 16:01:03 -08:00
Milan Burda
6f117b8e0c
feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue() ( #16282 )
...
* feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue()
* add more tests
* refactor: move appendSwitch / appendArgument to command_line module
* replace AppendSwitchASCII with AppendSwitchNative
* remove castArgs
2019-01-07 07:48:27 -08:00
Milan Burda
547097b036
security: allow to block desktopCapturer.getSources() calls ( #15964 )
...
* security: allow to block desktopCapturer.getSources() calls
* return empty instead of error
* fix: release resources of DesktopCapturer on exit
2018-12-20 11:44:30 +09:00
Shelley Vohr
4b18a38e9f
chore: simplify promisify helper ( #15952 )
...
chore: simplify promisify helper
2018-12-10 08:13:09 -08:00
Cheng Zhao
db2fda1b6f
chore: make rpc-server reply to sender frame instead of the main frame ( #15973 )
...
* chore: make rpc-server reply to frame
* fix: check IsRenderFrameLive
2018-12-10 09:37:42 +09:00
Shelley Vohr
3f15f51615
feat: promisify app.getFileIcon() ( #15742 )
2018-12-05 08:50:12 -08:00
Milan Burda
d561c5531b
feat: deprecate modules internally using remote.require in sandboxed renderer context ( #15145 )
2018-12-05 10:34:09 +01:00
Shelley Vohr
a1a431eb87
fix: make windowMenu role correct on MacOS ( #15930 )
2018-12-03 11:52:46 -08:00
Milan Burda
a33eeda4f7
refactor: don't expose NavigationController as an internal module ( #15920 )
2018-12-03 17:13:09 +01:00
Shelley Vohr
41c2685204
feat: promisify win.capturePage() ( #15743 )
...
* feat: promisify win.capturePage
* mark optional arg correctly
* Add to breaking changes doc
* properly deprecate win.capturePage
* remove change from api-contract
* document both callback and promise versions
* address docs feedback
* update promisification progress doc
2018-11-27 23:50:53 -05:00