deepak1556
c9b314d43c
renderer: generate net error strings when requested
2016-05-21 10:21:15 +05:30
Cheng Zhao
8ac93e02c6
Merge pull request #5616 from electron/inherit-zoom
...
Inherit zoomFactor in webview
2016-05-20 00:27:06 +00:00
Kevin Sawicki
b09c81202a
Add test for webview zoomFactor inheritance
2016-05-19 14:46:52 -07:00
Juan Cruz Viotti
1a27ecdad4
Override child_process.execFile
asar patch for child_process.exec
...
NodeJS implements `child_process.exec` by simply passing the whole
command to `child_process.execFile`. See:
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L90
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L99
Electron patches `child_process.execFile` to add support for `asar`
archives by injecting logic that extracts the required files from the
`asar` to a temporary location before delegating the work to the
original `child_process.execFile`.
In order to decide whether to inject the custom `asar` extracting logic,
Electron makes use of a helper function called `splitPath()`. See:
- https://github.com/electron/electron/blob/master/lib/common/asar.js#L37
If the first argument of the returned array equals `true`, means that
the path is considered to be an `asar` archive, and thus the extraction
logic takes place. The problem is that if the command passed to
`child_process.execFile` *contains* a path to an asar archive, padded
with other commands/arguments, `splitPath()` will consider it to be an
`asar` archive, and will try to extract it, throwing a rightfully
`Invalid package` error.
Fixes: https://github.com/electron/electron/issues/5571
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-19 17:19:36 -04:00
Cheng Zhao
242508e22f
Merge pull request #5574 from electron/devtools-extension-test
...
Add test that loads a devtools extension
2016-05-18 01:46:44 +00:00
Kevin Sawicki
cee31ff67a
Remove semicolon
2016-05-17 16:42:37 -07:00
Kevin Sawicki
9266f9abfc
Update interval id variable name
2016-05-17 16:42:21 -07:00
Kevin Sawicki
f95c46d987
Show last panel by id
2016-05-17 16:40:34 -07:00
Kevin Sawicki
13cfc2d2a0
Add comment about panel switching via input event
2016-05-17 15:05:58 -07:00
Kevin Sawicki
8d0c5c30b8
Use consistent function styles
2016-05-17 15:05:27 -07:00
Kevin Sawicki
0b4b79d0a4
Use control on non-mac platforms
2016-05-17 15:01:32 -07:00
Kevin Sawicki
7db2601ea8
DRY up specs
2016-05-17 14:59:33 -07:00
Kevin Sawicki
77b074fbad
Add spec for undocked devtools
2016-05-17 14:56:00 -07:00
Kevin Sawicki
189380d4ea
Add spec for devtools extension
2016-05-17 14:52:45 -07:00
Cheng Zhao
90f52169af
No more need to check for nodeIntegration when creating guest view
2016-05-17 17:06:02 +09:00
Cheng Zhao
0140015500
spec: WebView is disabled when nodeIntegration is disabled
2016-05-17 17:04:13 +09:00
Cheng Zhao
f43b9665c1
And increase timeout for the rest
2016-05-15 10:00:29 +09:00
Cheng Zhao
861a79dd6a
Suppress the tests that need to call window.open on Travis CI
2016-05-15 09:41:02 +09:00
Cheng Zhao
0ad03d9ff7
Suppress crashReporter test on x64 Windows for now
2016-05-13 11:12:01 +09:00
Cheng Zhao
0f52a6da39
Merge branch '1-0-release'
2016-05-11 15:14:56 +09:00
Cheng Zhao
8e7a5adc60
spec: protocol.registerStandardSchemes does not throw
2016-05-10 09:57:13 +09:00
Cheng Zhao
797b0ddb9a
Fix exception when refreshing specs window
2016-05-09 20:08:50 +09:00
Cheng Zhao
af0afecb45
Merge pull request #5406 from deepak1556/protocol_standard_scheme_patch
...
protocol: fix registerStandardSchemes api
2016-05-09 09:12:35 +09:00
Cheng Zhao
c682ccd9d0
Suppress the window.open tests on travis CI's mac machine
2016-05-08 15:15:16 +09:00
deepak1556
9c71c9fa6a
fix docs and spec
2016-05-08 01:37:57 +05:30
deepak1556
0f2ae385ed
allow protocol module initialization before app ready.
...
* ensure registerStandardSchemes can only be called before app ready
* ensure other protocol methods can only be used after app ready
2016-05-08 01:36:34 +05:30
deepak1556
1ff33b7c81
protocol: fix registerStandardSchemes api
2016-05-08 01:36:34 +05:30
Kevin Sawicki
609f5dcaaf
Update read path to something that exists
2016-05-06 10:12:55 -07:00
Kevin Sawicki
4d6b95aa52
Tweak spec description
2016-05-06 10:12:55 -07:00
Kevin Sawicki
0eefb282ca
Test no handler via call to deprecate.log
2016-05-06 10:12:55 -07:00
Kevin Sawicki
722a07de86
Add explicit call to deprecate.log
2016-05-06 10:12:55 -07:00
Kevin Sawicki
58473f41ab
Remove deprecated BrowserWindow options specs
2016-05-06 10:12:54 -07:00
Kevin Sawicki
bea232f53a
Update specs for internal module require
2016-05-06 10:12:54 -07:00
Kevin Sawicki
ef801d5543
Remove .only call
2016-05-06 10:12:54 -07:00
Kevin Sawicki
a6cf7a1095
Remove deprecated crashReporter.start options
2016-05-06 10:12:53 -07:00
deepak1556
45b3bd3a22
ipcRenderer: fix crash with multiple listeners to sync message
2016-05-06 02:52:59 +05:30
Cheng Zhao
8e1d2479ac
spec: Should not run app.setUserActivity test on non-OS X
2016-05-05 12:27:25 +09:00
Charlie Hess
7b207aa1b6
Don't run this spec on platforms where the method is unavailable.
2016-05-03 23:33:40 -07:00
Charlie Hess
12764a66ed
Add an accessor for the current activity type and write the simplest possible test.
2016-05-03 15:51:31 -07:00
Cheng Zhao
f65f8918c9
Fix specs on Windows when running without desktop session
2016-04-30 21:03:22 +09:00
Cheng Zhao
214eb0430c
Fix a few failing tests on Windows
2016-04-30 18:21:18 +09:00
Cheng Zhao
8aa88067ca
Do not write to stdout in Electron when running on win32 CI machine
...
This makes Electron crash on CI machine somehow.
2016-04-30 17:08:51 +09:00
Zeke Sikelianos
9f99ba3b73
update all references to old atom-log bracket notation
2016-04-29 18:35:02 -07:00
deepak1556
d64e3784f4
renderer: fix desktop capture api not responding different subsequest calls
2016-04-28 14:24:22 +05:30
deepak1556
4e6b148eaa
webContents: fix executejavascript when called before page load
2016-04-28 01:54:08 +05:30
Kevin Sawicki
e4bd592e0e
Add failing spec
2016-04-21 11:49:42 -07:00
deepak1556
ca756c3c24
session: allow providing permission to handle external protocols
2016-04-21 05:27:07 +05:30
Cheng Zhao
aa29dc0c8a
Merge pull request #5199 from Mr0grog/5183-disambiguate-loading-from-main-frame-loading
...
Add `isLoadingMainFrame()` to WebContents
2016-04-20 20:49:56 +09:00
Rob Brackett
d3e879cd7f
Change WebContents::IsLoadingMainFrame
to compare SiteInstances
...
(per @deepak1556's recommendation)
Also updates tests to cover the situation where navigating between pages from the same potential "site" and adds generalized tests for `isLoadingMainFrame()`.
2016-04-19 22:05:09 -07:00
deepak1556
794d120754
rename importClientCertificate => importCertificate
2016-04-20 08:45:49 +05:30