Cheng Zhao
993695af07
Remove unneeded cleanup code
2016-04-25 10:23:36 +09:00
Cheng Zhao
2ae52d0ff4
Make Wrappable a template class
2016-04-25 10:17:54 +09:00
Cheng Zhao
5fae63a2f5
Fix compilation errors on OS X
2016-03-10 17:06:21 +09:00
Paul Betts
4503aafe64
int32 => int32_t
2016-03-10 17:06:21 +09:00
Cheng Zhao
50d69fd9bb
Get rid of SavePathData
2016-02-02 20:11:39 +08:00
Cheng Zhao
eaa60e9c17
Destroy the item once item is downloaded
2016-02-02 19:54:41 +08:00
Cheng Zhao
12d311fd29
Gracefully destroy downloadItem
2016-02-02 19:52:09 +08:00
Cheng Zhao
65cf85808f
Calling cancel() should destroy the downloadItem
2016-02-02 19:05:58 +08:00
Cheng Zhao
f1f91828ba
Rely on OnDownloadDestroyed to destroy downloadItem
2016-02-02 18:49:43 +08:00
Robo
2819af9586
fix lifetime of downloadItem class when defaultdownload canceled
2016-02-02 15:54:51 +05:30
Cheng Zhao
a15f9fab5b
Use BuildPrototype to build prototype
...
This saves the step of manually keeping the global template object,
which is easy to forget then leak.
2015-12-03 16:04:46 +08:00
Cheng Zhao
6795bd1d96
Do not manually manage native resources
...
We should rely on the destructor to cleanup everything, instead of
putting them in the Destroy method.
2015-12-03 15:38:43 +08:00
Cheng Zhao
fbb8e61958
Replace "Url" in API names with "URL"
2015-11-13 16:03:40 +08:00
Cheng Zhao
75f49477ca
Cleanup wrapper function when app has done quitting
...
The app may still do something when quitting, we need to make sure the
wrapper function is still there at that time.
2015-11-04 16:54:36 +08:00
Haojian Wu
4a64d1d946
📝 fix a typo
...
interrputed => interrupted
2015-09-25 13:13:11 +08:00
Haojian Wu
1879392c7b
Reimplement downloadItem.getFilename API.
...
Previously, the suggested file name(Always 'empty') returned by
'download_item->GetSuggestedFilename' is not the same with the default one saved
in local disk.
The patch reimplement this API allowing it to return the default file name, which
is more expected from user.
2015-09-24 16:39:02 +08:00
Haojian Wu
0861d5d44b
Redefine 'will-download' design.
2015-09-24 16:04:44 +08:00
Haojian Wu
57bf0cb615
Refractor in completed event in DownloadItem.
...
* Rename `completed` to `done`, making it align with Chromium's style.
* Add 'state' in `done` event's result. It can check the download item final
status: cancelled, completed, interrupted.
2015-09-21 14:00:38 +08:00
Haojian Wu
997ac91fe0
Add donwloadItem.getContentDisposition() API.
2015-09-21 09:38:38 +08:00
Haojian Wu
d0ee30101d
Fix cpplint warnings.
2015-09-21 09:34:49 +08:00
Haojian Wu
5ec74451ef
Introduce DownloadItem for supporting more downloading features.
2015-09-20 18:56:10 +08:00
