deepak1556
4e6b148eaa
webContents: fix executejavascript when called before page load
2016-04-28 01:54:08 +05:30
Rob Brackett
d3e879cd7f
Change WebContents::IsLoadingMainFrame to compare SiteInstances
...
(per @deepak1556's recommendation)
Also updates tests to cover the situation where navigating between pages from the same potential "site" and adds generalized tests for `isLoadingMainFrame()`.
2016-04-19 22:05:09 -07:00
Rob Brackett
3a9bbe30ac
Test for #5183 - webContents.executeJavaScript hangs on subframe load.
2016-04-18 10:33:56 -07:00
Cheng Zhao
65c612a66d
Avoid external URLs
2016-04-13 19:55:59 +09:00
Cheng Zhao
0a39449694
spec: loadUrl should not crash in did-fail-provisional-load handler
2016-04-13 19:39:11 +09:00
Rob Brackett
c1b1348735
Add resourceType arg to webContents did-get-response-details event.
...
Fixes #5074 and follows @zcbenz's recommendation to expose ResourceTypeToString from atom_network_delegate publicly.
Also adds testing for other arguments to the `did-get-response-details` events, since there were no existing tests for them.
2016-04-08 11:19:36 -07:00
Rob Brackett
f12f87d6f0
Add isMainFrame as last argument to WebContents did-fail-load event.
...
Fixes #5013 .
2016-04-04 19:26:06 -07:00
Zeke Sikelianos
b5afad9da7
avoid using eslint comment exceptions
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
cfdfdc8ccc
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
f35f362272
autoformat more files
2016-03-30 17:00:31 -07:00
Kevin Sawicki
737ffd8d7c
Improve deprecated message on webPreferences options
2016-03-17 13:37:08 -07:00
Kevin Sawicki
1b6e01ce6d
Add missing semicolons
2016-03-17 13:37:07 -07:00
Kevin Sawicki
1e8e8f18b4
Add failing specs for deprecated options usage
2016-03-17 13:37:07 -07:00
Cheng Zhao
03ec5ced05
Merge pull request #4751 from maxbeatty/window-blur
...
Add blur method to window
2016-03-11 19:15:51 +09:00
Max Beatty
704b8335aa
Add blur method to window ref #4724
2016-03-10 21:45:51 -08:00
Arek Sredzki
fcc1f4d7ed
Finalized browser-window show & hide events, added tests & fixed os x implementation
2016-03-10 13:51:31 -08:00
Kevin Sawicki
993b878925
🎨
2016-03-07 10:37:01 -08:00
Kevin Sawicki
4ec79d5d18
Add Linux exclusion to describe
2016-03-07 09:53:20 -08:00
Kevin Sawicki
bda5bb4a74
Add missing semicolon
2016-03-04 16:15:04 -08:00
Kevin Sawicki
73f6162f5c
Enable resizable spec on Linux
2016-03-04 16:12:14 -08:00
Robo
8386baf267
add spec
2016-02-25 11:46:30 +05:30
Kevin Sawicki
31028ab636
Update var declarations
2016-02-17 09:27:25 -08:00
Cheng Zhao
aaca93046c
spec: Give beginFrameSubscription test more time to run
2016-02-16 16:20:15 +08:00
Cheng Zhao
7ca09de386
Merge remote-tracking branch 'origin/dont-write-empty-dev-tools-extensions-file'
2016-02-16 12:30:42 +08:00
Cheng Zhao
ed1966ac76
spec: Bring back beginFrameSubscription test
2016-02-16 10:30:18 +08:00
Cheng Zhao
08e5c1f6fe
Merge branch 'webcontent_invalid_loadurl_patch' of https://github.com/deepak1556/atom-shell into deepak1556-webcontent_invalid_loadurl_patch
2016-02-15 21:14:54 +08:00
Kevin Sawicki
704bd4d191
Improve error message
2016-02-11 13:25:58 -08:00
Kevin Sawicki
3e399d09d7
Match existing function style
2016-02-11 13:25:58 -08:00
Kevin Sawicki
c94f1fc857
Throw error when IPC channel is missing
2016-02-11 13:25:58 -08:00
Kevin Sawicki
cead84d5d1
Add failing spec
2016-02-11 13:25:57 -08:00
Kevin Sawicki
4828835998
Clean up returns after CoffeeScript migration
2016-02-11 13:25:57 -08:00
Robo
5a8bebc2f8
browser: emit did-fail-load for invalid url
2016-02-12 01:52:42 +05:30
Kevin Sawicki
00261a5571
Remove lint warnings
2016-02-03 17:17:11 -08:00
Kevin Sawicki
5714ae0b73
Add failing spec for dev tools extensions file
2016-02-03 17:11:12 -08:00
Cheng Zhao
cc560a3900
spec: Fix failing tests on Windows
2016-01-24 14:31:37 +08:00
Cheng Zhao
8239f69139
spec: hasShadow state
2016-01-24 14:31:37 +08:00
Cheng Zhao
c33e8de676
spec: Improve the test for resizable
2016-01-24 14:31:37 +08:00
Cheng Zhao
c41de501cb
spec: Test the -able methods
2016-01-24 14:31:37 +08:00
Kevin Sawicki
70bcb0ac5a
Clean up no-unused-vars lint errors
2016-01-21 09:32:21 -07:00
Kevin Sawicki
ccce284a5b
Clean up no-empty lint errors
2016-01-21 09:32:21 -07:00
Cheng Zhao
60d44b3b04
spec: Remove annoying outputs from savePage test
2016-01-15 16:36:35 +08:00
Kevin Sawicki
1f9691ae13
Convert all source files to JavaScript
2016-01-12 16:24:06 -08:00
