mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: use v8::True(isolate) and v8::False(isolate) (#46571)

Browse source 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-04-08 15:40:15 -05:00 • committed by GitHub
parent 33964528e1
commit ffb4f0f812
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
shell/common/gin_helper/callback.cc
View file

@ -54,8 +54,7 @@ void CallTranslator(v8::Local<v8::External> external,
args->ThrowTypeError("One-time callback was called more than once"); args->ThrowTypeError("One-time callback was called more than once");
return; return;
} else { } else {
state->Set(context, called_symbol, v8::Boolean::New(isolate, true)) state->Set(context, called_symbol, v8::True(isolate)).ToChecked();
.ToChecked();
} }
} }

4
shell/common/gin_helper/event_emitter_caller.cc
View file

@ -18,7 +18,7 @@ v8::Local<v8::Value> CallMethodWithArgs(
// CallbackScope and MakeCallback both require an active node::Environment // CallbackScope and MakeCallback both require an active node::Environment
if (!node::Environment::GetCurrent(isolate)) if (!node::Environment::GetCurrent(isolate))
return handle_scope.Escape(v8::Boolean::New(isolate, false)); return handle_scope.Escape(v8::False(isolate));
node::CallbackScope callback_scope{isolate, v8::Object::New(isolate), node::CallbackScope callback_scope{isolate, v8::Object::New(isolate),
node::async_context{0, 0}}; node::async_context{0, 0}};
@ -39,7 +39,7 @@ v8::Local<v8::Value> CallMethodWithArgs(
if (v8::Local<v8::Value> localRet; ret.ToLocal(&localRet)) if (v8::Local<v8::Value> localRet; ret.ToLocal(&localRet))
return handle_scope.Escape(localRet); return handle_scope.Escape(localRet);
return handle_scope.Escape(v8::Boolean::New(isolate, false)); return handle_scope.Escape(v8::False(isolate));
} }
} // namespace gin_helper::internal } // namespace gin_helper::internal