mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Use prefix increment in for loops.

Browse source
This commit is contained in:
Haojian Wu 2017-03-30 22:56:21 +02:00
parent 8d8c7ce6ad
commit ff745e1a82
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/browser_mac.mm
View file

@ -64,7 +64,7 @@ bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol,
// On macOS, we can't query the default, but the handlers list seems to put // On macOS, we can't query the default, but the handlers list seems to put
// Apple's defaults first, so we'll use the first option that isn't our bundle // Apple's defaults first, so we'll use the first option that isn't our bundle
CFStringRef other = nil; CFStringRef other = nil;
for (CFIndex i = 0; i < CFArrayGetCount(bundleList); i++) { for (CFIndex i = 0; i < CFArrayGetCount(bundleList); ++i) {
other = base::mac::CFCast<CFStringRef>(CFArrayGetValueAtIndex(bundleList, other = base::mac::CFCast<CFStringRef>(CFArrayGetValueAtIndex(bundleList,
i)); i));
if (![identifier isEqualToString: (__bridge NSString *)other]) { if (![identifier isEqualToString: (__bridge NSString *)other]) {

4
atom/browser/ui/cocoa/atom_touch_bar.mm
View file

@ -414,7 +414,7 @@ static NSString* const ImageScrubberItemIdentifier = @"scrubber.image.item";
NSMutableArray* generatedItems = [NSMutableArray array]; NSMutableArray* generatedItems = [NSMutableArray array];
NSMutableArray* identifiers = [self identifiersFromSettings:items]; NSMutableArray* identifiers = [self identifiersFromSettings:items];
for (NSUInteger i = 0; i < [identifiers count]; i++) { for (NSUInteger i = 0; i < [identifiers count]; ++i) {
if ([identifiers objectAtIndex:i] != NSTouchBarItemIdentifierOtherItemsProxy) { if ([identifiers objectAtIndex:i] != NSTouchBarItemIdentifierOtherItemsProxy) {
NSTouchBarItem* generatedItem = [self makeItemForIdentifier:[identifiers objectAtIndex:i]]; NSTouchBarItem* generatedItem = [self makeItemForIdentifier:[identifiers objectAtIndex:i]];
if (generatedItem) { if (generatedItem) {
@ -474,7 +474,7 @@ static NSString* const ImageScrubberItemIdentifier = @"scrubber.image.item";
settings.Get("segments", &segments); settings.Get("segments", &segments);
control.segmentCount = segments.size(); control.segmentCount = segments.size();
for (size_t i = 0; i < segments.size(); i++) { for (size_t i = 0; i < segments.size(); ++i) {
std::string label; std::string label;
gfx::Image image; gfx::Image image;
bool enabled = true; bool enabled = true;