Style fixes

This commit is contained in:
Cheng Zhao 2017-09-14 16:12:34 +09:00
parent 33dd5e26fb
commit ff023115f5
5 changed files with 32 additions and 27 deletions

View file

@ -589,28 +589,33 @@ void App::OnWillContinueUserActivity(
const std::string& type) { const std::string& type) {
*prevent_default = Emit("will-continue-activity", type); *prevent_default = Emit("will-continue-activity", type);
} }
void App::OnDidFailToContinueUserActivity( void App::OnDidFailToContinueUserActivity(
const std::string& type, const std::string& type,
const std::string& error) { const std::string& error) {
Emit("continue-activity-error", type, error); Emit("continue-activity-error", type, error);
} }
void App::OnContinueUserActivity( void App::OnContinueUserActivity(
bool* prevent_default, bool* prevent_default,
const std::string& type, const std::string& type,
const base::DictionaryValue& user_info) { const base::DictionaryValue& user_info) {
*prevent_default = Emit("continue-activity", type, user_info); *prevent_default = Emit("continue-activity", type, user_info);
} }
void App::OnUserActivityWasContinued( void App::OnUserActivityWasContinued(
const std::string& type, const std::string& type,
const base::DictionaryValue& user_info) { const base::DictionaryValue& user_info) {
Emit("activity-was-continued", type, user_info); Emit("activity-was-continued", type, user_info);
} }
void App::OnUpdateUserActivityState( void App::OnUpdateUserActivityState(
bool* prevent_default, bool* prevent_default,
const std::string& type, const std::string& type,
const base::DictionaryValue& user_info) { const base::DictionaryValue& user_info) {
*prevent_default = Emit("update-activity-state", type, user_info); *prevent_default = Emit("update-activity-state", type, user_info);
} }
void App::OnNewWindowForTab() { void App::OnNewWindowForTab() {
Emit("new-window-for-tab"); Emit("new-window-for-tab");
} }

View file

@ -150,18 +150,18 @@ void Browser::InvalidateCurrentActivity() {
void Browser::UpdateCurrentActivity(const std::string& type, void Browser::UpdateCurrentActivity(const std::string& type,
const base::DictionaryValue& user_info) { const base::DictionaryValue& user_info) {
[[AtomApplication sharedApplication] [[AtomApplication sharedApplication]
updateCurrentActivity:base::SysUTF8ToNSString(type) updateCurrentActivity:base::SysUTF8ToNSString(type)
withUserInfo:DictionaryValueToNSDictionary(user_info)]; withUserInfo:DictionaryValueToNSDictionary(user_info)];
} }
bool Browser::WillContinueUserActivity(const std::string& type) { bool Browser::WillContinueUserActivity(const std::string& type) {
bool prevent_default = false; bool prevent_default = false;
for (BrowserObserver& observer : observers_) for (BrowserObserver& observer : observers_)
observer.OnWillContinueUserActivity(&prevent_default, type); observer.OnWillContinueUserActivity(&prevent_default, type);
return prevent_default; return prevent_default;
} }
void Browser::DidFailToContinueUserActivity(const std::string& type, void Browser::DidFailToContinueUserActivity(const std::string& type,
const std::string& error) { const std::string& error) {
for (BrowserObserver& observer : observers_) for (BrowserObserver& observer : observers_)
@ -175,7 +175,7 @@ bool Browser::ContinueUserActivity(const std::string& type,
observer.OnContinueUserActivity(&prevent_default, type, user_info); observer.OnContinueUserActivity(&prevent_default, type, user_info);
return prevent_default; return prevent_default;
} }
void Browser::UserActivityWasContinued(const std::string& type, void Browser::UserActivityWasContinued(const std::string& type,
const base::DictionaryValue& user_info) { const base::DictionaryValue& user_info) {
for (BrowserObserver& observer : observers_) for (BrowserObserver& observer : observers_)

View file

@ -11,7 +11,7 @@
@private @private
BOOL handlingSendEvent_; BOOL handlingSendEvent_;
base::scoped_nsobject<NSUserActivity> currentActivity_; base::scoped_nsobject<NSUserActivity> currentActivity_;
NSCondition *handoffLock_; NSCondition* handoffLock_;
BOOL updateReceived_; BOOL updateReceived_;
} }
@ -28,7 +28,7 @@
withUserInfo:(NSDictionary*)userInfo withUserInfo:(NSDictionary*)userInfo
withWebpageURL:(NSURL*)webpageURL; withWebpageURL:(NSURL*)webpageURL;
- (void)invalidateCurrentActivity; - (void)invalidateCurrentActivity;
- (void)updateCurrentActivity:(NSString *)type - (void)updateCurrentActivity:(NSString*)type
withUserInfo:(NSDictionary*)userInfo; withUserInfo:(NSDictionary*)userInfo;
@end @end

View file

@ -10,14 +10,17 @@
#include "base/strings/sys_string_conversions.h" #include "base/strings/sys_string_conversions.h"
#include "content/public/browser/browser_accessibility_state.h" #include "content/public/browser/browser_accessibility_state.h"
static inline void dispatch_sync_main(dispatch_block_t block) { namespace {
if ([NSThread isMainThread]) {
block(); inline void dispatch_sync_main(dispatch_block_t block) {
} else { if ([NSThread isMainThread])
dispatch_sync(dispatch_get_main_queue(), block); block();
} else
dispatch_sync(dispatch_get_main_queue(), block);
} }
} // namespace
@implementation AtomApplication @implementation AtomApplication
+ (AtomApplication*)sharedApplication { + (AtomApplication*)sharedApplication {
@ -44,7 +47,7 @@ static inline void dispatch_sync_main(dispatch_block_t block) {
[[NSUserActivity alloc] initWithActivityType:type]); [[NSUserActivity alloc] initWithActivityType:type]);
[currentActivity_ setUserInfo:userInfo]; [currentActivity_ setUserInfo:userInfo];
[currentActivity_ setWebpageURL:webpageURL]; [currentActivity_ setWebpageURL:webpageURL];
[currentActivity_ setDelegate: self]; [currentActivity_ setDelegate:self];
[currentActivity_ becomeCurrent]; [currentActivity_ becomeCurrent];
[currentActivity_ setNeedsSave:YES]; [currentActivity_ setNeedsSave:YES];
} }
@ -54,16 +57,16 @@ static inline void dispatch_sync_main(dispatch_block_t block) {
} }
- (void)invalidateCurrentActivity { - (void)invalidateCurrentActivity {
if (currentActivity_.get() != NULL) { if (currentActivity_) {
[currentActivity_.get() invalidate]; [currentActivity_ invalidate];
currentActivity_.reset(); currentActivity_.reset();
} }
} }
- (void)updateCurrentActivity:(NSString *)type - (void)updateCurrentActivity:(NSString*)type
withUserInfo:(NSDictionary*)userInfo { withUserInfo:(NSDictionary*)userInfo {
if (currentActivity_.get() != NULL) { if (currentActivity_) {
[currentActivity_.get() addUserInfoEntriesFromDictionary:userInfo]; [currentActivity_ addUserInfoEntriesFromDictionary:userInfo];
} }
[handoffLock_ lock]; [handoffLock_ lock];
@ -73,9 +76,7 @@ static inline void dispatch_sync_main(dispatch_block_t block) {
} }
- (void)userActivityWillSave:(NSUserActivity *)userActivity { - (void)userActivityWillSave:(NSUserActivity *)userActivity {
__block BOOL shouldWait = NO; __block BOOL shouldWait = NO;
dispatch_sync_main(^{ dispatch_sync_main(^{
std::string activity_type(base::SysNSStringToUTF8(userActivity.activityType)); std::string activity_type(base::SysNSStringToUTF8(userActivity.activityType));
std::unique_ptr<base::DictionaryValue> user_info = std::unique_ptr<base::DictionaryValue> user_info =
@ -90,7 +91,7 @@ static inline void dispatch_sync_main(dispatch_block_t block) {
updateReceived_ = NO; updateReceived_ = NO;
while (!updateReceived_) { while (!updateReceived_) {
BOOL isSignaled = [handoffLock_ waitUntilDate:[NSDate dateWithTimeIntervalSinceNow:1]]; BOOL isSignaled = [handoffLock_ waitUntilDate:[NSDate dateWithTimeIntervalSinceNow:1]];
if (!isSignaled) { break; } if (!isSignaled) break;
} }
[handoffLock_ unlock]; [handoffLock_ unlock];
} }
@ -105,7 +106,6 @@ static inline void dispatch_sync_main(dispatch_block_t block) {
atom::NSDictionaryToDictionaryValue(userActivity.userInfo); atom::NSDictionaryToDictionaryValue(userActivity.userInfo);
atom::Browser* browser = atom::Browser::Get(); atom::Browser* browser = atom::Browser::Get();
browser->UserActivityWasContinued(activity_type, *user_info); browser->UserActivityWasContinued(activity_type, *user_info);
}); });
[userActivity setNeedsSave:YES]; [userActivity setNeedsSave:YES];

View file

@ -118,17 +118,17 @@ continueUserActivity:(NSUserActivity*)userActivity
return browser->ContinueUserActivity(activity_type, *user_info) ? YES : NO; return browser->ContinueUserActivity(activity_type, *user_info) ? YES : NO;
} }
- (BOOL)application:(NSApplication *)application willContinueUserActivityWithType:(NSString *)userActivityType { - (BOOL)application:(NSApplication*)application willContinueUserActivityWithType:(NSString*)userActivityType {
std::string activity_type(base::SysNSStringToUTF8(userActivityType)); std::string activity_type(base::SysNSStringToUTF8(userActivityType));
atom::Browser* browser = atom::Browser::Get(); atom::Browser* browser = atom::Browser::Get();
return browser->WillContinueUserActivity(activity_type) ? YES : NO; return browser->WillContinueUserActivity(activity_type) ? YES : NO;
} }
- (void)application:(NSApplication *)application didFailToContinueUserActivityWithType:(NSString *)userActivityType error:(NSError *)error { - (void)application:(NSApplication*)application didFailToContinueUserActivityWithType:(NSString*)userActivityType error:(NSError*)error {
std::string activity_type(base::SysNSStringToUTF8(userActivityType)); std::string activity_type(base::SysNSStringToUTF8(userActivityType));
std::string error_message(base::SysNSStringToUTF8([error localizedDescription])); std::string error_message(base::SysNSStringToUTF8([error localizedDescription]));
atom::Browser* browser = atom::Browser::Get(); atom::Browser* browser = atom::Browser::Get();
browser->DidFailToContinueUserActivity(activity_type, error_message); browser->DidFailToContinueUserActivity(activity_type, error_message);
} }