mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #7579 from electron/tweak-about-panel-key-names

Browse source 
Use lower-case about panel option keys
This commit is contained in:
Kevin Sawicki 2016-10-12 11:32:01 -07:00 committed by GitHub
commit fcfc13c1ea
2 changed files with 17 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
atom/browser/browser_mac.mm
View file

@ -261,7 +261,18 @@ void Browser::ShowAboutPanel() {
void Browser::SetAboutPanelOptions(const base::DictionaryValue& options) {
about_panel_options_.Clear();
about_panel_options_.MergeDictionary(&options);
// Upper case option keys for orderFrontStandardAboutPanelWithOptions format
for (base::DictionaryValue::Iterator iter(options);
!iter.IsAtEnd();
iter.Advance()) {
std::string key = iter.key();
std::string value;
if (!key.empty() && iter.value().GetAsString(&value)) {
key[0] = base::ToUpperASCII(key[0]);
about_panel_options_.SetString(key, value);
}
}
}
} // namespace atom

10
docs/api/app.md
View file

@ -859,11 +859,11 @@ details.
### `app.setAboutPanelOptions(options)` _macOS_
* `options` Object
* `ApplicationName` String (optional) - The app's name.
* `ApplicationVersion` String (optional) - The app's version.
* `Copyright` String (optional) - Copyright information.
* `Credits` String (optional) - Credit information.
* `Version` String (optional) - The app's build version number.
* `applicationName` String (optional) - The app's name.
* `applicationVersion` String (optional) - The app's version.
* `copyright` String (optional) - Copyright information.
* `credits` String (optional) - Credit information.
* `version` String (optional) - The app's build version number.
Set the about panel options. This will override the values defined in the app's
`.plist` file. See the [Apple docs][about-panel-options] for more details.