From fcf396ff91eb0eff96dfa3b2b2a7b450792928d5 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Wed, 8 Jan 2025 16:05:08 -0600 Subject: [PATCH] refactor: remove redundant CreateExtensionsClient() (#45154) * refactor: have CreateExtensionsClient return a unique_ptr, not a raw pointer Co-authored-by: Charles Kerr * refactor: remove CreateExtensionsClient() Co-authored-by: Charles Kerr --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/renderer/renderer_client_base.cc | 8 +------- shell/renderer/renderer_client_base.h | 7 ------- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/shell/renderer/renderer_client_base.cc b/shell/renderer/renderer_client_base.cc index 87825b82e9c9..bc35d609313d 100644 --- a/shell/renderer/renderer_client_base.cc +++ b/shell/renderer/renderer_client_base.cc @@ -242,7 +242,7 @@ void RendererClientBase::RenderThreadStarted() { true); #if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS) - extensions_client_.reset(CreateExtensionsClient()); + extensions_client_ = std::make_unique(); extensions::ExtensionsClient::Set(extensions_client_.get()); extensions_renderer_client_ = @@ -568,12 +568,6 @@ v8::Local RendererClientBase::GetContext( return frame->MainWorldScriptContext(); } -#if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS) -extensions::ExtensionsClient* RendererClientBase::CreateExtensionsClient() { - return new ElectronExtensionsClient; -} -#endif - bool RendererClientBase::IsWebViewFrame( v8::Local context, content::RenderFrame* render_frame) const { diff --git a/shell/renderer/renderer_client_base.h b/shell/renderer/renderer_client_base.h index 78f2a7b66c7b..d7bfe06fc98b 100644 --- a/shell/renderer/renderer_client_base.h +++ b/shell/renderer/renderer_client_base.h @@ -139,13 +139,6 @@ class RendererClientBase : public content::ContentRendererClient bool was_created_by_renderer, const url::Origin* outermost_origin) override; - protected: -#if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS) - // app_shell embedders may need custom extensions client interfaces. - // This class takes ownership of the returned object. - virtual extensions::ExtensionsClient* CreateExtensionsClient(); -#endif - private: #if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS) std::unique_ptr extensions_client_;