mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: explicitly call GetNativeNSView() on macOS (#46750)

Browse source 
* fix: explicitly call GetNativeNSView() on macOS

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: move macOS impl to a .mm file

This is needed in order to access gfx::NativeView::GetNativeNSView()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-04-24 09:53:53 -05:00 • committed by GitHub
parent 2629b31c19
commit fc319e0ea3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 62 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

32
shell/browser/api/electron_api_base_window_mac.mm Normal file
View file

@ -0,0 +1,32 @@
// Copyright (c) 2025 Microsoft, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "shell/browser/api/electron_api_base_window.h"
#include "electron/buildflags/buildflags.h"
#include "shell/browser/api/electron_api_view.h"
#include "shell/browser/native_window.h"
#include "shell/common/node_includes.h"
namespace {
// Converts binary data to Buffer.
v8::Local<v8::Value> ToBuffer(v8::Isolate* isolate, void* val, int size) {
auto buffer = node::Buffer::Copy(isolate, static_cast<char*>(val), size);
if (buffer.IsEmpty())
return v8::Null(isolate);
else
return buffer.ToLocalChecked();
}
} // namespace
namespace electron::api {
v8::Local<v8::Value> BaseWindow::GetNativeWindowHandle() {
NSView* handle = window_->GetNativeWindowHandle().GetNativeNSView();
return ToBuffer(isolate(), &handle, sizeof(handle));
}
} // namespace electron::api