mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Addressed review feedback

Browse source
This commit is contained in:
Ales Pergl 2017-04-05 14:27:52 +02:00
parent f73233ee55
commit fbe3b27409
2 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
brightray/browser/notification_presenter.cc
View file

@ -19,7 +19,6 @@ NotificationPresenter::~NotificationPresenter() {
base::WeakPtr<Notification> NotificationPresenter::CreateNotification( base::WeakPtr<Notification> NotificationPresenter::CreateNotification(
NotificationDelegate* delegate) { NotificationDelegate* delegate) {
Notification* notification = CreateNotificationObject(delegate); Notification* notification = CreateNotificationObject(delegate);
if (!notification) return {};
notifications_.insert(notification); notifications_.insert(notification);
return notification->GetWeakPtr(); return notification->GetWeakPtr();
} }

2
brightray/browser/win/notification_presenter_win.cc
View file

@ -38,8 +38,6 @@ bool SaveIconToPath(const SkBitmap& bitmap, const base::FilePath& path) {
// static // static
NotificationPresenter* NotificationPresenter::Create() { NotificationPresenter* NotificationPresenter::Create() {
auto version = base::win::GetVersion(); auto version = base::win::GetVersion();
if (version < base::win::VERSION_WIN7)
return nullptr;
if (version < base::win::VERSION_WIN8) if (version < base::win::VERSION_WIN8)
return new NotificationPresenterWin7; return new NotificationPresenterWin7;
if (!WindowsToastNotification::Initialize()) if (!WindowsToastNotification::Initialize())