build: remove unused node patches (#19296)

This commit is contained in:
Samuel Attard 2019-07-17 12:33:41 -07:00 committed by GitHub
parent 478360f317
commit fbcbdb051b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 8 additions and 52 deletions

View file

@ -3,7 +3,6 @@ fix_don_t_create_console_window_when_creating_process.patch
refactor_alter_child_process_fork_to_use_execute_script_with.patch
feat_add_uv_loop_watcher_queue_code.patch
feat_initialize_asar_support.patch
export_nativemodule.patch
expose_get_builtin_module_function.patch
fix_expose_traceeventhelper.patch
fix_build_and_expose_inspector_agent.patch
@ -23,7 +22,6 @@ fixme_remove_async_id_assertion_check.patch
src_use_check_false_in_switch_default_case.patch
fixme_comment_trace_event_macro.patch
fix_export_node_abort_and_assert.patch
fix_make_it_possible_to_change_nobrowserglobals_at_runtime.patch
fix_key_gen_apis_are_not_available_in_boringssl.patch
fix_do_not_define_debugoptions_s_constructors_in_header.patch
src_disable_node_use_v8_platform_in_node_options.patch

View file

@ -1,7 +1,8 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Cheng Zhao <zcbenz@gmail.com>
Date: Thu, 11 Apr 2019 17:16:13 +0900
Subject: build: modify js2c.py to allow injection of original-fs and custom embedder JS
Subject: build: modify js2c.py to allow injection of original-fs and custom
embedder JS
This patch does two things:
* Updates js2c.py so that original-fs is automatically created with

View file

@ -1,18 +1,20 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Samuel Attard <sattard@slack-corp.com>
Date: Mon, 15 Jul 2019 17:45:02 -0700
Subject: chore: read _noBrowserGlobals from global not process
Subject: chore: read _noBrowserGlobals from global not config
This is used so that we can modify the flag at runtime where
config can only be set at compile time.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 6f096ff3abce7d4b08a174a159217a9ac012f2b2..48c430e966e449397475887b4a65b9aea9021924 100644
index 60c0bd845b18cd782d5b314f339e0c4e7bf88388..48c430e966e449397475887b4a65b9aea9021924 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -168,7 +168,7 @@ const {
queueMicrotask
} = require('internal/process/task_queues');
-if (!process._noBrowserGlobals) {
-if (!config.noBrowserGlobals) {
+if (!global._noBrowserGlobals) {
// Override global console from the one provided by the VM
// to the one implemented by Node.js

View file

@ -1,22 +0,0 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Cheng Zhao <zcbenz@gmail.com>
Date: Sun, 27 Mar 2016 14:43:14 +0900
Subject: Export NativeModule
This is used by atom for doing module compile cache.
(cherry picked from commit 83b45fddb9a36c1376f7a2b5c70717e37b6f0133)
diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
index bf63de07613b4d19d95607f404139e587319f11d..b99858fa9df3d817fb7a4614366154e4fbc560c8 100644
--- a/lib/internal/bootstrap/loaders.js
+++ b/lib/internal/bootstrap/loaders.js
@@ -168,6 +168,8 @@ NativeModule.exposeInternals = function() {
}
};
+process.NativeModule = NativeModule;
+
const {
moduleIds,
compileFunction

View file

@ -1,23 +0,0 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Cheng Zhao <zcbenz@gmail.com>
Date: Fri, 29 Mar 2019 16:21:42 +0900
Subject: fix: make it possible to change noBrowserGlobals at runtime
This is a temporary hack in responding to Node's change:
https://github.com/nodejs/node/pull/26228
We need to figure out a better solution.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 8dee38a0e71698258bee7642f9b91c5c8b9060c2..1cdf79dfaa9aecc4ac3bcb05212514929b80603d 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -164,7 +164,7 @@ const {
queueMicrotask
} = require('internal/process/task_queues');
-if (!config.noBrowserGlobals) {
+if (!process._noBrowserGlobals) {
// Override global console from the one provided by the VM
// to the one implemented by Node.js
// https://console.spec.whatwg.org/#console-namespace

View file

@ -5,7 +5,7 @@ Subject: refactor: allow embedder overriding of internal FS calls
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 1cdf79dfaa9aecc4ac3bcb05212514929b80603d..6f096ff3abce7d4b08a174a159217a9ac012f2b2 100644
index 8dee38a0e71698258bee7642f9b91c5c8b9060c2..60c0bd845b18cd782d5b314f339e0c4e7bf88388 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -65,6 +65,10 @@ if (ownsProcessState) {