mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

options all the things

Browse source
This commit is contained in:
Shelley Vohr 2018-02-20 11:10:53 -05:00
parent 56f06187d5
commit fb7fb4972d
No known key found for this signature in database
GPG key ID: F13993A75599653C
2 changed files with 22 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

20
spec/api-menu-spec.js
View file

@ -344,7 +344,11 @@ describe('Menu module', () => {
})
it('returns immediately', () => {
const { browserWindow, x, y } = menu.popup(w, {x: 100, y: 101})
const { browserWindow, x, y } = menu.popup({
window: w,
x: 100,
y: 101
})
assert.equal(browserWindow, w)
assert.equal(x, 100)
@ -360,7 +364,12 @@ describe('Menu module', () => {
})
it('works with a given BrowserWindow, options and callback', (done) => {
const {x, y} = menu.popup(w, {x: 100, y: 101}, () => done())
const {x, y} = menu.popup({
window: w,
x: 100,
y: 101,
callback: () => done()
})
assert.equal(x, 100)
assert.equal(y, 101)
@ -368,12 +377,7 @@ describe('Menu module', () => {
})
it('works with a given BrowserWindow, no options, and a callback', (done) => {
menu.popup(w, () => done())
menu.closePopup()
})
it('calls the callback', (done) => {
menu.popup({}, () => done())
menu.popup({window: w, callback: () => done()})
menu.closePopup()
})
})