From 5194288fcea291d843727571e9b3193789e234c2 Mon Sep 17 00:00:00 2001 From: Nitish Sakhawalkar Date: Fri, 9 Feb 2018 18:01:14 -0800 Subject: [PATCH 1/2] Add ability to log atom ipc messages --- atom/app/atom_main_delegate.cc | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/atom/app/atom_main_delegate.cc b/atom/app/atom_main_delegate.cc index fdf76f3cb291..4dd2f30bfc7a 100644 --- a/atom/app/atom_main_delegate.cc +++ b/atom/app/atom_main_delegate.cc @@ -21,9 +21,18 @@ #include "base/logging.h" #include "chrome/common/chrome_paths.h" #include "content/public/common/content_switches.h" +#include "ipc/ipc_features.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/resource/resource_bundle.h" +#if BUILDFLAG(IPC_MESSAGE_LOG_ENABLED) +#define IPC_MESSAGE_MACROS_LOG_ENABLED +#include "content/public/common/content_ipc_logging.h" +#define IPC_LOG_TABLE_ADD_ENTRY(msg_id, logger) \ + content::RegisterIPCLogger(msg_id, logger) +#include "atom/common/api/api_messages.h" +#endif + namespace atom { namespace { From e19e2b9242dccbb6e8e2951a761ad41499630fbf Mon Sep 17 00:00:00 2001 From: Nitish Sakhawalkar Date: Sun, 11 Feb 2018 10:25:11 -0800 Subject: [PATCH 2/2] Address review comments --- atom/app/atom_main_delegate.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/atom/app/atom_main_delegate.cc b/atom/app/atom_main_delegate.cc index 4dd2f30bfc7a..2eeb69dbe7f5 100644 --- a/atom/app/atom_main_delegate.cc +++ b/atom/app/atom_main_delegate.cc @@ -30,7 +30,7 @@ #include "content/public/common/content_ipc_logging.h" #define IPC_LOG_TABLE_ADD_ENTRY(msg_id, logger) \ content::RegisterIPCLogger(msg_id, logger) -#include "atom/common/api/api_messages.h" +#include "atom/common/common_message_generator.h" #endif namespace atom {