mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: do not wait on promise returned by remote APIs (#18990)

Browse source 
* fix: make <webview>.loadURL async

* docs: webview.loadURL returns Promise
This commit is contained in:
Cheng Zhao 2019-07-10 22:20:28 +09:00 • committed by John Kleinschmidt
parent 015e1348e0
commit faa2710485
4 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/common/web-view-methods.js
View file

@ -3,7 +3,6 @@
// Public-facing API methods.
exports.syncMethods = new Set([
'getURL',
'loadURL',
'getTitle',
'isLoading',
'isLoadingMainFrame',
@ -54,6 +53,7 @@ exports.syncMethods = new Set([
])
exports.asyncMethods = new Set([
'loadURL',
'capturePage',
'executeJavaScript',
'insertCSS',