fix: do not wait on promise returned by remote APIs (#18990)
* fix: make <webview>.loadURL async * docs: webview.loadURL returns Promise
This commit is contained in:
parent
015e1348e0
commit
faa2710485
4 changed files with 21 additions and 2 deletions
|
@ -3,7 +3,6 @@
|
|||
// Public-facing API methods.
|
||||
exports.syncMethods = new Set([
|
||||
'getURL',
|
||||
'loadURL',
|
||||
'getTitle',
|
||||
'isLoading',
|
||||
'isLoadingMainFrame',
|
||||
|
@ -54,6 +53,7 @@ exports.syncMethods = new Set([
|
|||
])
|
||||
|
||||
exports.asyncMethods = new Set([
|
||||
'loadURL',
|
||||
'capturePage',
|
||||
'executeJavaScript',
|
||||
'insertCSS',
|
||||
|
|
|
@ -196,7 +196,7 @@ class SrcAttribute extends WebViewAttribute {
|
|||
const method = 'loadURL'
|
||||
const args = [this.getValue(), opts]
|
||||
|
||||
ipcRendererUtils.invokeSync('ELECTRON_GUEST_VIEW_MANAGER_CALL', guestInstanceId, method, args)
|
||||
ipcRendererUtils.invoke('ELECTRON_GUEST_VIEW_MANAGER_CALL', guestInstanceId, method, args)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue