mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: re-enable tests that aren't broken & remove old test (#38251)

Browse source
This commit is contained in:
Calvin 2023-05-16 06:30:25 -06:00 • committed by GitHub
parent c05051e307
commit fa81f77f40
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
spec/api-protocol-spec.ts
View file

@ -282,18 +282,6 @@ describe('protocol module', () => {
ipcMain.once('loaded-iframe-custom-protocol', () => done()); ipcMain.once('loaded-iframe-custom-protocol', () => done());
}); });
// DISABLED-FIXME
it('throws an error when custom headers are invalid', (done) => {
registerFileProtocol(protocolName, (request, callback) => {
expect(() => callback({
path: filePath,
headers: { 'X-Great-Header': (42 as any) }
})).to.throw(Error, 'Value of \'X-Great-Header\' header has to be a string');
done();
});
ajax(protocolName + '://fake-host').catch(() => {});
});
it('sends object as response', async () => { it('sends object as response', async () => {
registerFileProtocol(protocolName, (request, callback) => callback({ path: filePath })); registerFileProtocol(protocolName, (request, callback) => callback({ path: filePath }));
const r = await ajax(protocolName + '://fake-host'); const r = await ajax(protocolName + '://fake-host');
@ -880,7 +868,6 @@ describe('protocol module', () => {
await requestReceived; await requestReceived;
}); });
// DISABLED-FIXME
it('can access files through the FileSystem API', (done) => { it('can access files through the FileSystem API', (done) => {
const filePath = path.join(fixturesPath, 'pages', 'filesystem.html'); const filePath = path.join(fixturesPath, 'pages', 'filesystem.html');
protocol.registerFileProtocol(standardScheme, (request, callback) => callback({ path: filePath })); protocol.registerFileProtocol(standardScheme, (request, callback) => callback({ path: filePath }));

6
spec/disabled-tests.json
View file

@ -4,13 +4,9 @@
"BrowserWindow module document.visibilityState/hidden visibilityState remains visible if backgroundThrottling is disabled", "BrowserWindow module document.visibilityState/hidden visibilityState remains visible if backgroundThrottling is disabled",
"Menu module Menu.setApplicationMenu unsets a menu with null", "Menu module Menu.setApplicationMenu unsets a menu with null",
"process module main process process.takeHeapSnapshot() returns true on success", "process module main process process.takeHeapSnapshot() returns true on success",
"protocol module protocol.registerFileProtocol throws an error when custom headers are invalid",
"protocol module protocol.registerProtocol throws an error when custom headers are invalid",
"protocol module protocol.registerSchemesAsPrivileged standard can access files through the FileSystem API",
"protocol module protocol.registerSchemesAsPrivileged cors-fetch disallows CORS and fetch requests when only supportFetchAPI is specified", "protocol module protocol.registerSchemesAsPrivileged cors-fetch disallows CORS and fetch requests when only supportFetchAPI is specified",
"session module ses.cookies should set cookie for standard scheme", "session module ses.cookies should set cookie for standard scheme",
"webFrameMain module WebFrame.visibilityState should match window state", "webFrameMain module WebFrame.visibilityState should match window state",
"reporting api sends a report for a deprecation", "reporting api sends a report for a deprecation",
"chromium features SpeechSynthesis should emit lifecycle events", "chromium features SpeechSynthesis should emit lifecycle events"
"version-bumper nextVersion bump versions bumps to beta from nightly"
] ]

1
spec/version-bump-spec.ts
View file

@ -132,7 +132,6 @@ describe('version-bumper', () => {
).to.be.rejectedWith('Cannot bump to beta from stable.'); ).to.be.rejectedWith('Cannot bump to beta from stable.');
}); });
// DISABLED-FIXME(ELECTRON 15): Re-enable after Electron 15 alpha has released
it('bumps to beta from nightly', async () => { it('bumps to beta from nightly', async () => {
const version = 'v2.0.0-nightly.19950901'; const version = 'v2.0.0-nightly.19950901';
const next = await nextVersion('beta', version); const next = await nextVersion('beta', version);