From b3a1fc65e53d4433fee814162b1bef97da68866f Mon Sep 17 00:00:00 2001 From: Aleksei Kuzmin Date: Sat, 4 Nov 2017 07:45:22 +0300 Subject: [PATCH 1/2] Disable deprecation warning of `crashReported.setExtraParameter()` It caused a couple of Crash Reported tests to timeout on Mac. Task to enable it back: https://github.com/electron/electron/issues/11012 --- lib/common/api/crash-reporter.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/common/api/crash-reporter.js b/lib/common/api/crash-reporter.js index cc284e8aceca..29d1d8512543 100644 --- a/lib/common/api/crash-reporter.js +++ b/lib/common/api/crash-reporter.js @@ -106,10 +106,14 @@ class CrashReporter { // TODO(2.0) Remove setExtraParameter (key, value) { - if (!process.noDeprecations) { - deprecate.warn('crashReporter.setExtraParameter', - 'crashReporter.addExtraParameter or crashReporter.removeExtraParameter') - } + // TODO(alexeykuzmin): Warning disabled since it caused + // a couple of Crash Reported tests to time out on Mac. Add it back. + // https://github.com/electron/electron/issues/11012 + + // if (!process.noDeprecations) { + // deprecate.warn('crashReporter.setExtraParameter', + // 'crashReporter.addExtraParameter or crashReporter.removeExtraParameter') + // } binding.setExtraParameter(key, value) } From bd766067ace2cc8d43a87a2d976dd06c6b377f11 Mon Sep 17 00:00:00 2001 From: Aleksei Kuzmin Date: Sat, 4 Nov 2017 07:52:47 +0300 Subject: [PATCH 2/2] Remove unused `deprecate` var to make linter happy --- lib/common/api/crash-reporter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/common/api/crash-reporter.js b/lib/common/api/crash-reporter.js index 29d1d8512543..219ae904276d 100644 --- a/lib/common/api/crash-reporter.js +++ b/lib/common/api/crash-reporter.js @@ -4,7 +4,7 @@ const {spawn} = require('child_process') const os = require('os') const path = require('path') const electron = require('electron') -const {app, deprecate} = process.type === 'browser' ? electron : electron.remote +const {app} = process.type === 'browser' ? electron : electron.remote const binding = process.atomBinding('crash_reporter') class CrashReporter {