mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: build failure when PDF viewer is disabled (#44965)

Browse source 
* fix: unused variable warning when the PDF viewer is disabled

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fix: unused function error when PDF viewer is disabled

error: unused function ParseManifest [-Werror,-Wunused-function]

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-12-06 09:41:56 -06:00 • committed by GitHub
parent 4062d18270
commit fa20da8fe4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/extensions/electron_extension_system.cc
View file

@ -88,6 +88,7 @@ void ElectronExtensionSystem::InitForRegularProfile(bool extensions_enabled) {
management_policy_ = std::make_unique<ManagementPolicy>(); management_policy_ = std::make_unique<ManagementPolicy>();
} }
#if BUILDFLAG(ENABLE_PDF_VIEWER)
namespace { namespace {
std::unique_ptr<base::Value::Dict> ParseManifest( std::unique_ptr<base::Value::Dict> ParseManifest(
@ -104,10 +105,11 @@ std::unique_ptr<base::Value::Dict> ParseManifest(
} }
} // namespace } // namespace
#endif // if BUILDFLAG(ENABLE_PDF_VIEWER)
void ElectronExtensionSystem::LoadComponentExtensions() { void ElectronExtensionSystem::LoadComponentExtensions() {
std::string utf8_error;
#if BUILDFLAG(ENABLE_PDF_VIEWER) #if BUILDFLAG(ENABLE_PDF_VIEWER)
std::string utf8_error;
std::string pdf_manifest_string = pdf_extension_util::GetManifest(); std::string pdf_manifest_string = pdf_extension_util::GetManifest();
std::unique_ptr<base::Value::Dict> pdf_manifest = std::unique_ptr<base::Value::Dict> pdf_manifest =
ParseManifest(pdf_manifest_string); ParseManifest(pdf_manifest_string);