mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: deprecate properties in app.getAppMetrics() (#13446)

Browse source 
* fix: deprecate properties in app.getAppMetrics()

* address feedback from review

* fix deprecated property location

* simplify test
This commit is contained in:
Shelley Vohr 2018-06-26 23:47:01 -07:00 • committed by GitHub
parent 08ccc2d624
commit f9e2ec43d0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 47 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
spec/api-deprecations-spec.js
View file

@ -65,7 +65,7 @@ describe('deprecations', () => {
expect(o).to.not.have.a.property(oldPropertyName)
expect(o).to.have.a.property(newPropertyName).that.is.a('number')
deprecate.property(o, oldPropertyName, newPropertyName)
deprecate.renameProperty(o, oldPropertyName, newPropertyName)
o[oldPropertyName] = ++value
expect(msg).to.be.a('string')
@ -76,6 +76,19 @@ describe('deprecations', () => {
expect(o).to.have.a.property(oldPropertyName).that.is.equal(value)
})
it('deprecates a property of an object', () => {
let msg
deprecations.setHandler(m => { msg = m })
const propertyName = 'itMustGo'
const o = { [propertyName]: 0 }
deprecate.removeProperty(o, propertyName)
expect(msg).to.be.a('string')
expect(msg).to.include(propertyName)
})
it('warns if deprecated property is already set', () => {
let msg
deprecations.setHandler((m) => { msg = m })
@ -85,7 +98,7 @@ describe('deprecations', () => {
const value = 0
let o = { [oldPropertyName]: value }
deprecate.property(o, oldPropertyName, newPropertyName)
deprecate.renameProperty(o, oldPropertyName, newPropertyName)
expect(msg).to.be.a('string')
expect(msg).to.include(oldPropertyName)