From f8e6d45b7037e4017d1afbe66c102acbe169cd68 Mon Sep 17 00:00:00 2001 From: Milan Burda Date: Fri, 8 Oct 2021 23:55:28 +0200 Subject: [PATCH] docs: nativeWindowOpen default was changed in Electron 15 (#31345) --- docs/breaking-changes.md | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/docs/breaking-changes.md b/docs/breaking-changes.md index ecd08d070bd3..a5e841c928ab 100644 --- a/docs/breaking-changes.md +++ b/docs/breaking-changes.md @@ -69,6 +69,18 @@ Electron apps. See [here](#removed-desktopcapturergetsources-in-the-renderer) for details on how to replace this API in your app. +## Planned Breaking API Changes (15.0) + +### Default Changed: `nativeWindowOpen` defaults to `true` + +Prior to Electron 15, `window.open` was by default shimmed to use +`BrowserWindowProxy`. This meant that `window.open('about:blank')` did not work +to open synchronously scriptable child windows, among other incompatibilities. +`nativeWindowOpen` is no longer experimental, and is now the default. + +See the documentation for [window.open in Electron](api/window-open.md) +for more details. + ## Planned Breaking API Changes (14.0) ### Removed: `remote` module @@ -119,16 +131,6 @@ ensure your code works with this property enabled. It has been enabled by defau You will be affected by this change if you use either `webFrame.executeJavaScript` or `webFrame.executeJavaScriptInIsolatedWorld`. You will need to ensure that values returned by either of those methods are supported by the [Context Bridge API](api/context-bridge.md#parameter--error--return-type-support) as these methods use the same value passing semantics. -### Default Changed: `nativeWindowOpen` defaults to `true` - -Prior to Electron 14, `window.open` was by default shimmed to use -`BrowserWindowProxy`. This meant that `window.open('about:blank')` did not work -to open synchronously scriptable child windows, among other incompatibilities. -`nativeWindowOpen` is no longer experimental, and is now the default. - -See the documentation for [window.open in Electron](api/window-open.md) -for more details. - ### Removed: BrowserWindowConstructorOptions inheriting from parent windows Prior to Electron 14, windows opened with `window.open` would inherit