mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: enable nativeWindowOpen by default (#28552)

Browse source 
* feat: enable nativeWindowOpen by default

* set nativeWindowOpen: false on spec/ main window

* update snapshots

* fix tests

* fix test

* fix webview test missing allowpopups

* fix other test

* update default
This commit is contained in:
Jeremy Rose 2021-04-13 12:36:38 -07:00 • committed by GitHub
parent dba4df9326
commit f8bdef5349
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 90 additions and 95 deletions
Download patch file Download diff file Expand all files Collapse all files

14
spec-main/api-browser-window-spec.ts
View file

@ -3075,19 +3075,7 @@ describe('BrowserWindow module', () => {
expect(url).to.equal('http://example.com/test');
expect(frameName).to.equal('');
expect(disposition).to.equal('foreground-tab');
expect(options).to.deep.equal({
show: true,
width: 800,
height: 600,
webPreferences: {
contextIsolation: true,
nodeIntegration: false,
webviewTag: false,
nodeIntegrationInSubFrames: false,
openerId: options.webPreferences!.openerId
},
webContents: undefined
});
expect(options).to.be.an('object').not.null();
expect(referrer.policy).to.equal('strict-origin-when-cross-origin');
expect(referrer.url).to.equal('');
expect(additionalFeatures).to.deep.equal([]);