mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

No more plan for ipc.sendSync in browser.

Browse source 
I want the browser to be fully asynchronous, so sending synchronous
messages from browser to renderer will be unacceptable.
This commit is contained in:
Cheng Zhao 2013-04-23 22:21:49 +08:00
parent 1b87a31940
commit f8899242c5
2 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

5
common/api/api_messages.h
View file

@ -27,8 +27,3 @@ IPC_SYNC_MESSAGE_ROUTED2_1(AtomViewHostMsg_Message_Sync,
IPC_MESSAGE_ROUTED2(AtomViewMsg_Message, IPC_MESSAGE_ROUTED2(AtomViewMsg_Message,
std::string /* channel */, std::string /* channel */,
ListValue /* arguments */) ListValue /* arguments */)
IPC_SYNC_MESSAGE_ROUTED2_1(AtomViewMsg_Message_Sync,
std::string /* channel */,
ListValue /* arguments */,
DictionaryValue /* result */)

4
renderer/api/lib/ipc.coffee
View file

@ -5,11 +5,9 @@ class Ipc extends EventEmitter
constructor: -> constructor: ->
process.on 'ATOM_INTERNAL_MESSAGE', (args...) => process.on 'ATOM_INTERNAL_MESSAGE', (args...) =>
@emit(args...) @emit(args...)
process.on 'ATOM_INTERNAL_MESSAGE_SYNC', (args...) =>
@emit(args...)
send: (args...) -> send: (args...) ->
@sendChannel('message', args...) ipc.send('ATOM_INTERNAL_MESSAGE', 'message', args...)
sendChannel: (args...) -> sendChannel: (args...) ->
ipc.send('ATOM_INTERNAL_MESSAGE', args...) ipc.send('ATOM_INTERNAL_MESSAGE', args...)