mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: add error event for utility process (#43774)

Browse source 
* feat: add error event for utility process

* chore: use public report api

* chore: fix lint

* doc: mark error event as experimental

---------

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
Robo 2024-09-27 10:17:06 +09:00 • committed by GitHub
parent 8397fef3ef
commit f68184a9f9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 167 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
spec/api-utility-process-spec.ts
View file

@ -113,6 +113,21 @@ describe('utilityProcess module', () => {
const [code] = await once(child, 'exit');
expect(code).to.equal(exitCode);
});
// 32-bit system will not have V8 Sandbox enabled.
// WoA testing does not have VS toolchain configured to build native addons.
ifit(process.arch !== 'ia32' && process.arch !== 'arm' && !isWindowsOnArm)('emits \'error\' when fatal error is triggered from V8', async () => {
const child = utilityProcess.fork(path.join(fixturesPath, 'external-ab-test.js'));
const [type, location, report] = await once(child, 'error');
const [code] = await once(child, 'exit');
expect(type).to.equal('FatalError');
expect(location).to.equal('v8_ArrayBuffer_NewBackingStore');
const reportJSON = JSON.parse(report);
expect(reportJSON.header.trigger).to.equal('v8_ArrayBuffer_NewBackingStore');
const addonPath = path.join(require.resolve('@electron-ci/external-ab'), '..', '..', 'build', 'Release', 'external_ab.node');
expect(reportJSON.sharedObjects).to.include(path.toNamespacedPath(addonPath));
expect(code).to.not.equal(0);
});
});
describe('app \'child-process-gone\' event', () => {