fix: pass rfh instances through to the permission helper (#35419)
* fix: pass rfh instances through to the permission helper * refactor: use WeakDocumentPtr instead of frame node id * fix: handle missing initiator document * fix: dispatch openExternal event for top level webview navs still
This commit is contained in:
parent
8128fa6d85
commit
f65b05b8cc
5 changed files with 38 additions and 11 deletions
|
@ -33,7 +33,8 @@ class WebContentsPermissionHelper
|
|||
};
|
||||
|
||||
// Asynchronous Requests
|
||||
void RequestFullscreenPermission(base::OnceCallback<void(bool)> callback);
|
||||
void RequestFullscreenPermission(content::RenderFrameHost* requesting_frame,
|
||||
base::OnceCallback<void(bool)> callback);
|
||||
void RequestMediaAccessPermission(const content::MediaStreamRequest& request,
|
||||
content::MediaResponseCallback callback);
|
||||
void RequestPointerLockPermission(
|
||||
|
@ -42,8 +43,10 @@ class WebContentsPermissionHelper
|
|||
base::OnceCallback<void(content::WebContents*, bool, bool, bool)>
|
||||
callback);
|
||||
void RequestWebNotificationPermission(
|
||||
content::RenderFrameHost* requesting_frame,
|
||||
base::OnceCallback<void(bool)> callback);
|
||||
void RequestOpenExternalPermission(base::OnceCallback<void(bool)> callback,
|
||||
void RequestOpenExternalPermission(content::RenderFrameHost* requesting_frame,
|
||||
base::OnceCallback<void(bool)> callback,
|
||||
bool user_gesture,
|
||||
const GURL& url);
|
||||
|
||||
|
@ -56,7 +59,8 @@ class WebContentsPermissionHelper
|
|||
explicit WebContentsPermissionHelper(content::WebContents* web_contents);
|
||||
friend class content::WebContentsUserData<WebContentsPermissionHelper>;
|
||||
|
||||
void RequestPermission(blink::PermissionType permission,
|
||||
void RequestPermission(content::RenderFrameHost* requesting_frame,
|
||||
blink::PermissionType permission,
|
||||
base::OnceCallback<void(bool)> callback,
|
||||
bool user_gesture = false,
|
||||
base::Value::Dict details = {});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue