chore: clean up forward declarations (#29904)

shell/common/api/electron_api_native_image_win.cc

@@ -12,7 +12,9 @@
 #include "shell/common/gin_converters/image_converter.h"
 #include "shell/common/gin_helper/promise.h"
 #include "shell/common/skia_util.h"
+#include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/icon_util.h"
+#include "ui/gfx/image/image_skia.h"
 
 namespace electron {
 

shell/common/extensions/electron_extensions_client.h

@@ -17,7 +17,6 @@ class APIPermissionSet;
 class Extension;
 class PermissionMessageProvider;
 class PermissionIDSet;
-class ScriptingWhitelist;
 class URLPatternSet;
 }  // namespace extensions
 

shell/common/gin_converters/blink_converter.h

@@ -17,7 +17,6 @@ class WebMouseEvent;
 class WebMouseWheelEvent;
 class WebKeyboardEvent;
 struct DeviceEmulationParams;
-struct WebSize;
 }  // namespace blink
 
 namespace gin {

shell/common/gin_converters/extension_converter.h

@@ -11,7 +11,7 @@
 
 namespace extensions {
 class Extension;
-}  // namespace extensions
+}
 
 namespace gin {
 

shell/common/gin_converters/frame_converter.h

@@ -9,7 +9,7 @@
 
 namespace content {
 class RenderFrameHost;
-}  // namespace content
+}
 
 namespace gin {
 

shell/common/gin_converters/net_converter.h

@@ -13,14 +13,8 @@
 #include "services/network/public/mojom/fetch_api.mojom.h"
 #include "shell/browser/net/cert_verifier_client.h"
 
-namespace base {
-class DictionaryValue;
-class ListValue;
-}  // namespace base
-
 namespace net {
 class AuthChallengeInfo;
-class URLRequest;
 class X509Certificate;
 class HttpResponseHeaders;
 struct CertPrincipal;

shell/common/gin_helper/wrappable_base.h

@@ -9,7 +9,7 @@
 
 namespace gin {
 class Arguments;
-}  // namespace gin
+}
 
 namespace gin_helper {
 

shell/common/heap_snapshot.cc

@@ -4,7 +4,9 @@
 
 #include "shell/common/heap_snapshot.h"
 
+#include "base/files/file.h"
 #include "v8/include/v8-profiler.h"
+#include "v8/include/v8.h"
 
 namespace {
 

shell/common/heap_snapshot.h

@@ -5,8 +5,13 @@
 #ifndef SHELL_COMMON_HEAP_SNAPSHOT_H_
 #define SHELL_COMMON_HEAP_SNAPSHOT_H_
 
-#include "base/files/file.h"
-#include "v8/include/v8.h"
+namespace base {
+class File;
+}
+
+namespace v8 {
+class Isolate;
+}
 
 namespace electron {
 

shell/common/node_bindings.cc

@@ -17,6 +17,7 @@
 #include "base/environment.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
+#include "base/single_thread_task_runner.h"
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"

shell/common/node_bindings.h

@@ -10,12 +10,11 @@
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
-#include "base/single_thread_task_runner.h"
 #include "uv.h"  // NOLINT(build/include_directory)
 #include "v8/include/v8.h"
 
 namespace base {
-class MessageLoop;
+class SingleThreadTaskRunner;
 }
 
 namespace node {

shell/common/node_util.h

@@ -11,7 +11,7 @@
 
 namespace node {
 class Environment;
-}  // namespace node
+}
 
 namespace electron {
 

shell/common/process_util.cc

@@ -6,6 +6,7 @@
 
 #include "gin/dictionary.h"
 #include "shell/common/gin_converters/callback_converter.h"
+#include "shell/common/node_includes.h"
 
 namespace electron {
 

shell/common/process_util.h

@@ -7,7 +7,9 @@
 
 #include <string>
 
-#include "shell/common/node_includes.h"
+namespace node {
+class Environment;
+}
 
 namespace electron {
 

shell/common/skia_util.cc

@@ -4,6 +4,7 @@
 
 #include <string>
 
+#include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/strings/pattern.h"
 #include "base/strings/string_util.h"

shell/common/skia_util.h

@@ -5,7 +5,13 @@
 #ifndef SHELL_COMMON_SKIA_UTIL_H_
 #define SHELL_COMMON_SKIA_UTIL_H_
 
-#include "ui/gfx/image/image_skia.h"
+namespace base {
+class FilePath;
+}
+
+namespace gfx {
+class ImageSkia;
+}
 
 namespace electron {