mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Assert that listener count decreases after a remove event.

Browse source
This commit is contained in:
Charlie Hess 2017-01-18 12:44:26 -08:00 • committed by Kevin Sawicki
parent c213971a2d
commit f6410d3b77
3 changed files with 17 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/browser/rpc-server.js
View file

@ -146,7 +146,7 @@ const throwRPCError = function (message) {
throw error
}
const rendererMissingErrorMessage = (meta, args, callIntoRenderer) => {
const removeRemoteListenersAndLogWarning = (meta, args, callIntoRenderer) => {
let message = `Attempting to call a function in a renderer window that has been closed or released.` +
`\nFunction provided here: ${meta.location}`
@ -218,7 +218,7 @@ const unwrapArgs = function (sender, args) {
if (!sender.isDestroyed() && webContentsId === sender.getId()) {
sender.send('ELECTRON_RENDERER_CALLBACK', meta.id, valueToMeta(sender, args))
} else {
console.warn(rendererMissingErrorMessage(meta, args, callIntoRenderer))
console.warn(removeRemoteListenersAndLogWarning(meta, args, callIntoRenderer))
}
}