refactor: more inline constexpr string view (#44498)
* chore: remove unused electron::kHidProductIdKey * refactor: make electron::kHidDeviceNameKey inline constexpr std::string_view refactor: make electron::kHidGuidKey inline constexpr std::string_view * refactor: make serial_chooser_context keys inline constexpr std::string_view * refactor: make native_window keys inline constexpr std::string_view * refactor: make electron::options keys inline constexpr std::string_view pt 1 * fixup! refactor: make electron::options keys inline constexpr std::string_view pt 1 chore: make kElectronNativeWindowKey a base::cstring_view ui::Widget::GetNativeWindowProperty requires a const char* * refactor: make electron::options keys inline constexpr std::string_view pt 2 * refactor: make electron::options keys inline constexpr std::string_view pt 3 * refactor: make electron::options keys inline constexpr std::string_view pt 4 * refactor: make electron::options keys inline constexpr std::string_view pt 5 * refactor: make electron::options keys inline constexpr std::string_view pt 6 * refactor: make electron::options keys inline constexpr std::string_view pt 7 * refactor: make electron::options keys inline constexpr std::string_view pt 8 * chore: remove unused file shell/common/options_switches.cc * docs: add code comment explaining use of base::cstring_view * fixup! fixup! refactor: make electron::options keys inline constexpr std::string_view pt 1 * chore: use consistent capitalization of the word 'fullscreen'
This commit is contained in:
Charles Kerr
GitHub
parent
48801be8e9
commit
f5bdbdb1e8
15 changed files with 305 additions and 412 deletions
|
|
@ -5,127 +5,289 @@
|
|||
#ifndef ELECTRON_SHELL_COMMON_OPTIONS_SWITCHES_H_
|
||||
#define ELECTRON_SHELL_COMMON_OPTIONS_SWITCHES_H_
|
||||
|
||||
#include "electron/buildflags/buildflags.h"
|
||||
#include <string_view>
|
||||
|
||||
#include "base/strings/cstring_view.h"
|
||||
|
||||
namespace electron {
|
||||
|
||||
namespace options {
|
||||
|
||||
extern const char kTitle[];
|
||||
extern const char kIcon[];
|
||||
extern const char kFrame[];
|
||||
extern const char kShow[];
|
||||
extern const char kCenter[];
|
||||
extern const char kX[];
|
||||
extern const char kY[];
|
||||
extern const char kWidth[];
|
||||
extern const char kHeight[];
|
||||
extern const char kMinWidth[];
|
||||
extern const char kMinHeight[];
|
||||
extern const char kMaxWidth[];
|
||||
extern const char kMaxHeight[];
|
||||
extern const char kResizable[];
|
||||
extern const char kMovable[];
|
||||
extern const char kMinimizable[];
|
||||
extern const char kMaximizable[];
|
||||
extern const char kFullScreenable[];
|
||||
extern const char kClosable[];
|
||||
extern const char kHiddenInMissionControl[];
|
||||
extern const char kFullscreen[];
|
||||
extern const char kSkipTaskbar[];
|
||||
extern const char kKiosk[];
|
||||
extern const char kSimpleFullScreen[];
|
||||
extern const char kAlwaysOnTop[];
|
||||
extern const char kAcceptFirstMouse[];
|
||||
extern const char kUseContentSize[];
|
||||
extern const char kZoomToPageWidth[];
|
||||
extern const char kTitleBarStyle[];
|
||||
extern const char kTabbingIdentifier[];
|
||||
extern const char kAutoHideMenuBar[];
|
||||
extern const char kEnableLargerThanScreen[];
|
||||
extern const char kDarkTheme[];
|
||||
extern const char kTransparent[];
|
||||
extern const char kType[];
|
||||
extern const char kDisableAutoHideCursor[];
|
||||
extern const char kBackgroundColor[];
|
||||
extern const char kHasShadow[];
|
||||
extern const char kOpacity[];
|
||||
extern const char kFocusable[];
|
||||
extern const char kWebPreferences[];
|
||||
extern const char kVibrancyType[];
|
||||
extern const char kBackgroundMaterial[];
|
||||
extern const char kVisualEffectState[];
|
||||
extern const char kTrafficLightPosition[];
|
||||
extern const char kRoundedCorners[];
|
||||
extern const char ktitleBarOverlay[];
|
||||
extern const char kOverlayButtonColor[];
|
||||
extern const char kOverlaySymbolColor[];
|
||||
extern const char kOverlayHeight[];
|
||||
inline constexpr std::string_view kTitle = "title";
|
||||
inline constexpr std::string_view kIcon = "icon";
|
||||
inline constexpr std::string_view kFrame = "frame";
|
||||
inline constexpr std::string_view kShow = "show";
|
||||
inline constexpr std::string_view kCenter = "center";
|
||||
inline constexpr std::string_view kX = "x";
|
||||
inline constexpr std::string_view kY = "y";
|
||||
inline constexpr std::string_view kWidth = "width";
|
||||
inline constexpr std::string_view kHeight = "height";
|
||||
inline constexpr std::string_view kMinWidth = "minWidth";
|
||||
inline constexpr std::string_view kMinHeight = "minHeight";
|
||||
inline constexpr std::string_view kMaxWidth = "maxWidth";
|
||||
inline constexpr std::string_view kMaxHeight = "maxHeight";
|
||||
inline constexpr std::string_view kResizable = "resizable";
|
||||
inline constexpr std::string_view kMovable = "movable";
|
||||
inline constexpr std::string_view kMinimizable = "minimizable";
|
||||
inline constexpr std::string_view kMaximizable = "maximizable";
|
||||
inline constexpr std::string_view kFullScreenable = "fullscreenable";
|
||||
inline constexpr std::string_view kClosable = "closable";
|
||||
|
||||
// WebPreferences.
|
||||
extern const char kZoomFactor[];
|
||||
extern const char kPreloadScript[];
|
||||
extern const char kNodeIntegration[];
|
||||
extern const char kContextIsolation[];
|
||||
extern const char kExperimentalFeatures[];
|
||||
extern const char kScrollBounce[];
|
||||
extern const char kEnableBlinkFeatures[];
|
||||
extern const char kDisableBlinkFeatures[];
|
||||
extern const char kNodeIntegrationInWorker[];
|
||||
extern const char kWebviewTag[];
|
||||
extern const char kCustomArgs[];
|
||||
extern const char kPlugins[];
|
||||
extern const char kSandbox[];
|
||||
extern const char kWebSecurity[];
|
||||
extern const char kAllowRunningInsecureContent[];
|
||||
extern const char kOffscreen[];
|
||||
extern const char kUseSharedTexture[];
|
||||
extern const char kNodeIntegrationInSubFrames[];
|
||||
extern const char kDisableHtmlFullscreenWindowResize[];
|
||||
extern const char kJavaScript[];
|
||||
extern const char kImages[];
|
||||
extern const char kTextAreasAreResizable[];
|
||||
extern const char kWebGL[];
|
||||
extern const char kNavigateOnDragDrop[];
|
||||
extern const char kEnablePreferredSizeMode[];
|
||||
// whether to keep the window out of mission control
|
||||
inline constexpr std::string_view kHiddenInMissionControl =
|
||||
"hiddenInMissionControl";
|
||||
|
||||
extern const char kHiddenPage[];
|
||||
inline constexpr std::string_view kFullscreen = "fullscreen";
|
||||
|
||||
#if BUILDFLAG(ENABLE_BUILTIN_SPELLCHECKER)
|
||||
extern const char kSpellcheck[];
|
||||
#endif
|
||||
// Whether the window should show in taskbar.
|
||||
inline constexpr std::string_view kSkipTaskbar = "skipTaskbar";
|
||||
|
||||
// Start with the kiosk mode, see Opera's page for description:
|
||||
// http://www.opera.com/support/mastering/kiosk/
|
||||
inline constexpr std::string_view kKiosk = "kiosk";
|
||||
|
||||
inline constexpr std::string_view kSimpleFullscreen = "simpleFullscreen";
|
||||
|
||||
// Make windows stays on the top of all other windows.
|
||||
inline constexpr std::string_view kAlwaysOnTop = "alwaysOnTop";
|
||||
|
||||
// Enable the NSView to accept first mouse event.
|
||||
inline constexpr std::string_view kAcceptFirstMouse = "acceptFirstMouse";
|
||||
|
||||
// Whether window size should include window frame.
|
||||
inline constexpr std::string_view kUseContentSize = "useContentSize";
|
||||
|
||||
// Whether window zoom should be to page width.
|
||||
inline constexpr std::string_view kZoomToPageWidth = "zoomToPageWidth";
|
||||
|
||||
// The requested title bar style for the window
|
||||
inline constexpr std::string_view kTitleBarStyle = "titleBarStyle";
|
||||
|
||||
// Tabbing identifier for the window if native tabs are enabled on macOS.
|
||||
inline constexpr std::string_view kTabbingIdentifier = "tabbingIdentifier";
|
||||
|
||||
// The menu bar is hidden unless "Alt" is pressed.
|
||||
inline constexpr std::string_view kAutoHideMenuBar = "autoHideMenuBar";
|
||||
|
||||
// Enable window to be resized larger than screen.
|
||||
inline constexpr std::string_view kEnableLargerThanScreen =
|
||||
"enableLargerThanScreen";
|
||||
|
||||
// Forces to use dark theme on Linux.
|
||||
inline constexpr std::string_view kDarkTheme = "darkTheme";
|
||||
|
||||
// Whether the window should be transparent.
|
||||
inline constexpr std::string_view kTransparent = "transparent";
|
||||
|
||||
// Window type hint.
|
||||
inline constexpr std::string_view kType = "type";
|
||||
|
||||
// Disable auto-hiding cursor.
|
||||
inline constexpr std::string_view kDisableAutoHideCursor =
|
||||
"disableAutoHideCursor";
|
||||
|
||||
// Default browser window background color.
|
||||
inline constexpr std::string_view kBackgroundColor = "backgroundColor";
|
||||
|
||||
// Whether the window should have a shadow.
|
||||
inline constexpr std::string_view kHasShadow = "hasShadow";
|
||||
|
||||
// Browser window opacity
|
||||
inline constexpr std::string_view kOpacity = "opacity";
|
||||
|
||||
// Whether the window can be activated.
|
||||
inline constexpr std::string_view kFocusable = "focusable";
|
||||
|
||||
// The WebPreferences.
|
||||
inline constexpr std::string_view kWebPreferences = "webPreferences";
|
||||
|
||||
// Add a vibrancy effect to the browser window
|
||||
inline constexpr std::string_view kVibrancyType = "vibrancy";
|
||||
|
||||
// Add a vibrancy effect to the browser window.
|
||||
inline constexpr std::string_view kBackgroundMaterial = "backgroundMaterial";
|
||||
|
||||
// Specify how the material appearance should reflect window activity state on
|
||||
// macOS.
|
||||
inline constexpr std::string_view kVisualEffectState = "visualEffectState";
|
||||
|
||||
inline constexpr std::string_view kTrafficLightPosition =
|
||||
"trafficLightPosition";
|
||||
inline constexpr std::string_view kRoundedCorners = "roundedCorners";
|
||||
|
||||
inline constexpr std::string_view ktitleBarOverlay = "titleBarOverlay";
|
||||
|
||||
// The color to use as the theme and symbol colors respectively for Window
|
||||
// Controls Overlay if enabled on Windows.
|
||||
inline constexpr std::string_view kOverlayButtonColor = "color";
|
||||
inline constexpr std::string_view kOverlaySymbolColor = "symbolColor";
|
||||
|
||||
// The custom height for Window Controls Overlay.
|
||||
inline constexpr std::string_view kOverlayHeight = "height";
|
||||
|
||||
/// WebPreferences.
|
||||
|
||||
// The factor of which page should be zoomed.
|
||||
inline constexpr std::string_view kZoomFactor = "zoomFactor";
|
||||
|
||||
// Script that will be loaded by guest WebContents before other scripts.
|
||||
inline constexpr std::string_view kPreloadScript = "preload";
|
||||
|
||||
// Enable the node integration.
|
||||
inline constexpr std::string_view kNodeIntegration = "nodeIntegration";
|
||||
|
||||
// Enable context isolation of Electron APIs and preload script
|
||||
inline constexpr std::string_view kContextIsolation = "contextIsolation";
|
||||
|
||||
// Web runtime features.
|
||||
inline constexpr std::string_view kExperimentalFeatures =
|
||||
"experimentalFeatures";
|
||||
|
||||
// Enable the rubber banding effect.
|
||||
inline constexpr std::string_view kScrollBounce = "scrollBounce";
|
||||
|
||||
// Enable blink features.
|
||||
inline constexpr std::string_view kEnableBlinkFeatures = "enableBlinkFeatures";
|
||||
|
||||
// Disable blink features.
|
||||
inline constexpr std::string_view kDisableBlinkFeatures =
|
||||
"disableBlinkFeatures";
|
||||
|
||||
// Enable the node integration in WebWorker.
|
||||
inline constexpr std::string_view kNodeIntegrationInWorker =
|
||||
"nodeIntegrationInWorker";
|
||||
|
||||
// Enable the web view tag.
|
||||
inline constexpr std::string_view kWebviewTag = "webviewTag";
|
||||
|
||||
inline constexpr std::string_view kCustomArgs = "additionalArguments";
|
||||
|
||||
inline constexpr std::string_view kPlugins = "plugins";
|
||||
|
||||
inline constexpr std::string_view kSandbox = "sandbox";
|
||||
|
||||
inline constexpr std::string_view kWebSecurity = "webSecurity";
|
||||
|
||||
inline constexpr std::string_view kAllowRunningInsecureContent =
|
||||
"allowRunningInsecureContent";
|
||||
|
||||
inline constexpr std::string_view kOffscreen = "offscreen";
|
||||
|
||||
inline constexpr std::string_view kUseSharedTexture = "useSharedTexture";
|
||||
|
||||
inline constexpr std::string_view kNodeIntegrationInSubFrames =
|
||||
"nodeIntegrationInSubFrames";
|
||||
|
||||
// Disable window resizing when HTML Fullscreen API is activated.
|
||||
inline constexpr std::string_view kDisableHtmlFullscreenWindowResize =
|
||||
"disableHtmlFullscreenWindowResize";
|
||||
|
||||
// Enables JavaScript support.
|
||||
inline constexpr std::string_view kJavaScript = "javascript";
|
||||
|
||||
// Enables image support.
|
||||
inline constexpr std::string_view kImages = "images";
|
||||
|
||||
// Make TextArea elements resizable.
|
||||
inline constexpr std::string_view kTextAreasAreResizable =
|
||||
"textAreasAreResizable";
|
||||
|
||||
// Enables WebGL support.
|
||||
inline constexpr std::string_view kWebGL = "webgl";
|
||||
|
||||
// Whether dragging and dropping a file or link onto the page causes a
|
||||
// navigation.
|
||||
inline constexpr std::string_view kNavigateOnDragDrop = "navigateOnDragDrop";
|
||||
|
||||
inline constexpr std::string_view kEnablePreferredSizeMode =
|
||||
"enablePreferredSizeMode";
|
||||
|
||||
inline constexpr std::string_view kHiddenPage = "hiddenPage";
|
||||
|
||||
inline constexpr std::string_view kSpellcheck = "spellcheck";
|
||||
} // namespace options
|
||||
|
||||
// Following are actually command line switches, should be moved to other files.
|
||||
|
||||
namespace switches {
|
||||
|
||||
extern const char kEnableSandbox[];
|
||||
extern const char kDisableHttpCache[];
|
||||
extern const char kStandardSchemes[];
|
||||
extern const char kServiceWorkerSchemes[];
|
||||
extern const char kSecureSchemes[];
|
||||
extern const char kBypassCSPSchemes[];
|
||||
extern const char kFetchSchemes[];
|
||||
extern const char kCORSSchemes[];
|
||||
extern const char kStreamingSchemes[];
|
||||
extern const char kCodeCacheSchemes[];
|
||||
extern const char kAppUserModelId[];
|
||||
extern const char kAppPath[];
|
||||
// Implementation detail: base::cstring_view used for switches because
|
||||
// base::CommandLine::CopySwitchesFrom() still needs C-style strings.
|
||||
// These constants can migrate to std::string_view if that function does.
|
||||
|
||||
extern const char kScrollBounce[];
|
||||
extern const char kNodeIntegrationInWorker[];
|
||||
// Enable chromium sandbox.
|
||||
inline constexpr base::cstring_view kEnableSandbox = "enable-sandbox";
|
||||
|
||||
extern const char kWidevineCdmPath[];
|
||||
extern const char kWidevineCdmVersion[];
|
||||
// Disable HTTP cache.
|
||||
inline constexpr base::cstring_view kDisableHttpCache = "disable-http-cache";
|
||||
|
||||
// The list of standard schemes.
|
||||
inline constexpr base::cstring_view kStandardSchemes = "standard-schemes";
|
||||
|
||||
// Register schemes to handle service worker.
|
||||
inline constexpr base::cstring_view kServiceWorkerSchemes =
|
||||
"service-worker-schemes";
|
||||
|
||||
// Register schemes as secure.
|
||||
inline constexpr base::cstring_view kSecureSchemes = "secure-schemes";
|
||||
|
||||
// Register schemes as bypassing CSP.
|
||||
inline constexpr base::cstring_view kBypassCSPSchemes = "bypasscsp-schemes";
|
||||
|
||||
// Register schemes as support fetch API.
|
||||
inline constexpr base::cstring_view kFetchSchemes = "fetch-schemes";
|
||||
|
||||
// Register schemes as CORS enabled.
|
||||
inline constexpr base::cstring_view kCORSSchemes = "cors-schemes";
|
||||
|
||||
// Register schemes as streaming responses.
|
||||
inline constexpr base::cstring_view kStreamingSchemes = "streaming-schemes";
|
||||
|
||||
// Register schemes as supporting V8 code cache.
|
||||
inline constexpr base::cstring_view kCodeCacheSchemes = "code-cache-schemes";
|
||||
|
||||
// The browser process app model ID
|
||||
inline constexpr base::cstring_view kAppUserModelId = "app-user-model-id";
|
||||
|
||||
// The application path
|
||||
inline constexpr base::cstring_view kAppPath = "app-path";
|
||||
|
||||
// The command line switch versions of the options.
|
||||
inline constexpr base::cstring_view kScrollBounce = "scroll-bounce";
|
||||
|
||||
// Command switch passed to renderer process to control nodeIntegration.
|
||||
inline constexpr base::cstring_view kNodeIntegrationInWorker =
|
||||
"node-integration-in-worker";
|
||||
|
||||
// Widevine options
|
||||
// Path to Widevine CDM binaries.
|
||||
inline constexpr base::cstring_view kWidevineCdmPath = "widevine-cdm-path";
|
||||
// Widevine CDM version.
|
||||
inline constexpr base::cstring_view kWidevineCdmVersion =
|
||||
"widevine-cdm-version";
|
||||
|
||||
// Forces the maximum disk space to be used by the disk cache, in bytes.
|
||||
inline constexpr base::cstring_view kDiskCacheSize = "disk-cache-size";
|
||||
|
||||
// Ignore the limit of 6 connections per host.
|
||||
inline constexpr base::cstring_view kIgnoreConnectionsLimit =
|
||||
"ignore-connections-limit";
|
||||
|
||||
// Whitelist containing servers for which Integrated Authentication is enabled.
|
||||
inline constexpr base::cstring_view kAuthServerWhitelist =
|
||||
"auth-server-whitelist";
|
||||
|
||||
// Whitelist containing servers for which Kerberos delegation is allowed.
|
||||
inline constexpr base::cstring_view kAuthNegotiateDelegateWhitelist =
|
||||
"auth-negotiate-delegate-whitelist";
|
||||
|
||||
// If set, include the port in generated Kerberos SPNs.
|
||||
inline constexpr base::cstring_view kEnableAuthNegotiatePort =
|
||||
"enable-auth-negotiate-port";
|
||||
|
||||
// If set, NTLM v2 is disabled for POSIX platforms.
|
||||
inline constexpr base::cstring_view kDisableNTLMv2 = "disable-ntlm-v2";
|
||||
|
||||
extern const char kDiskCacheSize[];
|
||||
extern const char kIgnoreConnectionsLimit[];
|
||||
extern const char kAuthServerWhitelist[];
|
||||
extern const char kAuthNegotiateDelegateWhitelist[];
|
||||
extern const char kEnableAuthNegotiatePort[];
|
||||
extern const char kDisableNTLMv2[];
|
||||
} // namespace switches
|
||||
|
||||
} // namespace electron
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue